- 09 Apr, 2020 40 commits
-
-
David Bienvenu authored
Removes check for process_startup when deciding not to open browser windows when no-startup-window is specified on the command line. Adds support for restoring last opened profiles to ProcessCommandLineAlreadyRunning, if no browser windows are open. Bug: 850919 Change-Id: I53db8b682f3838a8b871239b73d447cfafdb99d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134594 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#757830}
-
Owen Min authored
1) Reorder the function in .cpp to match the header file. 2) Add a unit test for Stop() function. 3) When time is up, remove the observer before running the |user_task|. This allows user restart the timer inside the |user_task|. Bug: 1062410 Change-Id: I6472c97198d63f4745a6ee5f2af7f376c8555894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140715Reviewed-by:
-
Marc Grimme authored
Idea is to first consolidate the code to share common functionality to simplify troubleshooting and align the tests. This change moves policy functionality into the DevicePolicyTestHelper and display functionality into the DeviceDisplayTestHelper and move this into respective class files. R=marcgrimme Change-Id: I587081d0947ab6f67e9904ce92b2551499ca9a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111312 Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#757828}
-
Danyao Wang authored
This CL contains the final steps to make the Java PaymentAppService invoke the C++ PaymentAppService: - Moved remaining PaymentHandlerFinder functionality, namely, onInstalledPaymentHandlerFounder() and onInstallablePaymentHandler() from ServiceWorkerPaymentAppBridge to PaymentAppServiceBridge. - Exposed the native method fireCanMakePaymentEvent() via a static method on ServiceWorkerPaymentAppBridge so it can be used by PaymentAppServiceBridge. - Proxied ServiceWorkerPaymentAppBridge.setCanMakePaymentForTesting to PaymentAppServiceBridge. This will be cleaned up in a subsequent CL. - Fixed a bug from a previous CL to pass payment apps to callbacks by value instead of by reference. Bug: 1063118 Change-Id: I87e254d6dc11e12f890353c9a0a6dde6cca73c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141436Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757827}
-
Simeon Anfinrud authored
This allows it to directly or indirectly depend on testonly targets that internal chromecast build infrastructure may want to put into the archives of a build. Bug: None Test: downstream patch Change-Id: I2b9dbe958577f8e99db6ec1831cb099c6463520b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136308Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757826}
-
Tim van der Lippe authored
This makes sure that the text is properly centered. Before and after as shown in screenshot of crbug.com/933114 R=jacktfranklin@chromium.org Bug: 1066415 Change-Id: I0565a680e7ca4486b1e85a6d03500a66b19e5c5a Fixed: 933114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144097 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#757825}
-
Jacobo Aragunde Pérez authored
Also add comment linking the related issue. Bug: 1042010 Bug: 1068579 Change-Id: Ia956aef5d609261f543c1a3eb0e06da80fc64eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139763 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#757824}
-
Bartek Nowierski authored
It wouldn't compile anyway, because AddPassingHashCode doesn't exist Change-Id: I1e2b282dd1d62033b34fe769799b8c81fa9ede37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143873Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#757823}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b2eec58cc7e..b5faec02776c Created with: gclient setdep -r src-internal@b5faec02776c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1031465 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I8e9fccf08214aedf0487ff2aa34d640541e678cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143960Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757822}
-
Miyoung Shin authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose, and renames it to clip-under-filter-002.html. Bug: 1063749 Change-Id: Idc93f627cda9116c09230a40e52bb792ecc08dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142072 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#757821}
-
Miyoung Shin authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose, and renames it to clip-under-filter-001.html. Bug: 1063749 Change-Id: I8f54983f67fe4249f2d73339ec4d5ceaa432999b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141497 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dcee8f94a9f8..728b9178660e git log dcee8f94a9f8..728b9178660e --date=short --first-parent --format='%ad %ae %s' 2020-04-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 444b7cd3eecd..bb32b2a70168 (2 commits) 2020-04-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 4db086125947..47d5e27460af (4 commits) 2020-04-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 63ed0e445fa5..3cfa8e28be80 (7 commits) Created with: gclient setdep -r src/third_party/angle@728b9178660e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I4ec93e340bfabdf0cf8fdedafcc913df27bfd382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143958Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757819}
-
Eric Seckler authored
Encode thread time + instruction count using counter tracks in the proto format. This should also pave the way to add more counters in the future. Bug: 928738 Change-Id: I6524aa99d630f7f156606cdde9f0f50a7735c31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139822 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#757818}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3cfa8e28be80..5c883d3c18db git log 3cfa8e28be80..5c883d3c18db --date=short --first-parent --format='%ad %ae %s' 2020-04-09 cwallez@chromium.org Clamp _SNORM formats to -1.0 Created with: gclient setdep -r src/third_party/swiftshader@5c883d3c18db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iaa8dd6632ae22fc3ec2007ec93291bc8e50e2781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143956Reviewed-by:
-
kylechar authored
Pixel_DirectComposition_Video_MP4_Rounded_Corner is failing on the Windows with GLRenderer. It looks like it has percision issues so the rounded corner quads are off by a couple pixels with large number of variations, too many to add to gold. The test is only running with GLRenderer on a single FYI bot that and that shouldn't be for much longer, so just skip it until it's no longer an issue. Also fix skia-renderer vs no-skia-renderer tags. The tag is still often wrong when there are no flags provided, but that should be fixed as a follow up since it has the potential for flipping many expectations. Bug: 1068301 Change-Id: Ia373d52892c757697825c39d4308d062191a6ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142397Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#757816}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8cf85562ad908d8f28a87d5f2fbf5fed1a04ccf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143961Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/46d2d5e4c4ce..25eeda1872e4 git log 46d2d5e4c4ce..25eeda1872e4 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 mmorrison@nvidia.com Fix socket not getting registered for epoll events Created with: gclient setdep -r src/third_party/webrtc@25eeda1872e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia8827a1d08ef57f7cfc819117fd23c05f90a1b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143959Reviewed-by:
-
David Dorwin authored
Also alphabetize the list. Change-Id: I01fef1a4b0d0681b108c7b69fa5ce2c14d7dfd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143032Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#757813}
-
Alexander Surkov authored
ATK tree traversal makes the a11y tree formatter to produce ATK trees which makes accessible tree testing realistically reflect accessibility trees on Linux Bug: 1066536 Change-Id: I03072c9bdd419202703308b7c79d65bb5e1e9e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140306Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Reviewed-by:
-
Anatoliy Potapchuk authored
Since AutoclickMenuPosition contains quite generic values, which can be reused by other floating menus, we should rename it to better indicate its properties. Bug: 1061068 Change-Id: Ifb58be11de2fa4163fc2e9a4f37a4b9c9bdc43b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141928 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#757811}
-
Adithya Srinivasan authored
Makes the automation node for a portal a leaf, allowing it to be focused (and get a focus ring). Also fixes an issue where using the tab key results in the portal getting focus, but not getting a focus ring in ChromeVox. This CL adds the ability to start an embedded test server in extension js tests and injects the base url of the server for use in tests. This is needed to test portals, as portals can only be embedded in http/https pages, and portal src URLs can only be in the HTTP family as well. Bug: 1060112, 1045608 Change-Id: I82a696cf01ffea2e4fa4c2bde3c7291607b8979d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104993Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#757810}
-
Monica Basta authored
This CL replaces 'Signin.OAuth2TokenGetFailure' with 'Signin.OAuth2TokenGetResult'. This is needed as the old histogram recorded only failures but not success. Bug: 1059818 Change-Id: I7ae81229dd1b4a48d42b3ec8e7daf6c5af6b96ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142258Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#757809}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3d75d778f466..597193051bfc git log 3d75d778f466..597193051bfc --date=short --first-parent --format='%ad %ae %s' 2020-04-09 tvanderlippe@chromium.org Use karma-coverage in favor of community-maintained packages 2020-04-09 wolfi@chromium.org Increase width of device dropdown in device emulation 2020-04-09 alexrudenko@chromium.org Use var --focus-bg-color for expandable view in sources 2020-04-09 tvanderlippe@chromium.org Handle old versions of DevTools localStorage corruption 2020-04-09 mathias@chromium.org Remove `preinstall` hook from package.json Created with: gclient setdep -r src/third_party/devtools-frontend/src@597193051bfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066415,chromium:1068145 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia61b8700176153c79a2d341f938362753c68ed34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143957Reviewed-by:
-
Victor Hugo Vianna Silva authored
Previous to this CL, the method was misleading because it could show a different UI (autofill dropdown) if the generation was automatic, i.e. not directly triggered by the user). The different UI call is now moved to AutomaticGenerationAvailable, the only caller of this method passing true for |is_manually_triggered|. The bool parameter can't be entirely removed because it is still used in other parts of the method. Bug: 1060131 Change-Id: I82f769129fe601f55008607ce867d4bf04415241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144151Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#757807}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2d536d03..61094cb6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If4d105643a408b30da8a062c2e12b47e3c459a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757806}
-
Colin Blundell authored
I inadvertently landed a change that set this member to true rather than false :P. This landed in https://chromium-review.googlesource.com/c/chromium/src/+/2132385. Fortunately the above CL first landed in 84: https://storage.googleapis.com/chromium-find-releases-static/955.html#955b7118ab87d23cbb053608efa451ae9bd80d20 Hence there doesn't need to be any question of whether this change would be worth merging to 83 or not. Bug: 1031465 Change-Id: I49e0c780f512c8786770851fa56cdcbc03d66608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144051Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#757805}
-
Mathias Bynens authored
A V8 CL [1] improves the terminology that’s used for internal promise state. Per the spec [2], a resolved promise may be “pending, fulfilled, or rejected”, but previously V8 incorrectly used the term “resolved” instead of “fulfilled”. This change is user-observable through the `d8` REPL and the DevTools Console, and so this patch updates the affected test’s expectations and temporarily disables it. [1]: https://chromium-review.googlesource.com/c/v8/v8/+/2144011 [2]: https://tc39.es/ecma262/#sec-properties-of-promise-instances Bug: v8:6751, v8:5416 Change-Id: I359560afab9155511aed762c864e80f33ac57262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144095 Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#757804}
-
Yutaka Hirano authored
At https://crrev.com/c/2098190 I introduced a COEP parsing logic to content/common but it was problematic - parsing an untrusted data in the browser process is forbidden. This CL moves the parsing logic from the browser process to the renderer process. Bug: 887967 Change-Id: I3bf4bd0f6d727573406e2f866df6c1ffdc7f59e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132902Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#757803}
-
Antonio Gomes authored
CL adds <title>, <link>s and <meta name=assert> entries to the original test, and moves it to external/wpt/css/filter-effects/. Target location/name: external/wpt/css/filter-effects/effect-reference-feimage-003.html Associated TestExpectations entries are also updated. BUG=968791,1063749 R=pdr@chromium.org Change-Id: Ie2a49760e32642613757272db97745fb3994dd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141350 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Jose Lopes authored
The function splitlines consumes the trailing newlines so the resulting diff lines are printed in a single line and the diff is not readable. This CL implements the recommendation from the difflib library, which is to use readlines and writelines for a correct diff output: * https://docs.python.org/3/library/difflib.html#difflib.unified_diff Change-Id: I88b9bf1a1ff8f4c1f75c9cb1aca82e209f72abdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139699 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757801}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10401829730c..3d75d778f466 git log 10401829730c..3d75d778f466 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 alexrudenko@chromium.org Empty Navgiator tree should not get focus via keyboard Created with: gclient setdep -r src/third_party/devtools-frontend/src@3d75d778f466 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I96896ac50402313d74b664aed3237291d989bbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143954Reviewed-by:
-
Jérôme Lebel authored
Adding image inset for "More" button in sign-in, to get more space between the arrow and the title. Before: https://drive.google.com/open?id=1zyn8Lon_4Nb6_N0M4tRWxGCNfaYnEaCb After: https://drive.google.com/open?id=1Cn2BURPpstvEgssk8hCtN_yy5RyfLOXm Bug: 971989 Change-Id: I6dc46a21b81a048ccf34d397ffb835c4a46f411a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142253 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#757799}
-
Fergal Daly authored
This is mostly a no-op. It reduces redundancy and hopefully makes it simpler and clearer. It also skips calling SetEmbeddingToken if it's already set. There's a question as to whether this is OK to land during our stability freeze. In terms of stability, this should be a no-op and fairly easy to verify. In terms of cherry-picks, this is a very local refactor, if something has a merge conflict with it, we could just CP this too. Change-Id: Icb575f5fe3ff7a9bbea3d24cd7dec9c5ad884794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138935 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#757798}
-
Anatoliy Potapchuk authored
This cl is a policy-part of native a11y project for kiosk mode. it adds a policy which will control the visibility of the floating menu. Bug: 1061068 Change-Id: I1bbcf39790f81e797e46d96c148d46756923da42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139754 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
For consistency with other generated scripts and also to work around an issue with test_env.py failing to run a script from the current directory. Bug: 1050517 Change-Id: I83c0608add7450dc7d7996cc722ca7a809e39581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141987Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#757796}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/00e6685b05e8..f3ae9d6b5d40 git log 00e6685b05e8..f3ae9d6b5d40 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 primiano@google.com Merge "service: allow to specify a file path with write_into_file" 2020-04-09 treehugger-gerrit@google.com Merge "TraceProcessor: ingest TracingServiceEvent.all_data_sources_started" 2020-04-08 rsavitski@google.com fix typo in get.perfetto.dev 2020-04-08 primiano@google.com Merge "GN: enable PIE on Linux" 2020-04-08 primiano@google.com Docs: improve comments on builtin data sources 2020-04-08 treehugger-gerrit@google.com Merge "CPU frequency indexing function" 2020-04-08 fmayer@google.com Add new table for heap_graph_class. 2020-04-08 lalitm@google.com Merge "tp: add proto for hsc startup metrics" 2020-04-08 fmayer@google.com Merge "Create proper table for packages list." Created with: gclient setdep -r src/third_party/perfetto@f3ae9d6b5d40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:150546312 Tbr: perfetto-bugs@google.com Change-Id: I9470c305a131f16e41a0d7f19c37708bbd7f0b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143951Reviewed-by:
-
Aya ElAttar authored
Bug: 1068206 Change-Id: Iab84006d32e3cefbea3856cc94461c1343aa32d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137329 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
-
Miyoung Shin authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose, and renames it to effect-reference-source-alpha-002.html. Bug: 1063749 Change-Id: I938d13f151aeb24d4a176b5841f675c3fa5c8084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141557Reviewed-by:
-
Miyoung Shin authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose, and renames it to effect-reference-source-alpha-001.html. Bug: 1063749 Change-Id: I43f149c9eb45cd83f739e50d2b8601446b0ec714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141555Reviewed-by:
-
Alex Ilin authored
ChromeOS can now support multiple accounts in the extension consent flow. This change should be compatible with the old consent flow as well. Bug: 1026237 Change-Id: I915a6697dc0301bb67f297983c32f98a1a2e5fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141102 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
