GitLab

Revert of Make components_browsertests swarmable and add to main waterfall. (patchset #3 id:40001 of https://codereview.chromium.org/863023003/)

Reason for revert:
Cause mac build flakiness, see http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/21875/steps/compile/logs/stdio

I think the '<(PRODUCT_DIR)/Content Shell.app/', line in the isolate needs to go. Looking closer, we should be launching the components_browsertest binary for the renderer as well. Right now it launches Content Shell for the renderer, which seems odd.

Original issue's description:
> Make components_browsertests swarmable and add to main waterfall.
>
> - Makes components_browsertests swarmable.
> - Adds components_browsertests to the main waterfall for linux, mac and
>   win bots.
> - Updates the chromium tryserver to run components_browsertests as
>   swarmable.
>
> BUG=311270
>
> Committed: https://crrev.com/7a3df3b7171fa87f556d22803fdc02a67e975865
> Cr-Commit-Position: refs/heads/master@{#312886}

TBR=nyquist@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=311270

Review URL: https://codereview.chromium.org/856323003

Cr-Commit-Position: refs/heads/master@{#312976}

The data reduction proxy code is initialized in profile code
in Chrome, primarily in ProfileImplIOData, and in the
AwBrowserContext and AwURLRequestContextGetter. This code is
rather involved. This change moves that initialization logic
to a new class, DataReductionProxyIOData, to avoid
duplication across platforms, and reduce the potential for regressions.

This CL also completely removes DRP support from the system network delegate.

BUG=429732, 447346

Review URL: https://codereview.chromium.org/778463002

Cr-Commit-Position: refs/heads/master@{#312975}

This patch removes the virtual base class for the tiling set raster
queues, since the calling code (raster tile priority queues) knows
exactly what type it's using.

R=reveman, danakj

Review URL: https://codereview.chromium.org/866883003

Cr-Commit-Position: refs/heads/master@{#312974}

These notifications will be useful in order to fire the right Windows
accessibility events for certain tree changes, but this patch
just adds the notifications and refactors existing code to use them.

BUG=447962

Review URL: https://codereview.chromium.org/830943004

Cr-Commit-Position: refs/heads/master@{#312973}

Promises were not chained properly. As a
result, the majority of tests were always passing despite of errors.

TEST=browser_tests: *ImportHistoryTest*
BUG=None

Review URL: https://codereview.chromium.org/867123007

Cr-Commit-Position: refs/heads/master@{#312972}

Revert of Report whether a reboot happened since the SRT asked for one. (patchset #1 id:40001 of https://codereview.chromium.org/823113005/)

Reason for revert:
GetTickCount64() isn't available on Windows XP

Original issue's description:
> Report whether a reboot happened since the SRT asked for one.
>
> BUG=450831
>
> Committed: https://crrev.com/d1f7bbc03afac5ff0cc3e7fcca73ff92d1b955e7
> Cr-Commit-Position: refs/heads/master@{#312652}

TBR=robertshield@google.com,robertshield@chromium.org,waffles@chromium.org,mad@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450831

Review URL: https://codereview.chromium.org/874693003

Cr-Commit-Position: refs/heads/master@{#312971}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/865123003

Cr-Commit-Position: refs/heads/master@{#312970}

Use 2ms which is used by GpuCommandBufferStub. This helps
throughput of idle work like the idle uploader.

BUG=448168

Review URL: https://codereview.chromium.org/851473003

Cr-Commit-Position: refs/heads/master@{#312969}

When the GPU process crashes we can get an OnChannelEstablished() before
the OnChannelDestroyed() is received. Use the host_id to figure out if
the OnChannelDestroyed() should be processed.

BUG=451584

Review URL: https://codereview.chromium.org/872093002

Cr-Commit-Position: refs/heads/master@{#312968}

1. asan required disable_nacl=1 since there's no 64-bit runtime yet.
   disable_nacl=1 doesn't work with isolates.  Move the asan flags
   around a bit so that they're only applied to 32-bit targets.
   Now everything builds fine without disable_nacl=1

2. One isolate file was missing a <(EXECUTABLE_SUFFIX), add that.

BUG=416078
TEST=
* `ninja -C out\Release chrome_nacl_win64` builds correctly
* out\Release\obj\base\base.ninja still has asan flags,
  the base_unittests.exe link command still has asan flags

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/871973004

Cr-Commit-Position: refs/heads/master@{#312967}

783a8cd Regression fix for lossless decoding

Regression fix for lossless decoding

Reported here: https://code.google.com/p/webp/issues/detail?id=239

At the beginning of method 'DecodeImageData', pixels up to
'dec->last_pixel_' are assumed to be already cached. So, at the end of
previous call to that method also, that assumption should hold true.

Hence, we should cache all pixels up to 'src' regardless of 'src_last'.

This affects lossless incremental decoding only, as that is when
src_last and src_end differ.
Note: alpha decoding is implicitly incremental, as alpha decoding of
only the rows 'y_end - y_start' happens during FinishRow() call. So, this bug
affects alpha decoding in non-incremental decoding flow as well.

This bug was introduced in: https://gerrit.chromium.org/gerrit/#/c/59716.

BUG=

Review URL: https://codereview.chromium.org/872923002

Cr-Commit-Position: refs/heads/master@{#312966}

Before Image: https://plus.google.com/photos/108653480353422372181/albums/6107652991484426929/6107651917564125842?e=-RedirectToSandbox&pid=6107651917564125842&oid=108653480353422372181

After Image: https://plus.google.com/photos/108653480353422372181/albums/6107652991484426929/6107651943460200946?e=-RedirectToSandbox&pid=6107651943460200946&oid=108653480353422372181

Review URL: https://codereview.chromium.org/869193006

Cr-Commit-Position: refs/heads/master@{#312965}

Review URL: https://codereview.chromium.org/872073002

Cr-Commit-Position: refs/heads/master@{#312964}

When the full-screen app is minimized and then restored, an onRestored event fires,
which causes the title bar to re-appear and the remote desktop to be resized. This
CL suppresses that notification.

I don't think this is easily testable, because there's no way of programmatically
restoring a window from a minimized state.

BUG=400921

Review URL: https://codereview.chromium.org/863123002

Cr-Commit-Position: refs/heads/master@{#312963}

On Imagination GPUs client side arrays are used for stream usage
(GL_STREAM_DRAW) VBO. Service side makes
glBufferData(target, 0, NULL, GL_STREAM_DRAW) calls to allow the driver
to free any previous data assoicated with the buffer. However, drivers
for Imagination PowerVR SGX 540 GPUs throw GL_OUT_OF_MEMORY error when
glBufferData is called with buffer size of 0.

BUG=451501

Review URL: https://codereview.chromium.org/870883005

Cr-Commit-Position: refs/heads/master@{#312962}

The promise wasn't chained properly, and the condition was opposite.

TEST=browser_tests: *ImportHistoryTest*
BUG=None

Review URL: https://codereview.chromium.org/873853002

Cr-Commit-Position: refs/heads/master@{#312961}

Currently, when multiple downstream targets depend on chrome_shell resource
paks, ninja outputs several warnings similar to:

ninja: warning: multiple rules generate ../assets/sample_apk/am.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate ../assets/sample_apk/ar.pak. builds involving this target will not be correct; continuing anyway

This commit refactors the pak copying logic into chrome_android_paks.gypi to
allow proper reuse of the target.

BUG=441011

Review URL: https://codereview.chromium.org/793943004

Cr-Commit-Position: refs/heads/master@{#312960}

WebRTC 8137:8141
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/efa8073..67d96fc

Libjingle 8136:8141
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/737de38..419aa31

For libJingle README.chromium:
TBR=tommi@chromium.org

BUG=

Review URL: https://codereview.chromium.org/867183004

Cr-Commit-Position: refs/heads/master@{#312959}

Using OnError() to deliver status codes during Initialize() complicates
upstream state paths, so require clients to return status via the
initialization callback provided instead of via the error callback.

BUG=450764
TEST=media_unittests, mojo://media_test

Review URL: https://codereview.chromium.org/870693002

Cr-Commit-Position: refs/heads/master@{#312958}

This has been causing occasional build breakage on the bots,
depending on whether we got unlucky in build ordering. Because
extensions_common and extensions_browser both cause
extensions_strings to run, I didn't notice this error before.

BUG=451442

Review URL: https://codereview.chromium.org/869743004

Cr-Commit-Position: refs/heads/master@{#312957}

BUG=393291

Review URL: https://codereview.chromium.org/873823002

Cr-Commit-Position: refs/heads/master@{#312956}

BUG=447059

Review URL: https://codereview.chromium.org/872453002

Cr-Commit-Position: refs/heads/master@{#312955}

GLShareGroup should be the same whenever MailboxManager is the same.
So store the GLShareGroup instance in the in-process service.

BUG=443464

Review URL: https://codereview.chromium.org/870693003

Cr-Commit-Position: refs/heads/master@{#312954}

The last active use of PluginReverseInterface was via its
StartupInitializationComplete()/"init_done" method, but recent
cleanups have made that into a no-op.

We can therefore remove PluginReverseInterface.  We no longer need to
call NaCl's "reverse_setup" SRPC call.

This removes the Chromium-side parts of the old SRPC-based
open_resource() implementation, which was no longer called.  This
allows us to remove OpenManifestEntry() from PPB_NaCl_Private.

Add some #includes to fix include-what-you-use problems that become
apparent after removing code.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864
TEST=NaCl tests in browser_tests

Review URL: https://codereview.chromium.org/870923004

Cr-Commit-Position: refs/heads/master@{#312953}

If two <webview>s have the same embedder process but have different embedder
WebContents, adding a WebRequest API event listener may fail if they happen
to generate the same subevent names. This CL fixes the problem by updating the
WebRequest EventListener's comparator to account for different <webview>s.

BUG=450161

Review URL: https://codereview.chromium.org/864893003

Cr-Commit-Position: refs/heads/master@{#312952}

Fixes name changes from https://codereview.chromium.org/816353008/

BUG=451541

Review URL: https://codereview.chromium.org/865403004

Cr-Commit-Position: refs/heads/master@{#312951}

If the user enters a word that triggers the alternate nav infobar (i.e. is a
search by default but also happens to be an intranet hostname), and the omnibox
navigation synchronously triggers the extension system to navigate a background
page, the background page navigation could be mistaken for the omnibox
navigation, leading to a crash when trying to show the infobar.

This could also goof up shortcut backend statistics, in theory, if the
background page navigation succeeded but the omnibox navigation did not.

This CL also adds a different CHECK to verify that the navigations that we do
pay attention to are the ones we want.  I'll convert this to a DCHECK in a
couple of weeks if it doesn't turn up anything in the field.

BUG=363105
TEST=none

Review URL: https://codereview.chromium.org/865313002

Cr-Commit-Position: refs/heads/master@{#312950}

C++11 range-based for loops make it a lot easier to iterate over an STL
container without incredibly long type names. The last users of these
typedefs have been updated and so they are no longer necessary.

BUG=

Review URL: https://codereview.chromium.org/869063004

Cr-Commit-Position: refs/heads/master@{#312949}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1c40292..6a14434

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/871913006

Cr-Commit-Position: refs/heads/master@{#312948}

BUG=449662, chrome-os-partner:35334
TEST=covered by unittest. Also tested on link_freon

Review URL: https://codereview.chromium.org/854203002

Cr-Commit-Position: refs/heads/master@{#312947}

BUG=

Review URL: https://codereview.chromium.org/872783003

Cr-Commit-Position: refs/heads/master@{#312946}

BUG=427660
TBR=rouslan@chromium.org

Review URL: https://codereview.chromium.org/867963005

Cr-Commit-Position: refs/heads/master@{#312945}

Types such as DxDiagNode are causing OOMs in this case.

BUG=450268
R=inferno@chromium.org,tsepez@chromium.org

Review URL: https://codereview.chromium.org/871933003

Cr-Commit-Position: refs/heads/master@{#312944}

This is effectively a revert of commit positions 308378 and 307774.

BUG=451173
TBR=bauerb@chromium.org,rogerta@chromium.org

Review URL: https://codereview.chromium.org/872433003

Cr-Commit-Position: refs/heads/master@{#312943}

This is intentionally tiny and intended to be merged into M41.
views::Label already knows the size of the text (GetTextSize()
returns the cached size), therefore it knows the current text
does not fade at all.

Since this will avoid the check if the text may fade or not in
gfx::Canvas::DrawFadedString(), this can potentially make
the drawing 2x faster if the text doesn't fade at all.

BUG=451297
R=sky@chromium.org
TEST=on link_freon, with the bookmark sample in crbug.com/440551
  (contains ~15 bookmarks), repaint of bookmark bar is improved
  as: ~100msec -> ~55msec

Review URL: https://codereview.chromium.org/870903002

Cr-Commit-Position: refs/heads/master@{#312942}

Review URL: https://codereview.chromium.org/870913003

Cr-Commit-Position: refs/heads/master@{#312941}

BUG=chromedriver:998
NOTRY=true
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/870123002

Cr-Commit-Position: refs/heads/master@{#312940}

BUG=450854,429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/867333002

Cr-Commit-Position: refs/heads/master@{#312939}

<webview> has its own implementation of HandleKeyboardEvent that deals with back/forward keys
and so on but for keys it doesn't know how to handle, it should pass them along as other
GuestViews do.

This CL also moves WebContentsObserver and WebContentsDelegate overrides in GuestViewBase from private to protected.

BUG=none

Review URL: https://codereview.chromium.org/869193004

Cr-Commit-Position: refs/heads/master@{#312938}

This also updates the logging in shiil_property_util to use
device_event_log.h.

TBR=isherman@chromium.org for trivial change
BUG=none

Review URL: https://codereview.chromium.org/819583004

Cr-Commit-Position: refs/heads/master@{#312937}