- 28 Oct, 2020 40 commits
-
-
Kyle Williams authored
Ease indirect dependency requirements by adding sources directly into the main browser/chromeos build target BUG=chromium:1105567, b:165864612 TEST='autoninja -C out/Default/ chrome/test:unit_tests \ && xvfb-run ./out/Default/unit_tests \ --gtest_filter=CfmServiceAdaptorTest.*' Change-Id: Idc69f08b44e0fdd5c85895ed5b92a75226adb6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495409Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#821695}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I9bd86e8040109917232c9477c7e9d5f418f47f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504741Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#821694}
-
Vidhan authored
AlternativeStateNameMap encapsulates mappings from state names in the profiles to their localized and the abbreviated version. AlternativeStateNameMap can provide the following data for the states: 1. The state string stored in the address profile. 2. The state canonical name (StateEntry::canonical_name) which acts as the unique identifier representing the state. It is used for the comparison and determining the mergeability of the address profiles. 3. The abbreviations of the state (StateEntry::abbreviations). 4. The alternative names of the state (StateEntry::alternative_names). StateEntry holds the information about the abbreviations and the alternative names of the state. Example of a StateEntry object: { 'canonical_name': 'California', 'abbreviations': ['CA'], 'alternate_names': ['The Golden State'] } Bug: 1111960 Change-Id: I3dc3aa6f9c52c160d179e6dcad646b52b619b9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360274Reviewed-by:Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#821693}
-
Yuki Shiino authored
Blink-V8 bindings haven't supported IDL namespaces for a long time, however, finally IDL namespaces get supported. This patch changes `window.CSS` from an IDL interface to an IDL namespace in conformance to the standard. Change-Id: I60a7129df48b68e890ed30bf7ed03d7f79228522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434404Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#821692}
-
Oriol Brufau authored
In InsertListCommand::UnlistifyParagraph, if `list_element` has no <li>, then `list_child_node` will be a non-<li> child. In that case, `previous_list_child` and `next_list_child` may end up being the same `list_child_node` if it has multiple block children. This would make some DCHECKs fail. However, the behavior seems fine, so this patch changes the DCHECKs to ensure that `previous_list_child` and `next_list_child` are obtained from nodes different than the block where the caret is. Bug: 1138054 TEST=InsertListCommandTest.UnlistifyParagraphCrashOnNonLi Change-Id: I18631b1c90d59539433373a2139aab36115e59ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497161 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821691}
-
Peter McNeeley authored
Overlay selection is extremely important for optimal power and performance.The |OverlayCandidateTemporalTracker| class provides a way to temporally track overlay candidate properties and to categorize them. This tracker operates on highly opaque input; it only understands resource id (changes) and damage ratios. The hysteresis in categorization is intentional and its purpose is to temporally stabilize result. Bug: 1113306 Change-Id: I3da04cd075208fab936d426d8d6c05473fbd659c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491015Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#821690}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/11223a39..ecbac8fd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5f17891727d8c3dfdd4e1c908a66f37661ac7227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504222Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821689}
-
Alice Wang authored
This CL extracts the account picker bottom sheet header in a separate file to reuse it in different account picker view xml files after the refactoring. Bug: 1138824 Change-Id: I025c9aac45ca5022a6b95d4ba3d847120d7cf3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502588Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821688}
-
Dominik Röttsches authored
This reverts commit 0d7be96e. Reason for revert: Suspected of causing failures on CrOS device bots, see https://crbug.com/1143224 Original change's description: > Add --use-swarming-go to the custom trigger scripts > > Design doc: http://go/roll-go-swarming-to-trigger-scripts > > Bug: 1127205 > Change-Id: I8ca8e2bb381f340fc23b91339cdb56374f8eead8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500976 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Commit-Queue: Ye Kuang <yekuang@google.com> > Cr-Commit-Position: refs/heads/master@{#821619} TBR=tikuta@chromium.org,wenbinzhang@google.com,yekuang@google.com Change-Id: I017fc7ef2947a7d0f2e077e6d8eafd98b7f2865f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505509Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#821687}
-
Dominik Röttsches authored
Bug: 1143206 Change-Id: I2aa70984f0b03d9c59ed2ac8e738bfea051e8a3b Tbr: titouan Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503696Reviewed-by:
-
Eric Seckler authored
Makes it possible to enable LITTLE-cores-only mode via Finch, by replacing the existing command line flag with a base::Feature. It can still be enabled locally by passing --enable-features=WebViewCpuAffinityRestrictToLittleCores or enabling the feature in WebView DevTools. Test: Run WV shell with flag above & check chrome://histograms/Power. Bug: 1111789 Change-Id: I209b132ccd5354e41849a33bb0509773b619fc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502511 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#821685}
-
Sergey Poromov authored
According to the latest UX mocks, when the running video screen capture is interrupted due to confidential content that appears in the captured area a corresponding notification should be shown to the user. See mocks: https://docs.google.com/presentation/d/1v0GM-lwHCznFJ6hnZlUH37eBOuAkJMw5Q6UnSkcKOgA/edit?hl=en#slide=id.ga41d6e7481_4_0 Bug: 1133324 Change-Id: Ibde37d0d5980b2ebe67f5b69cc2ab3f96e4fab99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502341 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#821684}
-
chrome://sync-internalsVictor Hugo Vianna Silva authored
For context please see crbug.com/1138535#c6. This CL brings back the code in SyncInternalsMessageHandler and about.js to fill the entity counts table in chrome://sync-internals. Some differences however: - StatusCounters is renamed to TypeEntitiesCount. - StatusCounters::ToValue() is inlined in SyncInternalsMessageHandler, since it's that layer which knows about the JS, and in particular that some hardcoded strings must agree with the JS code. - TypeEntitiesCount lives under model/, not under engine/cycle/, since it's not used by SyncEngine et al anymore. - SyncInternalsMessageHandler used to receive notifications for updates on these counts via a dedicated TypeDebugInfoObserver interface. Now, it actively queries SyncService::GetEntityCountsForDebugging() every time it gets notified via SyncServiceObserver::OnStateChanged(). Note that the SyncServiceObserver is only registered once the page loads [1], which means the counts aren't propagated before that, as it should be. - Notifications sent by SyncInternalsMessageHandler to the JS now include all data types at once. The notifications were coming for all data types in a for-loop before anyway [2]. - Value::Set*Path() APIs are used instead of the deprecated Set*(). Bringing back the code in ModelTypeProcessor to actually compute the counts is left for next CLs. [1] https://source.chromium.org/chromium/chromium/src/+/9b0dbaf8e5f258c1da4236e12edca53d7524344b:components/sync/driver/resources/about.js;l=206 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2474877/2/components/sync/driver/profile_sync_service.cc#1554 Bug: 1138535 Change-Id: Iae9f62cd5003b3e481d0e1814ff53c30a0002574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503728 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#821683}
-
Anders Hartvoll Ruud authored
Currently we assume that element-based offsets always have non-null targets ResolveOffset-time, since we enforce this during the creation of the (non-CSS) ScrollTimelines. However, for CSSScrollTimelines, we can't invalidate the rule this way, since we're referring to an element indirectly via an ID, not with a pointer to a specific element. Checking whether or not the target is null during ResolveOffset fixes this, and it's also what we're supposed to be doing per spec. This fixes a crash when using @scroll-timelines with element-based offsets that reference non-existent IDs. Also removed a nearby comment that's outdated (but not strictly related to the change in this CL). Bug: 1074052, 1102788 Change-Id: I4e138b55c3ef8cb122c58755a72a586e94c97e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498463 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#821682}
-
Eric Seckler authored
Switches the implementation of the --webview-force-little-cores switch from base::SetProcessCpuAffinityMode to content::EnforceProcessCpuAffinity. The latter periodically verifies that the affinity setting remains active, to detect when the system resets the affinity setting, and reapplies it if necessary. Test: Run system WV shell with the flag & check chrome://histograms Bug: 1111789 Change-Id: Icf4c360a36b8588086a0beb1caedd0e5869e3b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502430Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#821681}
-
Elizabeth Popova authored
It is propagated from address_profile.cc and will be used later in AddressEditor.java to show honorific field in Autofill Settings. Bug: 1141884 Change-Id: Iea5753792b3eebd78a18b53e9ea69aff4ffeeb71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498523Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#821680}
-
Dominik Röttsches authored
Bug: 1143192 Change-Id: Ic26cb52ff89f80aacdfb65a1611ddb6b68e27490 Tbr: nektar, dmazzoni Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503735Reviewed-by:
-
Jazz Xu authored
This CL fix the issue where user cannot use keyboard to access global media controls dialog and detailed controls in quick settings. Change-Id: I909e00e4e55ad0460886eb3ea3e231eaf0d79195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503399Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821678}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e6112e17b371..84b39fecd0ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: drott@google.com Change-Id: I007a69ad06b172ced95db0671450d7ac5603e99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505117Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821677}
-
Dominik Röttsches authored
BUG=1142877 TBR=poromov@chromium.org NOTRY=TRUE Change-Id: Ie4171b419bf82ebe534d3ae735a587d346986725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504513 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Olesia Marukhno authored
Based on: https://chromium-review.googlesource.com/c/chromium/src/+/1865014 Bug: 1005568 Change-Id: I8c04530c8a0582c2d7446dfcc42ec661d6efae2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398500Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#821675}
-
Anders Hartvoll Ruud authored
I made a mistake when writing this test initially: I wrote tests that verified that logical orientations (inline/block) resolve against the writing mode of the target element of the animation attached to a scroll timeline. This is not correct, it's supposed to resolve against the writing mode of the *source* of the scroll timeline. Bug: 1074052 Change-Id: I12f54502575e182f1a4b65df36f402b32632a2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501623 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
Observed after https://chromium-review.googlesource.com/c/chromium/src/+/2462900 NOTRY=TRUE Tbr: tkent Change-Id: I1cfe9edba0dd717fa4fbb88c3a43b712a6f00d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503518 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Add the main entry point for JS modules for Audio Player. Currently it contains the first two dependencies that have the module generated. Use this main.m.js generate the JS bundle for Audio Player. Use preprocess_grit() rules to group all required resources in the same directory to be able to generate the JS bundle. These are also used to inline images in CSS files. Bug: 1133186, 1030998 Change-Id: Ia40deab89d86cbeb9cf0a7855fda7268830fb15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504440 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#821672}
-
Michael van Ouwerkerk authored
This reverts commit 0b97d41c. Reason for revert: The failures were reproduced... in many places. Hopefully enough data to help debug. Bug: 1143207 Original change's description: > Enable NavigationRacesWithSitelessCommitInDefaultProcess on all platforms. > > Unable to reproduce flakiness locally. Enabling tests and removing skip > test logic for --site-per-process. Code was added to remove this flag in > SetUpCommandLine() so the tests can run on all platforms. > > Bug: 1110497 > Change-Id: I552f82d1fe4786e59cd624edf5504b713318d523 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500280 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Aaron Colwell <acolwell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821477} TBR=acolwell@chromium.org,alexmos@chromium.org Change-Id: I0d6472a0b2424b65db61559fb330275463fca9c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504266Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#821671}
-
sandromaggi authored
The method has been replaced by the equivalent |FindElement|. This will enable us to report the found element of the check to the caller. This change is a pure refactor without any intended behavioural changes. Bug: b/171782156 Change-Id: I5291099cbe0bc14473f62acf43b5a6554af891ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502374 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821670}
-
Eric Willigers authored
This CL records the intent that a ChromeOS application was launched with as part of the AppLaunchParams. This necessitates changing AppLaunchParams to be move-only, as apps::mojom::IntentPtr is move-only. When a web app is launched using LaunchAppWithIntent, the intent is passed to WebAppLaunchManager. Bug: 1125880 Change-Id: Ib6ec233fdac7efeb5862d5759cca750832549ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444614Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#821669}
-
Aya ElAttar authored
- Changed clipboard data endpoint destinations to accept a new parameter to control whether to notify the user if the clipboard is restricted with data leak prevention policy rules. - Updated clipboard read references with the new parameter according to the following: - If the clipboard read call is because of a user action trying to copy-paste, then a notification should be shown. - Otherwise the notification shouldn't be shown e.g. ChromePasswordManager, ClipboardAura, checking if the paste command is enabled for the context menu, ...etc. Bug: 1136290 Change-Id: I9eea9bee8d027650c56ace132e34dfed1e78d2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452712 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821668}
-
Finnur Thorarinsson authored
This reverts commit 4fd275d3. Reason for revert: Breaks the internal build: ../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:27: error: symbol not found org.chromium.chrome.browser.banners.AppDetailsDelegate import org.chromium.chrome.browser.banners.AppDetailsDelegate; ^ ../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:42: error: could not resolve AppDetailsDelegate public class PhoneskyDetailsDelegate extends AppDetailsDelegate ^ ../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:71: error: could not resolve Observer Observer observer, String url, String packageName, String referrer, int iconSize) { ^ ../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:26: error: symbol not found org.chromium.chrome.browser.banners.AppData import org.chromium.chrome.browser.banners.AppData; ^ ../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:83: error: could not resolve AppData private AsyncTask<AppData> createRetrievalTask(final Observer observer, final String url, ^ ../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:83: error: could not resolve Observer private AsyncTask<AppData> createRetrievalTask(final Observer observer, final String url, ^ ../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:123: error: could not resolve AppData private AppData parseAndVerifyAppBundle( ^ ../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:53: error: could not resolve AppData private final LinkedList<AsyncTask<AppData>> mQueuedRequests; ^ ../../clank/java/src/org/chromium/chrome/browser/AppHooksImpl.java:39: error: symbol not found org.chromium.chrome.browser.banners.AppDetailsDelegate import org.chromium.chrome.browser.banners.AppDetailsDelegate; ^ ../../clank/java/src/org/chromium/chrome/browser/AppHooksImpl.java:92: error: could not resolve AppDetailsDelegate public AppDetailsDelegate createAppDetailsDelegate() { ^ Original change's description: > [Android] Move and modularize android/banners. > > This CL moves AppBanner* code from: > chrome/android/banners > ... to ... > chrome/browser/banners/android > ... and modularizes it in the process. > > Bug: 1135551 > Change-Id: I8773b293e55f03ca66da15551e27a06e26e2ae96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489917 > Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821646} TBR=nyquist@chromium.org,finnur@chromium.org,dtrainor@chromium.org Change-Id: Ib1570bc83be4716cabf67bc71b3d4e723333bffa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503952Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#821667}
-
Dominik Röttsches authored
Tbr: alcooper@chromium.org, klausw@chromium.org Change-Id: Ib0b150b53a31ce63d3fe7dbf41ca700c81dd57cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504672Reviewed-by:
-
Michael Lippautz authored
The flag allows switching the Blink heap implementation to using V8's version of Oilpan. Bug: chromium:1056170 Change-Id: I56e116586b38f4cea0666074d9ecbc8a754d0eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504252Reviewed-by:
-
Jazz Xu authored
Bug: 1142880 Change-Id: I7e637b83bf15f6957782eb6348b87761bfe85296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503314Reviewed-by:
-
Cherie Cheung authored
Refactor OpenFileToRead() to prepare for MTP support in ARCVM. 1. In OpenFileToRead(), the main work for MTP flow is refactored into GenerateVirtualFileId() and OpenFileById(). 2. Added 2 new FileSystemHost mojo call: GetVirtualFileId() and HandleIdReleased(). BUG=b:158606367 TEST=As a regression test, in ARC++, a file can still be opened with an Android app via MTP successfully. Change-Id: Iea6cedd37903f94138428016b663e225d05138dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444757Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Cherie Cheung <cherieccy@google.com> Cr-Commit-Position: refs/heads/master@{#821663}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: If3a54f33224fe1ab7f3557dbf8dfdc620c150d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504204Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821662}
-
Hidehiko Abe authored
This CL replaces third_party/icu uses with base/third_party/icu. Along with the change, base/third_party/icu/* is updated to v67. - Extracted several macros used for char_iterator implementation. - Removed utf8_nextCharSafeBody, as it is no longer used. This CL is preparation to move char_iterator to base/strings so that it can be used in new functions in base/. Bug: 2492481 Test: Ran base_unittests. Change-Id: I779c7384b15701dcac3feac9d258be5793ca209d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494402 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821661}
-
Viktor Semeniuk authored
This change adds "Signed in with" row for federation credential on the Password Details screen. Bug: 1137807 Change-Id: Ie9e6d8b78eef253098111904306fbffe4262f897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467937 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#821660}
-
Kushagra Sinha authored
Move `AccountManagerFacade` from //chromeos/components/account_manager to //components/account_manager_core so that it can be depended on by ash-chrome and lacros-chrome both. Bug: 1117466 Change-Id: I475c0b18d8ce50698c085d841a014f33016e5a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494938Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#821659}
-
Dominic Farolino authored
This CL removes the temporary fetch() UseCounters introduced in crrev.com/c/2242205 to help with metrics collection for ServiceWorker folks. R=kinuko@chromium.org, yhirano@chromium.org Bug: 1072350 Change-Id: Id3327fe1ed9792a9ed8fd3e7333c08293cca1f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503188 Auto-Submit: Dominic Farolino <dom@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Alexander Dunaev authored
The UserInputMonitorLinux depends on X11 directly and cannot be used by Ozone platforms because of that. This CL introduces a new platform interface for the user input monitor, and moves the X11 implementation to //ui/base/x. The UserInputMonitorLinux now uses either the X11 implementation directly (when X11 is enabled but Ozone is not) or requests the platform implementation when Ozone is enabled. Bug: 1116414 Change-Id: I0a21074f2fe028fea13c7efb33ddf9d102c9f35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489863 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#821657}
-
Maggie Cai authored
Currently if we open the link in a new tab (e.g. ctrl + click, context menu, from another app), the intent picker icon will not show up even there are apps that can handle that URL. This is because: 1. We check the browser for the web contents in navigation throttle before the adding the web contents to tab strip model for new tab case. 2. When open new tab from new-tab page, the starting URL is empty. This CL fixes this issue by moving these checks to only check for automatically pop up the bubble or automatically launch the app, but still show the icon if there are app found. BUG=1141049, b/171260488 Change-Id: Idcf4b07c34304bf6664f874142128ceddb6d6569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500974Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#821656}
-
