- 05 May, 2020 28 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4271443d7e44..41f7bcce04a8 git log 4271443d7e44..41f7bcce04a8 --date=short --first-parent --format='%ad %ae %s' 2020-05-04 cclao@google.com Vulkan: Add missing cache flush 2020-05-04 jmadill@chromium.org Vulkan: Update VMA integration. 2020-05-04 sugoi@google.com Fix clearing the program's validation-related cache too early Created with: gclient setdep -r src/third_party/angle@41f7bcce04a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1074162 Tbr: courtneygo@google.com Change-Id: Iafcd49f03b16ef17bda3071183df33360562f677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181647Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765371}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1363c04b..f753bc34 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If92f4aab9b34700eb19a14d0e2c46955b856a2e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181890Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765370}
-
Natalie Chouinard authored
Now that KitKat (v19) is deprecated, merge settings-related style resources under //components/browser_ui/settings from v21/styles.xml into the base styles.xml. Bug: 1009058, 971791 Change-Id: Iaa7adad93141fb970157c0b9fdc3a07f01895936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176515 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#765369}
-
Zhenyao Mo authored
BUG=1046598 TEST=bots R=kbr@chromium.org Change-Id: I86f6251736db588366eb9fd3089cf00398752a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181225 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#765368}
-
Ted Meyer authored
running theory is that it's possible for RTCVideoDecodeAdapter to be destroyed while the callback is posting, so when it is finished the result is dropped. Making the method static prevents this. Bug: 1076817 Change-Id: I07f6ef991891af4b3646df87597f6abf7bcee94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181717Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#765367}
-
Jon Mann authored
This metric will get recorded each time the sync service starts and whenever the total count changes. The count of unique users that record this metric can be used to find the active user count. Bug: 966270 Change-Id: I06b79c2e703299d5585935d70003198a4958aa52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166123Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Jon Mann <jonmann@google.com> Cr-Commit-Position: refs/heads/master@{#765366}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db551cbc8b4b..af417bfdda10 Created with: gclient setdep -r src-internal@af417bfdda10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC estade@google.com,keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1065456 Tbr: estade@google.com,keishi@google.com Change-Id: I6c10bc00225bdab34a4810cc3a9355b183a19dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181644Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765365}
-
Tom Anderson authored
BUG=1074222 R=thestig Change-Id: I7789f5ed070997491aa3ea3366edae9a3c76a8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181050Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#765364}
-
gogerald authored
screenshots: https://drive.google.com/a/google.com/file/d/1t90H0jzZynyzwd4-JdMlh6s_Q6KhWlsk/view?usp=sharing https://drive.google.com/a/google.com/file/d/1gTirnwr0jhJghSWCkr2tnd0ySlaUF2Ai/view?usp=sharing Bug: 1076449 Change-Id: I64292f34e40269707d2cc09cbdd7a4da4c56e303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173118Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#765363}
-
nancy authored
Content menus use the AppService mojom, so it is asynchronous. When right click on an icon for context menu, the context menu callback is not run yet, so the checking in Ash (context_menu_ && context_menu_->IsShowingMenu()) can't return true to draw the round rect for the icon. Add waiting_for_context_menu_options_ to the checking condition, to draw the round rect for the icon. BUG=1076839 Change-Id: I0fbc2809dd11afacddde9cf21db4043cb5196fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174251Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#765362}
-
Antonio Gomes authored
This is a follow up of https://crrev.com/c/2165906, and another step forward to get rid of RenderWidget::SetHasTouchEventHandlers(). Note that the only reason the method is not removed as part of this CL already is because this method is still overridden by TouchEventHandlerWebWidgetClient class (web_view_test.cc). It essentially moves the ownership of |render_widget_scheduling_state_| from content::RenderWidget to blink::WidgetBase. WebWidget gets an accessor, implemented by its 3 child concrete classes WebPagePopupImpl, WebExternalWidgetImpl and WebFrameWidgetBase. BUG=1071594 Change-Id: I1b54332695a6c7784737a3c54c9a1a76a91b0fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173482Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#765361}
-
Matthew Denton authored
Bug: 1015134 Change-Id: I7f119912e5a8ebbca92178c99220d9f66f5f7fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156143 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#765360}
-
Xianzhu Wang authored
This can avoid duplicated entries for virtual tests. This allows a virtual test without specific expectations inherit the base test expectations. If a virtual test has specific expectations, they will override the base test expectations, except that [ Slow ] will be merged. This requires flag-specific expectations to use the same override rule. Previously they always inherit the base test expectations, causing us unable to override the expectations to e.g. [ Pass ]. Requires https://chromium-review.googlesource.com/c/catapult/+/2173206. Bug: 1072015 Change-Id: Ie3d1911a96f70799a996b6abbd78f9a5107d7eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173656 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#765359}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I75b41728ae8208f9f763fafebe97373e6cdfab5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175698Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#765358}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d5f937bfca36..6d2febd632a2 git log d5f937bfca36..6d2febd632a2 --date=short --first-parent --format='%ad %ae %s' 2020-05-05 egdaniel@google.com Reland "Add create backend texture with color upload bench." Created with: gclient setdep -r src/third_party/skia@6d2febd632a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: Ia3eeeed126af0ddd31462d16705e12f8c4fc4c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765357}
-
Sergey Ulanov authored
Previously PlatformSharedMemoryRegion would fail to wrap a read-only handle with SET_PROPERTY permission. Now PlatformSharedMemoryRegion will ignore SET_PROPERTY permission on the VMO handle. This will allow to wrap read-only VMO handles produced by sysmem with PlatformSharedMemoryRegion. Also added a check to verify that the passed handle is a VMO and not some other zircon object. Bug: 1077827 Change-Id: I71a7d68e4f0edd2ca4eecc962f213a42dc55b0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180546 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#765356}
-
yilkal authored
This cl refactors WebTimeActivityProvider from keeping a map between active browser instances and their active web contents. The map is not necessary and has been replaced by active browser instances. We can easily get access to the active web content via the tab strip model of the browser instance. There is no change in the functionality of the code. Bug: 1051201 Change-Id: I38c928118fe0eb68c5593188e3db2d570e78ce9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181186 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#765355}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I933a2cb27b816d15c4808aa798cbd40af0a5b5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175779Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#765354}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0ad7d761de823432566498e5a1d33db64f64d9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765353}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c8c8fa1a5358..7ccffca0b480 git log c8c8fa1a5358..7ccffca0b480 --date=short --first-parent --format='%ad %ae %s' 2020-05-05 btolsch@chromium.org Make IPv6 E2E test optional Created with: gclient setdep -r src/third_party/openscreen/src@7ccffca0b480 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I05ffff0ad27c90cecf823f2e8172e49f9dfa92a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765352}
-
James Cook authored
Introduce "LacrosLoader" to manage the download and hold the mounted image path. Bug: 1077348 Change-Id: I3de7a42b821c0ca58af63af85c74872b2d77b913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177299Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#765351}
-
Nate Chapin authored
Also, move it entirely out of core/. This involves adding a callback to CoreInitializer to notify ScreenOrientationController of orientation changes, but it's less code overall, and it allows us to lazily initialize the ScreenOrientationController. Bug: 1029822 Change-Id: Ifc2b98886fdcf2a5e20e78d6e2bc577e5ce4b580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173397 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#765350}
-
chrome://discards/graphSigurdur Asgeirsson authored
Bug: 1068233 Change-Id: I6670998acb5fc4ecefd78d0cb2cff784e193c099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173869 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#765349}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I236ae120c36f4da53c5c0b5fffb6792fb5629d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175936Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#765348}
-
Rahul Arakeri authored
This CL gets rid of the several ScrollbarLayerImplBase references in the private methods of ScrollbarController. They need not be passed around because the ScrollbarLayerImplBase can easily be looked up by calling ScrollbarController::ScrollbarLayer (which retrieves the needed scrollber layer by using CapturedScrollbarMetadata::scroll_element_id). Bug: 1077093 Change-Id: I2bb48b4fe61227e6e89c4dff8cef4064a20e3965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174809 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#765347}
-
Sunny Sachanandani authored
CanvasResourceDispatcher creates a CompositorFrame with exactly one quad, but because it uses the default RenderPass::Create() factory function, it ends up allocating storage for 128 quads and 32 shared quad states. A similar use case, VideoFrameSubmitter, was measured to take around 0.2% of total Chrome CPU time in cases like Google Meet which have a large number of VideoFrameSubmitters. Although there are no measurements for offscreen / low latency canvas, the same optimization should help. Bug: 1077299 Change-Id: I4862e8bda50edd35c73adf26c1d5b180de1cb2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181076 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#765346}
-
yilkal authored
This cl removes chrome time limit hack where android chrome's time limit is used to set the time limit for chromeos chrome. This cl default disables web time limit feature flag. Bug: 1077930 Change-Id: I397041d73fca80ffb7e6c08889bf8a89218e5ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176601 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#765345}
-
Darwin Huang authored
ui::Clipboard::ReadAvailableTypes contained an unused argument named |contains_filenames|, which was both not implemented (always defaulted to false) and not used (all users of this function didn't use this argument). Remove this unused argument. This argument was added by https://crrev.com/6685063 in 2011, as wiring to later provide support for copying and pasting from filesystem managers (ex. Windows Explorer). This feature was never fully implemented, and there are no active longer plans to implement it, so remove this unused code. Change-Id: I4615a3a08d80d1aa9f91e126db940cf89b9c9895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173666 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#765344}
-
- 04 May, 2020 12 commits
-
-
Abigail Klein authored
Send a TranscriptionResult struct, which contains the transcription and whether it is a partial or final result, from the speech service to the UI. When the UI receives a partial result, it replaces the previous partial with the new one. When the UI receives a final result, it commits that string. Bug: 1055150 Change-Id: Ib5aa0cff2cc7346338c7aca9763535cf9d355eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176593Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#765343}
-
Robert Ogden authored
Adds all the ones wanted for UKM, as well as an additional one, kPrefetchSuccessful, which probably won't ever be logged to UKM (since such a prefetch would be used and have a different status set) but is nice for unit testing. Bug: 1074385 Change-Id: I4c9b3641295a1a262f3c0277a0e953efbc0e306f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181543Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#765342}
-
John Lee authored
This CL also cleans up some of the padding and margins to make it more consistent with the other pages. https://imgur.com/a/NfdN1im Bug: 973674 Change-Id: I216c63a9c09bc0635ec5c37ef6f9c2ed76ecece9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181523Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#765341}
-
Yves Arrouye authored
Most constructions of a CloudPolicyClient do not provide a single piece of device identification and don't care to use the client for operations where these matter. Provide a cleaner constructors for all those uses. Bug: chromium:1077551 Test: Build Chromium Change-Id: Iabad86a87203726b9695243696160b875bc5226e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177227 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#765340}
-
chrome://appsDaniel Murphy authored
This change adds the installAppLocally support to chrome://apps. There is no current way to set the 'locally_installed' attribute to true other than through this 'ForTesting' method, but that method looks appropriate for this use case. This CL changes that method to not be ForTesting, and calls the appropriate follow up steps using the WebApplication systems (creating shortcuts and registering file handlers). This is the final migration of AppLauncherHandler to use the BMO WebAppProvider system. R=calamity@chromium.org, loyso@chromium.org Bug: 1009302 Change-Id: I0f2c3211a2d74f67c5de637f96129fae2398118d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171845 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#765339}
-
Xinghui Lu authored
Before we return extended_reporting_enabled, we should set *reason = RequestOutcome::DISABLED_DUE_TO_USER_POPULATION if extended reporting is disabled. If we fail to do so, *reason keeps its default value. A future CL will separate setting reason from the implementation of IsPingingEnabled, which will help avoid such bug in the future. Bug: 1077420 Change-Id: Ie22fb3f6e6db1c7ea7b2b81e05f7bcfadb6b9433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181466Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#765338}
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1077671 Change-Id: I8a6d86dd5a5066246db235a5ce8597ee2540b28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179042 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#765337}
-
chrome://appschrome://app-icon/Daniel Murphy authored
This change is the front-end half, which hooks up the chrome://apps page icons to the chrome://app-icon scheme. This doesn't fully work yet, as the AppIconSource is not yet compiled on non-ChromeOS builds. That will be done in a follow up CL. Bug: 1062081,1068453 Change-Id: Iec1905d83a515ee54f5b6c45aaaf893471d86841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163948 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#765336}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c07cb95ffe25..db551cbc8b4b Created with: gclient setdep -r src-internal@db551cbc8b4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC adithyas@google.com,estade@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1038145 Tbr: adithyas@google.com,estade@google.com Change-Id: I0e0b9aba5f052d222dccf707442ca09ed54fc723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181486Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#765335}
-
Renjie Tang authored
This change introduces no API changes. But API documents need to be updated. Change-Id: Ibc347df79066de704c5be0683c5b658ba6e1896a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168553 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#765334}
-
deepak1556 authored
Bug: none Change-Id: Iace766c61a64987fa4c25a12b0a74b3ec09d2c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173416 Auto-Submit: Deepak Mohan <hop2deep@gmail.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#765333}
-
Dale Curtis authored
The way this is implemented will lead to overlays being enabled on paths where a blacklist may be applied. The variable names are changed to make it clear that this affects all overlay support, not just hardware ones. R=sunnyps, zmo Bug: 906722, 1056267 Change-Id: I25ae0e465376f1cb9d19b279b7498802021a23fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176269Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#765332}
-