- 04 Jun, 2020 40 commits
-
-
Edward Jung authored
Bug: 1088998 Change-Id: Idf5412744f4408b4aca7faeabb9cec1344b0478c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228621 Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#775259}
-
Preethi Mohan authored
Bug: 1025371 Change-Id: I12bce9cd3f8f9a62cdb859db6d499b59f6d1a4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219409Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#775258}
-
Jonathan Koren authored
Makes the list of SDKs and the GCS bucket more configurable. Bug: fuchsia/52114 Change-Id: I0f2da8da42486f2fe84c3c71537151e2f5a1781c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181573Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Jonathan Koren <jdkoren@google.com> Cr-Commit-Position: refs/heads/master@{#775257}
-
Eric Orth authored
*Remove unused address-family breakouts *Convert SecureDnsMode times from per-request to per-job as the network stuff (per-job) is where we expect interesting data *Move handling of per-request metrics into RequestImpl for better organization. Slight behavior change of now including "incomplete" requests that were aborted or cancelled for full queue, but seems to be a reasonable simplification for a request-level metric. Also rename these metrics to be more obviously request metrics. *Update expirations to "never" since these are core metrics we want to keep (except the SecureDnsMode metrics). *Update owner on changed metrics to myself. Bug: 1088994,854018 Change-Id: Icabf35e4136ca3a0bad6774aea78bca55f242228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227377 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#775256}
-
Brian Sheedy authored
Adds most of the standard GPU gtests to the GPU CrOS builders. Several test suites are left omitted for now due to widespread failures in them. Bug: 1080424, 1087590, 1087567, 1087563, 1087558, 1087552 Change-Id: I5055d870d445f13fafa626f2d2d8a40afae8b654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219227Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#775255}
-
Fabio Rocha authored
Manifest-based registration for protocol handlers should, as much as possible, use the same validation logic used by `registerProtocolHandler`. In order to do that we needed to modify NavigatorContentUtils a bit for some of the validation functions not be dependent on objects not known to the manifest parser (e.g.: Document, ExceptionState..). Instead, we extract some error handling logic out and pass arguments in the format ready to be validated. A subsequent CL will include modifications for the manifest parser to consume from the functions exposed here. Bug: 1019239 Change-Id: I38189e305b67a4ccb9820cbb450546e056774c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227469Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#775254}
-
Andrew Xu authored
When calculating the target layout strategy, only two parameters are required: the scroll distance on the main axis and the length of available space to layout shelf icons. In other words, we don't need the scrollable shelf's view bounds which is the third parameter of the current function. This CL should not introduce any visible difference. Bug: 1042911 Change-Id: I57431969cb0bdaee71e5ba2b82faa4fdcc02428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231090Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775253}
-
Jun Kokatsu authored
This change adds Trusted Type policy for parse_html_subset.js, so that sanitization happens without a Trusted Types violation. Bug: 41905 Change-Id: I545d1a7a28b22d56f5c4539a3c20923ab26d6d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215701 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#775252}
-
Robert Ma authored
This prevents the server from dying silently in run_blink_[SERVER].py by checking whether the server is alive every second. (See the race condition where the server dies after a seemingly successful start in the linked issue.) Unfortunately, this does not fix run_web_tests.py. Bug: 1090491 Change-Id: Ifb5a73284716a980a752ce3ed9c8210ba9510f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229472 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#775251}
-
Lukasz Anforowicz authored
Fields in system headers (and generated) code were not rewritten even before this CL, because |apply_edits.py| ignores edits that apply to files that |git| doesn't know anything about. But, before this CL, such fields would be considered "affected" and therefore Chromium code might see |.get()| appended when using such fields in |printf|, |reinterpret_cast|, etc. Such inconsistency would lead to build errors after the rewrite. After this CL, fields in system headers (and generated code) are explicitly excluded (early on, in the |field_decl_matcher|). Bug: 1069567 Change-Id: Icc9735b94558828c002572b38dcef12a812de35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204305 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#775250}
-
Jon Mann authored
This reverts commit c222db59. Reason for revert: Breaks layout of some Chrome OS settings pages including network details and displays. Original change's description: > WebUI: Remove --cr-section mixin > > The CSS rules in the --cr-section mixin are moved into the only CSS > class left using it. A TODO has been added to address the similarity > of cr-row and settings-box, but this should not be considered high > priority. > > Bug: 973674 > Change-Id: I34437c39cb38b6fe0568a243a1eee41900ab6490 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216646 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773978} TBR=dpapad@chromium.org,johntlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973674 Fixed: 1091386, 1091389 Change-Id: Ief47ae2ffb0f7cbfb0e5e0c7331544214a6ac0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231462Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#775249}
-
Ken Rockot authored
The presubmit step for checking mojom backward-compatibility does not work properly when a mojom file is deleted. This is due to incorrect use of the presubmit input API, effectively not providing the checking tool with any information about deleted files. This fixes that. Fixed: 1091407 Change-Id: I4cd3d7bb5ce07a7d75e8bac99319c75ca6d28118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231266Reviewed-by:
-
Sean Gilhuly authored
The test in this filter file is for SkiaRenderer Dawn Vulkan, which is run only on Linux. To avoid possible test numbering collision or confusion, use this filter only on Linux. Bug: 1021566 Change-Id: I2f379093f3bed831e6b3037ee9d653cfeb35d08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225216Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#775247}
-
Robert Ma authored
Originally, I tried to use shutil.copy to preserve the mode of the files, but I found out there were tons of permission violations in the upstream, so I filed a bug * and tweaked the existing workaround. * https://github.com/web-platform-tests/wpt/issues/23997 Bug: 1091205 Change-Id: Id54c466192d671c758f04fcdf81b51eb9ebdf070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231264 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591214254-82dbd7c2e7bf4bdc6dd6038655b6e3a5aff423fd.profdata to chrome-win64-master-1591286362-902781b12ab9dd448871f9768174868838c7d326.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8abdb1dee4fef4ce246073deb27163729e5e7b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230249Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775245}
-
David Schinazi authored
This is part of our effort to eventually make ParsedQuicVersion a class (instead of a struct). This CL does not change any behavior. Change-Id: I43000a2f7bdaa69f2cdf47e82976835d826104fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227316 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#775244}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591214254-e18b6c29801bc822569148c5ef87c3e9d9cb875d.profdata to chrome-win32-master-1591286362-6877841deaea578e7b1f46c63cdb9931635faa06.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id3d64796123032fc1767b72600756ab61d80ed28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231014Reviewed-by:
-
danakj authored
Delay navigating an iframe until after the main frame has finished loading its document so that, in case the iframe is in another process due to site isolation, the logging from the main frame and the iframe do not race and create flaky results. R=dgozman@chromium.org Bug: 1088441 Change-Id: Id33996ac3a07c307fde2b0fc099e35f1e2f0500f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229402 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#775242}
-
Esmael El-Moslimany authored
Bug: 1091367 Change-Id: I8283c28f0bdbb2b1fa87bdab76e2dc508ff6bdb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231291 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#775241}
-
Daniel Cheng authored
Bug: 1059157 Change-Id: Ie40c9fd6ca3a0fc38a9618ba0c173794a0902903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228190Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#775240}
-
Filip Gorski authored
Color tint list for dark theme is behaving differently when: - selected - focused - pressed - activated Fix is to remove the alpha from these states. Bug: 927145 Change-Id: Ifc5409b85135e58c236a57f06432920e8134155d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218494Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#775239}
-
Chris Hamilton authored
This cleans up the scattered hooks in favor of a centralized hook, and tightens up assumptions in production code and in tests. It also cleans up various test harnesses, removing redundant notifications and using standardized harnesses. Change-Id: Iacca86a52e579053670a4e28ce3b7152ecb02a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219184 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#775238}
-
Robert Sesek authored
Bug: 1088543, 1088544 Change-Id: I50ac8ec143eee0b931968e9e3aa7170b7f952a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227064 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#775237}
-
Chong Gu authored
Bug: 757053 Change-Id: Iddc2c1bd3cd19f1ee2613f7c273fbcfad79426e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231442Reviewed-by:
-
Yiwei Zhang authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/90c5e17a8261..4c095d041 $ git log 90c5e17a8..4c095d041 --date=short --no-merges --format='%ad %ae %s' 2020-06-04 yiwzhang Remove a duplicated method introduced in rebase 2020-06-04 yiwzhang [logdog] Merge all changes to copy of logdog client lib in recipe engine 2020-06-04 yiwzhang [lucictx] Mark env key for LUCI_CONTEXT non-internal and export it from pkg 2020-06-04 yiwzhang [lucictx] Allow LUCI_CONTEXT file to leak after contextmanager exits 2020-06-03 tikuta client: update isolated client 2020-06-03 tikuta client: update isolated client 2020-06-03 tikuta client: update isolated client 2020-06-01 tikuta client: update isolated client 2020-06-01 tikuta client: include title of luci-go CLs in isolated updating CL 2020-06-01 tikuta Revert "client: enable isolated everywhere again" 2020-05-29 tikuta client: enable isolated everywhere again 2020-05-29 tikuta client: introduce heap profile collection for some bots Created with: roll-dep src/tools/swarming_client R=iannucci, tikuta Change-Id: I9b25e12268f1da7fd4a47000d5fd7cabb283f385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229884 Commit-Queue: Yiwei Zhang <yiwzhang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#775235}
-
Peter Wen authored
Reduce lint to using __header and __assetres targets instead of the full java targets. For chrome java signatureless, this means going from 110s -> 83s, a 27s improvement. The only target that __lint targets wait for is the turbine header generation (~5 seconds for chrome_java), so not much more headroom for improvements without actually speeding up lint. Bug: 1082743 Change-Id: I205151fcf1949252017c66b49986bcc91284f2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229206 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#775234}
-
Jonathan Ross authored
This reverts commit 3be4a6e9. Reason for revert: Updated test is flaking on all platforms. crbug.com/1091377 Original change's description: > [WebSocket] Test header + close frame in same packet > > Modify the existing web platform test opening-handshake/005.html to send > the response header and the close frame in the same packet. This > verifies that Chrome passes the close data to JavaScript correctly in > this case. > > This increases the coverage of the existing test, so there's no need to > retain the old behaviour. > > Also remove the timeout expectations for this test, and make sure it > doesn't timeout on failure. > > Closed: 1090210 > Change-Id: I327c55d1517615511d6d71e1b464d5d3dc03b502 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228252 > Commit-Queue: Adam Rice <ricea@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775124} TBR=ricea@chromium.org,yhirano@chromium.org Change-Id: I729663e5d0f7f6e41304b67c135b9af8946e503e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231268Reviewed-by:
-
Gang Wu authored
This is a reland of 3288b2d9 Original change's description: > Reland "Fix image search from search activity" > > This is a reland of 91eda9e8 > > Original change's description: > > Fix image search from search activity > > > > SearchActivity did not handle image search data since image search need > > post data, so the fix is add the post data into intent to pass to chrome. > > > > Bug: 1078773 > > Change-Id: I04efdad0bba315508e0b05d3d9e444d8c1a5d955 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187191 > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Ender <ender@google.com> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#772335} > > Bug: 1078773 > Change-Id: I86f1fbab1cc27a66ceb5ad8ac987179b8f5e8e68 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220150 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Gang Wu <gangwu@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774036} Bug: 1078773 Change-Id: I0084e475067c75db4d89ce3a890694525705c865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228983 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#775232}
-
Etienne Pierre-doray authored
Bug: 989102 Change-Id: If733b62f4e5b2b3044c20935ef443748b47399b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201658 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#775231}
-
Jonathan Backer authored
This call can be slow on some GL driver stacks (e.g. ANGLE with D3D backend). This reduced the number of checks on ie_chalkboard from ~900 to ~300 calls. Bug: 1090232 Change-Id: I6f70e53269c6df967b0ce5050b3334da44cb3cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229406Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#775230}
-
Yi Gu authored
This test has been flaky since it was introduced. Probably due to the same issue as issue 1046784. TBR=yurys@chromium.org Bug: 1046784 Change-Id: I02b4e0c7c39c6123b1a6f0db70f1dacf6c7cbd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230913Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775229}
-
Fabian Sommer authored
Remove constness of the ExtensionHostObserver passed in OnExtensionHostDestroyed. This allows scoped observers to stop observing a host that is getting destroyed. Fixed: 1086475 Change-Id: I9abc696fe164f26b4927cd7366e1cd04570dbe43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216211Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#775228}
-
Clark DuVall authored
This implements popup blocking logic in WebLayer that matches chrome. To make this work, I needed to add a bit of functionality to open windows in other dispositions besides CURRENT_TAB. Bug: 1084013 Change-Id: I99df4b618a97f954347a1acdac844702053d1be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228365Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Juanmi Huertas authored
There was a missing part of an if cause allowing passthrough to be tried as a Canvas Resource Provider. Re adding that check, and removing the expectation of the test to fail. This CL fixes as well https://buganizer.corp.google.com/issues/158138519 Bug: 1088023 Change-Id: Ic896d0d0b6cdbc72a0751daf0b2e629a0febdf18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230764Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
Peng Huang authored
Bug: None Change-Id: Ibb1568a17df7b7b2656f90888620c19a8e9e1ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231443Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#775225}
-
Eugene But authored
False is no longer supported configuration. Bug: 1017165 Change-Id: I67ec5b56afc2b2363c6013106bf4f4f0123e2114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228052Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#775224}
-
Sammie Quon authored
Early users were finding trying to align windows to the top of the display was sometimes difficult because maximize kept procing. Reduce the threshold to 8px. It's much smaller, but we anticipate people who want to use it will normally slam their mouses to the top of the screen. Test: manual Bug: 1091036 Change-Id: Id5c58f77d30fbc4b07d0cdba64e5fcbecbd3b0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229764Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#775223}
-
Jacques Newman authored
This implements the base class NGGridTrackCollectionBase and relevant tests. NGGridTrackCollectionBase provides an implementation for some shared functionality on track range collections, specifically binary search on the collection to get a range index given a track number. This change also adds NGGridTrackCollectionBase::RangeRepeatIterator, which iterates over ranges. There are 4 planned NGGridTrackCollections: 1. NGGridTrackRangeCollectionBase - Base class for shared functionality, layout-only, non-persistent. 2. NGGridElementTrackCollection - Defines the ranges needed due to specified tracks, layout-only, non-persistent. 3. NGGridAlgorithmTrackCollection - Used for sizing tracks in NGGridLayoutAlgorithm, layout-only, non-persistent. 4. Blink::Grid interface - Blink-wide interface used for accessing grid elements after layout, persistent. Link to Design Doc for LayoutNG CSS Grid: https://docs.google.com/document/d/1J2MunypRmbqPyHVLZjgN-xjNvYk77kPXyO3lhqj7OSI/edit?ts=5e949de9 There should be no behavioral changes associated with this CL. Bug: 1045599 Change-Id: Id9880fd2f1fb05e21e8642b0f4b766f9aaecad2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225835 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#775222}
-
Christopher Cameron authored
Change YouTube, GMail, and Google Drive (non-bookmark) apps to use RemoteCocoa. Do this just by inspecting their app id. These apps exist in a strange corner where they are not bookmark apps, but largely behave like bookmark apps. It's an open question if they should be multi-profile or not. In this patch I err on the side of caution and treat them as old-style non-multi-profile apps, because much of the multi-profile handling code is now PWA-only (post-BMO). In working on this, I found a bug wherein we assume when generating app shims, that any app that has a start URL is a bookmark or PWA app. This is not a valid assumption. Add a new field to web_app::ShortcutInfo to track if an app should be multi-profile, and populate it accordingly. There will be one bug here that I won't be able to fix without more effort and risk than it's worth. If someone created a multi-profile app shim for any non-PWA app that happened to have a valid URL, that shortcut will no longer "work" in that it will open the app in a new Chrome window instead of an app. Launching through chrome://apps will repair the situation. This is documented in crbug.com/1091318. R=dmurph TBR=rdevlin.cronin Bug: 1086824 Change-Id: Ibd829b07ed806c3e3c45b67075c5e25e368b9341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229663 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
phillis authored
The badging success/error windows metric looks stable and we can mark it as obsolete. Extend for MacOS to further investigate on no app shim host errors. Bug: 1089333, 1088645, 1088644 Change-Id: Ie5fe0bc219a9203079237124bc014056fd1b6721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229365Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
