- 21 Oct, 2020 40 commits
-
-
Tal Pressman authored
Currently, renderer-side objects (RenderFrame, RenderView, etc.) assume the AgentSchedulingGroup outlives them, but this is not the case if the disconnect handler is called before they are destroyed. After this CL, the ASG's lifetime will match the RenderThread's, and it will be destroyed when the RenderThread is destroyed. This is OK for now, since we currently only have a single ASG per process and the host's lifetime matches the RenderProcessHost's. In the meantime, kouhei@ is working on properly shutting down ASGs via an IPC, similar to other objects. Bug: 1137580, 1138942 Change-Id: Iab02cecf3cd828a0b84f2bc29e451d1a591422ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478622 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#819238}
-
Arnaud Mandy authored
Test is not passing in upstream wpt due to insecure context error. https://wpt.fyi/results/screen_enumeration/screen_enumeration_permission.window.html?run_id=728120001 Renaming file with .https. extension to use secure context. Bug: 1075656 Change-Id: I5842a253d296b364bfc26130b7f0f0af23dc90de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485503Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#819237}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bd66f2d95186..d2e6434aadb1 2020-10-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iefd37357fea84f35f9564c4e76aa0e388bcbc2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819236}
-
Fergal Daly authored
This reverts commit b9d174e5. Reason for revert: I think this is causing tree closures https://ci.chromium.org/p/chromium/builders/ci/android-archive-dbg/6649? Original change's description: > Enable isolated splits in canary > > All known issues have been fixed so enabling this in canary to see if > there are any major problems. > > Bug: 1126301 > Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819200} TBR=agrieve@chromium.org,cduvall@chromium.org Change-Id: I6d4266c956c435cd21b0b0d9d36135def48a933b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488961Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819235}
-
Alexey Baskakov authored
Drive-by: Use GetApps() iteration where `is_in_sync_install` flag was checked. This CL introduces no behavior changes. This is a follow up renaming for previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1295131 Bug: 891172 Change-Id: I3f187846c5d1732835da618293c5bd6d37cfbcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485417Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#819234}
-
Timothy Loh authored
This CL fixes a crash that can occur when a USB device shared with a VM is shared with a different VM. If the device has not yet been attached, e.g. as the first VM is not yet started, we end up in a recursive loop between CrosUsbDetector::AttachUsbDeviceToVm(), DetachUsbDeviceFromVm() and AttachAfterDetach(), eventually getting a stack overflow. Bug: b/171265431 Change-Id: I0ecc28e55160c310473dce3a98f8ada0f99eb3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485660 Commit-Queue: Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#819233}
-
Alex Kalugin authored
Download.DownloadManager.CreationDelay histogram description states > Records the delay of creating non-incognito download manager after the > download system is initialized. but currently histogram is reported only for incognito profiles. Change-Id: I48344f2b67af3cb1bf62b54d6b2b7fbb507b5e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485269Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#819232}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/85d9d5d4bbc6..84f5eeb6dd9b 2020-10-21 amaiorano@google.com Fix Android build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I97406f7996c9fc47ca7bae0ba77163e3704cd61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488154Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819231}
-
Nidhi Jaju authored
According to https://github.com/whatwg/streams/pull/1035, all methods and accessors are now enumerable, per Web IDL defaults, instead of non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can be removed from the Streams WebIDL files. This CL specifically removes them from transform streams. Bug: 1093862 Change-Id: I509b470722039ebad20b8caeaa7f34189c24b1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486006 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#819230}
-
Andrew Grieve authored
All uses of it replaced with one of: * Arrays.asList() * Collections.emptyList() * Collections.singletonList() TBR=agrieve # Trivial .java refactor to //components Bug: 1056751 Change-Id: Ie70e425312da48058a098a512cbafa26bdfa5fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476839 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#819229}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ie45833037473cdcbcf7e9112317f574a2c84c27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819228}
-
Sam Sebree authored
Controls This adds slight opacity to the dark mode audio control default background, and addresses some background color bugs for the dark mode video control overlay menu. Bug: 1111887 Change-Id: Ie677110b32b4588459038f820db713924f2e8e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486033Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819227}
-
Kramer Ge authored
This is a reland of aa21781d Root-cause of previous issue was Gnome's interpretation of whether buffer.release should be triggered for buffers preempted from subsurface cache. Original change's description: > [ozone/wayland] Use 4x4 opaque background and stack underlay correctly > > Using a 4x4 sized opaque background will not regress performance in > underlay cases because the root surface is still opaque. The background > will be stretched out by wayland viewporter extension. > > This is 6/? CL for overlay forwarding using wl_subsurface. > > Change-Id: I59b0d4cdbfbb6727d578e286c9d19cf69a9bff32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352523 > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#810527} Change-Id: I7ecbc27a82598479f7131b5645dfe96136d227a1 Bug: 1133195, 1063865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442137Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#819226}
-
Adam Rice authored
This reverts commit a2505c5b. Reason for revert: Broken bots, possibly caused by CQ collision. See https://crbug.com/1140836 Original change's description: > Remove NotEnumerable from Writable Streams WebIDL > > According to https://github.com/whatwg/streams/pull/1035, all methods > and accessors are now enumerable, per Web IDL defaults, instead of > non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can > be removed from the Streams WebIDL files. This CL specifically > removes them from writable streams. > > Bug: 1093862 > Change-Id: I935a9f8726b3cb1dc4efb5b4d6db71384c8efe37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485664 > Reviewed-by: Adam Rice <ricea@chromium.org> > Commit-Queue: Nidhi Jaju <nidhijaju@google.com> > Cr-Commit-Position: refs/heads/master@{#819181} TBR=ricea@chromium.org,nidhijaju@google.com Change-Id: I3f49640931f5968e1127664f6d755525dcdb9543 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1093862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489062Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#819225}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ia4b3dfc28460e388dcc85b67ca36ac56053564bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488304Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819224}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/637786a9a862..9d160b0bba68 2020-10-20 cnorthrop@google.com Tests: Add Brawl Stars trace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: angle_perftests --gtest_filter="*brawl_stars*" Change-Id: Ie1ca382f65ea3133b29e0c7105fe86aaebe3fb0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488924Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819223}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbc6250f7a85..a87909398b71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fergal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117663,chromium:1138023,chromium:1140725 Tbr: fergal@google.com Change-Id: Ibd57a5193eeaa4629f193641f8f8f46fb06c1453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488148Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819222}
-
Ken Rockot authored
If an intraprocess pipe calls SetQuota on one endpoint, it's possible for this to result in a deadlock due to Mojo internals re-entering the endpoint's MessagePipeDispatcher while already holding its internal lock. This fixes the issue about deferring the potential re-entry until the lock is released. Fixed: 1137988 Change-Id: I814415a3ce155a991a2e6d2cfd07fa309004eeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485147 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819221}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5a350685decfef71d58acfa26a1a11596c9cdf2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488151Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819220}
-
Nnamdi Theodore Johnson-Kanu authored
- Adds temporary fix to cr-dialog, to fix dialog title being vocalized twice by chromeVOX, this should be reversed when crbug.com/1139958 is closed. - Add vocalization of signal strength icon Bug: 1007433 Change-Id: I6a1dc2d8d37bc3e7e43097bcf2aa568c280152b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480884 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819219}
-
Luc authored
Bug: 1007635 Change-Id: I7e9a7bffda59cdda441018275a40cbb2144d146f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486962Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#819218}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603216608-9fdc3766d62145cb23e4981f379b4b4bd1eab8ae.profdata to chrome-linux-master-1603238376-41278602b445da41d1916a61de8117b0857ab174.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2fdd67e566be233b3c6c3eb2097f21330bb9cea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488155Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819217}
-
Sophie Chang authored
Also changes dougarnett to mcrouse/sophiechang where appropriate Bug: 1140005,1140000,1139999,1139998,1139997,1139996,1139995,1139994,1139993,1139992,1138428 Change-Id: Ie562d08a9038a7ff8fc4be093aa1f7771fa2cfc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485757 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819216}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603216608-7529e831dfcfdc3eeb93d3e8d9f23aaded5766b2.profdata to chrome-mac-master-1603238376-a0754723f0cd6eaa7fc2494ab4a5f08c0cee1720.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8198fea6a11d4a25551739ccbaeb4495bc70323a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819215}
-
Leo Zhang authored
ImeDecoder is used for loading decoder shared library and all required function pointers before sandbox is engaged. After sandboxing DecoderEngine will take advantage of these preloaded functions to decode inputs. TEST=local betty VM. BUG=b/161491092 Change-Id: I8ab77da32ad678a996f607be2b3840d7345be4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486825 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#819214}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a08f3d9f..d20e0a34 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I832901f133635060125f50b35abc3203a4c6400c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489000Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819213}
-
Jinsuk Kim authored
ToolbarManager injects the necessary objects through ViewShifting- ActionBarDelegate to remove the dependendency on ChromeActivity in the class. Bug: 1127732 Change-Id: Ief8e4a5f12d2488389e02c4fbe5af0e353f3d8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430566Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819212}
-
Matt Mueller authored
Bug: b/143909628 Change-Id: I8942a9b3f68ad5266b7d10aa3146c9cf8778e76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488712Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819211}
-
Nick Harper authored
https://boringssl.googlesource.com/boringssl/+log/3743aafdacff2f7b083615a043a37101f740fa53..a673d02458b1b7d897084266b93d5c610e36bd17 The following commits have update notes: cefbf9cea Const-correct X509_get0_extensions. Bug: none Change-Id: I256c6fcdd9217c1ca4be47409204d41413988b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461604 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#819210}
-
Ian Wells authored
This reverts commit 8699ff59. Reason for revert: Caused crbug.com/1140401 and various other failures. Original change's description: > Enable JDK library desugaring by default > > Bug: 1056751 > Change-Id: Id517413e180ad7cc2f7688d47038587f2a3ecb5e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458853 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817575} TBR=agrieve@chromium.org,iwells@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056751 Change-Id: I3da3c17f6b56f7233232f5ae9eee4af83158b525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487817Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#819209}
-
David Van Cleve authored
This change expands the definition of a Trust Tokens key commitment struct to accept a list of operating systems on which to redirect issuance operations (for the issuer hosting the key commitment) to the operating system, rather than sending these issuance requests directly via an HTTP request. It's the first step in implementing on-device ("platform-issued") trust token issuance support. Fixed: 1130249 Change-Id: I9eec53ecf2c3eb611e547b78ee60cbdc800e0c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432445Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#819208}
-
David Schinazi authored
R=bnc@chromium.org Change-Id: Ib485c7c701ec9269829806be907a070b6829eb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488754 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#819207}
-
Lachlan Ford authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/2469836 Change-Id: I6f32193f583cf368d8de152d8577b6796f4a3387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488605 Commit-Queue: Lachlan Ford <laford@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#819206}
-
Haiyang Pan authored
When this property has the default value "no", AVDs with android-10 and later have issue with "back" and "home" buttons under graphical mode. These buttons will not work as they should when clicked. Setting the prop to "yes" will fix this issue. Bug: 922145 Change-Id: I67322347f323d9b31927589b00624a41f5acc356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486288 Commit-Queue: Haiyang Pan <hypan@google.com> Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819205}
-
Jinsuk Kim authored
With this CL, toolbar/ classes are free of dependencies on chrome/browser/ntp. A new interface NewTabPageDelegate plus its implementation in ToolbarManager replaces the references to NewTabPage. Dependencies on static URL util methods in NewTabPage, NativePageFactory were addressed by moving the methods to modularized targets - components/embedder_support/android:util_java and chrome/browser/ui/native_page, respectively. Bug: 1127732 Change-Id: I8619db6454b1aa274328a3a243b977cbd87aac02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467578 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819204}
-
Robert Ma authored
Calling killpg() on a process group whose leader is defunct causes a permission error on macOS, in which case we try to collect the defunct process. (On Linux, this would be a no-op. kill() a zombie process is always a no-op on both macOS and Linux.) Fixed: 1140363 Change-Id: I3253f315c40fecd3b9ebb4ebe4d0d18bcf0636d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488369 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#819203}
-
Bill Budge authored
- Adds a getter to go with the SetIsCrossOriginIsolated function. We need to be able to access this in content::RenderProcessImpl, in order to properly set V8 up. Bug: chromium:923807 Change-Id: I99337ea49537cd6f2b5ebb76f2ceddac38260dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488716Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#819202}
-
Koji Ishii authored
|ShapingLineBreaker::Hyphenate| should look for hyphenation points at the line edge or after, but it did not include the character at the line edge. This patch fixes this. This occurs often when `fit-content` inline size is used. Also changes the test to use Ahem because Win uses U+2010 HYPHEN instead of U+002D HYPHEN-MINUS, but other platforms use U+002D. Bug: 1140738 Change-Id: I5e1157de07b58edddb92c6c80ff8df460fc064b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485352Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819201}
-
Clark DuVall authored
All known issues have been fixed so enabling this in canary to see if there are any major problems. Bug: 1126301 Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819200}
-
Yi Zhang authored
//chrome/browser/devtools/ This CL is the 1st part of converting base::Bind to Once/Repeating in //chrome/browser/devtools/ Bug: 1007635 Change-Id: I8a58f155c3ae402f860492af77df21c133c5f453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486573Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#819199}
-