GitLab

The chrome://large-icon endpoint is meant to serve (square) large icons
to the NTP to replace thumbnails. If icon is available, it is resized
first. Otherwise a fallback of the requested size is returned. Therefore
a custom NTP should always gets an image back, and cannot deduce whether
user has visited a site by examining icon presence or icon size.

BUG=467712

Review URL: https://codereview.chromium.org/1016833003

Cr-Commit-Position: refs/heads/master@{#321464}

Use placeholders for all uses of line-break tags.

BUG=468957
TEST=manual
TBR=cpu

Review URL: https://codereview.chromium.org/997173004

Cr-Commit-Position: refs/heads/master@{#321463}

This patch tests GL_LUMINANCE only when OpenGL is not ES3
and tests GL_RED when on OpengGL ES3.

This change should allow crrev.com/1022603002 to run on Android perf
bots. Without this patch crrev.com/1022603002 fails on perf bots because
glTextureStorage2D doesn't always accept GL_LUMINANCE8 as
internalformat.

glTextureStorage2D has been added to OpenGL ES3 and it's available
as an extension (GL_{EXT,ARB}_texture_storage) prior to that.
If glTextureStorage2D is availabe via the extension it accepts
GL_LUMINANCE8_EXT as internal format, otherwise it doesn't.

BUG=468748

Review URL: https://codereview.chromium.org/1022923002

Cr-Commit-Position: refs/heads/master@{#321462}

Recent changes to skia now require this object, and crash if this
factory isn't supplied. We create the minimal implementation to get a
Google search working in html_viewer. This allocator will free
unlocked chunks once it has reached its memory threshold.

We're starting with a soft limit of 20 megabytes. We'll adjust this
based on observed performance.

Review URL: https://codereview.chromium.org/1016493002

Cr-Commit-Position: refs/heads/master@{#321461}

(Based on manual request.)

BUG=467486

Cr-Commit-Position: refs/heads/master@{#321460}

aa@ is no longer active on this project. sky@ is.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/1018463003

Cr-Commit-Position: refs/heads/master@{#321459}

This CL adds the embedderId parameter to appview documentation.

Review URL: https://codereview.chromium.org/1010253003

Cr-Commit-Position: refs/heads/master@{#321458}

Don’t scale fonts up twice when running with device_scale_factor > 1.0.

Chrome’s UI is scaled up to device_scale_factor (e.g. 2x) by calling
SkCanvas->scale(). See Chrome’s gfx::Canvas class which calls
canvas.scale(image_scale, image_scale):
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/canvas.cc

Here is a skia fiddle which renders text with .setTextSize(21):
https://fiddle.skia.org/c/098cb32edac7e394aba5b9ff4c08b06c

Here is the same fiddle, but calling canvas.Scale(2.0, 2.0) before rendering to simulate what Chrome does:
https://fiddle.skia.org/c/a7b456338776239278e398741e1098d9

As you can see, the text is twice as large.

Therefore, this commit changes Chrome to take into account the DPI that
GTK provides, but set it in perspective to the device scale factor. This
preserves the same behavior when device scale factor == 1 but yields
correct rendering when device scale factor > 1.0 (hi-dpi displays).

Before this change:
http://t.zekjur.net/chrome-hidpi-enabled.png

After this change:
http://t.zekjur.net/chrome-hidpi-enabled-scalefix.png

This change also enables subpixel rendering on HiDPi displays, which is what Chrome OS also does.
Without subpixel rendering:
http://t.zekjur.net/without-subpixel.png

With subpixel rendering:
http://t.zekjur.net/with-subpixel.png

BUG=143619

Review URL: https://codereview.chromium.org/929733002

Cr-Commit-Position: refs/heads/master@{#321457}

- Close data pipes when TCP network connection goes down.

Review URL: https://codereview.chromium.org/1015733002

Cr-Commit-Position: refs/heads/master@{#321456}

App remoting relies on the onVideoStreamingStarted() to determine whether it should
hide the loading window and show the remote app.
In the existing implementation, onVideoStreamingStarted() is invoked in remoting.DesktopViewport
which is not part of the shared code.

This CL moves that logic into AppConnectedView.

BUG=465878

Review URL: https://codereview.chromium.org/1015523005

Cr-Commit-Position: refs/heads/master@{#321455}

The class is replaced by ProfileExtender, which is functionally equivalent.
Reparent SmallProfileCreator to inherit from FastNavigationProfileExtender,
which cuts out all the deprecated code. This CL breaks ExtensionProfileCreator
on Mac. That class will be fixed in a follow up CL. ExtensionProfileCreator is
already broken on all other OSes, and it's not hooked into any tests.

BUG=

Review URL: https://codereview.chromium.org/1020703002

Cr-Commit-Position: refs/heads/master@{#321454}

success

BUG=none

Review URL: https://codereview.chromium.org/1019143003

Cr-Commit-Position: refs/heads/master@{#321453}

These mostly match what's currently available in WebView class itself.
The implementation in WebView will be removed.

BUG=

Review URL: https://codereview.chromium.org/1022993002

Cr-Commit-Position: refs/heads/master@{#321452}

This class will report to UMA the Android kernel version and the level of kernel
support for seccomp-bpf sandboxing.

BUG=468455

Review URL: https://codereview.chromium.org/1018953004

Cr-Commit-Position: refs/heads/master@{#321451}

While the recent fixes to the pointer lock code have helped, we still have problems when we move the cursor near
the bounds of the content window. The pointer lock code in RWHVA detects that and forces a move to the center of
the window via a SetCursorPos operation. The expectation here is that we would see a mouse move message with the
location specified by SetCursorPos which would ignore.

With fractional scale factors like 1.25/1.5, etc it turns out that the conversions of the mouse messages from pixel
to DPI and vice versa causes us to end up with messages which are off by 1 or 2 px which causes us to miss the move
to center event in the locked mode. The renderer sees the message and bounces the cursor back to the center leading
to erratic behavior.

Proposed fix is to add an allowance of 2 for the mouse event x and y coordinates if we are waiting for the move to
center event.

BUG=411634
TEST=As described in the bug. Please try a clockwise and anticlockwise mouse rotation with device scales set to 1.25/
1.5, etc.

Review URL: https://codereview.chromium.org/1005213003

Cr-Commit-Position: refs/heads/master@{#321450}

TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/1021873002

Cr-Commit-Position: refs/heads/master@{#321449}

This is a rather cosmetic change: INFO log level is used to print test summaries. This CL makes the script log one summary instead of 2 consecutive ones. These logs end up in a spreadsheet, and having one line (as opposed to 2) per test is easier to process for statistics.

R=engedy@chromium.org
BUG=468245

Review URL: https://codereview.chromium.org/1023673005

Cr-Commit-Position: refs/heads/master@{#321448}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5553bed..6c1b338

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1005873004

Cr-Commit-Position: refs/heads/master@{#321447}

Before DirectWrite, default monospace font was Courier New but while
adding support for DirectWrite, it is switched to Consolas which lacks
Arabic glyphs. This is to improve the situation.

BUG=466754

Review URL: https://codereview.chromium.org/1013653002

Cr-Commit-Position: refs/heads/master@{#321446}

R=rvargas@chromium.org
BUG=468631

Review URL: https://codereview.chromium.org/1022863002

Cr-Commit-Position: refs/heads/master@{#321445}

Review URL: https://codereview.chromium.org/1002493005

Cr-Commit-Position: refs/heads/master@{#321444}

If an XHR has succeeded and the form that the user was typing in has now
disappeared either by no longer being visible or being removed from the DOM,
prompt to save.

BUG=464891

Review URL: https://codereview.chromium.org/1012853002

Cr-Commit-Position: refs/heads/master@{#321443}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a2bf336a..c18bc92e

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1003363004

Cr-Commit-Position: refs/heads/master@{#321442}

This patch fixes a build break in ozone-wayland.

BUG=None

Review URL: https://codereview.chromium.org/1015323002

Cr-Commit-Position: refs/heads/master@{#321441}

The flag was added to allow us test the mode with display item cache
enabled or disabled. It seems that we haven't been using it for some
time, so perhaps it's time to remove it and always enable the cache.

This is the chromium side change paired with the blink side change
https://codereview.chromium.org/1018053003/.

This is a revert of content/renderer/gpu/render_widget_compositor.cc
in https://codereview.chromium.org/913163004.

TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/1012383005

Cr-Commit-Position: refs/heads/master@{#321440}

BUG=467633

Review URL: https://codereview.chromium.org/1006753003

Cr-Commit-Position: refs/heads/master@{#321439}

I believe this will unblock a required migration in our signing
infrastructure.

BUG=none
R=garykac@chromium.org

Review URL: https://codereview.chromium.org/1020823003

Cr-Commit-Position: refs/heads/master@{#321438}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/22ac63e..68da64b

TBR=pilgrim@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1019893003

Cr-Commit-Position: refs/heads/master@{#321437}

Due to a bug in a recent refactoring, the script would log an error to the
console, but would still set the success exit code, 0.

BUG=468523
TEST=Try to submit a CL with invalid formatting, the presubmit script should block submission.
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1019123003

Cr-Commit-Position: refs/heads/master@{#321436}

Optimization: 2 is /O2, not /Os.  (The old comment contradicted the comments
in the FavorSizeOrSpeed section further below.)

BUG=none

Review URL: https://codereview.chromium.org/1020943002

Cr-Commit-Position: refs/heads/master@{#321435}

This patch adds all of the priority rects we use in tilings to tracing.

R=enne
BUG=468813

Review URL: https://codereview.chromium.org/1019353002

Cr-Commit-Position: refs/heads/master@{#321434}

Not needed: On 32-bit builds, warnings-as-errors are disabled globally. On
64-bit builds, nothing warns, including 3rd-party code.

BUG=82385

Review URL: https://codereview.chromium.org/1011383007

Cr-Commit-Position: refs/heads/master@{#321433}

Show the details panel when file manager is first opened...on an import location. Adjust width and position of details panel to avoid line-wrapping main line.

BUG=464562
TEST=manual

TBR=fukino  // for minor CSS tweaks

Review URL: https://codereview.chromium.org/1019833003

Cr-Commit-Position: refs/heads/master@{#321432}

Guest is a primary user when logged in, so my previous
fix hiding the checkbox was unnecessary. The checkbox
should work and currently does work.

This reverts commit ae8d1b4f.

BUG=448551
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/1020763002

Cr-Commit-Position: refs/heads/master@{#321431}

Move all trace_event related build files in their own
gyp / gn target under base/trace_event.
This should allow easier maintenance of tracing code.

BUG=

Review URL: https://codereview.chromium.org/1014923002

Cr-Commit-Position: refs/heads/master@{#321430}

kEnhancedBookmarksExperiment is used by android intrumentation tests to
force enhanced bookmark feature to be enabled.
https://codereview.chromium.org/1009673002 introduced a regression that
the even if the flag is set to be true, it does not take effect. This CL
fixes it.

BUG=468106

Review URL: https://codereview.chromium.org/1017913002

Cr-Commit-Position: refs/heads/master@{#321429}

Previously, if the viewport ever moved farther than the skewport limits
in a single frame, the skewport math would break.  It would first
intersect with the max skewport (becoming empty) and then unioning with
the viewport (becoming the viewport).  By moving the union first, it
prevents this empty condition, leaving a valid skewport in the right
direction.

This addresses a case where prepainting wasn't happening when it should
have.

BUG=446645

Review URL: https://codereview.chromium.org/1021663002

Cr-Commit-Position: refs/heads/master@{#321428}

Reuse was disabled in #317499 because CrOS corruption rates were spiking and
were too close to the stable branch point to gather more history.  Re-enabling
to allow monitoring in dev/beta channels with the hope that the rise we saw on
CrOS was normal fluctuations and unrelated to this change.

BUG=460568

Review URL: https://codereview.chromium.org/1023773003

Cr-Commit-Position: refs/heads/master@{#321427}

Original CL reverted here: https://codereview.chromium.org/1013003002/

Nothing has changed from that CL above. We are relanding after Oshima
prevented marking events created from the same native event as "repeat"
in this CL https://codereview.chromium.org/1017323002/

Menus used to block detecting user activity. The fix works by making the
UserActivityDetector a PlatformEventObserver rather than an
EventHandler.
Also made sure that PlatformEventSource has an instance in
ozone_platform_test.cc

TBR=sadrul@chromium.org,spang@chromium.org,oshima@chromium.org,jamescook@chromium.org
BUG=462735
TEST=ui_base_unittests --gtest_filter=UserActivityDetectorTest.*

Review URL: https://codereview.chromium.org/1024583003

Cr-Commit-Position: refs/heads/master@{#321426}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3ef71e3..5553bed

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1023633004

Cr-Commit-Position: refs/heads/master@{#321425}