- 06 Mar, 2020 40 commits
-
-
Dominique Fauteux-Chapleau authored
These tests use the least possible amount of overrides to ensure DeepScanningDialogDelegate every requests/callbacks eventually resolves and returns to the caller. Also add code to handle the web contents being destroyed and avoid ASAN issues. Bug: 1041890 Change-Id: Ibfe232354f0591ae9e854bf5a0163ede68d6faf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083598 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#747713}
-
Joshua Pawlicki authored
Integrity of the check is still guaranteed by CUP. The check will no longer be confidential. Bug: 1057341 Change-Id: I366453b1586f3116ec75a11ef3718cfbbf5522ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090336 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#747712}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I385d19863911be4a72161ae9184a17ca8e536abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091421Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747711}
-
Robbie Gibson authored
This reverts commit 2aa19d70. Reason for revert: Breaks QR code scanner. In investigating that, I think I found a better solution. Original change's description: > Fix NTP omnibox animation when there are suggestions > > Before, if there were suggestions on the NTP, they would immediately > appear. The better animation is to scroll the fakebox up to the top > of the screen and then present the suggestions. > > To do this, when entering the omnibox from NTP, we only focus the > location bar, which causes the scrolling animation. -fakeboxFocused > is already called in the animation completion block, which does the > actual work to make the omnibox text field first responder, causing the > suggestions to appear. > > To finish off, the -locationBarDidBecomeFirstResponder code now only > focuses the location bar if we are not on the regular NTP. > > Bug: 1057643 > Change-Id: I472ee1ee5693fa4102717275bf266f4ab97e121a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082556 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746450} TBR=stkhapugin@chromium.org,gambard@chromium.org,rkgibson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057643 Change-Id: Ifda283f7733b9439e3803d1110b0afefeee084f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089782Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#747710}
-
Thomas Lukaszewicz authored
Removed GetInstanceForNativeUi() from NativeFileSystemUsageBubbleView and CastDialogSinkButton. Changed the FileSystemUsageBubble to update its icons on theme change to keep sync with the current theme color values. Bug: 1056916 Change-Id: I81254025570f009cfea5db26ee982cf14ad45580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089986Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#747709}
-
David Tseng authored
This is the first step in a series of changes to improve touch interaction with ChromeVox. This change: - introduces a new earcon when entering a touch anchor - introduces a new earcon when touching a blank area of the screen (defined as an anchor that is neither a touch leaf nor a touch object) - when moving from a touch anchor to a non-touch anchor, immediately stop speech so the user knows they have left. This will help avoid confusion about what's currently focused or not when hovering a finger. This might also be familiar (e.g. iOS behaves this way). Note for the last point, we will have to solve the issue of really small touch targets. One potential solution (not for this change) is to come up with a way to do "fuzzy" hit testing. Change-Id: I262c664bc0d86aa6e8ce96cf1e263db7a8f184cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088510 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#747708}
-
Gabriel Charette authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2076423 After https://chromium-review.googlesource.com/c/chromium/src/+/2087971 and https://chromium-review.googlesource.com/c/chromium/src/+/2087892 R=ajwong@chromium.org Bug: 1026641 Change-Id: Ia2c180759677a51502c5c1c04508d165f7c35856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087893 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#747707}
-
Andrew Shulaev authored
Change-Id: I91e8da3812ae5870f56023a247ca9b83ea1cb5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089850 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#747706}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 9284abd0040afecfd619dbcf1b244a8b533291c9`. linux_chromium_chromeos_msan_rel_ng trybot redness: Also red on the main waterfall in similar ways and has been for days (!). ipad-device, iphone-device trybot redness: happens on whitespace cl too, filed crbug.com/1059256 Bug: 1058012 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iafc17a96a7d40e9b99f58bce474ed50dc6bfb0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086341 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#747705}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/33be9dfe7a23..8e9fd4857e2e git log 33be9dfe7a23..8e9fd4857e2e --date=short --first-parent --format='%ad %ae %s' 2020-03-06 zetilovn@google.com Fix FakeVp8Encoder name. 2020-03-06 kron@webrtc.org Rename index.md to README.md to make it automatically show up Created with: gclient setdep -r src/third_party/webrtc@8e9fd4857e2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6bc81dbf783f7114f13217fd91f49938419e598f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091411Reviewed-by:
-
Yuzu Saijo authored
This CL adds an additional CHECK to ensure that the controller status is REDUNDADNT when crash happens. Bug: 1021718 Change-Id: I534d1198fb1f27368e41435d8127f6530a7e4bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087500Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Auto-Submit: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#747703}
-
Justin Miron authored
Introduces a new SafeBrowsingStatus field to Popup.Closed indicating the safe browsing status of a pop-up's navigation. This is checked using the sub resource filter observer's OnSafeBrowsingChecksComplete callback, similar to safe_browsing_triggered_popup_blocker. BUG=1044601 Change-Id: I012fbbde60741d30bad74457ddd3058f2fd909eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085161 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#747702}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ia37eefa5925208304469a2859f05a915d392525e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089828Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#747701}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2de34c1791f3..e3f3e9a80d5f git log 2de34c1791f3..e3f3e9a80d5f --date=short --first-parent --format='%ad %ae %s' 2020-03-06 cwallez@chromium.org Revert "Vulkan: Report and enable subgroup size control device extension." 2020-03-06 cwallez@chromium.org Revert "Vulkan: Enforce fixed subgroup size for compute shaders." 2020-03-06 cwallez@chromium.org GN: Use the hermetic XCode if available. 2020-03-05 natlee@microsoft.com Query if Texture subresource has been initialized 2020-03-05 david.turner.dev@gmail.com Vulkan: Enforce fixed subgroup size for compute shaders. 2020-03-05 david.turner.dev@gmail.com Vulkan: Report and enable subgroup size control device extension. Created with: gclient setdep -r src/third_party/dawn@e3f3e9a80d5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1036080,chromium:1059205 Tbr: cwallez@google.com Change-Id: I3b42808fc1c72dd2c0812e1f09cf32906edbdade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091413Reviewed-by:
-
Mirko Bonadei authored
This is requred to fix some //base tests compiled by standalone webrtc when running "ninja -C out/Debug all". Bug: webrtc:11411 Change-Id: Ibcc43e19c594f3860fe5ebbc435aad5fd3a928f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090420 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#747699}
-
Sorin Jianu authored
After introducing the App instance, --install is broken on Windows. * pv is not handled correctly and it is not clear if this ever worked at all, even before refactoring. * the splash screen object has an incorrect life time. * the prefs are not save correctly due to threading and run loop issues. Bug: 1059135 Change-Id: I3a5930dcdbf530b0229692722734cb05680d63aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090973Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747698}
-
Maksim Moskvitin authored
This CL supports transitions from trusted vault passphrase to keystore and custom passphrases. To avoid data corruptions by buggy clients the bridge verifies that the remote keybag contains the last trusted vault key, which was used as the default key. Since browser restart can happen in between of receiving the remote update and decryption of the new remote keybag, |last_trusted_vault_key| stored in NigoriLocalData. Bug: 1020084 Change-Id: Ica654898a3499f599258bf9e65eb8d91580fcc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087766 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747697}
-
Fredrik Söderquist authored
SVGSMILElement::ResolveActiveEnd() is the only caller of NextAfter(kEnd, ...), and it already handles the case of an empty list, so hoisting this check makes it more obvious that 'indefinite' is the initial value, and the failure to find a proper instance time means failure. This makes NextAfter() less dependent on what list it is searching, which will help split it out (and optimize certain operations on it). Bug: 1039243 Change-Id: I8fbc8b86521df53b32ea67bbd5e3281e261246cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089867 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#747696}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e9030e1f5b01..0b1579a826af git log e9030e1f5b01..0b1579a826af --date=short --first-parent --format='%ad %ae %s' 2020-03-06 lalitm@google.com metrics: make null values passed to repeated fields more obvious Created with: gclient setdep -r src/third_party/perfetto@0b1579a826af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic206d0d7c0b3cd0a69fce2440b52c3b77a67bfed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091412Reviewed-by:
-
Stepan Khapugin authored
Reparents the tab grid to SceneController. Note that the lazy getter loses a DCHECK - it seems too hard to cleanly port to SceneController at the moment, though once multiwindow is operational we should add new invariant checks everywhere. Bug: 1045657 Change-Id: I7e4eecd58bea4338a634f9e01e2cbc255c49c328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087337 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747694}
-
Surma authored
The WebAssembly Web API spec[1] prescribes that the responses for `WebAssembly.{compile,instantiate}Streaming()` must have the `Content-Type` header `application/wasm` without any extra parameters. So far we ignored extra parameters, causing interop issues with Firefox. [1]: https://www.w3.org/TR/wasm-web-api-1/#streaming-modules Bug: 1057973 Change-Id: I2273e2b5577dc6a11343536d55fa72b9e518c0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085257 Commit-Queue: Surma <surma@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Ehimare Okoyomon authored
OnJavascriptDisallowed does not get called to remove the observer if the incognito ntp tab is closed, which can result in a crash (see bug). To fix this, add RemoveObserver call to the destructor. Bug: 1058769 Change-Id: I18413d0ae54593adc032aa017f39f5787bd5bc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088713 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#747692}
-
Mike West authored
This patch checks in failing expectations instead to make our existing behavior clear. Bug: 1024786 Change-Id: I1cf5b536cc410b7798ce69a6a140b01f61ca2481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089704 Commit-Queue: Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Auto-Submit: Mike West <mkwst@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#747691}
-
Kevin Ellis authored
This patch resolves most of the known cases for resolving potential conflicts between play state changes originating from web-animation API calls and animation-play-state. Next steps: - resolve the behavior of methods that indirectly call play such as reverse. Additional tests will likely be required for these cases. - fix pending. When pending is called from JavaScript on a CSSAnimation, the style must be flushed to ensure than any pending change to play state is resolved; however, there are other call sites to pending that should simply check the status without a forced style update. An additional method is needed to separate the two use cases. The change is straightforward, but potentially bulky, and thus deferred to a separate CL. Bug: 1006086 Change-Id: I65d1f51c3c2fd026255099ac7f200257b3ece7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078414 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747690}
-
Monica Basta authored
This CL removes the history usage hint for the sWAA on and updates the strings for the sync setup page. Bug: 1035421 Change-Id: Ife04c81e5994874e3f437adecd4f4d5afd923456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089872Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#747689}
-
Omer Katz authored
On-stack buffer used as the target of the copy (in hash_table.h) needs to be force-aligned. Bug: 1058777 Change-Id: Id70f54ce0c44c780e0dfa9c1e0b97e9e37f3d632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089833Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747688}
-
Victor Hugo Vianna Silva authored
The feature has been successfully enabled by default, so this CL removes it, as well as the favicon cleanup logic for pseudo-USS introduced by https://crrev.com/c/1917173. Bug: 978775 Change-Id: I8539cda6166e6a03e434b9545278b7b6abda3a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089823 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Viktor Semeniuk authored
This change adds UI for the case when no leaked credentials were detected after password check. Bug: 1047726 Change-Id: Ifa383a09e764a2dbd5286ef542f78c6c95f63692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087711Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#747686}
-
Gabriel Charette authored
These missing includes are preventing removal of unused headers from task_runner_util.h and consequently migration from task_runner_util.h to task_runner.h's new PostTaskAndReplyWithResult member method. The following script was run on every file in the codebase, prioritizing .h over matching .cc to best enforce the rule of not include a header included by your .h : def Fix(file_path): content = refactor_lib.ReadFile(file_path) # Assume fwd-decls are correct in first pass. fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content) if fwd_decls_match: print 'fwd_decls_match in %s' % (file_path) return False bind_helpers_match = re.compile( # Doesn't begin with a comment. r'\n *[^/\n][^/\n]' # Anything else after a non-comment start (and don't allow this to capture a comment start either) r'[^/\n]*' # Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definition of Foo. r'[^<]' # Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed. r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content) callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content) ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content) if not bind_helpers_match and not callback_helpers_match and not ptr_util_match: return False updated_content = content if bind_helpers_match: updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h") if callback_helpers_match: updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h") if ptr_util_match: updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h") if updated_content == content: return False # Write updated file refactor_lib.WriteFile(file_path, updated_content) return True TBR=danakj@chromium.org (mechanical change for //base API) Bug: 1026641 Change-Id: Ic88585c62dd2f74d34c59c708faeddb231aee47f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087971Reviewed-by:Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#747685}
-
Christos Froussios authored
The API change was proposed in https://docs.google.com/document/d/1M_Tzgap5_mdSNBWJwBVrsX_bFoJ0AYM0mmi9-LYs26g/edit# The callbacks were simplified to VoidCallback, because an event already covers this functionality. Bug: 1047726 Change-Id: I9aa297d1d15a0815c5e81af965c88b237cd81758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084596 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
jonross authored
We already have measurements in place for the Gpu's peak memory allocation over various user interactions. However when we see spikes there is no way to attribute them. This change builds out attribution for the source of the allocations being done. It also includes this in the existing trace events. Bug: 1001168 Change-Id: Ibf9256eae51e076457218ee558aa25b5caa94c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024920 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#747683}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b3d09c15. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ie3e3daa1a8b7a5614c1020c796329970a24ed840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090732Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747682}
-
Michael Lippautz authored
Migrate: - RegionTree->PageMemoryRegionTree: Keep track of all PageMemoryRegion regions in a BST for lookup of arbitrary addresses. - PagePool->NormalPagePool: All normal pages are kept in a page pool for fast retrieval. Currently, PageMemoryRegion used for normal pages is never returned to the operating system but pages are kept in the NormalPagePool until shutdown. This can be improved in future. Introduce: - PageBackend: Entry point for higher-level abstractions. Provides bottlenecks for allocation/freeing of PageMemory objects (large and normal) as well as new ones. Change-Id: Ia46daef501a8bd4785885d68f3b420157bf153b6 Bug: 1056170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083474 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#747681}
-
Olivier Robin authored
Change-Id: Iab7bbe97f00eed841465dd27adbb0a3f24164f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090419Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747680}
-
David Roger authored
These histograms are used to monitor the AccountReconcilor, which is a core component of the signin infrastructure. The related histograms should never expire, as they are used to check the health of the system and detect/fix bugs and outages. Fixed: 1037292 Change-Id: I0a66e1afd6d9bd3929b33039894f09daeb81556f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089871 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747679}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c899036d79f7..51afe2e3ccf5 git log c899036d79f7..51afe2e3ccf5 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 petermarshall@chromium.org [docs] Update l10n docs to fix some markup Created with: gclient setdep -r src/third_party/devtools-frontend/src@51afe2e3ccf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I01d80c51c6bb888e783ed99f66e36bf702699cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091408Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/582e51453444..9e85398565d3 Created with: gclient setdep -r src-internal@9e85398565d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib42546e9f9fa86bb75de562d5a2c1d5ecedd4222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091407Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747677}
-
Javier Ernesto Flores Robles authored
Verifies that the first responder is valid when the keyboard appears and when a text input ends editing. If not valid, the custom keyboard is paused, else it is resumed. Bug: 1051907, 1058328 Change-Id: I5540ffb2560b798bb6649b71109cfd2b0974e1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088104Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#747676}
-
Mohamed Amir Yosef authored
Bug: 1032992 Change-Id: I91a8aac1d668e42c8e6fe5ae6fd86c86343a2ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089764 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#747675}
-
Milica Selakovic authored
Bug: 1053522 Change-Id: I968877db3dc2e3749c872f748502276002fea07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089680 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747674}
-
