GitLab

This reverts commit 74270ce2.

Reason for revert: Apparently causes crashes, https://crbug.com/1055188

Original change's description:
> Roll libunwind 43bb9f8722..d999d54f4b
> 
> ...and enable Wbitwise-conditional-parentheses on android.
> 
> https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/43bb9f8722..d999d54f4b
> 
>  Fix a -Wbitwise-conditional-parentheses warning in _LIBUNWIND_ARM_EHABI libunwind builds
> 11b0129 [libunwind] Treat assembly files as C on mingw
> 76f6916 [libunwind] Fix building standalone after c48974ffd7d1676
> aea9f89 [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C
> e4cbc26 Bump the trunk major version to 11
> e12b248 [libunwind] Fix evaluating DWARF operation DW_OP_pick
> c3889d9 [unwind] Don't link libpthread and libdl on Fuchsia
> 81f7e17 [libunwind][RISCV] Add 64-bit RISC-V support
> baf07ac Reland "Enable `-funwind-tables` flag when building libunwind"
> 2ef1190 Revert "Enable `-funwind-tables` flag when building libunwind"
> 2fd0a70 Enable `-funwind-tables` flag when building libunwind
> f939ab7 [libunwind] Emit dependent libraries only when detected
> 4cd4dca [libunwind] Adjust the signal_frame test for Arm
> 0b1d80f change LLVM_VERSION_SUFFIX default from svn to git
> b6a6639 Correctly update isSignalFrame when unwinding the stack via dwarf.
> e7f96ac unwind: restore the LINKER_LANGUAGE
> e24563d unwind: reflow some of the build rules (NFC)
> f2c3035 unwind: disable RTTI during the build of libunwind
> a4a7180 Revert "build: explicitly set the linker language for unwind"
> ccff66b build: explicitly set the linker language for unwind
> a914ec1 [libunwind] [Windows] Add a log message if EnumProcessModules fails
> 2a4f136 [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic
> b6bfd8b [libunwind][Android] Improve workaround for PIE zero-dlpi_addr bug
> 1073ad9 [libunwind] Fix issues introduced in r374606
> cfb6df8 [libunwind] Refactor CMake flag checks to match libc++ and libc++abi
> 57be2d2 [libunwind] Adjust libunwind_01.pass.cpp test for ARM EHABI
> 5342138 Unwind: avoid warning about unused typedef
> 78b42cc Unwind: prevent unw_get_proc_info from returning stale data
> 2aa34a8 unwind: remove a could of extraneous `else` (NFC)
> c699521 [runtimes] Don't depend on libpthread on Android
> 9d72a29 [libunwind][ARM] Fix types in _Unwind_VRS_Get.
> d003462 [libunwind][ARM] Fix loading FP registers on big-endian targets
> 558e694 Bump the trunk version to 10.0.0svn
> 8d9ed37 [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets
> 0baf612 [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto
> b5b4a50 [Docs] Modernize references to macOS
> 7aecb76 [CMake] Use find_package(LLVM) instead of LLVMConfig
> e2fa4a0 [runtimes] Use -Wunknown-pragmas for the pragma check
> 0e59516 [runtimes] Check if pragma comment(lib, ...) is supported first
> 7b72703 [runtimes] Support ELF dependent libraries feature
> 06a69dc [libunwind] [test] Fix inferring source paths
> 1f9c24d [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++
> 7611bf2 [PPC] Fix 32-bit build of libunwind
> 8a6fc69 [PPC64][libunwind] Fix r2 not properly restored
> 7f90e76 Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force
> 22e7c0c [gn] Support for building libunwind
> 103afa4 [NFC] Fix typo in debug log
> f5d6a44 Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)
> f8c730d [NFC] Move the export attribute after extern "C".
> 59d0c60 [NFC] Correct outdated links to the Itanium C++ ABI documentation
> 01fc413 [libunwind] Fix the typo in unw_save_vfp_as_X alias
> 2b63e62 Move the alias definition of unw_getcontext to within !defined(__USING_SJLJ_EXCEPTIONS__)
> 2ec9ffc [libunwind] Export the weak alias in Mach-O
> 9bbfad5 [libunwind] Export the unw_* symbols as weak symbols
> e63f955 [libunwind] Do not share an object library to create the static/shared libraries
> 2a2b62e Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/"
> 9021011 [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/
> 4287808 [CMake][libunwind] Define add_target_flags which is missing
> 3674fe4 [CMake] Don't cache LLVM_MAIN_SRC_DIR
> 99b7c05 [CMake] Support compiler-rt builtins library in tests
> a6a888a [CMake] Support CMake variables for setting target, sysroot and toolchain
> 5f5036e Provide a placement new definition for the SEH version of UnwindCursor
> 36f6154 [libunwind] Provide placement new definition
> f50a5ed [libunwind] Remove the remote unwinding support
> 370ec3f [CMake] Use correct visibility for linked libraries in CMake
> a0f0700 Revert "[CMake] Use correct visibility for linked libraries in CMake"
> d6e1714 [CMake] Use correct visibility for linked libraries in CMake
> 809c2b5 [libunwind] Support building hermetic static library
> ac0d9e0 Drop the dependency on <algorithm>, add placement new inline
> 8835912 Adjust documentation for git migration.
> fafb21e Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__
> a9ccb4e Revert "[libunwind] Drop the dependency on <algorithm>, add placement new inline"
> cf8d0d6 Revert "[CMake] Use __libc_start_main rather than fopen when checking for C library"
> b31f294 [libunwind] Drop the dependency on <algorithm>, add placement new inline
> 6a3a019 [CMake] Use __libc_start_main rather than fopen when checking for C library
> 1f978e9 [libunwind] Use placement new to avoid dependency C++ library
> 06be328 [libunwind] Don't abort if encoutering invalid .eh_frame_hdr
> 059a163 Silence warnings about unused parameters
> 13d23c8 Remove an unused variable
> 688e594 Add casts to avoid warnings about implicit conversions losing precision
> 985a1d1 Fix warnings about printf format strings
> 55b1c00 Enable LLVM_ENABLE_WARNINGS when building standalone out of tree
> 0dc7999 Fix typos throughout the license files that somehow I and my reviewers
> 61860a5 Update more file headers across all of the LLVM projects in the monorepo
> 60b38b7 Install new LLVM license structure and new developer policy.
> 9180f77 [SjLj] Don't use __declspec(thread) in MinGW mode
> 14d9c7b Bump the trunk version to 9.0.0svn
> b9268be Update year in license files
> 9f2f07a [Sparc] Add Sparc V8 support
> 38d0a65 Revert "[Sparc] Add Sparc V8 support"
> d71bc56 [Sparc] Add Sparc V8 support
> ce15011 [SEH] Add initial support for AArch64
> cba83c3 [AArch64][libunwind] Unwinding support for return address signing with B Key
> 4d8e431 [AArch64][libunwind] Unwinding support for return address signing
> 
> Bug: 1016947
> Change-Id: I37d815a111ce4a5cf4a246fc4558d8c7ba5f7fad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062638
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#743604}

TBR=thakis@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1016947
Change-Id: I057e99ca246ea87fbcc8799f3ba157915e24a54b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068735Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743922}

* Remove shared-clipboard-receiver (enabled by default)
* Extend shared-clipboard-ui
* Extend sharing-derive-vapid-key
* Extend click-to-call-ui

Change-Id: I6434cae0855c2834e44175a31123419d5ea7f3b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068601Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743921}

.. the remove the former.

Drive by CL. Both methods are identical.

BUG=None
R=haraken@chromium.org
TBR=kinuko@chromium.org

Change-Id: I664c6289d89ef9b8335d3346c295485bd9312a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069571Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743920}

https://skia.googlesource.com/skia.git/+log/57bc977e124c..cc5415a8ce36

git log 57bc977e124c..cc5415a8ce36 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 nifong@google.com Modify 3D example with light and bump shader.

Created with:
  gclient setdep -r src/third_party/skia@cc5415a8ce36

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: I3af94fbf769bb4628c1c0d5b7ac3ec5fd43ff91a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070085Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743919}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e1d7a0fe6ffb..e0897515da03

git log e1d7a0fe6ffb..e0897515da03 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@e0897515da03

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib2306fd20a40108fd0879ebbddd36a630eb84456
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070084Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743918}

..from net::ERR_FAILED to net::ERR_BLOCKED_BY_RESPONSE. This is more
precise, as the navigation was blocked.

Bug: chromium:1051466
Change-Id: Ic3b7166a581710610f00fee197afbd0dcc2e9f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066748
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743917}

When running the multi user mode on Chrome OS, windows can visit
another user's desktop. This was implemented for up to 3 users and
didn't work correctly when more than 3 users were signed in. Since the
upper limit is 5 users, this cl adds 2 command_ids enabling it for up
to 5 users.

Bug: 940461
Change-Id: I884ce02440a44c0deba449e039da66aa8ceed334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036055
Commit-Queue: Anina Koehler <aninak@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743916}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d5361f3bf54..6b9651c5ec90


Created with:
  gclient setdep -r src-internal@6b9651c5ec90

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I180bc680443287e6f40d2c50274dea8e243a9b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070083Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743915}

This CL adds async/await to the remaining web tests in
http/tests/devtools/console for the upcoming source map asyncification.

The CL also adds a few live location sync points where necessary. This
generally happens right after console message rendering is triggered.
Before the console message is logged, all pending live location
updates need to be {await}ed, as these will happen asynchronous in
the future.

Note: console-uncaught-promise.js is re-baselined as the test output
contains a stack trace with a frame from the test script itself.
As the test moves around some code, we also require a new baseline
reflecting those changes.

Bug: chromium:1032016
Change-Id: I57e5708038f4978b903080e5699afcab4e3f5b05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066856
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743914}

Used AccessPasswordInSettingsEvent::ACCESS_PASSWORD_COPIED metrics to
count number of times user clicked Copy password button in the password
settings. Added related check to unittests.

Bug: 917337
Change-Id: I4b6172acfaffc0f8b840632cfc320187e242ad7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064549
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743913}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a66f0bf6..bc317330

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie90602dc528ac91afe303287c640dac4534c2ddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069873Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743912}

Now that both Find In Page and Text Zoom have their own separate
commands, we can move the actual implementations into BrowserCoordinator.
This leaves BVC simpler and simplifies the cleanup logic, because now
both coordinators can be stopped in BrowserCoordinator's
-stopChildCoordinators.

Bug: 1052818
Change-Id: Ib19dc967fae1777a086a6184ab328062eeef525c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062442
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743911}

GCC fails to resolve IsA template as a function parameter in DeleteSelectionCommand.
To avoid this we add a static function that uses it internally, with the expected
function signature expected by EnclosingNodeOfType.

Bug: 819294
Change-Id: If9dfcfb4ca7e298d33545bfd870b6e3d05f9ce76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052173
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743910}

relies on Extensions methods to wait for the web app to be installed,
or to check the web app launch url.

Not yet addressed: InstallBookmarkApp calls in ExtensionPolicyTest.
https://crbug.com/1055183

Bug: 1052722
Change-Id: I5b7f81b8fe3c778ce5adbe46d28da40e7a070986
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067784Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743909}

This CL fixes a test that is checking the wrong behavior at the moment,
and disables the test until the fix in V8 lands.

Background:
The idea of the test is to create an invalid WebAssembly module, and
then check that the module is rejected by streaming compilation. The
invalid module was created by taking an empty module and adding two '0'
bytes at the end. However, two '0' bytes represent an empty unknown
section, which was originally accected by the streaming decoder. The
test, however, misinterpreted the test result (i.e. "FAIL Invalid code:
compileStreaming assert_unreached: Should have rejected: undefined
Reached unreachable decoder" a.k.a. FAIL, streaming compilation
succeeded unexpectedly) as the error message of the streaming compiler,
and then marked it in the test expectations as the expected behavior.

The CL changed the test now to add bytes that clearly create an invalid
module, and also deleted the invalid test expectations.

R=leszeks@chromium.org

Bug: v8:10126
Change-Id: Ie49a7a890abd841a85dc9f634308762ea07e5928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066907Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743908}

https://chromium-review.googlesource.com/c/chromium/src/+/1959334
upstreamed the favicon caching functionality of ContentFaviconDriver
into WebContentsImpl. One thing that it missed was making clearing
the favicon cache on navigation start conditional that the main frame
was being navigated.

This CL adds that conditional and fixes a bug where delayed iframe
loads would prevent "Create shortcut..." from working as it would wait
indefinitely for a favicon URL event when it saw there was none.

Bug: 1046883
Change-Id: I520531558dec2d2daa8817884a33701b75f017bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068266Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743907}

https://chromium.googlesource.com/angle/angle.git/+log/8b73596fe704..959d077f605e

git log 8b73596fe704..959d077f605e --date=short --first-parent --format='%ad %ae %s'
2020-02-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 16cf5591e399..a553ed74b7fe (3 commits)
2020-02-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src c12493ff69e2..07e1a0a67aee (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@959d077f605e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: geofflang@google.com
Change-Id: I0d3d0fbc6a4618f3cce857188ac95289b761c510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070081Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743906}

Change-Id can be accidentally deleted from an in-flight CL *, in which
case we need to add it back so that the exporter can find the export PR
later.

* https://crbug.com/gerrit/12244

Bug: 1032044
Change-Id: I9796e4a1e13dc8e2f617d9e45e7d2cb1a4ee61f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065132
Auto-Submit: Robert Ma <robertma@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743905}

Move the message 'This device will be managed by example.com' from the
footer to the subtitle slot. Also, render the domain name using normal
face instead of bold.

Fixed: 1051851
Change-Id: Ic0fd0a582940f4c280d95ab13fbd0cbb1ad8b1d5
Bug: 1051851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069539Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Auto-Submit: Renato Silva <rrsilva@google.com>
Cr-Commit-Position: refs/heads/master@{#743904}

Previously we used vertical-align and SetInlineStyleProperty
to pass mspace height to the mspace layout algorithm, which was
a bit of a hack and due to SetInlineStyleProperty probably
caused security bug 1054765.
To fix this store mspace height as math baseline on computed style, setting it in the style adjuster.

Bug: 6606, 1054765
Change-Id: I87b7be8b5ed6d0b66b62ed9efb223cb4fc51f696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068599Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#743903}

This reverts commit d8e3222d.

Reason for revert: crbug.com/1055093

Original change's description:
> metrics: Clear the global memory dump once data has been logged.
>
> The global memory dump is fetched once per memory metrics recording, and
> never re-used. However the global dump is never reset, wasting memory.
>
> Bug: 1054360
> Change-Id: I04f65427194068e579cd87938d4cf65af9bd0962
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056820
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#743056}

TBR=asvitkine@chromium.org,lizeb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR: asvitkine
Bug: 1054360, 1055093
Change-Id: I313c6c511cb422f69998f1c4d0f7d2ecf602da04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069320
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743902}

https://android.googlesource.com/platform/external/perfetto.git/+log/5ca404665a4c..8c5bd85a9ac2

git log 5ca404665a4c..8c5bd85a9ac2 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 fmayer@google.com Merge "Add traced_perf example config."

Created with:
  gclient setdep -r src/third_party/perfetto@8c5bd85a9ac2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ic691f2c858da05c27693ee55f007a08297b2b334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070082Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743901}

Currently we stop collection of the pattern attributes if one of the
<pattern>s that is inherited from is not in the layout tree (but still
use the result). For gradients this cause the generation of the paint
server to fail (triggering fallback if available).

So consider a missing LayoutObject the same as a missing element in the
various Collect...Attributes implementations, essentially ignoring the
reference.
This also aligns our behavior with that of Gecko.

Add const qualification to the CollectGradientAttributes() methods.

Bug: 109212

Change-Id: Ie8a22664c4dc37ebc10fb02f18e1176a9d41a0e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/968924Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#743900}

This CL modernizes the OmniboxPopupCoordinator
 - to use |browser| in the initializer,
 - to remove the public property for  dispatcher, webstatelist and
browserstate,
 - to use self.browser to get browserstate, webstatelist and dispatcher
values.

This CL includes migration to ChromeCoordinator as a superclass.

Bug: 1029346, 1048423
Change-Id: Id99b8197d23cbb9d0b16e9a35b096a9b91213562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068598Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Cr-Commit-Position: refs/heads/master@{#743899}

This CL modernizes the UnifiedConsentCoordinator to use |browser| in
the initializer. This CL includes migration to ChromeCoordinator as a
superclass.

Bug: 1029346, 1048685
Change-Id: Ie2ce333091fcfcc9ed37fef74b2d71b254105f52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068597Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Cr-Commit-Position: refs/heads/master@{#743898}

With this CL, WebLayer now shares the logic of when to allow users to
proceed past security interstitials with Chrome rather than using its
previous custom implementation. I verified manually that proceeding
past an SSL interstitial still works as expected in WebLayer on Android
and Linux. There are potential behavioral differences, as the logic of
the previous custom implementation was simpler than that of
ChromeSSLHostStateDelegate. However, any such behavioral differences
should simply be bringing WebLayer's behavior in line with Chrome's
behavior here, and hence should be a Good Thing from a security UX
POV.

This CL also opens the possibility of tracking metrics for recurrent
errors in WebLayer, as ChromeSSLHostStateDelegate exposes the
necessary functionality. However, this CL does not make any changes
there. Making those changes would be a matter of porting the
//chrome-level callsites of
ChromeSSLHostStateDelegate::HasSeenRecurrentErrors() to //weblayer
(or figuring out how to share them).

Bug: 1030692
Change-Id: I21fcc417bbbaf7574fabbf27d64ebf07dbceae9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064393
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743897}

This reverts commit 232ad148.

Reason for revert: this patch was reverted in crrev.com/c/2043451 due to suspect of sync protocol violation. It was fixed in crrev.com/c/2061751.

Original change's description:
> Revert "Unify clearing of sync prefs"
> 
> This reverts commit 44d3aa82.
> 
> Reason for revert: suspect of running into sync protocol violations and the corresponding DCHECK failures.
> 
> Original change's description:
> > Unify clearing of sync prefs
> > 
> > SyncPrefs is a thin layer on top of preferences and hosts two groups
> > of preferences:
> > 1) Actual user-facing settings, such as type-selection, exposed via
> >    SyncUserSettings.
> > 2) Local "bookkeeping" sync metadata, such the last synced time or the
> >    client ID (cache GUID).
> > 
> > In addition, there are two cases that fall somewhere in the middle,
> > whose behavior is changed in this patch:
> > a) FirstSetupComplete: which roughly represents the user having
> >    consented to sync-the-feature (as opposed to transport-only upon
> >    sign-in without explicit user consent).
> > b) The encryption-bootstrap-token: which represent an explicit
> >    passphrase (usually custom passphrase) entered by the user, that
> >    allows decrypting the incoming sync changes and encrypt outgoing
> >    ones.
> > 
> > The last two preferences above fit group 1 better, so this patch stops
> > clearing them in SyncPrefs::ClearPreferences(), now renamed to
> > SyncPrefs::ClearLocalSyncTransportData().
> > 
> > With such cleanup, what used to be
> > ClearDirectoryConsistencyPreferences() is now merged into a single
> > clearing function, ClearLocalSyncTransportData(), and all calling sites
> > are unified by directly clearing prefs in ShutdownImpl(DISABLE_SYNC), as
> > opposed to individual calling sites.
> > 
> > This introduces -arguably desirable- behavioral changes because
> > codepaths like RESET_LOCAL_SYNC_DATA or STOP_SYNC_FOR_DISABLED_ACCOUNT
> > now actually clear all local metadata, which most notably includes
> > keystore keys.
> > 
> > Change-Id: I2c42f98c4e068c7e340580d0b78a5cd5b5c46171
> > Bug: 1046237
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023649
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#735841}
> 
> TBR=treib@chromium.org,mastiz@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1046237, 1048771
> Change-Id: I4ce9e941f12aa58b7b6b286e990e74a1e01dad69
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043451
> Commit-Queue: Rushan Suleymanov <rushans@google.com>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739374}

TBR=treib@chromium.org,mastiz@chromium.org,rushans@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1046237, 1048771
Change-Id: Idfad70ab9b1c00f56dc8e78257fc1a75fc71466f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066726Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#743896}

Organize common UI utils to be consistent with ios/c/b/ui.

Bug: 1052505
Change-Id: I628c814e74c58c7a1e5e913ec8c934f02a0b97d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066737
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743895}

The callback is called once to indicate the initialization is complete:
* https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=bf6cbdd206196a39ecce5575a8a828eaa844dcb5&l=92

The initialization operations are defined in:
* https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=bf6cbdd206196a39ecce5575a8a828eaa844dcb5&l=98

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I7a2f3245f6d03eeed83c79a6155f1678aae136d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050588
Commit-Queue: Jose Lopes <jabolopes@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743894}

Bug: 1043030
Change-Id: Ifc97e8f42c67e21ca6418313469a933d08c3945f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066779Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743893}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d358d055a505..5d5361f3bf54


Created with:
  gclient setdep -r src-internal@5d5361f3bf54

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ic1123363c98659c7d36173d26dcbbd1871995bb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069914Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743892}

https://chromium.googlesource.com/angle/angle.git/+log/b5576b67bcf5..8b73596fe704

git log b5576b67bcf5..8b73596fe704 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader f50cc82b3bed..214ec337a0b2 (3 commits)

Created with:
  gclient setdep -r src/third_party/angle@8b73596fe704

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: If47094967a9e2f769d404a3af21ffa05e77ebf44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069913Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743891}

This CL adds unittest for ml_agent.h/cc and ml_agent_util.h/cc.
It's very like model_unittest.cc, as ml_agent.h/cc is supposed to
replace current model_impl.h/cc and ml_service_client.h/cc in the
future.

Bug: 1018065
Test: run this unittest and pass
Change-Id: I9fda48f1235ca24220e8422a9de84e94537d0899
Cq-Depend: chromium:1903168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905044
Commit-Queue: Xinglong Luan <alanlxl@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743890}

Bug: N/A
Change-Id: I3d3e3e997ef328f696a31a7056cf1ef942c47941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062370
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743889}

This factory will be needed for using this class in WebLayer in order
to share the logic for bypassing SSL interstitials between WebLayer and
Chrome. The factory follows that of //chrome.

Bug: 1030692
Change-Id: I84ac6ef02331b7d038b3a13e4e31951b4932d124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063007
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743888}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I1db6d9e2ed57c994e8a036a5c65428d376cfa5ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069911Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743887}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6e49dff0052a..fa147af4a525

git log 6e49dff0052a..fa147af4a525 --date=short --first-parent --format='%ad %ae %s'
2020-02-22 wl@gnu.org [woff2] Fix font table access.

Created with:
  gclient setdep -r src/third_party/freetype/src@fa147af4a525

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Bug: None
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: Iadf0eb4f2c60703086827fa9f1efe7d1d413078c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069395Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743886}

This reverts commit af46fc0f.

Reason for revert: Caused 10% speedometer2 regression
crbug.com/1054840

Original change's description:
> Change HeapObserverList to HeapObserverSet to support removal while iterating
> 
> Some observers call their regular shutdown methods from ContextDisposed(), and they end up calling RemoveObserver while HeapObserverList is being iterated over.
> To support this natively this CL adds removal while iteration support by sacrificing stable iteration order.
> 
> Bug: 1052319
> Change-Id: I83ece3b5596550b9016c911e433f6f9e1a5fdc34
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060348
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Keishi Hattori <keishi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742554}

TBR=haraken@chromium.org,keishi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1052319
Change-Id: I4c49ca4d04c75be5f933308366334f3de93f4938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066435Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743885}

https://skia.googlesource.com/skia.git/+log/f084b8b6b6a1..57bc977e124c

git log f084b8b6b6a1..57bc977e124c --date=short --first-parent --format='%ad %ae %s'
2020-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 94ec1e5f8df5..b5576b67bcf5 (18 commits)
2020-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f5ddd865..f0bb4f52 (1392 commits)

Created with:
  gclient setdep -r src/third_party/skia@57bc977e124c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: I1b40c93bdc520f4d17c0171afeb4d24ba3324cc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069905Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743884}

This reverts commit f88810b8.

Reason for revert: <INSERT REASONING HERE>
virtual/storage-access-api/external/wpt/storage-access-api/requestStorageAccess.sub.window.html
external/wpt/storage-access-api/requestStorageAccess.sub.window.html
are flaky on Mac 10.10 and 10.11,
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests

I think the expectation files are different when running on wpt serve.

Original change's description:
> Enable requestStorageAccess.sub.window.html test on Mac
> 
> Enable requestStorageAccess.sub.window.html test on Mac because two
> tests virtual/storage-access-api/external/wpt/storage-access-api/requestStorageAccess.sub.window.html
> external/wpt/storage-access-api/requestStorageAccess.sub.window.html
> failed on
> https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests, but I
> reverted the expectation file change.
> 
> TBR=brandm@microsoft.com
> 
> Bug: 1053903
> Change-Id: I348c8a387346ee2a4e8980a2fe6d84e4e5272232
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068253
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Reviewed-by: Lan Wei <lanwei@chromium.org>
> Auto-Submit: Lan Wei <lanwei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#743697}

TBR=lanwei@chromium.org,brandm@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1054577
Change-Id: I95ae362c6dd2700a1e7fa4c1611ddf28ac1adab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069848Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743883}