GitLab

Datatype is responsible for writing attachments to AttachmentStore.
GenericChangeProcessor doesn't need attachment data in SyncData, only
list of attachment ids.

This change removes AttachmentList from SyncData and fixes corresponding
dependencies.

BUG=
R=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/567053002

Cr-Commit-Position: refs/heads/master@{#294879}

If a view has a ton of children (say > 5000) with the majority hidden
then we spend a lot of unecessary time in View::UpdateRootBounds on
every paint.

BUG=409126
TEST=none, see bug
R=luken@chromium.org

Review URL: https://codereview.chromium.org/566403002

Cr-Commit-Position: refs/heads/master@{#294878}

In order to componentize host_content_settings_map, one big obstacle
is the extension system. This CL changes the direction of the
dependency.
old: host_content_settings_map register extension system
new: host_content_settings_map accepts providers which allows
     extension system to register itself.

I believe this is a better design.

BUG=384869
R=yoz@chromium.org, markusheintz@chromium.org, bauerb@chromium.org
TBR=rlp@chromium.org, sky@chromium.org
TEST=no regression

Review URL: https://codereview.chromium.org/545413002

Cr-Commit-Position: refs/heads/master@{#294877}

Revert of Fix lsan failure with ManifestParserTest.* (patchset #1 id:1 of https://codereview.chromium.org/554043004/)

Reason for revert:
broke build

Original issue's description:
> Fix lsan failure with ManifestParserTest.*
>
> BUG=None
> TBR=rockot@chromium.org
> NOTRY=true
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/36816846f1cf8ceea2f96d501ebc745c82349337
> Cr-Commit-Position: refs/heads/master@{#294870}

TBR=rockot@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/574433004

Cr-Commit-Position: refs/heads/master@{#294876}

Revert of [Android] Mark posted UI thread tasks as asynchronous (patchset #4 id:60001 of https://codereview.chromium.org/512333002/)

Reason for revert:
This patch was purely experimental, and the experiment has expired.

Original issue's description:
> [Android] Mark posted UI thread tasks as asynchronous
>
> Chromium shares a message loop with Android on the browser UI thread.
> This can cause problems when the associated Looper has a sync barrier,
> preventing posted Chromium tasks from being dispatched until the
> barrier is removed. Make this sharing more fair by marking all Chromium
> Message tasks as asynchronous, avoiding stalls when there is a sync
> barrier.
>
> Note: This change is for gathering data about the perf impact and we'll
> revert it before cutting a release branch.
>
> BUG=407149,380781,407133
>
> Committed: https://crrev.com/feabeebb3ac5810f896ac8303a77ee695acaf9d4
> Cr-Commit-Position: refs/heads/master@{#292551}

TBR=aelias@chromium.org,epenner@chromium.org,nyquist@chromium.org,sievers@chromium.org,skyostil@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407149,380781,407133

Review URL: https://codereview.chromium.org/564373005

Cr-Commit-Position: refs/heads/master@{#294875}

This adds key-system less support to isMediaMIMETypeSupported and mojo
surfaces bindings for YUV quads.

R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/571183002

Cr-Commit-Position: refs/heads/master@{#294874}

The test was added for keyboard usability experiment which is no longer
needed.

BUG=413583
TEST=none

Review URL: https://codereview.chromium.org/569323002

Cr-Commit-Position: refs/heads/master@{#294873}

This allows dogfooders to get Easy unlock on consumer devices
(i.e. non-enrolled devices).

BUG=395154

Review URL: https://codereview.chromium.org/546163005

Cr-Commit-Position: refs/heads/master@{#294872}

This started out as simply converting NaCl's baseline policy to bpf_dsl,
but that led me down the rabbit hole of converting a bunch of remaining
uses of SandboxBPFPolicy within content too.  There are still a few
lingering dependencies on sandbox_bpf.h after this CL, but not many.

BUG=414363

Review URL: https://codereview.chromium.org/570763002

Cr-Commit-Position: refs/heads/master@{#294871}

BUG=None
TBR=rockot@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/554043004

Cr-Commit-Position: refs/heads/master@{#294870}

TTS initialiation can take around ~150ms to initialize on Android. Trace
this initialization to make it clear if the task is blocking critical
updates on the browser UI thread.

BUG=406597

Review URL: https://codereview.chromium.org/558323002

Cr-Commit-Position: refs/heads/master@{#294869}

BUG=

Review URL: https://codereview.chromium.org/571943003

Cr-Commit-Position: refs/heads/master@{#294868}

Since Write() takes two (or more) steps to finish, it's possible for
CdmFileIOImpl to be destructed after SetLength() is called but before
WriteFile() is called. In that case, since we SetLength(data_size), we
could end up with a corrupted file.

This CL update FileIOTest to explictly cover this case.

BUG=410630
TEST=ECKEncryptedMediaTest.FileIOTest still passes.

Review URL: https://codereview.chromium.org/563193002

Cr-Commit-Position: refs/heads/master@{#294867}

DisplayManager wasn't handling multiply nested things correctly and the
client library wasn't handling uploading to multiple views from the same
application. This fixes those.  There's still some z-ordering issues that
show up pretty visibly. This hacks up texture alpha so you can see
partially through views to try to debug.

BUG=

Review URL: https://codereview.chromium.org/555953007

Cr-Commit-Position: refs/heads/master@{#294866}

Creating a framework for suppressing pollution of the profiler data and applying for know cases of pollution.
See the bug.

The CL introduces TaskStopwatch that has to be used to measure run time for tasks. It takes care of double-counting
run time in the nested-tasks case by subtracting run time of nested tasks from their parents. TaskStopwatch can be
also used for subtracting other nested intervals, such as the time while a nested message pump runs. ThreadData::TallyADeath
now takes a stopwatch parameter instead of start_time and end_time. This helps avoid mistakes when the interval passed up to
the parent for exclusion is different from the interval for the current task duration.

BUG=401560

Review URL: https://codereview.chromium.org/445413003

Cr-Commit-Position: refs/heads/master@{#294865}

Annotate several NavigationController methods used only in testing, and
remove a helper test function that is unused even in tests.

BUG=398263
NOTRY=true

Review URL: https://codereview.chromium.org/569343002

Cr-Commit-Position: refs/heads/master@{#294864}

BUG=409926

Review URL: https://codereview.chromium.org/566833003

Cr-Commit-Position: refs/heads/master@{#294863}

-[NSView setFrame:display:] accepts BOOL as the second argument,
passing nil only worked by accident.

Review URL: https://codereview.chromium.org/569263002

Cr-Commit-Position: refs/heads/master@{#294862}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/569233002

Cr-Commit-Position: refs/heads/master@{#294861}

We are going deprecate console.timeline/timelineEnd. As the first step they will result only in time/timeEnd events and won't start/stop tracing. This change removes the code that allows to change browser wide tracing recording from the render process, it mostly reverts part of r292578.

BUG=412782
TBR=dcheng

Review URL: https://codereview.chromium.org/569153004

Cr-Commit-Position: refs/heads/master@{#294860}

BUG=NONE

Review URL: https://codereview.chromium.org/569283002

Cr-Commit-Position: refs/heads/master@{#294859}

BUG=387410
R=qyearsley@chromium.org

Review URL: https://codereview.chromium.org/563243002

Cr-Commit-Position: refs/heads/master@{#294858}

Also update the name of the asan dynamic runtime thunk .lib since it was changed in LLVM r217673.
After this change, component ASan build should be able to report NULL derefs and other AVs the same way as the static build does.

BUG=345874

Review URL: https://codereview.chromium.org/573743002

Cr-Commit-Position: refs/heads/master@{#294857}

BUG=341951,371692
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/550663004

Cr-Commit-Position: refs/heads/master@{#294856}

Previously, a scope passed in explicitly via the command line was not applied consistently.

BUG=372381

Review URL: https://codereview.chromium.org/573753002

Cr-Commit-Position: refs/heads/master@{#294855}

This regressed in r294564.

BUG=413850

Review URL: https://codereview.chromium.org/568803004

Cr-Commit-Position: refs/heads/master@{#294854}

https://chromium.googlesource.com/chromium/blink/+log/1588dd41f3260c463323681a0d22a2180b6e6330..01025b523bac1a59fa91a10d5d49f969ed24000d
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/573613003

Cr-Commit-Position: refs/heads/master@{#294853}

The chrome.app.window API has been moved to src/extensions, so app_shell
no longer needs its custom chrome.shell API to open windows.

* Remove the API implementation -- mostly a manual revert of https://codereview.chromium.org/254473011/
* Remove app_shell_resources.grd since there are no more app_shell resources
* Remove athena's support for ShellAppWindow
* Fix example apps to remove the chrome.shell workaround.

No presubmit because it has a false-positive warning about the enum rename in extension_function_histogram_value.h

No try because no presubmit doesn't seem to work by itself.

BUG=413164
TEST=extensions_unittests, app_shell_unittests, app_shell_browsertests
TBR=isherman@chromium.org for deprecating an extension function histogram
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/571643003

Cr-Commit-Position: refs/heads/master@{#294852}

BUG=404239
NOTRY=True

Review URL: https://codereview.chromium.org/491653002

Cr-Commit-Position: refs/heads/master@{#294851}

Revert of Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (patchset #1 id:1 of https://codereview.chromium.org/562243004/)

Reason for revert:
Reverting the revert. Bot still failed with this CL reverted. Sorry for the noise.

Original issue's description:
> Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (patchset #1 id:1 of https://codereview.chromium.org/554583003/)
>
> Reason for revert:
> It looks like the moto E perf bots are broken. This change looks like it makes sense so I'm reverting.
>
> crbug.com/414267
>
> Original issue's description:
> > Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not have been created at this point.
> >
> > BUG=413481
> >
> > Committed: https://crrev.com/9bb65868ce3ac1e5aae3a844beacf62281c332b6
> > Cr-Commit-Position: refs/heads/master@{#294703}
>
> TBR=nduca@chromium.org,nednguyen@google.com,tonyg@chromium.org,chrishenry@google.com,wuhu@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=413481
>
> Committed: https://crrev.com/5f712b7be45145522f183d683f11bfb243dd89e1
> Cr-Commit-Position: refs/heads/master@{#294816}

TBR=nduca@chromium.org,nednguyen@google.com,tonyg@chromium.org,chrishenry@google.com,wuhu@google.com
NOTREECHECKS=true
NOTRY=true
BUG=413481

Review URL: https://codereview.chromium.org/569333002

Cr-Commit-Position: refs/heads/master@{#294850}

NOTRY=true
BUG=413636

Review URL: https://codereview.chromium.org/570123002

Cr-Commit-Position: refs/heads/master@{#294849}

If you compile without preprocessing (first clang -E then clang, like
ccache does by default without CCACHE_CPP2), you will see warnings like:

you will see warnings like:

../../content/browser/accessibility/browser_accessibility_cocoa.mm:1155:12:error: implicit conversion of NULL constant to 'NSUInteger' (aka
'unsigned long') [-Werror,-Wnull-conversion]
    return __null;
    ~~~~~~ ^~~~~~
           0

It's because we return nil when 0 or NO should be returned instead,
normal clang compile won't catch that for some reason, perhaps because
its checking is less strict for preprocessed code.

Review URL: https://codereview.chromium.org/565383003

Cr-Commit-Position: refs/heads/master@{#294848}

The variable is set in this file but there is no other references to
it in the code base.

BUG=None

Review URL: https://codereview.chromium.org/564523003

Cr-Commit-Position: refs/heads/master@{#294847}

R=sdefresne@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/570563002

Cr-Commit-Position: refs/heads/master@{#294846}

https://skia.googlesource.com/skia/+log/5087b2c06762d0ea8b471f63953a587ecafaae0f..a63d5df455e5fb32ac995f753709893221de6147

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/574453002

Cr-Commit-Position: refs/heads/master@{#294845}

This pulls in the following Native Client changes:

r13740: (dschuff) Update revision for PNaCl r13726->r13739
r13741: (dbrazdil) Implemented sysconf(), sbrk(), malloc() in MinSFI.
r13742: (dyen) Added testing for file dup/dup2 functions for irt_ext.
r13743: (jvoung) Add a checkdeps stage to the PNaCl bots/trybots as well.
r13744: (bradnelson) Only allow fastbuild to affect symbol level.
r13745: (jvoung) PNaCl: Update Subzero revision in pnacl/COMPONENT_REVISIONS
r13746: (sbc) Add creat() declaration to newlib fcntl.h

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/569133002

Cr-Commit-Position: refs/heads/master@{#294844}

We report when:
1, The first time a file is fully read.
2, After the CDM throws an error with a special system code.

BUG=413812
TEST=Tested and both new UMA show in about://histograms.

Review URL: https://codereview.chromium.org/568623003

Cr-Commit-Position: refs/heads/master@{#294843}

We need to make a copy of them first in order to keep Buildbot working.
Only after this lands we can update the Buildbot code to use the new
path.

BUG=338338
TEST=None
R=sky@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/563383003

Cr-Commit-Position: refs/heads/master@{#294842}

This is similar to https://codereview.chromium.org/328423002/ where we started archiving browser_tests for Windows.

BUG=

Review URL: https://codereview.chromium.org/568143003

Cr-Commit-Position: refs/heads/master@{#294841}

Upon receiving a notification that network connectivity has been
restored, ASI will clear any backoff delay for uploading attachments.

BUG=411981

Review URL: https://codereview.chromium.org/569463002

Cr-Commit-Position: refs/heads/master@{#294840}