- 14 May, 2018 40 commits
-
-
sunxd authored
We want to propagate pointer-events: none information to cc to generate correct hit testing data for viz. The plan is to have blink set the hit testable bit on cc::Layers. In order to disambiguate the bit in surface layer that represents the origin of the surface, we want to rename the variable. Bug: 841358 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I207815dcfad0f29b222b0a39c350f1e926aedac9 Reviewed-on: https://chromium-review.googlesource.com/1052506Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#558450}
-
Michael Spang authored
All framebuffers refer to the same image because the attachment index is used instead of the swap chain image index. Use the swap chain image index instead. Bug: 840470 Test: ozone_demo on X11 Change-Id: Ie9132719be5ed2391042530a5fce4aba8ecbff15 Reviewed-on: https://chromium-review.googlesource.com/1054499 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558449}
-
chrome://flagsEugene But authored
Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I92403b3a703965fa90cdfe998421463a6a3fec59 Reviewed-on: https://chromium-review.googlesource.com/1054006Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558448}
-
Ingvar Stepanyan authored
There was a regression since http://crrev.com/ffe776a where Inspector capability was introduced. Now devtools frontend expects Inspector domain to be present on any targets and crashes if it's missing. This commit restores usage of capability, adding it to targets that support it to best of my knowledge. R=dgozman@chromium.org, lushnikov@chromium.org Change-Id: I6eab098ef12d5212c65cc65f0d49f619aaf4edd3 Reviewed-on: https://chromium-review.googlesource.com/1042709Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558447}
-
Esmael El-Moslimany authored
Bug: 841509 Change-Id: I841f3487c12716d4ab0c88a6a27462729308f31c Reviewed-on: https://chromium-review.googlesource.com/1057837Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#558446}
-
Erik Staab authored
R=tandrii@chromium.org Bug: 731967 Change-Id: Ief7e6c0d37225f6cef01f8b5960aa4a7aa6e8f4b Reviewed-on: https://chromium-review.googlesource.com/1057994Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#558445}
-
Steve Kobes authored
Bug: 823365 Change-Id: Ib9d707af46d45b4cd5c0eabacd91102f84ef000f Reviewed-on: https://chromium-review.googlesource.com/1058035Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#558444}
-
kylechar authored
Add a new GPU test target that runs screenshot_sync a second time with --enable-features=VizDisplayCompositor. This test will verify that GPU compositing is working for OOP-D. The test only runs on Windows and Linux bots. Originally landed in https://crrev.com/c/1028613 but was reverted because it failed on Windows 7 waterfall bots. There is some bug in the interaction between the passthrough command decoder, OOP-D and frame capture. Disable viz_screenshot_sync on Windows 7 FYI bots for now. Bug: 812385, 825906 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I96ad1b49313bf5bbcdca0f464da4b185ee74722a Reviewed-on: https://chromium-review.googlesource.com/1047146 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558443}
-
Alexander Alekseev authored
This Cl replaces ID-based link with p-link for the help button on the Time zone settings dialog. Bug: 842839 Change-Id: I1d05f041543489c41230856e8240be464b52df1c Reviewed-on: https://chromium-review.googlesource.com/1058108Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#558442}
-
Michael Spang authored
Add missing value for required parameter pWaitDstStageMask to command buffer submission. This fixes a validation error: [25936:25936:0510/163736.372562:1612536696:ERROR:vulkan_instance.cc(24)] Object: 0x0 | vkQueueSubmit: required parameter pSubmits[0].pWaitDstStageMask specified as NULL. (null) Bug: 840470 Test: Run vulkan_tests on linux with nvidia GPU Change-Id: Ib7a70da78808872e60d6461cc2ff6495fc50115c Reviewed-on: https://chromium-review.googlesource.com/1054497 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558441}
-
James Zern authored
Bug: 800762 Change-Id: Ided3819577c81b78bef59bea60718a42812075be Reviewed-on: https://chromium-review.googlesource.com/1056356Reviewed-by:
Urvang Joshi <urvang@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#558440}
-
Alexei Filippov authored
Once a sample is being recorded we close the "fast path" (lock free operation) of RecordFree function. That was bacause insertion of an element into unordered_map may cause rehashing, making all concurrent read operations invalid. The patch makes it be less strict, by locking the fast path only when there's a chance for the container do rehashing. Change-Id: I80553f59400f97ada7a2a6097b201c2da62d3b2e Reviewed-on: https://chromium-review.googlesource.com/1056404 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558439}
-
Tommy C. Li authored
Enabling on trunk in preparation for the 100% Stable rollout. 1% Stable experiment has concluded with positive metrics consistent with the Beta experiment. Bug: 799085, 737787 Change-Id: I656f55dd100ca97973e417c11bbb494f4e3c4fa9 Reviewed-on: https://chromium-review.googlesource.com/1055929Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#558438}
-
Abhishek Arya authored
A path can belong to multiple components, so totals entry shows incorrect value. R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: 842760 Change-Id: Ibbae86ed31a9d330ed02a6e7a24a5211634b2fc5 Reviewed-on: https://chromium-review.googlesource.com/1058167Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#558437}
-
Erik Luo authored
After running an Audit, the cached device is set to `null`, so after opening DeviceMode (DM), the current device does not change. The Rotate toolbar button’s enabled state is only updated on emulated Device changed, so it doesn’t get properly updated. This CL properly updates the Rotate icon on emulation Type changes (e.g. None > Responsive), not Device changes. Bug: 829305 Change-Id: Ieac2a7d76e7f711409b5d1c0ca5a3da17a9672f5 Reviewed-on: https://chromium-review.googlesource.com/1058037Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#558436}
-
John Rummell authored
Looking through the code, is_track_encrypted_ appears to only be set, and never read. Since it appears unnecessary, removing it. BUG= TEST=compiles Change-Id: I29c78326b6004755e31104faf40ff8a0fc36ca8a Reviewed-on: https://chromium-review.googlesource.com/1056391Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#558435}
-
Kevin Bailey authored
Update the text of the tab switch button to latest UI recommendation, and also noticed we weren't using the resource constant. Bug: 780835 Change-Id: I43e685d7fff4ee7c62812a1a6a22a2914cf9b359 Reviewed-on: https://chromium-review.googlesource.com/1057698Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558434}
-
https://pdfium.googlesource.com/pdfium.git/+log/22c24441a3a4..77c223be193b $ git log 22c24441a..77c223be1 --date=short --no-merges --format='%ad %ae %s' 2018-05-14 dsinclair Use internal wcstof instead of system wcstod in formcalc lexer 2018-05-14 tsepez Add regression test for XFA crash under CPDF_LinkList::GetPageLinks(). 2018-05-14 hnakashima Cleanup unused members of CFWL_MonthCalendar. 2018-05-14 hnakashima Remove dead code from CFWL_WidgetMgr. Created with: roll-dep src/third_party/pdfium BUG=chromium:813646,chromium:840922 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I663f89d69fd2fe4be1c05357226fec22db967113 Reviewed-on: https://chromium-review.googlesource.com/1058032 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558433}
-
Kim Paulhamus authored
This CL adds the extension at the Blink layer and in authenticator.mojom and includes typeconverters and layout tests. This will be used by cloud-assisted BLE, a protocol used by the WebAuthN API to communicate with certain BLE devices without explicit pairing. Also, note that this extension is in early stages of standardization and still being presented to the working group, so names and such will likely change in future versions. This is a low-risk feature - its functionality will be behind a flag, and if a request is made with either the registration or authentication extensions and the feature is disabled, then the request will proceed normally as if the extension was not used at all. Bug: 840153 Change-Id: I554452d5702511f77f47666a2abf35bf5bd9d99e Reviewed-on: https://chromium-review.googlesource.com/1046110 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#558432}
-
Joel Hockey authored
Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4825a67e3716cca47c09b1510180c61079445dbd Reviewed-on: https://chromium-review.googlesource.com/1056931Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558431}
-
Stephan Stross authored
Perftest logging on fuchsia is broken. The changed file manages locating and initializing a log file, specialized for each platform. Previously, the file failed to initialize a log file, because there was no fuchsia specific clause in the Initialize() function, and the default assumptions don't work on Fuchsia. The OS_ANDROID clause also works for Fuchsia, so this change adds it to that code path. Bug: 841574 Change-Id: I83f0d424ce9acbb28f904c08d4660f7f7661fa3a Reviewed-on: https://chromium-review.googlesource.com/1053229 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558430}
-
Esmael El-Moslimany authored
Bug: 836303 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iecad80fe56c5cd92721a5ae5408e0cef3da22d36 Reviewed-on: https://chromium-review.googlesource.com/1055807 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558429}
-
Lei Zhang authored
Move the code into the last caller. Change-Id: I1bac0758a60279ee0a4debcc18cb618c30bd5d46 Reviewed-on: https://chromium-review.googlesource.com/1056319Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558428}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/8e75ae488047c519f14f2c08b02a55bf7712fa1d..69271b5d4fed328eb61b86b013937ce22549fee5 BUG=none Change-Id: I76cae0fa5c940e6abfe3e1efc846d0f4003898e8 Reviewed-on: https://chromium-review.googlesource.com/1057426 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#558427}
-
Tommy Martino authored
Bug: 842793 Change-Id: Ie52b2702453a8607824fb800c3708d4398e55f91 TBR=rdevlin.cronin@chromium.org Change-Id: Ie52b2702453a8607824fb800c3708d4398e55f91 Reviewed-on: https://chromium-review.googlesource.com/1058013 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#558426}
-
David Valleau authored
Currently users are able to edit their printer's network configuration in ways that would make the printer unusable. This change makes it so that network printers cannot have their protocol changed to a non-network protocol. Also, USB printers do not allow any changes to their URI. BUG=chromium:841053 R=skau@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I74b6e50a09f1b61b7b63cf52f789a5d63d0d980d Reviewed-on: https://chromium-review.googlesource.com/1053212 Commit-Queue: David Valleau <valleau@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#558425}
-
Bailey Berro authored
This change adds username and password fields to the SMB Share Dialog to enable users to connect to shares that require authentication. Bug: chromium:757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7c0f825e27eb6df7fab1641942f0da92af7c0be3 Reviewed-on: https://chromium-review.googlesource.com/978461 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558424}
-
Jonathan Backer authored
Flag an error if not in whitelist. Skip over rejected commands. I used a fake (InProcCommandBuffer) instead of a mock because it was too difficult to inject (e.g. if you use a fake GrContext, you have to use fake GrBackendTexture, etc). Bug: 836928 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7e3a996fb17491b755f0423d205b385c437f7509 Reviewed-on: https://chromium-review.googlesource.com/1057891 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#558423}
-
Dan Sanders authored
Also adds support for empty buffer to VTVDA, since this feature is supported on Windows. Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I15fcbee034b4be6c56d04b283931a7c4ea6b82ab Reviewed-on: https://chromium-review.googlesource.com/1056322 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#558422}
-
Randy Rossi authored
Part of ongoing effort to enable ChromeVox in chromecast. This CL brings in the extension schema from chrome and adds relevant api features. PS 1 is base for copied files. PS 2+ modifications on top of copied files. Duplicate code will be removed later (b/837773). Bug: 73383411 Test: None Change-Id: Iabf5d5905ff2565e72e4ec38311ff35633766fe6 Reviewed-on: https://chromium-review.googlesource.com/1052496 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#558421}
-
Amirhossein Simjour authored
There are devices that have problem with the new implementation of DropdownPopupWindow on Android M. At this point, it looks to be too late to find a proper solution that we can merge back to 67. Therefore, I change the condition so that all devices < N use the old implementation of DropdownPopupWindow based on ListPopupWindow. Bug: 838736 Change-Id: Idfe1c00f609e1a911e09381401eff344131e28d0 Reviewed-on: https://chromium-review.googlesource.com/1055477Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#558420}
-
Sergey Ulanov authored
Ahem font is designed specifically for tests. There are serveral copies checked in in chromium. Putting it in third_party/test_fonts will allow to deploy it for layout tests on all platforms same way as other fonts. I will remove AHEM_____.TTF later in a separate CL(s). Bug: 787020, 778467 Change-Id: Id4bf45792c591ac1f0ac5ef94f7a1b95cef3b6f1 Reviewed-on: https://chromium-review.googlesource.com/1055811 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558419}
-
Xing Liu authored
Android API Context.getExternalFilesDirs may return a null File object when the user unmount the SD card at some point. This CL handles the null object cleanly so it won't trigger NullPointerException. TBR=nyquist@chromium.org Bug: 838419 Change-Id: I0efc8c793e45383d49038688b9af4076eeb54328 Reviewed-on: https://chromium-review.googlesource.com/1056287Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558418}
-
Rune Lillesveen authored
The anonymous block inside LayoutMenuList had its ComputedStyle modified in place. Instead, clone it for modification if necessary. Also, optimized a bit by not modifying the style when the active option text is modified if the option style does not change. Bug: 813068 Change-Id: I25e6aca96e795c7c822dd62f03c946be480f3020 Reviewed-on: https://chromium-review.googlesource.com/1057328Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558417}
-
Kenneth Russell authored
Enough of these tests are flaky on this bot that we should just use a wildcard suppression. This bot is not expected to pass WebGL 2.0 conformance. Bug: 756537 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I824d00e5f05bc42b119baa8089ef2cb81f0675a1 Tbr: rjkroege@chromium.org Tbr: zmo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1054360Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558416}
-
Greg Kerr authored
The current BrokerClient is not signal-safe because of its use of base::Pickle which uses new and delete, and also its use of std::vector, which is not technically signal safe either. These are used in messaging IPCs with the BrokerHost when a syscall is trapped, thus BrokerClient must be made signal safe. This is discussed in https://crbug.com/255063. This CL creates a new BrokerSimpleMessage class to handle simple IPC messaging with strings and ints only. It uses fixed sized messages to simplify logic and allow it to allocate all its memory on the stack. It creates send, receive, and a synchronous send-and-receive method. It also adds a basic set of unit tests to sanity check behavior. Bug: 255063 Change-Id: I8077a515921b62969a1b8b173d903f2a118ed186 Reviewed-on: https://chromium-review.googlesource.com/553400 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#558415}
-
Tom Anderson authored
Gtk increases the reference count of the cairo_pattern_t before returning it to clients, so this CL adds the appropriate call to cairo_pattern_destroy(). R=thestig Change-Id: I540c635e15d086aa515c0b1bc3953c1008df5607 Reviewed-on: https://chromium-review.googlesource.com/1058031Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#558414}
-
Marijn Kruisselbrink authored
The method being tested requires a non-unique origin, so make sure the dummy html is actually loaded with a valid security origin. Bug: 104300 Change-Id: I9b8728d1c16f788bee08fb1c0dff5637a17dc942 Reviewed-on: https://chromium-review.googlesource.com/1057830Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#558413}
-
Tom Sepez authored
Change-Id: Ic62a16887fb7e1028d961f3ba752ce9ad2fbe37e Reviewed-on: https://chromium-review.googlesource.com/1054696 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558412}
-
Jun Cai authored
Based on the discussion at: https://chromium-review.googlesource.com/c/chromium/src/+/1050935/5/content/browser/network_service_client.cc This CL changes the |is_main_frame| variable name to |is_request_for_main_frame| to make it more clear. The variable indicates if the request (associated with a frame) is the request for the frame itself or a subresource. Bug: 783990 Change-Id: I0369efc027c27cac3c19a1ce48a0fba7a67809a0 Reviewed-on: https://chromium-review.googlesource.com/1056292Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#558411}
-