GitLab

This source file was getting a bit hard to read. So some minor cleanups:

  * Pull the window tree host out into its own source file. Rename to
    CastWindowTreeHostAura to reflect naming scheme elsewhere in
    chromecast/graphics. (CastFocusClientAura, CastWindowManagerAura,
    etc.)
  * Move CastLayoutManager into the anonymous namespace
  * Fix order of methods in the window manager header.

Bug: none
Test: build & unit tests
Change-Id: I1e9f6a3ac30417b9f02ddf2c9d4439eb7b3bc734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819639
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698997}

The code has been updated with self-evident variable names, so we can
delete the obsolete comments.

Bug: none.
Test: manually.
Change-Id: Ia73d990edb8d223b35a30ab621ca48e1ec7595c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819682Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698996}

This has the following benefits:
- It forces us to consider data duplication across FrameNavigationEntry
  and PageState/ExplodedFrameState (e.g. url and referrer today).  The
  CL makes the FrameNavigationEntry the authoratitative source of the
  information.
- It is a prerequisite for persisting the |initiator_origin| of a
  navigation inside ExplodedFrameState (see also
  https://crrev.com/c/1679162).

Because of the above, this CL changes the code so that:
- Calls to NavigationEntryImpl::GetPageState *always* go through
  RecursivelyGenerateFrameState (before this CL this wasn't
  true for single-frame pages).
- Calls to NavigationEntryImpl::SetPageState *always* go through
  RecursivelyGenerateFrameEntries (before this CL this wasn't
  true for single-frame pages).

As a consequence of the changes above:
- Test Impact: Tests can no longer use an arbitrary string as the PageState
  (although empty string as a PageState is still supported).
- Performance Impact: The call to NavigationEntryImpl::SetPageState
  always (not just for multi-frame pages) will drop old
  FrameNavigationEntries and create a new tree of
  FrameNavigationEntries.
- Deserialization/Restore Impact: Session-restore code needs to take
  care to supply a correct PageState.  In particular, care needs to
  be taken to avoid using an empty PageState (see the changes this CL
  makes in sessions::ContentSerializedNavigationBuilder::ToNavigationEntry
  and android_webview::<anonymous>::RestoreNavigationEntryFromPickle).

Bug: 976055, 999078
Change-Id: Ica7036111fcbea1ddcb44acda8e4c8b21166a531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787868Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698995}

This is CL [2/4] in a series of CLs to expose "display: none"
elements to the browser process AXTree.

1. Add and improve tests for CSS display and visibility.
2. Introduce new command line flag and chrome://flags entry.
3. Update AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree
   and relevant logic for the feature to work, disabled using the
   feature flag.
4. Enable the feature in tests; update expectation files.

---

In this change I added a new RuntimeEnabledFeature flag and an
associated chrome://flags switch entry to enable the feature.

This CL does not use the flag, but prepares for use in CL [3/4].

Bug: 651614
Change-Id: I5cd4b517820a593994318d30a3ace8692e40a754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809610
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#698994}

Chrome now supports fuchsia, but t_a_extractor.exe does not. So when
compiling it, we need the `--without-fuchsia` flag.

Change-Id: I04648ae7aaeeb550d3ba4585f7b61bb2423ada3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815912
Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698993}

Just fixing casing of the name SuperSize in the links output by the
binary size trybot.

Change-Id: I7ea4a55139d964f280d06346f80b0f1f8579a68d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819108Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698992}

Bug: 1002711
Change-Id: Ie2cbd988b27c0342edbf24626727916875e04841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801915
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698991}

Bug: 977170
Change-Id: I79acbb3d4f1fd13449c515b8fc7e8731bf470296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819561
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698990}

https://skia.googlesource.com/skia.git/+log/e7bd1cb4f650..d166d2e62f3b

git log e7bd1cb4f650..d166d2e62f3b --date=short --no-merges --format='%ad %ae %s'
2019-09-23 ethannicholas@google.com SkSL interpreter now properly short-circuits boolean operators
2019-09-23 robertphillips@google.com Create a GrGpu::createBackendTexture choke point
2019-09-23 bsalomon@google.com Remove a few GrSurfaceProxy::config() usages

Created with:
  gclient setdep -r src/third_party/skia@d166d2e62f3b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@google.com

Bug: None
Change-Id: Ide3056d3de83ecb282dc26fc018b841bc2fe00ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819099Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698989}

Following WebGPU spec change at https://github.com/gpuweb/gpuweb/pull/414,
this CL adds a default value to offset in setIndexBuffer.

Bug: 877147
Change-Id: I15709fb73f4121a023a2b871a1232824f16b6460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815021
Auto-Submit: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698988}

This matches LayoutDeprecatedFlexibleBox, which uses
ClampToZero() in a couple of places.

BUG=993813
TEST=fast/deprecated-flexbox/002.html

Change-Id: Ib6a9abfbc50759fa7c819046ee4f173bb67ba06c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809105
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698987}

Currently the "content_security_policy" manifest key is restricted to trunk.
However it is mandatory for Mv3 extensions. Hence, always allow it if the
manifest version is 3.

Also, make some other minor cosmetic changes.

BUG=993530

Change-Id: Ifca0c588d923a36644002e865f853d74533d7356
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815277
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698986}

To reduce thread hops when generating VideoFrames, this CL adds
PooledSharedImageVideoProvider.  It builds on the direct provider by
maintaining a pool of SharedImageVideo objects, which it hands out
on its own thread to clients.

It also adds histograms to track VideoFrame creation time, so that
we can see which device(s) benefit from pooling.

All of this is turned off by default; it must be switched on by
enabling UsePooledSharedImageVideoProvider.

Change-Id: I4cfc03938dd4717252f3f527a3bcab0e7ae085a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699138
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698985}

Adding a new interface to AutocompleteEditText as a go-to observer to
use. The existing one UrlBar.UrlTextChangeListener with the method
onTextChangedForAutocomplete is very specifically tied to the lifetime
of the native autocomplete counterparts. Having a generalized observer
open to java features is preferable.

Bug: 1002130
Change-Id: If171d1266e4ab0a2aeeb494badac5266ee5461a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792240
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698984}

******************************Resource Sizes Diff******************************

Specifics:
       +73,728 bytes main lib size
      +620,276 bytes main dex size
    +1,046,995 bytes normalized apk size
InstallSize:
      +398,048 bytes APK size
    +1,123,771 bytes Estimated installed size (Android Go)
    +2,903,963 bytes Estimated installed size
InstallBreakdown (+2,898,339 bytes):
        +3,954 bytes Native resources (no l10n) size
        +2,284 bytes Non-compiled Android resources size
       +73,728 bytes Native code size
        +3,412 bytes PNG drawables size
          +637 bytes Package metadata size
    +2,786,312 bytes Java code size
       +28,012 bytes Compiled Android resources size
Dex:
        +2,963 entries fields
        +2,507 entries strings
        +3,770 entries unique methods
        +1,270 entries types
        +3,770 entries methods


Bug: 948739
Change-Id: I65320fcf8c554eae07a1563134701747a7edeecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815906Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698983}

Specifically, for positioned elements in a webkit-box with
a column orientation. This matches similar code in
LayoutDeprecatedFlexibleBox::LayoutVerticalBox.

BUG=993813
TEST=fast/deprecated-flexbox/012.html

Change-Id: Ibad9868a077d3a1ff62f2b2844cb086b78c33612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809526
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698982}

Accessibility testing revealed the following issues within the tool:
1. no label for the group by combobox
2. link is not keyboard accessible

This change adds:
1. better aria-placeholder for filter input bar
2. aria-label for icons and group by combobox
3. context menu for links

Bug: 963183

Change-Id: I63f343e4cc056468c3e640b735b50f7bec3051c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633332Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#698981}

The QuicStreamFactory methods definition order was completely different
from the declaration order in the header. This CL fixes that. It also
renames the test-only method CryptoConfigCacheIsEmpty() to
CryptoConfigCacheIsEmptyForTesting().

This CL doesn't actually change any code, other than the rename and
moving stuff around.

Bug: 1003423
Change-Id: I751d656cf24b41e206414be04958ac52cf4a9faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819352Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698980}

[155/51065] ACTION //chrome/browser/resources/browser_switch:app_module(//build/toolchain/win:win_clang_x64)
../../tools/polymer/polymer.py:307: SyntaxWarning: invalid escape sequence \(
  CR_DEFINE_START_REGEX = 'cr.define\('

Bug: 958138
Change-Id: I07a7b6fe2e4fe2e983b95e38c20c50986abd28e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816410
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698979}

https://imgur.com/a/gDmzwqL

Bug: 963183
Change-Id: Ibce22aaad2d609d4672700658603dff24ec30da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808796Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Anubha Mathur <anubmat@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#698978}

The module contains an ICU data file, added in crrev/c/1648623, for 30
extra languages we would like to support in Chrome going forward. The
DFM is installed on first Chrome install or update. That way all users
will receive the extra data file but we don't bloat the Android system
image. In a follow up CL, we will load the extra ICU data file on
startup if the module is installed.

Change-Id: I8368454977431031325f551616f7a19b51235ea0
Bug: 1006794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811973
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698977}

The tapping area for the arrow button in the scrollable shelf is really
small, which makes it hard to click on small devices. This change
increases it enopugh for it to be easier to hit the target.

Bug: 1004998
Change-Id: I74c9c3083e496f1e248eb00383be3ae1ba35bcf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815359
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698976}

* Fixes a bunch of bugs, I should probably add an automated test.
* script now also keeps track of number of line modifications rather than
  just commits.
* Because of asking git-log for number of lines modified, it takes 10x the
  amount of time. Might make sense to add option to disable.
* script now tries to cache git-log result.
* script now ignores trivial directories that are empty except for one child
  directory.
* Fix handling of merge commits.
* Improve parsing of owners files (now understands file:// import and set
  noparent directives).
* Now also shows owners commit stats for reference.

Change-Id: I23bcf0645b3b2d330cb781ba7daa15ac9cfcb695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810256Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698975}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/246cf2b1..770af0ab

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I95569d66ff9b7d4264fa3a3c8e7010bc16924018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819582Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698974}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/cb8b3fc5caf9..4edb70c11cc5

git log cb8b3fc5caf9..4edb70c11cc5 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 rharrison@google.com Another round of cleaning the spvc test script (#811)
2019-09-23 rharrison@google.com Rolling 2 dependencies (#812)

Created with:
  gclient setdep -r src/third_party/shaderc/src@4edb70c11cc5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I0f7120cda621e09cda07940ecd722fda418b55b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819487Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698973}

Check that frame_->View() is non-null before calling
LocalFrameView::DismissFragmentAnchor() on a mouse press.

Bug: 1006666, 995381
Change-Id: I1ee4f68787971e07ea02deb1a79b6125f58a5ade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818873Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698972}

This member seems to be unused since crrev.com/c/1139229.

Bug: 1006860
Change-Id: I8e456ddceb4313e920fc8604026bc13396cb44a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818484Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698971}

The present CL makes code more consistent between these two workflows:
1. There is already a window snapped in clamshell split view, and you
drag another window from overview and snap it on the other side.
2. There is only one window in overview, and you enter clamshell split
view by dragging and snapping it.

BEFORE: SplitViewController::OnWindowSnapped ends split view mode in
Workflow 1, whereas SplitViewController::OnOverviewModeEnding ends split
view mode in Workflow 2.
AFTER: SplitViewController::OnOverviewModeEnding ends split view mode in
both workflows.

Test: ash_unittests SplitViewOverviewSessionInClamshellTest.BasicFunctionalitiesTest
Change-Id: I698cb047dd2fbd69de8a6db08cfdae91961b58ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779005
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698970}

This is really a bounds change listener.

Bug: 1005568
Change-Id: I67456302b97ca68a8c662a5ee87b8179241a9928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817295
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698969}

Currently, the selected bookmarks are all cleared whenever there is a
change on another device. This behavior does hurt user experience and is
also different from that in iOS version. This CL only clears bookmarks
which are removed on other devices and keeps the rest of selected ones.

Bug: 999269
Change-Id: Ic86a8e6f76b0160118caf712966697c9b3af136c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808014
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698968}

The histogram is now expired so remove the code that logs it.

BUG=984277

Change-Id: Ib31f0c9347dcd415d5590b8ff539636040c7440e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815089
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698967}

Change-Id: I2658f64cabdf622071e2d8ba0c2063aa2342e847
TBR: nuskos@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815020Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698966}

This patch allows enabling Crashpad with a command line switch
--enable-crashpad, but leaves Breakpad enabled by default.

Bug: 942279
Change-Id: I48ce764efe0f74e7ab5afe35e71725b908d8ddd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765663Reviewed-by: Prasad Vuppalapu <prasadv@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698965}

Starting in macOS 10.15, screen capture requires system permissions that are
disabled by default.
This CL updates getDisplayMedia() test expectations to take this into account.

Bug: 1002984
Change-Id: I26150e8add754831e40702681719a92b33b55bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819252Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698964}

This reverts commit 7db5fb15.

Reason for revert: likely breaking PFQ, eg:
https://ci.chromium.org/p/chromeos/builders/general/Informational/b8901517067800831488

Original change's description:
> Enable cros_download_vm flag for betty-pi-arc in DEPS
> 
> Without this flag, VM image for betty-pi-arc is not downloaded when
> gclient runhooks is run
> 
> R=​bpastene@chromium.org
> 
> Bug: 1000513
> Change-Id: Ice17757549dd3a4ca506a6eec5e8e5f487425cda
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815882
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Anushruth  <anushruth@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#698609}

TBR=bpastene@chromium.org,anushruth@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1000513
Change-Id: I2d6ea05b07f78f14a04444636602c5ecfc16adb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819056Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698963}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b5578f4f0b22..314adcb844e1

git log b5578f4f0b22..314adcb844e1 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@314adcb844e1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I19dd13a221c8dbfb28e65d04ea91b3281cfb8f6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819486Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698962}

It is actually not used anywhere and only set in one place, so we can
do away with it.

Bug: None
Change-Id: Ib6f2445f2fb02dbcaac25caa3f0beae1c473fd56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816118
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698961}

OS_IOS is never set in the chrome/ directory. Also fix lint errors.

Change-Id: I6f5f56ed6415b962737262ca15f30c36562177f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816292Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698960}

This CL was created automatically with tools/perf/update_wpr script

R=perezju@chromium.org

Change-Id: If01ba7806eeed18598ba5e449c35803af5452665
Bug: 878390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813307Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698959}

This CL ensures that credential changes are picked up by a new Model
Change Processor and forwarded to a ListAdapter.
With the help of a ViewBinder, it binds chips to list items. The initial
creation of the list items happens in a simple ViewFactory that inflates
a new layout.

The added helper classes can be reused for any ListView and any type of
item inside a ListModel. I consider generalizing them and moving them to
the modelutil package but since this would simplify ListView usage
(which we usually want to avoid in favor of RecyclerViews), I'd expect
soft pushback and will defer that.

For our specific use case, RecyclerViews did not work as expected. The
reason might be the varying height of the the bottom sheet. I'll
reconsider using RecyclerViews once the mocks are final. Until then,
this solution makes it dead simple to swap out the list view for a
recycler view.

Bug: 957532
Change-Id: Id9564ecfbc26b1076604fef297cfa9d03adf94cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815120
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698958}