- 22 Oct, 2020 40 commits
-
-
Cattalyya Nuengsigkapian authored
- Show edit and delete buttons for screenshot preview notification. - Show only an edit button for video preview notification. # Testing - Screen recording shows expected buttons in preview notification for image and video, and correct behaviors when pressing each button. https://drive.google.com/file/d/10KUoHfGgNk3hzZACNz2WOSZmkYGY4Cl9/view?usp=sharing Bug: 1136666 Change-Id: Ia6efe6ce5862dc2be1163b994f5ef74966ee6c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488365 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#819915}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/377d9b3b2b65..c1aeb6318c47 2020-10-22 vidorteg@microsoft.com Reland "Localization: Migrating Settings Folder" 2020-10-22 alexrudenko@chromium.org Improvements for the Icon component 2020-10-22 jacktfranklin@chromium.org Fix flickering in emulation mode 2020-10-22 janscheffler@chromium.org Remove verbose logging in e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135482,chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0d976bdc4a046040cb27054348c117dfb36c1f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491316Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819914}
-
Dave Tapuska authored
The widget can ask the browser to start a close on the widget's behalf. BUG=1097816 Change-Id: I8f1094c6efbb0f4e553e6763d32cd7d1cdcb6744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472425Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#819913}
-
Xianzhu Wang authored
The conditions were in CompositingReasonFinder controlling compositing reasons. To prevent CompositorAnimations from starting composited transform animation for the element, we needed to disable compositing. Now move the conditions into CompositorAnimations. We'll still composite the elements with transform animation even if the animation can't be started on compositor. Compositing will still benefit to main thread animations, and we'll respect other compositing triggers. Bug: 1134652 Change-Id: Idc341a2a428f8911f98f7742169db506ab677c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490747 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#819912}
-
Matt Jones authored
This patch removes the roundabout way of setting the ResourceManager in LayerTitleCache in favor of setting it directly in the constructor. The initialization path no longer has to pass through CompositorView. Bug: 1070281 Change-Id: I9a622a4c19c8e11d72ee159583b1916c46b0e5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481469Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819911}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b6f13473709..3065fbe8b1b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC robertocn@google.com,mmentovai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091475 Tbr: robertocn@google.com,mmentovai@google.com Change-Id: I10645fe157e3420045c62e7be547b764825a3370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819910}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603335567-5b7ae75a80b56b2c3e08e562ca96c9be42987f9c.profdata to chrome-win64-master-1603357187-4783767f29971847246b39ba5f03512056047f0d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I67a2da59d10ad62e66cfefda53219350989e2901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491809Reviewed-by:
-
Matt Jones authored
Because of the way touch events are routed in the layout system, it is possible for the gesture detectors to occacionally miss events. This patch checks that events captured by the AreaGestureEventFilter have a valid down event prior to processing. Bug: 1026139 Change-Id: I37c26dcc49c36c61290aba7586bdc962238a06eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490321 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
minch authored
See recorded video at https://drive.google.com/file/d/13kAPw4I16KbMgqXjx5juVMADNSzJF6K2/view?usp=sharing Bug: 1131543 Change-Id: I25071e7f5576c1c425373164007389167bd4946f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489322 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Tom Sepez authored
The FPDF_PageToDevice() API does not guarantee specific out-parameter values when failure is indicated, so avoid using them in subsequent calculations. Although this can't happen in the currently shipping chrome, future changes in PDFium to support XFA might make this possible. Bug: 1141256 Change-Id: Ib0b9b40ab419b2ea698e0dc6172343fea0ef989c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491978Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#819906}
-
Dominique Fauteux-Chapleau authored
This moves and renames classes from chrome/browser/safe_browsing/cloud_content_scanning/ to chrome/browser/enterprise/connectors/ when they are only used by Connectors, leaving code shared by APP/SafeBrowsing/Connectors in cloud_content_scanning. This is only a refactor and should not affect the behaviour of APP, Safe Browsing or Connectors. Bug: 1109244 Change-Id: I2bf3439b7baa48bc0e662aa0a73e23dd896780cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468898Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#819905}
-
Azeem Arshad authored
This CL fixes issue with mobile data toggle screen-reader callouts not being descriptive about how the toggle can be enabled. Fixed this by adding a description about enabling bluetooth. Screenshot: https://screenshot.googleplex.com/w8Sw5qbeq9C3oy7.png Fixed: 1111853 Change-Id: I64b32b14e20dda610f7f2d33a197289140181eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482082 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#819904}
-
Jeffrey Young authored
Use global UserActivityDetector to check for ambient mode timeouts. Handle ET_SCROLL and ET_MOUSEWHEEL events. BUG=b:170217692 BUG=b:170892408 TEST=move mousewheel or two finger scroll on lock screen to exit ambient mode Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I043233979ea7cbae205b9dbbcc932b45f333d059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476582 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#819903}
-
Harry Cutts authored
Bug: none Test: change a preference and check chrome://histograms shows the sample Change-Id: I7746b17bbe84864be03954c664b3263204a040b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491985 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819902}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f80cfd667638..0ce7bcc8e296 2020-10-22 ihf@chromium.org [licenses_lib] Remove pepper-flash handling. 2020-10-22 edcourtney@google.com paygen: Use CreateTarball for stateful.tgz. 2020-10-22 ctmcnamara@chromium.org retry_util: Force curl to use HTTP 1.1 2020-10-21 seanabraham@chromium.org commands: include suite details in "Suite failed." error If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Idd59082ccab706cd608f7a27a3a09fc2c30a505d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491610Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ibaf213fdebb4c06d6d0bec4ea733de35ba504fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491356Reviewed-by:
-
Xianzhu Wang authored
This combines the following two LayoutView full paint invalidation methods: SetShouldDoFullPaintInvalidationForViewAndAllDescendants() InvalidatePaintForViewAndCompositedLayers() The new method is named InvalidatePaintForViewAndDescendants() Change-Id: If49dabc2759ccd940788c1db5e4e4f019155f7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489673 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#819899}
-
Peter E Conn authored
This CL is a refactoring that should contain no behavioural changes. It splits parts of the DigitalGoodsConverter into two additional classes, the GetDetailsConverter and the AcknowledgeConverter, and it deduplicates some of the logic in the DigitalGoodsAdapter. This should put the code in a slightly nicer state to add the new method call, ListPurchases. Change-Id: I6e56a5dc2077371a8de8bbb16eb0799bdb971a31 Bug: 1139795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487087Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#819898}
-
Aaron Leventhal authored
- Lengthen crash key strings and shorten data. 64 characters was not enough, especially when the crash key name uses some of that. - Temporarily remove the illegal reparenting dumps, as they are currently too noisy. TBR=dmazzoni@chromium.org AX-Relnotes: n/a Bug: 1141441 Change-Id: Ibaa6c91f2b17f04db1d724b49251a9fc3440545a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490115 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819897}
-
Nate Chapin authored
Change-Id: I8c19316f71a74160d470cbc9cd0fd5073b25435b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491001 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#819896}
-
Ryan Daum authored
* Relanding of functionality in chromium/2422501 * With fixes to register the IME observer in OnVisible instead of AttachTo, and breaks the observer out into its own source unit. * Registers and watch for text input focus events within webview content. * Defines a new gRPC payload for said events, and broadcasts them. Bug: internal b/161811385 Test: on device & manually with wayland client tool Change-Id: I3d264f5a76931becae2e83c35ae18dceb13b84d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490359Reviewed-by:Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#819895}
-
Ryan Sturm authored
The rate limiting is based on the number of attempted prefetches in the last minute (technically, it is the number of prefetches in the caching limit that were not served). Bug: 1138650 Change-Id: I0ed6108a8f065c2fb7acc5a90521d978dca0f830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490551Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819894}
-
Emily Stark authored
This reverts commit f11131a3. Reason for revert: We want to take a more cautious approach that doesn't immediately re-enable elision for existing extension users. Original change's description: > Remove unelide feature from Suspicious Site Reporter extension > > Since there is now a context menu option to show full URLs, this > feature is no longer needed in the Chrome extension. This allows > more flexibility, since users can now use the extension and keep > simplified domain display. > > Change-Id: I4e8a3b7baeca34983ee2bff82535bd332c1087cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435960 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812155} TBR=ellyjones@chromium.org,meacer@chromium.org,vakh@chromium.org,livvielin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib4e8b4c155df78a44bf281c1a4e207cdc4b29e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491976Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#819893}
-
James Cook authored
platform_util contains utilities for showing a file in a file explorer and opening a URL with an external protocol handler. These will need to be plumbed from lacros to ash via crosapi. Introduce a stub file for lacros. Rename the existing _chromeos file to _ash to match our naming scheme. No functional changes. Bug: 1139128, 1140585 Change-Id: I51d50f3687010f8397c8ea584cce21caccbe6982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488084 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#819892}
-
Jan Wilken Dörrie authored
This change adds a feature flag that allows treating heuristics to find new_password fields as reliable. This increases the number of password forms on which password generation can be offered, but might lead to false positives. Bug: 1140493 Change-Id: Ie7083a14664b811d2bac87c4dac302e35575a79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490116Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819891}
-
Ryan Sturm authored
Search pages are considered stale after 60 seconds (finch param that probably won't be set). This CL adds a OneShot Timer map entry match the prefetch entry and removes them in sync as well. The Timer triggers removal if it has not already occurred. Bug: 1138639 Change-Id: I5442eba3fb6855aa4edcf0e0d51fcec8db8b4f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490984Reviewed-by:
-
sandromaggi authored
Bug: 1140957 Change-Id: I620da71cea62a553eba7a756065aac0e2d47cfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489989 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#819889}
-
minch authored
FloatingMenuButton only reuses little logic of TopShortcutButton. e.g, set the tooltip. And TopShortcutButton named as the top shortcut button at the system tray menu. Make FloatingMenuButton as ImageButton instead. And AutoclickScrollCloseButton to be a FloatingMenuButton to reuse its logic. Then simplify TopShortcutButton to have only one constructor. Bug: 1131543 Change-Id: I68bc2ed7e535b45319c47271c2dfc4cd8f0e2626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485563 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Aaron Colwell authored
Removing old test code that is no longer correct and was not even being used anymore. The comment in the block being removed refers to a bug that has been closed for over a year. The coverage data also shows that this path was no longer executed. I also removed a --site-per-process early return that is no longer needed because that case is handled by the AreDefaultSiteInstancesEnabled() comparison. Bug: 1015882 Change-Id: I8664a2818b7678984b483138eca625b714f9f0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490869 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#819887}
-
minch authored
Get the focus ring color from AshColorProvider instead. Bug: 1133748 Change-Id: I681a6dde5fcf635fc4cee4f0628de17eb3cdd0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481686Reviewed-by:
-
Brian Sheedy authored
Causes GPU trybots to upload their Telemetry-based test results to a new luci-resultdb.chromium.gpu_try_test_results table. This is the same as the earlier crrev.com/c/2446893, but for try instead of CI. Bug: 1134751 Change-Id: Iab59f9057c8d41db4f3c8358da93afae7eb5b429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490144Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#819885}
-
Johann authored
A static local |instance| is set up in GetInstance. |instance_| is unused. Change-Id: Ia84422f46643eb869d1f03d0a73fbfe7d91bff11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492280 Commit-Queue: Johann Koenig <johannkoenig@google.com> Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#819884}
-
Jesse McKenna authored
This change makes IdleWakeups interpret a numeric target process as a process ID. When a process ID is provided as the target, IdleWakeups will track that process and its child processes. This is useful for measuring a particular version of Chrome, e.g., a local Chromium build, without needing to close all other running versions. Example usage: idlewakeups.exe 22612 The above makes IdleWakeups take measurements for process ID 22612, plus all of its child processes. Change-Id: I267bfc1dda8f5c0600f3fc677e40ca0f6bb26f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490253 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#819883}
-
Cammie Smith Barnes authored
This makes the histogram obsolete and removes the lines that record and test it. Bug: 1135299 Change-Id: I2339582b892bb1536139459516f74b9101d74002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485298Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819882}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1c7f0284516a..5641e3c185a8 2020-10-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 84f5eeb6dd9b to e02d8938821a (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ib00743d981ce2ca05a92c6e829563b62febef40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491967Reviewed-by:
-
Steven Bingler authored
This change makes the regexp more strict and cleans up the test's cookies when finished. Bug: 1141450 Change-Id: I706e42f321f4dbcc58931634356bab2b1e56fb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492240 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#819880}
-
Sky Malice authored
TBR: reillyg@chromium.org Bug: 1139470 Change-Id: I0e3847f0d9532f44d6cfb5a688c45fcb052e2f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480631Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#819879}
-
Ian Kilpatrick authored
... and respect box-sizing. Ok where to begin. The code which originally introduced this was: https://chromium.googlesource.com/chromium/src/+/b5d4683b6da963698fb5e3a82ac0b5b0f5c1c56e%5E%21/#F16 Basically this meant that percentages of replaced elements would resolve against their *instrinic* size only if they were located within table-cells. This wasn't matching IE's behaviour or at the time. Despite the claim. This was somewhat of a work around for the code at that time not having a good concept of table-cells within the "measure" or "layout" phase. In order to deal with resolving percentages incorrectly, treating some elements as border-box, instead of content-box was introduced (also incorrect). This patch matches the behaviour of Firefox and EdgeHTML. Effectively replaced elements if they can't resolve their percentages will return the intrinsic size. In addition we stop the box-sizing quirk, which makes some elements appear to be oversized within an element. (Again the tests which have been rebaselined match Firefox and EdgeHTML). I've implemented this behind a flag, as not super confident, and would like an easy way to turn this off without a large merge. Bug: 1122025 Change-Id: Ifd4780adc723c32754758b7ae857abf871bfc995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487780 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#819878}
-
Sammie Quon authored
Altering this number makes a trackpad swipe move around one desk at a time. This was mostly based off of my own manual testing, and I do not expect this to be a final value, but in the meantime this unblocks UX as the previous threshold had the desks moving way too fast for them to make decisions. Test: manual Change-Id: I73ebb2ab3e67fb8b53242698ce7822401fc56d3d Fixed: 1134738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490854Reviewed-by:
-
Yu Su authored
- Decouple Lens Chip onClick from Lens Shopping Menu item selection. - Switch to use #queryImage in LensAsyncManager. Will deprecate #classifyImage in a follow up cl. - Support using the Lens intent type in Lens Prime API callback when creating Lens deeplink intent. Change-Id: I541d080e4ec269fee4577153183037f15e78f576 Bug: 1099982, b/170126006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463455 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#819876}
-
