GitLab

BUG=82717
TBR=ananta@chromium.org

Review URL: http://codereview.chromium.org/8849008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113459 0039d316-1c4b-4281-b951-d872f2087c98

Fixing background mode manager to correctly display the name of the profile in the status icon. Previously it was not being updated when Chrome first started up and it was also using the incorrect name. Now it gets the correct name from the profile info cache and also updates based on changes to the profile info cache.

BUG=101837
TEST=start chrome with background apps and the status icon will have names populated correctly, also BackgroundModeManagerTest::ProfileInfoCacheObserver

Review URL: http://codereview.chromium.org/8802013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113458 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes Hunspell-related options from the spelling context menu on the Mac and tries to bring the menu more inline with the native platform menu.

Notably:
* Spelling submenu observer is split into Hunspell and Mac implementation files.
* strings are split into mac/non-mac variants (saving a bit of space on non-mac platforms?) and the titles are brought more in line with OS X (probably need more work to make this match on all OS X versions).
* Menu is reordered on Mac to more closely match the Cocoa spelling submenu. 

BUG=69944
TEST=Spelling submenu should continue to work on non-Mac platforms. On Mac it should contain 3 items - "Show Spelling and Grammar", "Check Spelling while you Type" and "Language Settings..."


Review URL: http://codereview.chromium.org/8823009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113457 0039d316-1c4b-4281-b951-d872f2087c98

Set mask after sending modifier keys.
Print unknown keysym in hex and add warning for unknown keycode.

BUG=106630
TEST=All BrowserKeyEventsTest except for AccessKey will pass


Review URL: http://codereview.chromium.org/8836007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113456 0039d316-1c4b-4281-b951-d872f2087c98

The largest sources of flake should now be fixed or supressed.

BUG= none
TEST= none

Review URL: http://codereview.chromium.org/8823014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113455 0039d316-1c4b-4281-b951-d872f2087c98

When diff-ing two snapshots, do the merge *before* doing the diff. In practice this doesn't usually yield different results, but it is possible. Merging before diffing makes more sense though, and avoids some duplicated work.

BUG=105301
Review URL: http://codereview.chromium.org/8676023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113454 0039d316-1c4b-4281-b951-d872f2087c98

Older gcc versions apparently do not support this when used with STL.

Review URL: http://codereview.chromium.org/8771061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23871
TEST=None

Review URL: http://codereview.chromium.org/8858001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:21845
TEST=Shut down option should be present at the bottom of the wrench menu on any cros device.

Review URL: http://codereview.chromium.org/8834006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63670,87461
TBR=sail@chromium.org

Review URL: http://codereview.chromium.org/8851011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113446 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106305
TEST=manually

Review URL: http://codereview.chromium.org/8793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113441 0039d316-1c4b-4281-b951-d872f2087c98

Move windows implementation to pimpl idiom
  http://c2.com/cgi/wiki?PimplIdiom

There should be no behavior change.

BUG=none
TEST=ConditionVariableTest in base_unittests suffice
Review URL: http://codereview.chromium.org/8823012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113439 0039d316-1c4b-4281-b951-d872f2087c98

MessagePumpMac wants NSApp to be initialized before the UI MessageLoop
is created.

BUG=102224


Review URL: http://codereview.chromium.org/8844001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113437 0039d316-1c4b-4281-b951-d872f2087c98

This change adds the apple software renderer as an option on Chrome/Mac.  It's enabled by passing --use-gl=apple on the command line.  It also removes the default pbuffer creation on Mac since it's not required to create GL contexts and is incompatible with the generic float renderer.

BUG=106584
TEST=--use-gl=apple on chrome/mac cmdline
Review URL: http://codereview.chromium.org/8698008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113436 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8832001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99524
TEST=compositor_unittests, views_unittests, aura_unittests...


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112641

Review URL: http://codereview.chromium.org/8565019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96010
TEST=trybots

Review URL: http://codereview.chromium.org/8831005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113429 0039d316-1c4b-4281-b951-d872f2087c98

[ Reland of 113290 http://codereview.chromium.org/8790004 ]

I keep getting confused between things like AudioImpl and PPB_Audio_Impl. This uses _shared for the names, so now we have _impl, _proxy, and _shared which makes more sense.

I also removed the ppb_opengles2_impl file since it was just a forward to the shared version.
Review URL: http://codereview.chromium.org/8849003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106716
TEST=On Chrome OS, manually test typing and autocompleting in the omnibox with accessibility turned on.

Review URL: http://codereview.chromium.org/8850001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113427 0039d316-1c4b-4281-b951-d872f2087c98

Looks like they're the same and only one of them is being reported now.

BUG=101781
TEST=none


Review URL: http://codereview.chromium.org/8824011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113426 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8786013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113425 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105872
TEST=no change

Review URL: http://codereview.chromium.org/8775064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113424 0039d316-1c4b-4281-b951-d872f2087c98

1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

BUG=87634
R=sky@chromium.org


Review URL: http://codereview.chromium.org/8815013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113423 0039d316-1c4b-4281-b951-d872f2087c98

This test looks like it's passing now.

BUG=104384
TEST=ran the test locally a few times on an aura build and didn't see any failures


Review URL: http://codereview.chromium.org/8758027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113422 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an issue where the network menu gets an I-beam
cursor instead of the default arrow cursor.

BUG=chromium-os:23842
TEST=manual: ran it and checked that the I-beam cursor is gone


Review URL: http://codereview.chromium.org/8826009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104535,75249,51716
TBR=timurrrr@chromium.org

Review URL: http://codereview.chromium.org/8853001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113420 0039d316-1c4b-4281-b951-d872f2087c98

  was_origin_cert_sent()

This will help SpdySession decide to send a CREDENTIAL frame.

BUG=106103
TEST=none

Review URL: http://codereview.chromium.org/8817021

TBR=rch@chromium.org
Review URL: http://codereview.chromium.org/8850003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113419 0039d316-1c4b-4281-b951-d872f2087c98

Discovered this while debugging WorkerTest.SharedWorkerHttpAuth for
Bug 106383.

BUG=103386
TEST=None


Review URL: http://codereview.chromium.org/8771055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113417 0039d316-1c4b-4281-b951-d872f2087c98

Adds code to explicitly destroy the Aura Shell class prior to the destruction of Aura Desktop.  The reason for this is that the Shell leaks the DesktopFilter event listeners otherwise and DCHECKs fire.

Note, this currently only affects the Mac port because other platforms exit() from the run loop and don't do explicit tear-down.

BUG=none
TEST=Manually run aura_shell_exe on Mac.
R=sky@chromium.org, xiyuan@chromium.org

Review URL: http://codereview.chromium.org/8824017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113415 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113414 0039d316-1c4b-4281-b951-d872f2087c98

TBR=simonjam@chromium.org

Review URL: http://codereview.chromium.org/8854002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113413 0039d316-1c4b-4281-b951-d872f2087c98

This is an incremental change rolled out of a larger one to remove cros_user, and make
the ProfileSyncService<Foo>Test framework easier to configure / decouple from the cros case. 
In the upcoming patch I'll remove cros_user and in several cases rely on SigninManager's new GetAuthenticatedUsername.

Also makes it so we always initialize the signin manager, regardless of platform.

Also fix a case in ProfileSyncService that calls DisableForUser when a UI error seems more appropriate.

This effectively re-implements the fix for bug 103861.

BUG=88109
TEST=


Review URL: http://codereview.chromium.org/8698001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113412 0039d316-1c4b-4281-b951-d872f2087c98

This flag determines which policies will be included in the recommended policies
templates.

BUG=49941
TEST=Everything works as before

Review URL: http://codereview.chromium.org/8773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113411 0039d316-1c4b-4281-b951-d872f2087c98

The DnsRRResoler has served its time and I don't have any further plans for it.

The TransportSecurityState will be used (in a future CL) to enforce public key
pinning at certificate verification time. Currently we only enforce it in
url_request_http_job.cc which means that we've already sent the HTTP request
(inc cookies) by the time we catch the problem. This was expeditious while we
fixed some other issues, but it's time to fix it.

BUG=none
TEST=compiles


Review URL: http://codereview.chromium.org/8692012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113410 0039d316-1c4b-4281-b951-d872f2087c98

  was_origin_cert_sent()

This will help SpdySession decide to send a CREDENTIAL frame.

BUG=106103
TEST=none

Review URL: http://codereview.chromium.org/8817021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113409 0039d316-1c4b-4281-b951-d872f2087c98

I'm not sure why it's causing valgrind errors, since the IPC system should
always be writing the variable. But it's probably good practice to initialize
it anyway.

BUG=106067
TEST=

Review URL: http://codereview.chromium.org/8773018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113408 0039d316-1c4b-4281-b951-d872f2087c98

Limiting InstallUninstallGarbageCollect to Windows.

TBR=aa@chromium.org
BUG=106381


Review URL: http://codereview.chromium.org/8847003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113406 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113305 - Revert 113300 - Revert of 112134 of Revert 112130 - Close idle connections / SPDY sessions when needed.

Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.

Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.

Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob
ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).

Added NET_EXPORT for layered_pool class defintion to fix windows shared compile.

BUG=62364, 92244, 105839
TEST=none


Review URL: http://codereview.chromium.org/8340012

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8745007

TBR=willchan@chromium.org

Review URL: http://codereview.chromium.org/8803019

TBR=rtenneti@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113305

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8836002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113405 0039d316-1c4b-4281-b951-d872f2087c98

1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

BUG=87634
R=willchan@chromium.org


Review URL: http://codereview.chromium.org/8817019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113404 0039d316-1c4b-4281-b951-d872f2087c98

1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

BUG=87634
R=jam@chromium.org


Review URL: http://codereview.chromium.org/8818014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113403 0039d316-1c4b-4281-b951-d872f2087c98