GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1c5d6304..3c2d9f15

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibed682199b00bb672430fe7cb2b6c9b9c6407992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095078Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748250}

This CL introduces the option to customize the informational text shown
on the onboarding screen based on the incoming intent. The existing
text is kept as a default, and overrides can be set up based on intent
strings.

Bug: b/150927780
Change-Id: Id49b0adc4210ea621287b32bad45dacc00a63a25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094299Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Marian Fechete <marianfe@google.com>
Cr-Commit-Position: refs/heads/master@{#748249}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5e9dd1d5e265..0d9de2003ea9

git log 5e9dd1d5e265..0d9de2003ea9 --date=short --first-parent --format='%ad %ae %s'
2020-03-09 szuend@chromium.org [utilities] Replace Array#remove with helper in DOMModelUndoStack
2020-03-09 szuend@chromium.org [utilities] Replace Array#remove with helper in AnimationTimeline
2020-03-09 szuend@chromium.org [utilities] Replace Array#remove with ArrayUtilities.removeElement
2020-03-09 szuend@chromium.org [utilities] Port Array#remove to a ArrayUtilities.removeElement helper
2020-03-09 janscheffler@chromium.org Revert "[utilities] Use Set instead of Array in CSSModel for pseudo classes"
2020-03-09 tvanderlippe@chromium.org Monkey-patch tsbuildinfo to make it deterministic
2020-03-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-03-09 tvanderlippe@chromium.org Use rollup to bundle module entrypoints
2020-03-09 tvanderlippe@chromium.org Add extra information for changed files check
2020-03-09 tvanderlippe@chromium.org Cleanup linter check
2020-03-09 szuend@chromium.org [utilities] Replace Array#remove call-site with Array#filter
2020-03-09 petermarshall@chromium.org Don't disable clear IndexedDB object store button
2020-03-09 szuend@chromium.org Prepare ResourceScriptMapping.js for asynchronous live locations
2020-03-09 szuend@chromium.org [utilities] Use Set instead of Array in CSSModel for pseudo classes

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@0d9de2003ea9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1032016,chromium:1046596,chromium:1050549,chromium:1054494,chromium:841126
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0d6f6f1e52cc821e3e5b8267ecf7b370d73df8eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094611Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748248}

Change-Id: I2a9f6b033b78d610fcae2f0c880613043a403db9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089991Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748247}

Enabled UKM collection for the XSrcset and WSrcset tags for image
srcset. See Opt-in instructions here:
https://cs.chromium.org/chromium/src/docs/use_counter_wiki.md

Srcset usage is fairly low but is likely above the 1% recommended
threshold. However, I think several of the other features counted
are also higher. Would like to have this available as an experiment
for using lower resolution image versions for data savers is run.

Bug: 1059444
Change-Id: Id2fba387d85f2c6d8537002d8cf5f6b0e06e36dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092184Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748246}

Using wpt-import in Chromium 6ff5bd12.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"
acf33020 "Add testing for the scrolling attribute"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id935f1cf36e92a93bb0776627cedb8eece4698f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095235Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748245}

https://webrtc.googlesource.com/src.git/+log/13188a24a490..2d525fe9bd56

git log 13188a24a490..2d525fe9bd56 --date=short --first-parent --format='%ad %ae %s'
2020-03-09 mbonadei@webrtc.org Fix compile all in debug mode.
2020-03-09 kron@webrtc.org Update ObjC video decoder factory to use same parameters as encoder factory

Created with:
  gclient setdep -r src/third_party/webrtc@2d525fe9bd56

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1029737
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ie88fa0da1fa0ed8141d9f89ff601b841450087f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094610Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748244}

This CL adds a test to ensure that FCP is not triggered when there's a
textfield with no text but is triggered when there's text. Spec issue:
https://github.com/w3c/paint-timing/issues/52

Bug: 1059427
Change-Id: I4cf4f961d43bfa92d6be2abd519a9d8acfde8141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091968
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748243}

This CL stops rewriting chrome-devtools: scheme URLs into
devtools: scheme URLs, by tweaking
//components/url_formatter/url_fixer.cc.

This CL also stops special-casing chrome-devtools: scheme
in //components/policy/core/browser/url_util.cc.

The CL then also proceeds to remove all other mentions of the
chrome-devtools: scheme from the codebase.  This part of the
change was initially done with the following command:
    $ git grep -l 'chrome-devtools[^-]' | xargs -n 1 \
        sed -i -e 's/chrome-devtools/devtools/g'
and then manually reviewing and tweaking the edited files.

Bug: 1055524
Change-Id: Ie9d51332e4c28fd6201f4b5590bbba5c79fc09d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088335Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748242}

Bug: 1049185
Change-Id: I9a688339f61d60d943088c413857744d7090e98b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094129
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748241}

This handler was little bit overcomplicated. This led to a bug in web
kiosk mode when we update network state, but do not update the handler.

Because of this convolution, in web kiosks, the network configure
screen did not update itself when connected to network(which is what
client will expect from the handler which observes network state).
Now it behaves more logically and predictably.

Bug: 1015383
Change-Id: I94eb7d8c1ff60f0f5b4a5843f6e3b2885c63b776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083018
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748240}

chrome://policy page calculates the elapsed time since last cloud policy
fetch. However, some elpsed times are calculated based on the timestamp
from server side whose clock may not be synced with the local one. This
may ends up with a negative elpsed time in the page.

To fix this:
1) Use last fetch timestamp in ReportScheduler if available. Because
ReportScheduler will use local clock if possible.
2) We have to fallback to server clock if ReportScheduler never records
a last fetch timestamp or there is no ReportScheduler instance.
In this case, a negative elapsed time will be changed to 0.

Bug: 1059025
Change-Id: I94fbc1b2127f81462ab389d448a9e25777edcd6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090731Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748239}

This keeps the payments specific dependencies clear and
avoids adding bloat to the already very large chrome/test/BUILD.gn.

Change-Id: I2242d5faec3166fe66b47909efaf6f4965846f42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086684
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748238}

Non-alias-properties that share a storage location on ComputedStyle with
some other property pose a problem for StyleCascade, since we must
preserve the ordering between them. For example:

  div {
    width: 10px;
    inline-size: 20px;
  }

In the above, we do not know if inline-size refers to width or height
until the computed value of direction and writing-mode are known.
Therefore, inline-size exists in the cascade alongside width, and
the "winner" must be determined not during Analyze, but during Apply.

In the first StyleCascade design, StyleCascadeSlots were used for this
purpose, which acted as a second level cascade. The first property to
be applied (width or inline-size) would effectively block the other
one from applying. This worked, but it was too slow: it has a negative
effect on certain microbenchmarks.

The problem is that we have to do extra work for regular properties
(like width), even when e.g. inline-size isn't used.

With the new StyleCascade design, it makes more sense to just skip
'width' if we're applying 'inline-size' with a higher priority.

Bug: 947004
Change-Id: Ibe3af34204dff226379e30dca17d93b337d0513f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080421
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748237}

force installed extensions

When force installed extensions failed to install with failure reason
CRX_INSTALL_ERROR_DECLINED and CrxInstallErrorDetail is
DISALLOWED_BY_POLICY and installation fails because extension type
is not allowed as per the policy ExtensionAllowedTypes, we consider it
as one of the misconfigurations.


Bug: 981891
Change-Id: If4c23d05ab8ba9f29189179e244eaa715733836d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007646Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Cr-Commit-Position: refs/heads/master@{#748236}

Bug: 938819, 906995
Change-Id: I41287062e67b4bac4b6eda3158a529b527e0c1bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083531
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748235}

This CL removes the code that records the histogram
Signin.AndroidTimeBetweenUpdateAccountList.

Bug: 1048211
Change-Id: I6948967acd281c921fa4b76aa62c598fafc82d60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093217Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748234}

Work on RTP header extension control requires the new
RTCRtpTransceiverDirection enum value "stopped", but it's
not possible to conditionally add the enum value under
a flag. The work to add "stopped" is underway in
RTCRtpTransceiver's new "stop" functionality so we're
landing the attribute addition under this intent to ship.

This change expands the serialization functions to allow
landing the "stopped" enum value in the WebRTC API, but
doesn't yet serialize the value.

Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/65YdUi02yZk
Bug: 980879

Change-Id: I32833ff16720a002b193b33e71c2fb493227002e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093219
Commit-Queue: Markus Handell <handellm@google.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748233}

Bug: 'ChromeReportingExtension'
Change-Id: If39c8ae2df58eaf34ce1e5e42ed47263375736a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090504Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748232}

Bug: 1055504
Change-Id: I291094220bf31990927b780aa76d5094c517fbd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082314Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748231}

Change-Id: I9a9d1202fea45903a138f8da5376cb04e98ccb51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090497
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748230}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d807280d52bf..ebcfc4bfc670


Created with:
  gclient setdep -r src-internal@ebcfc4bfc670

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1046374,chromium:1049638
Tbr: jbudorick@google.com
Change-Id: Iccee1db33bce59fc0e0f302996120c6e7be73259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094608Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748229}

Bug: 920638
Change-Id: I6c2d20e119ffa5219df32ffb0c6e747fa1a5c427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082606Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748228}

This adds a new test for the player that displays an already captured
paint preview. The test asserts that the player view is generated.

Bug: 1049303
Change-Id: I3a2c0bb451c8624d18da6926ad9014e7a07ecf48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076099Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748227}

The API key is not actually required to perform the request as long as
you are only dealing with authenticated requests (The access token is
enough of an identifier). This CL removes the API key (which has since
been revoked) as well as fixes a (use before define) bug in auth.js

Change-Id: I5abdde63b65b868d79a3bc4ca47ff59bc65cb25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092423Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748226}

The write barrier doesn't have to be triggered when a source object is
allocated on stack. The future implementation of the write barrier (with
generational heap in mind) will bailout if the source object is on
stack. This CL fixes tests that expect write barriers to be triggered
for source objects on stack.

Bug: 1029379
Change-Id: I5f8849c44bb42d42a472a9a8e8cab4f1eab6beef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094301
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748225}

Bug: 1006086
Change-Id: I0dd70c3b901b6f1cb1e979dda893c0aaef079943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091586Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748224}

This CL converts ViewMsg_ZoomToFindInPageRect message to blink.mojom.
LocalMainFrame interface.

This CL moves ZoomToFindInPageRect() from WebViewImpl to LocalFrame.
Then, it calls some WebViewImpl functions through ChromeClient in
LocalFrame::ZoomToFindInPageRect().

And, ZoomToFindInPageRect() is removed in WebView.h because it's not
called by RenderViewImpl anymore.

Bug: 1047467
Change-Id: I8c06c9857ce7f9805ab1b28c43d8b4b847895403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079714
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748223}

This is failing consistently.

BUG=1059767
NOTRY=true
CC=sadrul@chromium.org,vmiura@chromium.org
TBR=crouleau@chromium.org

Change-Id: I49e9e98852709daf004d7409f1f49458bc309477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093596Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748222}

Currently, we only have tests test how normal script policies affect on
setTimeout and setInterval handlers. This CL add four new tests aimed to
test the behavior via default polices.

Bug: 1059755
Change-Id: I820d08cebb0fe72e2787ce9f58c86a4a9a3068fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094133Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748221}

Design doc:
https://docs.google.com/document/d/1C2VKkFRSc0kdmqjKan1G4NlNlxWZqE4Wam41FNMgnmA/edit?usp=sharing

Base + enabled on subframe  : This CL
     + enabled on main frame: https://chromium-review.googlesource.com/c/chromium/src/+/1477694

A few tests are still failing. They can be seen at:
https://chromium-review.googlesource.com/c/chromium/src/+/2050308

Bug: 936696
Change-Id: I1451ae6917aeb60c12926500231d7f1eb4b5b687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533913
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748220}

This change adds special handling for compromised credentials from
mobile apps. Instead of a button Change password user see a label which
tells him to open the app and change password there.

Bug: 1047726
Change-Id: I29c633015a0dcbe22949d5ba7fe97b79883b63d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087583Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/master@{#748219}

There is a bug that navigation of OOPIF's remote iframe in Web Bundle
file cause DCHECK failure. The root cause of the bug is that:
  - When NavigationControllerImpl::NavigateFromFrameProxy() is called
    for a remote iframe, this method clones the committed
    NavigationEntryImpl.
  - NavigationRequest's constructor clones the WebBundleNavigationInfo
    of the passed NavigationEntryImpl. This is not correct, because
    WebBundleNavigationInfo should be attached to the frame, not the
    page.

To fix this bug, this CL moves WebBundleNavigationInfo from
NavigationEntryImpl to FrameNavigationEntry.

Bug: 1058721, 1040800
Change-Id: Ia654876cfd08433550d1bdb9b81e0aac402fe61b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091191Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748218}

This reverts commit 956b131c.

Reason for revert: 
Specualtive revert in order to fix broken test in
https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-chrome/2747

Original change's description:
> arc: net: remove ARC N legacy APIs
> 
> This patch removes net.mojom APIs and fields only used in ARC N:
>  - NetworkConfiguration mac_address: the host mac_address of a network
>  is now completely hidden in ARC P.
>  - GetDefaultNetwork and DefaultNetworkChanged: ARC P is multinetwork
>  aware and always need the full list of connected services.
> 
> BUG=b:149716479
> BUG=b:145960788
> TEST=Compiled, flashed eve, ran CtsNetTestCases.
> 
> Change-Id: I3368d620d44dd910aae7a12c84c207c3d5cb6cf3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086362
> Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Commit-Queue: Hugo Benichi <hugobenichi@google.com>
> Cr-Commit-Position: refs/heads/master@{#748094}

TBR=kinaba@chromium.org,jorgelo@chromium.org,hidehiko@chromium.org,mnissler@chromium.org,dominickn@chromium.org,hugobenichi@google.com,garrick@chromium.org,jasongustaman@chromium.org,taoyl@chromium.org

Change-Id: Id248f5e5f23d8c995404f509c30289b77f94e2cc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:149716479, b:145960788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094307Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748217}

sendBeacon depends on OOR-CORS and BlinkCORS does not support it.

NOTRY=true

TBR: yhirano@chromium.org
Change-Id: Ibd2d0d5b7f67fe3c9d680f985915326767b9be45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094421Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748216}

To address the UX feedback, this CL makes the error messages displayed
in the smart card PIN scenarios shorter:
1. Don't display "Please try again".
2. Don't display the number of attempts left when it's greater than 3.

Bug: 1024251
Change-Id: I6450cd96a62a60fc2c414e71ef81af06d93e0e26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091355Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748215}

Bug: 1006086
Change-Id: I7abf288db967ebb09a6a61be54fcbeaddab8febd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091587
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748214}

This CL converts FrameHostMsg_DidFinishLoad message to blink.mojom.
LocalFrameHost interface.

WebLocalFrameImpl::DidFinish() starts to invoke LocalFrameHost::
DidFinishLoad first, then it calls RenderFrameImpl::DidFinishLoad
because this CL can't move all logics of it to WebLocalFrameImpl::
DidFinish yet.

RenderFrameHostImpl begins to override DidFinishLoad. Then, it invokes
OnDidFinishLoad implemented in WebContentsImpl class through
RenderFrameHostDelegate class. In WebContentsImpl class, OnDidFinishLoad
is moved to from IPC handlers to the implements of
RenderFrameHostDelegate class.

Bug: 1047335
Change-Id: Id5e38f3338759345dae4654cb8843e9069f8bafb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074457
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748213}

Bug: 1022143

Change-Id: I5ff3ade372059ef4faabe904ae85582de2339d54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089692
Commit-Queue: Jana Grill <janagrill@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748212}

This reverts commit 2714fec9.

Reason for revert: Breaks GN's MSVC generator, https://crbug.com/1059666

Original change's description:
> Support typemaps inlined as GN targets
> 
> This introduces support for typemaps specified as GN targets, with new
> cpp_typemaps and blink_cpp_typemaps variables that mojom() targets can
> used to reference their typemap rules.
> 
> The underlying work to use the typemap configuration is shared with the
> existing typemap infrastructure, but the net result is that we no longer
> need separate .typemap files or global "bindings configurations" once
> everything is converted to this approach.
> 
> Bug: 1059389
> Change-Id: Id2e5fe765d3c7600a3f50e337fb693f1b3a3cc0a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090716
> Commit-Queue: Ken Rockot <rockot@google.com>
> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747990}

TBR=rockot@google.com,oksamyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1059389
Change-Id: I060cf9d20c7d03c930296a9e777ab5e8c4e2a7b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093136Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748211}