GitLab

BUG=354849
TBR=alancutter

Review URL: https://codereview.chromium.org/209813002

git-svn-id: svn://svn.chromium.org/blink/trunk@169833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/200783007

git-svn-id: svn://svn.chromium.org/blink/trunk@169832 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=248938
TBR=eseidel

Review URL: https://codereview.chromium.org/207453003

git-svn-id: svn://svn.chromium.org/blink/trunk@169831 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Originally [LegacyImplementedInBaseClass] was intended to be short-term,
as the name suggests, for some refactoring.

However, for more complex cases of 'implements' usage,
the requirements that 'implements' puts on C++ implementation
makes it an ugly mess.
Thus allowing implementation in base class seems useful long-term,
so re-introducing.

Per:
WebGLRenderingContextBase
https://codereview.chromium.org/205243013/

Documentation:
http://www.chromium.org/blink/webidl/blink-idl-extended-attributes#TOC-ImplementedInBaseClass-i-

Compare earlier CL removing this:
Remove support for [LegacyImplementedInBaseClass] IDL extended attribute 
https://codereview.chromium.org/169273002/

R=haraken
BUG=344224

Review URL: https://codereview.chromium.org/209663005

git-svn-id: svn://svn.chromium.org/blink/trunk@169830 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=355463
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/209783002

git-svn-id: svn://svn.chromium.org/blink/trunk@169829 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After the migration to the new SVG property implementation, some unused
functions were left. This patch removes the remainder of the unused
functions.

Review URL: https://codereview.chromium.org/208523005

git-svn-id: svn://svn.chromium.org/blink/trunk@169828 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently the bindings overuse WrapperConfiguration::Dependent.
This changes it to use WrapperConfiguration::Independent
unless Dependent is actually needed, by computing it once
in the interface context.
(Fixes one FIXME and removes some hard-coding.)

This is split off as 1/2 bindings-only change from:
Implement ImageData constructors.
https://codereview.chromium.org/196343032/

BUG=345503
TBR=haraken

Review URL: https://codereview.chromium.org/199633014

git-svn-id: svn://svn.chromium.org/blink/trunk@169827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This part of the source is fairly fragile. I had to temporarily add a
direct include to WebFrame.h because typedefs cannot be forward
declared. Unfortunately, this causes IntSize.h to be included before
Cocoa. Since Cocoa.h can set NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES,
this can cause build failures with conflicting typedef redefinitions of
NSRect. To hack around this, we temporarily move the Cocoa.h include to
the header as well.

BUG=355268

Review URL: https://codereview.chromium.org/209663002

git-svn-id: svn://svn.chromium.org/blink/trunk@169826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Check toWebPluginContainerImpl() result before dereferencing, even with isPluginDocument() sometimes it's 0;

BUG=331927

Review URL: https://codereview.chromium.org/207143003

git-svn-id: svn://svn.chromium.org/blink/trunk@169825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=355459
TBR=apavlov

Review URL: https://codereview.chromium.org/209683003

git-svn-id: svn://svn.chromium.org/blink/trunk@169824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is doing mechanical replacement and there's nothing non-trivial.

BUG=340522

Review URL: https://codereview.chromium.org/204743002

git-svn-id: svn://svn.chromium.org/blink/trunk@169823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Shadow DOM styling spec was changed.
/content/ was reverted in the spec.

Original issue's description:
> Implement /content/ combinator.
> 
> spec: shadow styling
> http://dev.w3.org/csswg/shadow-styling/#content-combinator
> 
> The added layout tests are basically the same as ::content's, because /content/ combinator should have almost the same behavior (except css text, ::content with descendant combinator).
> 
> BUG=349334
> TEST=fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html,fast/dom/shadow/content-combinator-css-text.html,fast/dom/shadow/content-combinator-dynamic-attribute-change.html,fast/dom/shadow/content-combinator-in-inert-shadow.html,fast/dom/shadow/content-combinator-scoped.html,fast/dom/shadow/content-combinator-with-cat.html,fast/dom/shadow/content-combinator-with-hat.html,fast/dom/shadow/content-combinator-with-host-pseudo-class-2.html,fast/dom/shadow/content-combinator-with-host-pseudo-class.html,fast/dom/shadow/content-combinator.html,fast/dom/shadow/multiple-content-combinator.html,fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-content-combinator.html
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169085

BUG=349334
TBR=dglazkov@chromium.org,hayato@chromium.org

Review URL: https://codereview.chromium.org/205563004

git-svn-id: svn://svn.chromium.org/blink/trunk@169822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Add a test to confirm that pre-finalization hook can be implmemented with HeapHashSet<WeakMmber<T>, U>.

BUG=

Review URL: https://codereview.chromium.org/204313002

git-svn-id: svn://svn.chromium.org/blink/trunk@169821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that we don't have partial layout we can recombine these methods. No
one should be calling the other one except updateLayoutIgnorePendingStylesheets
anyway.

R=pdr@chromium.org,ojan@chromium.org

Review URL: https://codereview.chromium.org/209323003

git-svn-id: svn://svn.chromium.org/blink/trunk@169815 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTMLMediaElement::beginScrubbing() would setPausedInternal(true), a mode
of pausing that is invisible to scripts. If a media controller was
detached while scrubbing, HTMLMediaElement::endScrubbing() would never
be called and the element would be stuck in this mode.

Since a user can already pause, scrub and then continue playing, making
MediaControls do the same should work just fine. Simply keep track of
the state before scrubbing and avoid updating the play button(s) as long
as we're scrubbing.

Note that the special handling of ended() is not needed, since reaching
the end of the resource pauses. This wasn't the case at the time the
code was originally written.

BUG=341813

Review URL: https://codereview.chromium.org/204803002

git-svn-id: svn://svn.chromium.org/blink/trunk@169814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Don't rely on values computed as a side effect of paint. (https://codereview.chromium.org/208203002/)

Reason for revert:
Looks like this is causing ASSERTs due to calling layout-dependent code at the wrong time: https://code.google.com/p/chromium/issues/detail?id=355277

Original issue's description:
> Don't rely on values computed as a side effect of paint.
> 
> Contrary to the assertions on the bug, the current code is correct. As
> the user changes the selection, there will naturally be a visual
> affordance to indicate the selection changes. By the time we scroll,
> RL::hasBlockSelectionGapsBounds will be current and correct.
> 
> That said, the hope is that in the future paint will have no side
> effects at all, nor do we want layout tests to require repaints during
> their execution. So even if this is technically correct it's undesirable
> on a number of levels.
> 
> This cl replaces the use of hasBlockSelectionGapsBounds with non-paint
> related code (in fact, that function could be removed entirely).
> 
> R=abarth@chromium.org
> BUG=353827
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169752

TBR=abarth@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=353827

Review URL: https://codereview.chromium.org/209543002

git-svn-id: svn://svn.chromium.org/blink/trunk@169813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#user-interface

Added to the spec in http://html5.org/r/8315 after a long discussion:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2013-November/041662.html

Firefox already implements click to play/pause when controls are
visible, but that implementation predates the spec so accesskey does not
work.

HTMLMediaElement::togglePlayState() is made public so that it can be
used to implement play/pause in MediaControls also.

The video-click-dblckick-standalone.html test has been expected to fail
since April 2013, r148246, so remove it now since the the results would
change. The new tests provide sufficient coverage.

BUG=354746
TEST=LayoutTests/media/activation-behavior.html
     LayoutTests/media/activation-behavior-accesskey.html
     LayoutTests/media/activation-behavior-shadow.html

Review URL: https://codereview.chromium.org/208483002

git-svn-id: svn://svn.chromium.org/blink/trunk@169812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik

Review URL: https://codereview.chromium.org/199633011

git-svn-id: svn://svn.chromium.org/blink/trunk@169811 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following https://codereview.chromium.org/171383002/ BisonCSSParser::parseMediaQueryList is no longer used. This CL removes that unused code.

BUG=

Review URL: https://codereview.chromium.org/201573006

git-svn-id: svn://svn.chromium.org/blink/trunk@169808 bbb929c8-8fbe-4397-9dbb-9b2b20218538

That CL caused a bunch of crashes (see referenced bug). This CL contains a
manual partial revert of that CL, which will hopefully fix the crashes.

TBR=eseidel@chromium.org
BUG=355262

Review URL: https://codereview.chromium.org/209473002

git-svn-id: svn://svn.chromium.org/blink/trunk@169807 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=japhet

BUG=355274

Review URL: https://codereview.chromium.org/208393009

git-svn-id: svn://svn.chromium.org/blink/trunk@169806 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We already had code to handle this case, which is shared
by editing as well as HTMLElement::setInnerText.
However that code (replaceChildrenWithText) appears to
be both wrong and unsafe (modifies existing text nodes
without checking if they're shared or not), so I chose
not to re-use it for now.

This was originally committed as:
https://src.chromium.org/viewvc/blink?view=rev&revision=169394
using replaceChildrenWithText, but was rolled out for
breaking a zillion tests. This version does not use
replaceChildrenWithText.
BUG=352836
R=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/200763006

git-svn-id: svn://svn.chromium.org/blink/trunk@169805 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/206413004

git-svn-id: svn://svn.chromium.org/blink/trunk@169804 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per the specification, the iframe's name should be an empty string if unset:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name

Instead, Chromium was using the iframe's id as window name if the name was
unset. This change makes us behave like Firefox 27 and IE 11, verified using:
http://jsfiddle.net/xf5H7/9/

This CL sets the name attribute iframe in a lot of layout tests so that
testRunner.dumpChildFramesAsText() keeps printing the same result.

R=arv@chromium.org, tkent@chromium.org
BUG=347169
TEST=fast/frames/iframe-no-name.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168553

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168801

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169304

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169683

Review URL: https://codereview.chromium.org/187103002

git-svn-id: svn://svn.chromium.org/blink/trunk@169803 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following the review of https://codereview.chromium.org/209443002/ , I've changed the unitTable access method to be a static CSSPrimitiveValue::fromName method.

BUG=

Review URL: https://codereview.chromium.org/209443003

git-svn-id: svn://svn.chromium.org/blink/trunk@169802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since MediaQueryExp::create returns a nullptr when the input string is not a valid media feature,
I've renamed it to createIfValid.

BUG=

Review URL: https://codereview.chromium.org/209443002

git-svn-id: svn://svn.chromium.org/blink/trunk@169801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Expand use of WidthCache to apply to all complex text width queries.
It'll still bail out for queries where the GlyphOverflow bounds are
needed.

BUG=347186
R=dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/206793005

git-svn-id: svn://svn.chromium.org/blink/trunk@169800 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We were blocking tag, id and class from matching when put before :host, but were
not correctly stopping things like :first-child:host or *:host.

Instead of trying to black list selectors we need to whitelist :host and
:ancestor as being special.

It turns out we did have test coverage for this, but the expected results were
all wrong so it printed PASS even though we were failing what the test was
supposed to be testing.

BUG=355149, 355158

Review URL: https://codereview.chromium.org/208933006

git-svn-id: svn://svn.chromium.org/blink/trunk@169799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSS2.1 is now clear about what to do if the collapsed margins are
greater than the offset required to clear a float.

"Computing the clearance of an element on which 'clear' is set is done
by first determining the hypothetical position of the element's top
border edge. This position is where the actual top border edge would
have been if the element's 'clear' property had been 'none'. If this
hypothetical position of the element's top border edge is not past
the relevant floats, then clearance [..] is set to the greater of:
The amount necessary to place the border edge of the block even with
the bottom outer edge of the lowest float that is to be cleared. [or]
The amount necessary to place the top border edge of the block at
its hypothetical position."

http://www.w3.org/TR/CSS2/visuren.html#clearance


BUG=

Review URL: https://codereview.chromium.org/195743002

git-svn-id: svn://svn.chromium.org/blink/trunk@169798 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is done in order to get the origin and WebFrame needed to create the
CDM. This is now similar to how WebMediaPlayer is created. This change adds
a Page supplement for MediaKeys to enable this.

BUG=250049, 353324
TEST=EME content tests pass (plus disabled ECK browser tests now pass)

Review URL: https://codereview.chromium.org/195053004

git-svn-id: svn://svn.chromium.org/blink/trunk@169797 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=308704
TEST=new test runs

Review URL: https://codereview.chromium.org/203323006

git-svn-id: svn://svn.chromium.org/blink/trunk@169796 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Notry because we don't have an XP trybot.
NOTRY=TRUE
BUG=354849

Review URL: https://codereview.chromium.org/208313005

git-svn-id: svn://svn.chromium.org/blink/trunk@169795 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove a lot of dead code from AXNodeObject. The following virtual function is
no longer used:
virtual void accessibilityText(Vector<AccessibilityText>&);

BUG=352771
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/202953005

git-svn-id: svn://svn.chromium.org/blink/trunk@169794 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Like with classes, even if local TargetedStyleRecalc is not
supported for an attribute selector, this also causes style
invalidation tree walks rather than
setting style recalc dirty bits directly.


BUG=339729,352300

Review URL: https://codereview.chromium.org/208323003

git-svn-id: svn://svn.chromium.org/blink/trunk@169793 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/205193002

git-svn-id: svn://svn.chromium.org/blink/trunk@169792 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: reset inspector agents before frame view is reset, but after the rest of the frame interations.

BUG=352702,312393,344623

Review URL: https://codereview.chromium.org/204543004

git-svn-id: svn://svn.chromium.org/blink/trunk@169791 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderBlockFlow::marginBeforeEstimateForChild() was checking the wrong
margin when detecting quirky children. The performance test added by
this patch times out without the change in this CL - obviously a
pathological case!

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169269

Review URL: https://codereview.chromium.org/190913003

git-svn-id: svn://svn.chromium.org/blink/trunk@169790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make corresponding fix to StyleInvalidator to not break invalidations in
which the document element itself needed invalidation.

Review URL: https://codereview.chromium.org/201443011

git-svn-id: svn://svn.chromium.org/blink/trunk@169788 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since the bits are actually stored in NodeRareData anyway, we should
just use those same bits for ShadowRoot and get rid of all this code
duplication.

Review URL: https://codereview.chromium.org/208933003

git-svn-id: svn://svn.chromium.org/blink/trunk@169787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Set the cache dirty in RenderLayer::styleChanged and recompute
the rect during computeCompositingRequirements.

Also, get rid of absoluteBoundingBox from RenderLayer. The only
caller can use the new cached value since it always happens after
computeCompositingRequirements.

The unfortunate thing is that if a RenderLayer is modified, we
need to recompute the absolute bounds for all its descendant layers.

This saves ~3% of the computeCompositingRequirements time on the
tip of tree version of https://github.com/abarth/app-widgets/blob/master/demo.html.

The version checked into the key_silk_cases pageset doesn't show
the perf win because it doesn't have many RenderLayers outside
of the drawer being dragged.

The bigger win will come from the following patch that adds/removes
layers to the RenderGeometryMap lazily. Right now that's 10-20% of
the computeCompositingRequirements time in this demo.

Review URL: https://codereview.chromium.org/208313004

git-svn-id: svn://svn.chromium.org/blink/trunk@169786 bbb929c8-8fbe-4397-9dbb-9b2b20218538