- 28 Nov, 2018 40 commits
-
-
Jan Lamecki authored
This view will be used to render Cast WebContents in android.app.Presentation dialog. Test: None. Bug: internal b/112463440. Change-Id: Idb848ac27233f9c2b2ce4200d216b49ae186f34a Reviewed-on: https://chromium-review.googlesource.com/c/1345070Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Jan Lamecki <jachor@google.com> Cr-Commit-Position: refs/heads/master@{#611644}
-
Andy Paicu authored
https://github.com/w3c/webappsec-csp/issues/322 raises an interop issue It appears the issue itself has been fixed since but I've added these tests regardless to ensure there is no regression. Bug: 694525 Change-Id: Icb5502e228b3a96c176cbe23d5b4ce9c5c8640ab Reviewed-on: https://chromium-review.googlesource.com/c/1348054Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611643}
-
Mihai Sardarescu authored
This reverts commit b04e513f. Reason for revert: This CL contains changes only for Windows, Linux and macOS (if you look at the main changes in signin_util.{h|cc} file, you'll see they are ifdefed out on ChromeOS. Browser test from the same test suite (WebviewClientCertsLoginTest) failed already at the previous build on the same target: * Build that fails a tests from WebviewClientCertsLoginTest and that does not include my CL: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9853 * Build that fails a test from WebviewClientCertsLoginTest and that includes my CL: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9854 Original change's description: > Revert "Clear managed profile on start-up if having a primary account is not allowed." > > This reverts commit e98161eb. > > Reason for revert: Sheriff suspecting this change is responsible for test failures https://crbug.com/909034 -- if not, please reland apologies for the trouble! > > Original change's description: > > Clear managed profile on start-up if having a primary account is not allowed. > > > > This CL clears the profile when it is loaded is the primary account is no longer > > allowed (e.g. profile was marked as a managed profile or the profile). > > > > As this is a very destructive action (the profile directory is removed from disk), > > the user is presented with a permanent browser modal dialog. > > > > Screenshots for each platform: > > Linux: https://drive.google.com/open?id=1HO693VkDnC0qjPxHJdFZr3CPqOs2Hidf > > Windows: https://drive.google.com/open?id=1gvmvt2wUsA42nmcVWTZCB1F5encHJRRH > > > > Design doc [Google internal only]: > > https://docs.google.com/document/d/1QqWoV1I7WgrzeHJwm9agG56ZqXD_Q2L3LB3K7Ck89GI/edit?usp=sharing > > > > Bug: 907474, 887756 > > > > Change-Id: Ib1187d79a45e0829b57768582c5d11126b0a5c46 > > Reviewed-on: https://chromium-review.googlesource.com/c/1288829 > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Owen Min <zmin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#611135} > > TBR=ellyjones@chromium.org,pastarmovj@chromium.org,droger@chromium.org,msarda@chromium.org,zmin@chromium.org > > Change-Id: I0c1468ce16d832ec57de9c456e1642e054fe9cfa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 907474, 887756 > Reviewed-on: https://chromium-review.googlesource.com/c/1352646 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#611432} TBR=ellyjones@chromium.org,pastarmovj@chromium.org,droger@chromium.org,rockot@google.com,msarda@chromium.org,zmin@chromium.org Change-Id: I6da34b30e8c740b48da32cba4be3fcac5e5e6ea0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907474, 887756 Reviewed-on: https://chromium-review.googlesource.com/c/1352360 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#611642}
-
Gauthier Ambard authored
This CL creates the AutofillEditTableVC, to be the replacement of the LegacyAutofillEditCollectionVC. Bug: 894791 Change-Id: I7dfff03765db8c856e52b226905ae4555bde89b4 Reviewed-on: https://chromium-review.googlesource.com/c/1345973 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#611641}
-
Matt Falkenhagen authored
Revert "NetworkService: add instrumentation for OnStartLoadingResponseBody crash." This reverts commit 2ba89415. Revert "NetworkService: more instrumentation for OnStartLoadingResponseBody crash" This reverts commit 4f3d5b77. Revert "Add instrumentation to debug a crash in ThrottlingUrlLoader." This reverts commit 709b126d. Bug: 882661 Change-Id: Ic320e60fb84a5008bf18a106476c006bf06ada5a Reviewed-on: https://chromium-review.googlesource.com/c/1350567Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611640}
-
Tobias Sargeant authored
Existing timeouts for input event ack (5s) and navigation commit (30s) trigger a renderer unresponsive signal that causes the Chrome notification to trigger. This CL connects the current signal to AwContentsClient, in preparation for exposing as a WebView callback. Bug: 907887 Change-Id: I3af8e8b9e6b7f991c951aba73e4c1a1e3af95a67 Reviewed-on: https://chromium-review.googlesource.com/c/1348093 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611639}
-
Andy Paicu authored
Added a test for behavior around srcdoc iframes CSP inheritance. This tests the current specified behavior of always inheriting the parent CSP for srcdoc iframes. Bug: 694525 Change-Id: I049ef8c5a9e75c052dc2767ea2d523f54cca497f Reviewed-on: https://chromium-review.googlesource.com/c/1350889Reviewed-by:
-
Douglas Stockwell authored
R=dsinclair@chromium.org, hnakashima@chromium.org Bug: 902646 Change-Id: I896f190feeacededc97355d575b8dc3c26b03879 Reviewed-on: https://chromium-review.googlesource.com/c/1329808Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#611637}
-
Vaclav Brozek authored
This CL replaces <owner> entries for vabr@ with relevant people, to keep the records up to date after vabr@'s departure. The CL also removes gcasto@ from all touched histograms. gcasto@ has not been working on Chromium's password manager for some years now. Similarly, the CL removes yfriedman@ (because yfriedman@ is more active on Chromium, vabr@ checked with yfriedman@ that this removal is OK). The CL does not add new owners to obsolete histograms. Bug: 908813 Change-Id: Ifddb086ab567ec6e7ba2bab39f592715210c9d91 Reviewed-on: https://chromium-review.googlesource.com/c/1352176Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611636}
-
Mohamed Amir Yosef authored
This CL changes Cryptographer::DecryptToString() to return a boolean instead of an empty string to signal failure/success. Change-Id: I12f1f65a177a23648a83d522900fa5c99f60ff4c Reviewed-on: https://chromium-review.googlesource.com/c/1350617 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#611635}
-
Attila Uygun authored
Bug: 908472 Change-Id: I2d67e946f46a83b930a22ace762cb064e73bb8fb Reviewed-on: https://chromium-review.googlesource.com/c/1350894Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Attila Uygun <auygun@opera.com> Cr-Commit-Position: refs/heads/master@{#611634}
-
Christian Dullweber authored
To simplify fixing Clear-Site-Data, I move some of the code that was duplicated for the network_service into a shared location. Bug: 898465 Change-Id: I25eac82e7a6f3481b03ac88946a1e7a6828cbfc9 Reviewed-on: https://chromium-review.googlesource.com/c/1350971 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#611633}
-
Javier Ernesto Flores Robles authored
Sets the background color to white. Changes the preffered height to 360. Bug: 878388, 845472 Change-Id: If4ff0363808af7c373e4f70d9d664196867fdbb6 Reviewed-on: https://chromium-review.googlesource.com/c/1350967Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#611632}
-
A Olsen authored
Like other recent CLs with the same author, this CL removes calls to CrosSettings->Set, since the write-path in CrosSettings makes it more complicated than it needs to be - writing to CrosSettings should use an OwnerSettingsService. See http://crbug.com/433840 Unfortunately OwnerSettingsService does not support kStubCrosSettings - so when this switch is true, CrosSettings must be used instead. So client code had to have this pattern: 1. Create OwnerSettingsService 2. if OwnerSettingsService works, then use it to write the setting 3. Otherwise, use CrosSettings->Set to write the setting (where OwnerSettingsSerrvice reports that it cannot write anything kStubCrosSettings switch has been set) However, this is prone to security errors, since OwnerSettingsService is profile-aware, but CrosSettings is not, so if OwnerSettingsService fails to write due to lack of permissions, the fallback to CrosSettings may succeed in spite of this. See document linked at http://crbug.com/433840#c40 This CL makes the OwnerSettingsService work even when kStubCrosSettings switch is set, by switching in a FakeOwnerSettingsService. (This class now has to be in the prod BUILD rule, not the tests, just like StubCrosSettingsProvider and for the same reason). This helps with http://crbug.com/433840 in general and should fix http://crbug.com/433840#c40 Bug: 433840 Change-Id: Ia5e2ea831ffb775aadfb6ad0fc4c36fa6749a07f Reviewed-on: https://chromium-review.googlesource.com/c/1329973Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611631}
-
Alexandr Ilin authored
To perform the permissions check on NaCl, we mmap() a shared memory region as writable and check the return value to know if map failed. It's expected that the call would fail if the region has read-only permissions. Unfortunately, NaCl doesn't handle failure cases gracefully and crashes instead of returning error value [1], [2]. This means, that an attempt to check permissions on a read-only shared memory region always leads to a crash. This CL removes the check altogether to allow the NaCl processes to use read-only shared memory. [1] Posix: https://cs.chromium.org/chromium/src/native_client/src/trusted/service_runtime/sys_memory.c?rcl=f701a90597fc85979319447c0cd44c3b52201c78&l=868 [2] Win: https://cs.chromium.org/chromium/src/native_client/src/shared/imc/win/nacl_shm.cc?rcl=f701a90597fc85979319447c0cd44c3b52201c78&l=112 Bug: 901646 Change-Id: I1f0cee4f7edae0390701320f5061470d62240186 Reviewed-on: https://chromium-review.googlesource.com/c/1352312Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611630}
-
Sami Kyostila authored
This patch renames the metric names for the "two posting threads" variants in sequence_manager_perftest. This ensures they don't conflict with the ones from the one posting thread variants. Bug: 891670 Change-Id: I79ad75d6a0cf6a84fb376108ee92a822ffcc290c Reviewed-on: https://chromium-review.googlesource.com/c/1352261Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#611629}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Change-Id: I6e3be1211140e28f38f8a10e1e7697c4bebf7737 Reviewed-on: https://chromium-review.googlesource.com/c/1352351Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#611628}
-
Vadym Doroshenko authored
We need submission indicator for metrics and for uploads. This CL implements handling it in new Password Manager architecture: 1.Setting it in the renderer process in FormData 2.Passing it over MOJO to the browser process 3.Setting it in FormParser to resulting PasswordForm. Bug: 831123 Change-Id: Ia1fe6e29f031706c91073d6209ae9d841c348929 Reviewed-on: https://chromium-review.googlesource.com/c/1350968Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#611627}
-
David Jean authored
Bug: 905654,905656 Change-Id: I331e96047e3c88e812247e7dab6a2181894f760b Reviewed-on: https://chromium-review.googlesource.com/c/1341517 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#611626}
-
Christian Dullweber authored
Some requests, e.g. requests for service worker updates, are not associated with a WebContents. In these cases Clear-Site-Data returns early and doesn't mark its task as finished, which leads to hanging requests. This CL fixes the hanging requests but does not actually perform the site data deletion. That will be fixed in a followup CL. Bug: 898465 Change-Id: I99bbf4339f7b123d4a46552e9f117d4d95b7ec67 Reviewed-on: https://chromium-review.googlesource.com/c/1346468 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Remove this method from both BrowserAccessibilityDelegate and from RenderWidgetHostViewBase. This method has only one caller, -[BrowserAccessibilityCocoa pointInScreen], which can implement the functionality using the existing AccessibilityGetViewBounds method. While in the neighborhood, convert pointInScreen to rectInScreen, because - that's what all of the callers but one want - there already exist helper functions for that method - it maintains the rule that "gfx::* structures are in gfx coordinates while NS* structures are in NS coordinates" Bug: 900846 Change-Id: Idd62dc256e5d05e946f9a47fa61b8479fbc8be56 Reviewed-on: https://chromium-review.googlesource.com/c/1351580 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#611624}
-
Kamila authored
This cl enables adding cookie site exceptions. The "+ ADD SITE EXCEPTION" is added in the Cookies Category. Bug: 468586 Change-Id: I4c78f5960b4dd92abe7e20f15f5bbaf287f33684 Reviewed-on: https://chromium-review.googlesource.com/c/1299088Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#611623}
-
Mario Sanchez Prada authored
Additionally, change the signature of the method to return a bool so that we can report failure (i.g. hasn't got a primary account) or success and provide new unit tests to check the effect of passing different values of PrimaryAccountMutator::ClearAccountsAction. Bug: 906056 Change-Id: I3c77e05334f8a5d7e12e7788b36d7a2895b905b1 Reviewed-on: https://chromium-review.googlesource.com/c/1348451 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#611622}
-
Vaclav Brozek authored
The bug was fixed, the directives are no longer needed. Bug: 821377 Change-Id: Ieb92e60118dc5bc519154db60957b06319471a5f Reviewed-on: https://chromium-review.googlesource.com/c/1352359Reviewed-by:
-
Mohamed Amir Yosef authored
This is necessary for full-blown USS. Bug: 902349 Change-Id: I1de4a3ac610151feb236c2f1696ba22b9f047568 Reviewed-on: https://chromium-review.googlesource.com/c/1336129 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Maggie Chen authored
When decideing whether a YUV format should be used for swapchain creation, check the current protected video type instead of the one from the previous swap chain creation. Bug: 903552 Change-Id: I028b32dcbcd66763ac8f4220f79fc6674f28bcdf Reviewed-on: https://chromium-review.googlesource.com/c/1352431 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611619}
-
Fredrik Söderquist authored
Since LayoutSVGShape::NodeAtPointInternal is now only called from LayoutSVGShape::NodeAtPoint, we can make it private. Rename it to something more helper-like - HitTestShape. Move the check of 'visibility' to LayoutSVGShape::NodeAtPoint from HitTestShape, to better match other similar methods. Change-Id: If251b8b9258b754bfc94044739d6a8c41f1b04e7 Reviewed-on: https://chromium-review.googlesource.com/c/1352253Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#611618}
-
Thomas Tangl authored
The UI implementation of the consent bump on Desktop is removed. The backend code and the consent bump flag will be removed in a follow-up CL. Bug: 906026 Change-Id: Ib10b0aaa692f5417c1ba1b1f7219d6e6e89457fc Reviewed-on: https://chromium-review.googlesource.com/c/1349691 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Greg Thompson authored
test_chrome_with_chromedriver.py sometimes fails to delete the user data dir because lingering chrome.exe processes (e.g., the crashpad handler) are still working in it. This change causes the test to wait for all Chrome procs to exit before searching for crash reports and cleaning up. BUG=907979 Change-Id: I6500973a906a7b71b36d44aae4c1ca50d42f2001 Reviewed-on: https://chromium-review.googlesource.com/c/1352177 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#611616}
-
Thomas Tangl authored
A test is added to DiceTurnOnSyncHelperTest to check whether DiceTurnOnSyncHelper enables all Google services tied to unified consent. The implementation uses the ChromeUnifiedConsentServiceClient instead of FakeUnifiedConsentServiceClient. Bug: 908111 Change-Id: Ib86721eb69e9bb6e213c610cd70451f515284765 Reviewed-on: https://chromium-review.googlesource.com/c/1350176 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
This change splits the server payload into a global and a script payload. The global payload is meant to contain the memory, the script payload the script execution state. Global payloads are forwarded from GetNextActions RPC to RPC, regardless of which script these actions are for. Server payloads are forwarded from GetNextActions RPC to RPC, for a given script. With this new definition, memory can be shared between scripts, even in the case where script execution is interleaved, like when running interrupts. Before this change, interrupts could not make changes to the memory that would be visible to the main script. With this change, and upcoming changes on the server to support global payloads, interrupts and main scripts share the memory. This change also make sure that the payloads are overwritten by each requests, whether the payloads are set or not. This is going to be useful while the servers transition to the new type of payloads. This change preserves the current behavior of forwarding script payload for the last main script response to the next script initial request, so memory sharing works as it does now until the server is modified. As a result, this change should have no effect until the server is modified. Bug: 806868 Change-Id: I953dfa4cdc898093946948fe9990d01c0551dcb2 Reviewed-on: https://chromium-review.googlesource.com/c/1350632Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#611614}
-
Arthur Sonzogni authored
Creating a mojo data pipe can fail due to insufficient resources. This CL handles this case. Bug: 905779 Change-Id: Iffd9e768689cce9e8ec51f307388ec8e63c7d9b2 Reviewed-on: https://chromium-review.googlesource.com/c/1352309Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611613}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 380c427f. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ia249916817c711e6675f3763126c252f59aa1042 Reviewed-on: https://chromium-review.googlesource.com/c/1352977 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611612}
-
Yoshifumi Inoue authored
This patch makes |Element#innerText| to utilize |NGInlineNode:: GetOffsetMapping()| to collect characters from |Text| node using |NGOffsetMapping| for both legacy layout tree and LayoutNG. In this way, |Element#innerText| is no longer needed to handling collapsed white spaces, this patch also gets rid of code related to collapsing white space. The |NGOffsetMapping::GetMappingUnitsForNode()| is introduced for calculating starting offset of remaining part of ::first-letter. This patch also changes |ElementInnerTextTest| to run on both legacy and LayoutNG layout tree for helping LayoutNG release. Bug: 854889, 873957 Change-Id: Ifc8dd54a426dc6b4962b01d59bc70359fbb7d6e5 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1350443 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#611611}
-
Adam Rice authored
At the V8 Extras implementation of WritableStream serialization, as well as the C++ wrappers. No user-visible behaviour changes. BUG=894838 Change-Id: Iae828b0f5b67508ab1b9ea7099a24635968888c4 Reviewed-on: https://chromium-review.googlesource.com/c/1352114Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#611610}
-
Marc Treib authored
It has been replaced by SyncUserSettings::SetSyncRequested(true). Note that *Profile*SyncService::RequestStart still exists for now (it's used by SyncUserSettings). This will be changed in a later CL. Bug: 884159 Change-Id: Ie96e6a999ae6060fd3bbe444e4471ba9327edef8 Reviewed-on: https://chromium-review.googlesource.com/c/1350907Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#611609}
-
Sergio Villar Senin authored
It was using the SigninManager API to the set authenticated (primary) account. It was also using an ad-hoc TestingProfile. From now on the profile is created using IdentityTestEnvironmentProfileAdaptor and the IdentityTestEnvironment owned by the adaptor is used to set the primary account. Bug: 903865 Change-Id: I1313f11fbbe1121afb755c1723c8a822747dea6c Reviewed-on: https://chromium-review.googlesource.com/c/1349697Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#611608}
-
Mohamed Amir Yosef authored
Change-Id: Ifee51301e6fc6c28246f91807a9e9243ed72d106 Reviewed-on: https://chromium-review.googlesource.com/c/1352164 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
edchin authored
Change-Id: I8f41c0cf8947aa771ceb1bf8ffc27091f72922be Reviewed-on: https://chromium-review.googlesource.com/c/1341247 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611606}
-
Gauthier Ambard authored
This adds myself as an owner of settings. As I already did a lot of refactoring in the folder, I think it makes sense. Most of the refactoring CL can be tracked in crbug.com/894791. Bug: none Change-Id: I7426aacab7a055f75433246ec5a79b04be636da7 Reviewed-on: https://chromium-review.googlesource.com/c/1350893Reviewed-by:
-
