- 28 Apr, 2020 40 commits
-
-
Chris Lu authored
This creates the placeholder request config to be used to hold a place in the Overlay queue. This will be useful for when Translate waits to finish to show the show original banner. Bug: 1071914 Change-Id: I77801c572b8aa83c7bbaf43ae934ce75667732c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163850 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#763479}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9bb56813821..06cce0bd8dab Created with: gclient setdep -r src-internal@06cce0bd8dab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com,hendrich@google.com,tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1065456,chromium:1074070 Tbr: yukishiino@google.com,hendrich@google.com,tommycli@google.com Change-Id: Ia07e2bd13b97653054b3344f66bc38b18ad1ce32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170788Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763478}
-
David Black authored
This CL also creates: - chromeos::assistant::mojom::AssistantEntryPoint::kLauncherChip - chromeos::assistant::mojom::AssistantQuerySource::kLauncherChip Bug: b:154153233 Change-Id: Iea6255b794588ff98ff66f75ada8cc7316087901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160107 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#763477}
-
Ben Joyce authored
Needs this CL to land first: https://chromium-review.googlesource.com/c/chromium/src/+/2166636 Bug: 1069613 Change-Id: I20d705ff00ed038f506315b8a22728fd4feec857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169847Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#763476}
-
Mason Freed authored
Per the explainer [1] and associated spec PRs, getInnerHTML() should use an options bag parameter, rather than just a boolean for the includeShadowRoots flag. This CL implements that change. [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#serialization Bug: 1042130 Change-Id: I678db433bc9555b6cf441d93f245cb1485c16e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166138 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#763475}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 35 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-10-25. TBR=chromium-metrics-reviews@google.com Change-Id: I24021565e71a8416ac6b488bd0a40eedb0b46480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170303Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#763474}
-
haozhe authored
This patch uses owning_element of animations to sorting animations in getAnimations(), aligning the implementation with the spec: https://drafts.csswg.org/css-transitions-2/#animation-composite-order Bug: 1070460 Change-Id: I1bc627ffecc8450e1f2ad1cff0fefc12ac3971da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139359Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#763473}
-
Rohit Rao authored
Compiles the SamplingHeapProfiler, with associated tests, and adds iOS to the list of platforms which use the allocator shim. BUG=1075702 Change-Id: I4e20027633f0e4ca9b49c37b110f6548ae8ace46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168810 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#763472}
-
Yves Arrouye authored
Use the term "Forced Re-Enrollment" for messages about FRE. Keep the term "Initial Enrollment Check" for initial enrollment. Add a log message when waiting for clock sync. Add a verbose log message when we have decided that an Initial Enrollment Check is needed. Add more verbose logging for conditions that make us skip that check. Bug: None Test: N/A Change-Id: I5e9b661e9a41da9e053afeed460d9c2b13ca77b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165863 Auto-Submit: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#763471}
-
Alexander Timin authored
As child FrameTreeNodes are now owned by RenderFrameHost, make parent() return RenderFrameHostImpl* because the parent RenderFrameHost cannot change for the lifetime of the FrameTreeNode. This makes our handling of non-current (pending deletion, bfcache) frames more robust by making harder to refer to a frame which is not your parent. R=arthursonzogni@chromium.org,creis@chromium.org,alexmos@chromium.org CC=,bfcache-bugs@chromium.org BUG=1073269 Change-Id: Ic2661b69ddd09e1cc5d9095caf7f158fa31f4189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160970 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#763470}
-
Vaclav Brozek authored
DoCanonicalizeFileSystemURL transforms a filesystem URL and also checks that the path of the inner URL (i.e., the path of the URL following the filesystem: prefix) has length at least 2. At the same time, canonicalizing the inner path can decrease the URL length, e.g., "/." becomes "/". So if the path length is checked on the non-canonicalized URL, the sanity check passes, whereas on the canonicalized it does not. The former situation is what happens before this patch. As a result, canonicalizing the URL twice (e.g., once when constructing and the second time when applying even empty replacements) results in a valid URL the first time and an invalid one the second time. This is a bug, because canonicalizing a canonicalized URL should not change its properties. Therefore this CL ensures that the sanity check is done on the already canonicalized path. This fixes the above described bug. Some URLs which used to be considered as valid (only) on the first canonicalization, are now considered invalid every time. Example: "filesystem:http://e:/.". Also, this CL does a minor clean-up in DoCanonicalizeFileSystemURL: The function cached a const version of the parsed.inner_parsed() pointer, but then sometimes used the cached const version, and sometimes the original non-const. The CL turns all of the latter cases into the former one. Bug: 1075515 Change-Id: I48ae1efc6de9207ea29ae774180a9e2662def9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169891Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#763469}
-
Mustafa Emre Acer authored
We have an allowlist for URLs that trigger lookalike heuristics, but we don't have the same for URLs that the lookalikes match to. This can be useful when many lookalikes match the same domain and we know that the lookalikes are not spoofs of the matched domain. In that case, allowlisting the matched domain is simpler than allowlisting multiple lookalikes. This new target allowlist contains regexes as opposed to SafeBrowsing style patterns. This is because it only makes sense to include hostnames as allowed targets and not full URLs. Bug: 1075739 Change-Id: I61b908123eca4df57f695f380e905715750a5e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166504 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#763468}
-
Andrew Grieve authored
Prevernts spamming bot logs when java_deobfuscate.py is broken Bug: 1075998 Change-Id: I0d56ffde20e58c065b6ff575673f656a4396f745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169764 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#763467}
-
Stephen Roe authored
This will enable BigQuery searches on exit codes to find intermittent errors. Bug: 1063106 Change-Id: I7387869331957f851817a7aa2deabf654ee3a954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162105Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#763466}
-
Tom Anderson authored
x11::Connection::Get() should replace gfx::GetXDisplay(). R=sky CC=msisov,nickdiego BUG=1066670 Change-Id: I5a2020c10f158f98697074fb9fec19c13ff6e644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168927 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#763465}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I054e9ccfcbe6417607237e46a42622194956f1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164513 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#763464}
-
Yi Gu authored
Previously during the shutdown process the compositor timeline may not be detached if it still has animation attached to it. Rather, it should be detached unconditionally. This patch moves the condition check to the call sites to make sure that the timeline cannot be detached if it still has animation attached. Bug: None Change-Id: I0e9b02493ffab9521211a0723557dafa19917f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167517Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#763463}
-
oysteine authored
This reverts commit 9cdc65f2. Reason for revert: crbug.com/1076102 Original change's description: > Make installation of the elevation service optional. > > There are cases where the elevation service may fail to install, for > instance, if security software prevents installation. > > Bug: 1023080 > Change-Id: Ibab20f2ee44395254ef702a460f8fad60836e682 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168825 > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: S. Ganesh <ganesh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#763421} TBR=ganesh@chromium.org,grt@chromium.org Change-Id: I341d30e6449f862d13a0a3be43a2cdfc42451c0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169876Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#763462}
-
Kevin Ellis authored
This patch reduces memory usage by doing an in place deduplication of keyframes. It further reduces memory by compacting keyframes when there are mixed easing functions. A safeguard is added to prevent overriding a property at the same offset when processing keyframes. https://pinpoint-dot-chromeperf.appspot.com/job/109e04b5e20000 Bug: 1073751, 1068639, 1070627 Change-Id: I35ba4e4eb3096bad2ec66757c6ec705cca4e6761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163639 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
BuildTrustedVaultNigoriSpecifics() had its own implementation for each of single_client_nigori_sync_test, nigori_sync_bridge_impl_unittests and fake_server_helper_android (was inlined into other function). This CL factors out the implementation and addresses these duplicates. There is small difference between old implementations: keybag_is_frozen wasn't set in some of them, but this field isn't consumed by modern clients. Bug: 1046663 Change-Id: Ia173ac1f1942b988d972adc3e47c3b3c803a3d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168881 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#763460}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 108 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-10-25. TBR=chromium-metrics-reviews@google.com Change-Id: I03a528e541a4d5863d50bf796a64689ccededb8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170786Reviewed-by:
-
Tom Anderson authored
This CL adds x11::Future::OnResponse() to install a response handler for X11 requests. Previously you could only Sync() to get the response. ui::X11WorkspaceHandler is changed to demo usage of async response handling. Eventually it should be migrated to a higher-level property handler, like we currently have in x11_util.* for Xlib. R=sky CC=msisov,nickdiego BUG=1066670 Change-Id: Ifcab2553008395bcfd9090e6aa1ccc5b4e53ae2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164245 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chrome://inducebrowsercrashforrealzEugene But authored
Start rapidly leaking memory by 10MB blocks if chrome://inducebrowsercrashforrealz?leak&crash=no URL gets loaded, which this causes out of memory termination by the OS. This feature allows to simulate UTEs for testing purpose in projects related to UTEs detection and fixes (like Synthetic crash logs for UTEs and Low Level Profiling). Bug: None Change-Id: I362f74c2e8fb7966fdf026a854dd587263d089cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167009Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#763457}
-
Xinghui Lu authored
Now that the implementation in internal repository is removed, it is safe to remove the interface. Bug: 1070836 Change-Id: I196df7afd48dd051b2f8e053166248eedd24305b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168648Reviewed-by:
-
Kurt Horimoto authored
This tab helper is used to store copies of UnsafeResources that are detected by the URL checks kicked off by the SafeBrowsingTabHelper. It will be populated with UnsafeResources by the UrlCheckerDelegateImpl before calling the SafeBrowsingTabHelper::UrlCheckerClient's completion callback. When the WebClient is preparing the error page for the unsafe navigation, it can pop the UnsafeResource copy and use it to populate the WebUI. For unsafe resources in the main frame, a copy is stored directly in the tab helper, as the associated pending NavigationItem may be deleted due to the navigation cancellation. For unsafe subresources, a copy is stored in the NavigationItem's user data. When the SafeBrowsingTabHelper detects an unsafe subresource, it will kick off a reload of the NavigationItem and use the presence of the unsafe subresource in the stack to cancel the main frame navigation and display the error page. Bug: 1064803 Change-Id: I96c99e0d5ca23443400a493023edb9f13a4fd393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166128Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#763455}
-
Chris Mumford authored
There is no need to log the obsolete SessionStorageDatabase.Commit UMA metrics in a class only used by tests. Bug: 975995 Change-Id: I7b6d23aaf91dcbc4fac22a7b48e7f7ce6f0ae5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169729 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#763454}
-
haozhe authored
The rotate-interpolation.html test occasionally flakes due to timeout. This patch this test as slow test. Link to the test flakiness: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=external/wpt/css/css-transforms/animation/rotate-interpolation.html Bug: 1067562 Change-Id: Ia75b5a1989deda052585b3c73df87bf2b48addbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170412Reviewed-by:
-
Ken Rockot authored
This allows multiple device.mojom.DeviceService connections to the Device Service and changes content::GetDeviceService() to safely maintain independent sequence-local connections. The new behavior corrects an issue where an inadvertent background- thread client could trample the global Device Service instance early in startup, leaving all main-thread clients with a permanently broken connection. Bug: 1041804 Change-Id: I3efcb661c9508e1e0007d00f2f9f963c26220de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168829Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#763452}
-
Lily Chen authored
Improve test coverage: verify that cookies with the default SameSite behavior under SameSite-by-default-cookies can be sent on top-level cross-site POST requests if less than 2 minutes old. Bug: 953306 Change-Id: I642f4df702f0cad62310a4d442f69a293096cab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169574 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#763451}
-
Jérôme Lebel authored
Sign-in UI cannot be dismiss without asynchronous calls. This was previously ignored. The new architecture is more strict, don't allow to ignore callbacks. To prepare the transition to the new architecture, all sign-in UI has to be managed by the SceneController. The SceneController already supports asynchronous dismiss of the sign-in UI. Adding support for to asynchronously dismissing the sign-in UI on top of the settings view. => crrev.com/c/2161007 GoogleServicesCoordinator crrev.com/c/2160911 AccountTableViewController crrev.com/c/2161027 SettingsTableViewController crrev.com/c/2165732 Fixing tests Bug: 971989 Change-Id: I29718d306fd4b35e48eaadb90834cd0626ddb22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161007 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#763450}
-
Alexander Timin authored
Add direct methods for getting storage partition and browser context to RenderFrameHost. This allows more features to be implemented only on top of RenderFrameHost without referencing WebContents, which can lead to the wrong RenderFrameHost being queried. R=alexmos@chromium.org TBR=amistry@chromium.org,reillyg@chromium.org BUG=1061899 Change-Id: Ib000cd0b28b90c92cccdca3e29799542e07a0145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162857Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7676f4ecf3ec..02b91385f58b git log 7676f4ecf3ec..02b91385f58b --date=short --first-parent --format='%ad %ae %s' 2020-04-28 herb@google.com Rename flush -> addOp 2020-04-28 jcgregorio@google.com Turn on Vulkan bots for Galaxy S20. 2020-04-28 brianosman@google.com Compare all fields in SkSL::Layout::operator== 2020-04-28 brianosman@google.com Use constant swizzle syntax in GrDrawVerticesOp 2020-04-28 fmalita@chromium.org [skottie] Brightness and Contrast effect 2020-04-28 mtklein@google.com detect failed matrix update in SkDraw::drawAtlas() 2020-04-28 brianosman@google.com Change Marker IDs to be strings Created with: gclient setdep -r src/third_party/skia@02b91385f58b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1070480 Tbr: ethannicholas@google.com Change-Id: I3e3f5af9ac2e1524cc9180c8d1cc3f8a3e16203f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170304Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763448}
-
Stepan Khapugin authored
The keyboard accessory view is only needed by the omnibox. Bug: 784819 Change-Id: Icbd24bf88c72a4b49233a32c68fe0ad03e30eb8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166268Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763447}
-
edchin authored
iOS 13.4 introduces new APIs for mouse cursor support on iPad. Buttons should react to pointer hover. This CL enables the default hover effect in the user signin screen. Test: iPad only. Enable pointer support flag. Ensure buttons respond to pointer in user signin screen. Bug: 1073961 Change-Id: Ied2f4a4185e5c0346d49059f8c46d6c363e0eda9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168642Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763446}
-
Alex Ilin authored
The webview's cookie jar isn't reset between getAuthToken() calls within a Chrome session. This can lead to sub-optimal experience when the user sees on the consent page the accounts they were previously signed in. This behavior is also problematic if we decide to roll back the new consent flow experiment. After the experiment rollback, the user will see all their Chrome accounts whereas Chrome should display only a primary account. This CL cleans webview's cookies before starting the legacy consent flow. Fixed: 1075929 Change-Id: Ia502ca74d5763c206c680772c43764476b74c5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168879 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#763445}
-
Hesen Zhang authored
- Fix the potential broken when moving the project to components/. Bug: 1074682 Change-Id: I1301e6e45facee1837e718f375bd4feb77ef5556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168242Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#763444}
-
nancy authored
For persistent notifications, get the app_id based on the scope url for the notification. For non-persistent notifications, get app_ids based on the origin url of the notification. TODO: Add web page notifications for WebApps. TODO: Add tests. BUG=1068884 Change-Id: I9e453c2095176e74f9db2da7fb74ae71ea05f67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162504 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#763443}
-
Manas Verma authored
Using a JNI bridge to create an implementation of InternalAuthenticator for Android. Bug: 949269 Change-Id: I9cf9c33ffba04b5814ed9fc6f98f2481b23293d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155531Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#763442}
-
Stepan Khapugin authored
This histogram is occasionally used for iOS omnibox feature analysis. Bug: 1037597 Change-Id: I6803c155e3406aff6bd40c1874143fbc9ae4684d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170626Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763441}
-
Mugdha Lakhani authored
Return a valid TabSpecificContentSettingsDelegate from PageInfoControllerDelegateImpl and add a browsertest to verify the same. Bug: 1052375 Change-Id: I60db31480fbefc46b48851891ffaa0d977c7fdc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170349 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#763440}
-
