- 26 Mar, 2018 40 commits
-
-
Tien-Ren Chen authored
A previous CL https://chromium.googlesource.com/chromium/src/+/0d2f4351ca12d64119d1aed52faf538a852a12c0 embedded the structure to PaintLayer itself, in order to avoid the cost of heap allocation. However that regressed transform animation with lots of layers on a number of Android devices. It is speculated that the increase in PaintLayer size put more pressure on L2 cache. This CL changes the structure back to external again. Note that this is not equivalent to reverting the previous CL. Before the regressed CL, the structure is reallocated everytime we updated it. With this CL applied, it will become a lazy rare data that will be allocated on first use, but then reused throughout PaintLayer's lifetime. BUG=821773 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia65b8dba8c4d07eed22aed9903a57472ad06960f Reviewed-on: https://chromium-review.googlesource.com/974282Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545882}
-
Qiang Xu authored
changes: Decouples `show notification` from OnAccessibilityStatusChanged. Callers decide to whether to show notification by explicitly notifying observer themselves. Bug: none Test: tested on emulator, everything looks fine Change-Id: If5cfbeaabea2583f7fe558cf098b69446a63bb14 Reviewed-on: https://chromium-review.googlesource.com/976091 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#545881}
-
Vladimir Levin authored
Before this patch: - We issue a CaptureDump callback from the main frame that has finished a test. If a secondary renderer issues a test finished, this routes via a browser and goes back to the main frame anyway. - We issue several IPCs to the browser for each type of dump requested. - After everything is done, we issue a test done IPC to the browser. With this patch: - We capture local dumps (temporarily*) - We request that a browser initiates a CaptureDump via IPC. - We get a mojo call to capture the dump with an output struct containing all the relevant fields, which the renderer populates from local dumps. - When it finishes populating everything, it issues a callback with that struct. - The browser then records all of the results from the struct and finishes. The new approach seems to be a bit better in that we can move more logic to the browser part and make the renderer part more synchronous. For example, if the browser needs to initiate a layout dump, we can just do that from the browser instead of requiring that the renderer sends an IPC to the browser with that request. Furthermore, because the end goal of this is to have OOPIF pixel dumps, we need those to be initiated from the browser at some point. This also aligns with the pattern where the browser is the part that initiates a capture dump. * - We would like to capture as little as possible locally and instead move things that capture things by asking the browser to the browser directly. R=lukasza@chromium.org, mkwst@chromium.org Bug: 667551 Change-Id: I07d2b16da687b679f6b3020732706e6bd7a77cd4 Reviewed-on: https://chromium-review.googlesource.com/972578 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#545880}
-
Eric Karl authored
We drop GL contexts on low-end devices when we go to the background. This is currently initiated by the GPU process, which kills all GPU channels, eventually causing context-loss in the various clients. While the current approach works, it makes it difficult to avoid rendering artifacts on app resume. As context-loss is lazily identified, it's possible for the browser and renderer to be notified at very different times. This can lead to races where the browser will attempt to draw with invalid renderer resources. To avoid these issues, this CL causes the context-dropping to be triggered from the browser itself. This allows the browser to drop renderer resources at the same time, greatly reducing (but unfortunately not eliminating) the possibility of a race. If we still see these issues with any frequency, further follow-up work, leveraging Surface Synchronization, will likely be able to fully eliminate these cases. Bug: 792120 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1c0f2c6000fc9c1f4171952b09484101a220654c Reviewed-on: https://chromium-review.googlesource.com/959605Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#545879}
-
chaopeng authored
This issue is caused by Direct Manipulation pan transform already scale for DPI, Chromium also scale the scroll event for DPI, so it scale twice. In this patch, we read the device scale factor at the beginning (DM_POINTERHITTEST) of the sequence then divide transform by device scale factor. Bug: 779372 Change-Id: I849d37704fbc17b9abe07d1f9e6e5e2465fbffff Reviewed-on: https://chromium-review.googlesource.com/976951Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545878}
-
Conley Owens authored
This change adds a string `mime_type` to the list of fields in SubresourceLoadInfo. Notably, this is important for recording page load metrics when the Network Service is enabled. BUG=816684 Change-Id: Ie95bd46074f2a0f915eb8378800afa0f5ed46ecd Reviewed-on: https://chromium-review.googlesource.com/963312Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#545877}
-
Jiaquan He authored
Boolean flags |is_tablet_mode_| and |search_engine_is_google_| are used by SearchBoxModel, so let's move them there. This commit also notifies SearchBoxView to change when the search engine changes. Bug: 825301 Bug: 733662 Change-Id: I7f32a96ceb274d2f3740191b23a07a67c2a08c79 Reviewed-on: https://chromium-review.googlesource.com/979711Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#545876}
-
Conley Owens authored
This change does 2 things to disable the Physical Web: 1. It makes the feature disabled by default. 2. It removes the relevant entry from about:flags. BUG=internal b/73944725, b/74450333 Change-Id: I126d88c72b97a7b00490453bef78cf3d230e5bfb Reviewed-on: https://chromium-review.googlesource.com/981108Reviewed-by:
Michal Mocny <mmocny@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#545875}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7dbc81628d41ecaf5c1a162f4b564245aa6aeafe Reviewed-on: https://chromium-review.googlesource.com/981412Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#545874}
-
Trent Apted authored
WidgetDelegates must outlive their Widget. Crashes suggest situations where they may not, but can't pinpoint the actual client code. The crash is instead attributed to a UAF on the widget delegate either in a layout call (during an animation), or when Widget::OnNativeWidgetDestroyed() tries to delete the delegate (again). This CL adds a CHECK() in ~WidgetDelegate which should track down the misbehaving code. Bug: 825091, 814821, 808318 Change-Id: I9490ff1682ee236436edf075f7c237ccf910c44c Reviewed-on: https://chromium-review.googlesource.com/977244Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#545873}
-
Xunran Ding authored
As GURL is still used in content/public/browser/appcache_service.h, and there are uses outside content/browser that needs updating, Convertion is still needed for AppCacheInfoCollection::infos_by_origin. Convertion is also needed for quota api(storage/browser/quota). Bug: 598424 Change-Id: I51e8f308a5c12ed61168f68c0f94f1a1bfb8f48a Reviewed-on: https://chromium-review.googlesource.com/977846Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#545872}
-
Dominic Battré authored
This reverts commit a5dfe3d8. Reason for revert: Fails on Mac builders (instead of crashing). Original change's description: > Update expectations for video-rotation.html to Failure Pass > > Because propriety codecs are not supported on some test > configurations, video-rotation.html is updated to be > Failure Pass instead of just Skipped, as it gives us better > code coverage. > > Bug: 750313 > Change-Id: Ia26c4cc0fdab21adb308b228a95c234577060af8 > Reviewed-on: https://chromium-review.googlesource.com/958262 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545859} TBR=wez@chromium.org,ccameron@chromium.org,mlamouri@chromium.org,liberato@chromium.org,lethalantidote@chromium.org Change-Id: I2dd1a6ee472a215c7139510c0ec08f0aef1bd4fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 750313 Reviewed-on: https://chromium-review.googlesource.com/980755Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#545871}
-
Daniel Bratell authored
Half the code used the SDK_VERSION_* constants when checking Android version, half the code used hard coded numbers 19, 21, 22, .... This changes the code to use SDK_VERSION_ everywhere. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icb4e3183f0490b00d16039681548ccf469e9d236 Reviewed-on: https://chromium-review.googlesource.com/975841 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#545870}
-
Eric Holk authored
In msan builds, V8 generates ARM code and runs it in a simulator. This means we cannot support trap handlers in that configuration. TBR=jam@chromium.org Bug: chromium:824645 Change-Id: If0971148262297d5688efd559a1526295a869e07 Reviewed-on: https://chromium-review.googlesource.com/979033Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#545869}
-
Theresa authored
Replace sending motion events to perform a long click with a direct call to View#performLongClick. Locally this fixes the weird blue highlighting after sending motion events. BUG=813589 Change-Id: I36ebfa69eedbd169bab2a1625963e14cf822b99b Reviewed-on: https://chromium-review.googlesource.com/976051Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#545868}
-
Rune Lillesveen authored
To prepare for immutable ComputedStyle objects. Bug: 813068 Change-Id: Id5b4a57940712adfc9d353634856bc32e4ef2a0d Reviewed-on: https://chromium-review.googlesource.com/979810Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#545867}
-
Andrew Grieve authored
* Fixes recently introduced -keep rule for @MainDex on methods: * <methods> works, whereas * sometimes doesn't * Teach jni_generator.py about @MainDex on methods * Removes @MainDex from browser-process-only AnimationFrameTimeHistogram * Removes @MainDex from browser-process-only MediaServerCrashListener * Adds a missing @MainDex needed to play <video> (SurfaceTexturePlatformWrapper, MediaCodecBridgeBuilder) * Outputs a new artifact from main_dex_list.py for seeing which classes are kept by ProGuard vs MainDexListBuilder * Adds assertions for a few classes that should not appear in the main dex. With this change, main dex method counts: chrome_public_apk=7623 chrome_apk=11333 monochrome_apk=22086 NOTRY=true # ios-simulator is unhappy. Bug: 820570 Change-Id: I4ea925ed985a0daa5a4db54a9cf72744fa92aeca Reviewed-on: https://chromium-review.googlesource.com/972641 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545866}
-
Francois Doray authored
For correctness, set the TabStripModel of a TabLifeycleUnit to nullptr when it is detached. Bug: 775644 Change-Id: Icf7ad8d1be8c130ae934f74f2855eab40d21207d Reviewed-on: https://chromium-review.googlesource.com/980777 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#545865}
-
Yash Malik authored
In this CL, we remove exit_prompt* classes and use prompt* instead. Bug: 818182 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia75046518d06b1953db85fa59c240f58dcbb8350 Reviewed-on: https://chromium-review.googlesource.com/978618 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#545864}
-
Marijn Kruisselbrink authored
Rather than just documenting that the class should be bound to a mojo pipe on a different thread than the main/worker threads, explicitly make the API such that it creates its own task runner to bind on. That same task runner is then also passed on to BlobBytesStreamer, to replace its usage of SequencedTaskRunnerHandle::Get(). Bug: 786332 Change-Id: Ic2e38a53514bc612ffaf579c3eb1bc4a88b29efe Reviewed-on: https://chromium-review.googlesource.com/976098Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#545863}
-
Tarun Bansal authored
Bug: 825880 Change-Id: I7c4e8abee53788e4c0f5fcd7857dde087b5ec6e3 TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/980919Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#545862}
-
Sidney San Martín authored
RTL was missing from this particular part of MD downloads. This change: 1. Adds RTL support. 2. Changes the look slightly overall to match dragging on macOS: instead of a representation of the file appearing under the mouse pointer, dragging creates a copy of the icon and text seen in the shelf, which start off in their original spots. (I tried this while I was working on RTL). Change-Id: I766d61227d04541f1beecf93adf87464da5a020b Bug: 825849 Reviewed-on: https://chromium-review.googlesource.com/979195Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545861}
-
Tom Anderson authored
CL [1] disabled sandbox_ipc_fuzzer on Linux to fix a build error on a certain configuration. Though the code is Windows-based, the fuzzer runs on Linux. Reenable the target on Linux and add a message not to disable it again. [1] https://chromium.googlesource.com/chromium/src/+/1dd06808a27b6903d2dc8971a40abc465c5a346e%5E%21/#F10 BUG=825851 TBR=jorgelo CC=inferno,wfh Change-Id: Ibb2b3bdd0bf25f80ec7bc2cd5cab3a8729b07cf7 Reviewed-on: https://chromium-review.googlesource.com/980917 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#545860}
-
CJ DiMeglio authored
Because propriety codecs are not supported on some test configurations, video-rotation.html is updated to be Failure Pass instead of just Skipped, as it gives us better code coverage. Bug: 750313 Change-Id: Ia26c4cc0fdab21adb308b228a95c234577060af8 Reviewed-on: https://chromium-review.googlesource.com/958262Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#545859}
-
Geoff Lang authored
The non-const parameter was causing issues with ubsan because ANGLE is compiled with lasted typedefs. BUG=820848 TBR=piman@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I366e101fb8c42edec1d381e27cb55a51283f4e09 Reviewed-on: https://chromium-review.googlesource.com/969083Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#545858}
-
Andrew Grieve authored
Shrinks monochrome_apk dex by 53kb uncompressed, 17kb compressed. Shrinks method_count by 1400. Bug: 620323 Change-Id: Ie9f7c37a20895ecd1d3f1f17357a663252a1be36 Reviewed-on: https://chromium-review.googlesource.com/981052Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#545857}
-
Emily Hanley authored
TBR=ashleymarie@chromium.org NOTRY=true Bug: 825224 Change-Id: Ifd87513095452f298ac9bf5ba5e44dd1f59c94df Reviewed-on: https://chromium-review.googlesource.com/981128Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#545856}
-
Filip Gorski authored
Change-Id: I19d2d75acb589d0e1af6562cdd84ab3c75abd0bc Reviewed-on: https://chromium-review.googlesource.com/979772Reviewed-by:
Patrick Noland <pnoland@google.com> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#545855}
-
Fredrik Söderquist authored
This DCHECK was made obsolete by 9b88406d, since it stopped using the "pending resource" flag for <use>. Bug: 825460 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie1202097eb2172ef9ed3866e3a6575fbe4aa09db Reviewed-on: https://chromium-review.googlesource.com/980252Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#545854}
-
Boris Sazonov authored
This CL migrates FirstRun and sign-in activities to support library fragments (android.support.v4.app.Fragment instead of android.app.Fragment). Rationale for this migration: 1. Framework version of fragments are getting deprecated in Android P. 2. Enables use of getChildFragmentManager, getParentFragment, etc., on all API versions. Bug: 825789 Change-Id: I2079f211b03e4df1d169c1568d764763bb677bd1 Reviewed-on: https://chromium-review.googlesource.com/980335Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#545853}
-
bsheedy authored
Fixes two VR test failures: 1. MockVrDaydreamApi not working properly. 2. DeepLinkedApp tests getting stuck in relaunch loops due to the relaunch logic not working properly with the DON flow skipped. Bug: 825248 Change-Id: Iee43fc55f8160bb4fdbbc4f60de8b67f64a3d8e9 Reviewed-on: https://chromium-review.googlesource.com/978887 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#545852}
-
Albert Chaulk authored
We need a ProcessManager to exist in order to load background pages but like everything extension-related it is lazy created Bug: b/73768170 Test: load extension at start verify background script prints occur Change-Id: I63ccc58ee819ec0435646c296ceb0d7678c433cc Reviewed-on: https://chromium-review.googlesource.com/959343Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#545851}
-
Reilly Grant authored
This test is failing consistently on Android in addition to having been flaky on Linux when the Network Service flag is enabled: * ResourceDispatcherHostBrowserTest.PageTransitionClientRedirect Bug: 818445 Change-Id: Icf555652a3c78126e28753bfc2e7b8878fe47460 Tbr: jam@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/981123Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#545850}
-
Toni Barzic authored
Bug: None Change-Id: I4bb6b63d8b47c281d644f24702100a23b33c029f Reviewed-on: https://chromium-review.googlesource.com/979032 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#545849}
-
Balazs Engedy authored
Otherwise, EXPECT_CALL macros tend to get ugly quickly. Bug: None Change-Id: I24584a7ea0d4ec324b84c7c55cf313a4407da419 Reviewed-on: https://chromium-review.googlesource.com/980533 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#545848}
-
Fady Samuel authored
Prior to this CL, both ui::Compositor and DelegatedFrameHost used the same ParentLocalSurfaceIdAllocator to allocate LocalSurfaceIds. This is technically not incorrect, but it's super confusing when debugging. Each embedding should have a different embed_token (previously called nonce), and this violated this (untested) assumption. This CL fixes that. This CL also drops the class member variables that store the LocalSurfaceId for ui::Compositor and DelegatedFrameHost because the ParentLocalSurfaceIdAllocator instead tracks the last ID. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I0c4f1810045272b52b037bd263c5dd906c983f8f Reviewed-on: https://chromium-review.googlesource.com/976743 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#545847}
-
AJITH KUMAR V authored
While doing stylus button text selection, focus is mainly on the stylus button press and text selection is anchored by the stylus button. In that case touch handle has less significance (same with touch long press drag selection). So we can hide touch handles during stylus button selection and can show after stylus button selection is concluded. Bug: 771667 Change-Id: I9dccaabfd5fafccb68c1f0bce23bba36cea9061f Reviewed-on: https://chromium-review.googlesource.com/685054Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com> Cr-Commit-Position: refs/heads/master@{#545846}
-
Ian Kilpatrick authored
This allows a LayoutChild to have layout performed on it, which will return a Fragment - with the correct inline and block sizes. These Fragments cannot be positioned yet, (next patch). The LayoutChild will be laid out with an available inline/block size of zero by default, and optionally can accept a fixed-inline/block size, which it must respect. Bug: 726125 Change-Id: Ie4386b8f6cd6ccec3f9e52ff332322101058836d Reviewed-on: https://chromium-review.googlesource.com/962870 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#545845}
-
Bo Liu authored
This method just returns a member since r544824. Bug: 813232 Change-Id: I7e8ee5e33b559f0fca0c5ee3f2cb7dc9837458a0 Reviewed-on: https://chromium-review.googlesource.com/980825Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#545844}
-
Mohamed Heikal authored
Adds Async TraceEvents to track the splashscreen and how long it is visible. Bug: 822816 Change-Id: I9a75001830d36cb7f0a35d0cb4d04511242d74fd Reviewed-on: https://chromium-review.googlesource.com/978453Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#545843}
-