- 22 Aug, 2019 40 commits
-
-
Joe Mason authored
R=proberge Bug: 969139 Change-Id: I14af6d59541cc5ca2e7ad02f5c93ca3a328c2c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762315Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#689649}
-
Mei Liang authored
This is a reland of 28b4dfc2 Original change's description: > [Dark] Update style for incognito grid tab switcher > > This CL modifies incognito GTS to use the same color palette as Dark > mode. In addition, this CLs add darker theme support for all tab group > related UIs in incognito, except for TabSelectionEditor. > > Change-Id: Ic1517867cf90ac0550fd1bf15e91cd19c4231eab > Bug: 960891 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745619 > Commit-Queue: Mei Liang <meiliang@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689339} Bug: 960891,996720 Change-Id: I12edea2877b44f6061fcc16e02f608758a172ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765829Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689648}
-
Tao Bai authored
From the bug report, RenderFrameHost might not available in some corner cases. Bug: 995121 Change-Id: I1258518ef171a03ee504a68c711f91f5979a5c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762830 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689647}
-
Karolina Soltys authored
Bug: 968047 Change-Id: Idaf9c72f13419ac29804a91e54be86d71ff9b7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751251 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#689646}
-
Nick Harper authored
This is a reland of 5572b090 with a fix to net_perftests. Bug: 980654 Change-Id: I18a5b339dbe6166ff42c0aec9f27b99d5a2139dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762821 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689645}
-
Daksh Idnani authored
Suppressed Pixel_OffscreenCanvasWebglResizeOnWorker on NVIDIA GPUs on Mac. Bug: 996824 Change-Id: I295c36d7f98b5d5fcc72f3723244ccc0dddc6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764562Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689644}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa6228187eab..3336a66fbd9d Created with: gclient setdep -r src-internal@3336a66fbd9d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:996754 Change-Id: Iaec3fd27b1bc71bf97a129990871d90cd6d0de6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764475Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689643}
-
David Black authored
ThreadPool argument should be supplied for creating a sequenced task runner with default traits. Bug: b:139822449 Change-Id: I9f9fd99050521c140a7472bb1be95b5e96f39a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764256 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#689642}
-
Donn Denman authored
Extends the expiration of various flags that would otherwise expire soon, for Contextual Search. Details and justification are in the bug. BUG=996814 Change-Id: I569cc2b368f785c97a896bf6113565d80c1a5427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762766 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
-
Eric Roman authored
Connecting to 0.0.0.0 varies between platforms. Tests that intend to have connections fail should not use it, as it is interpreted as the ANY address on Linux/Mac and connections to it may succeed leading to test flakiness. 0.0.0.1 is a more reliable address for testing. It is in the same reserved IPv4 block, but does not have special meaning like 0.0.0.0. 0.0.0.0 has a consistent meaning when listening, so fine to use for server sockets. Change-Id: If484cb42023b2d85e2517f959fb625accaf87161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764941Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689640}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 40be6fa4. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." c9bcba93 "Create Web Platform Tests for Scroll to text" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I491f9a4f795c34955bce7342ea5d549177404f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765573Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689639}
-
Alex Cooper authored
This change tailors the content of the WebXR consent flow to convey appropriate privacy concerns based on features that have been requested and information ineherently exposed due to the way the devices work. Bug: 987029,985026 Change-Id: I741c99d7cb39ef3fd1a59dedf0b1e58536d87f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762820 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#689638}
-
Andy Paicu authored
This CL does the following: Adds the ability to display a permission request via a notification on android. Uses this ability to show notification permission requests (gated by feature flag). This will enable experimenting with this particular UI, and represents the reparo "Mobile Experimental Candidate 3": go/reparo-candidates TBR=raymes@chromium.org Bug: 986737 Change-Id: I32f1567814b5938edf7211d7fd1d2522af778c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742168Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689637}
-
Nathan Zabriskie authored
This CL removes the maps storing various FrameTimingDetails timings in favor of a pending FrameTimingDetailsMap. This allows more timestamps to be added to FrameTimingDetails in future CL's without needing to create an additional base::flat_map for each one. Change-Id: I9b67ca9ed22e0fce40747fa942a90285fa290891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764255Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#689636}
-
Nico Weber authored
Bug: none Change-Id: I8357608f3d735c1882ed246abf001ec347690f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766248 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
R=hypan@google.com, johnw@chromium.org, sadrul@chromium.org Bug: 996830 Change-Id: I0e9e7f33818aa3278166e81b6580c699f45e1b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765997 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Daniel Rubery authored
When the enterprise policy says to upload a file, attach the DM token so the server can validate the SKU. The DLP protos had also changed on the server side, so add the content source for DLP scans. Bug: 980784 Change-Id: I65fd18a9e91fd4e9a43882ac5b30be648afce74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762880 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#689633}
-
Alexander Hendrich authored
This CL: * updates IsPermittedToGetDeviceAttributes() to also allow calls from the sign-in profile. So far, only affiliated users were allowed to prevent unaffiliated users from reading sensitive device information. The sign-in profile can never be affiliated since it does not map to a user account, but is bound to the device instead. * whitelists the Imprivata login screen extensions (prod and dev versions) to use the chrome.enterprise.deviceAttributes API. Bug: 996125 Change-Id: I62d1d1d7bf458250301d4b404ba546b9011a26ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762078Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#689632}
-
Alex Newcomer authored
IgnoreUpdateAndLayout does not have a clear purpose, and is causing a bug. So remove this code. I have manually tested this extensively and it appears to have no adverse side effects. Bug: 995877 Change-Id: I8ae1ce8ee680eda3771f045834daaeeded7b23ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764776 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689631}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/02d4c0d38ea1..243997ac5d09 git log 02d4c0d38ea1..243997ac5d09 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 capn@google.com Don't access sampler handles for sampled image descriptors 2019-08-22 capn@google.com Fix samplerless image fetch Created with: gclient setdep -r src/third_party/swiftshader@243997ac5d09 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139401791,chromium:b/139401791 Change-Id: I95db1ceb4f2a85e4db040efa6a10695c9168a240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689630}
-
Peng Huang authored
Bug: None Change-Id: I884771b8a060b4001ba997e4b504a9d391b4622b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765990Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689629}
-
Steven Bennetts authored
Bug: 853953 Change-Id: Ie6062b8baa01c76f3ff00c0a88bbe69c9dd74dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757171 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#689628}
-
Wei-Yin Chen (陳威尹) authored
Also update the default parameter of zooming-min-sdk-version to M. TBR=twellington@chromium.org Bug: 964406 Change-Id: I3a23e20511f9ecb48ed70fd6952f36b06191817c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743106 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689627}
-
Mike Wittman authored
This reverts commit e4fe4ff4. Reason for revert: causes timeouts in IsolateOriginsPrintBrowserTest.PrintIsolatedSubframe Original change's description: > Activate API based fallback by default > > This will prefer performing DWrite API based font fallback on all > Windowses, particularly on Windows 8.0 and below, where API based > fallback was previously not available and hard-coded lookup tables were > used. A content feature is used to flip the switch on this as a > last-resort deactivation method, should this lead to unexpected fallback > problems. > > Bug: 976737 > Change-Id: I65d160a573a625ea60a866bacfd12dd0d8a5935a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753006 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Auto-Submit: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688281} TBR=avi@chromium.org,drott@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 976737, 996185 Change-Id: Ifc648163b1414f39f8277b8b963a2d73de3b146b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765993Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689626}
-
David Black authored
Also wires up AssistantUiController to observe changes to the cache in ash in order to show/hide the associated view as necessary. Follow up CLs will wire up the associated view to be in sync with the live data in the cache (currently it stubs in placeholders) as well as to handle the entry point to show content in Assistant UI. Bug: b:139199754 Change-Id: I4bee76004fee1782abc70eab0e9ddb9f8695c648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762341 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/679dc3716bdb..2662d14861da git log 679dc3716bdb..2662d14861da --date=short --no-merges --format='%ad %ae %s' 2019-08-22 achuith@chromium.org Revert "Support minidump symbolization on ChromeOS" Created with: gclient setdep -r src/third_party/catapult@2662d14861da The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:978952 Change-Id: I35b79039982a2fc9b71ef28d4c4db01122e40b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765832Reviewed-by:
-
Morten Stenshorne authored
This is in preparation for column-span:all support, where we'll need to support multiple column rows within one and the same multicol container fragment. Change-Id: Ia1189ea1526faa37d1a0c51b2dadfc7a9d40b0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765509 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#689623}
-
Robbie McElrath authored
Bug: 934152 Test: gn check out/Default //android_webview/public Change-Id: I84a2ef997f65644b6c836b5d501d9da02dd579cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764341 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689622}
-
Wei-Yin Chen (陳威尹) authored
After switching to another tab from GTS, a thumbnail of the original tab is taken. However, the thumbnail taking would be blocked if the web contents of the original tab is detached. Therefore, when showing the GTS-to-Tab transition animation to another tab, we cannot detach the original tab. The original tab is supposed to be invisible, but the tab decoration was not properly hidden. This CL hides the decoration of that invisible tab. Bug: 995992 Change-Id: Ia55cc21ddcbbc59674fa8c8268faaddc458cd4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764660Reviewed-by:
-
Devon O'Brien authored
Adding Google Argon2022, Argon 2023, Xenon 2023 CT Logs to list of Qualified CT Logs in Chrome. Additionally, incorporate recent Qualified --> Usable Log states. Bug: 889033, 833350 Change-Id: Iaca8867da9de61cb5a03e6323e14e8b9df0b5c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764834 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689620}
-
Steven Bennetts authored
This CL: * Gets the managed properties via mojo for use within the details page. (Properties from networkingPrivate are still fetched to support sub elements which will be converted in forthcoming CLs). * Uses mojo versions of the policy JS in the details page * Eliminates ManagedThirdPartyVPNProperties, folding the properites into ManagedVPNProperties for consistency with state properties. * Additional cleanup of onc_mojo.js. Note: The result of this CL will temporarily add an extra API call in the details page. However, showing the details page for a network is an infrequent operation, and the extra API call has minimal overhead (O(10) ms on a relatively slow coral device). Bug: 853953 Change-Id: Ifbecea8d55567bec987554657326838ee16315b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757070 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Raymond Toy authored
WebAudio legacy code often does something like: DCHECK(foo); if (!foo) return; The style guide says the if/return should be removed; DCHECK failures should not be handled. Part 3 of N: Update a few more files and for the most obvious cases where we can remove the if/return. Bug: 957654 Change-Id: Ib9f66273db36dc4b6b2333e15ebb965251927c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763259 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689618}
-
Xing Liu authored
This CL applies the custom time window in schedule parameters to select the notification to show. Also add unit test cases in DisplayDeciderTest. Bug: 991010 Change-Id: I843eff284176635bfaf8ec7ed258b1b9793e299b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755043 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#689617}
-
Sadrul Habib Chowdhury authored
Do not allow running chrome with swiftshader for the rendering benchmark, since the produced metrics wouldn't be generally useful. BUG=988045 Change-Id: I58d765ff056ad220912fc6a1a258c706c09a50c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734190 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#689616}
-
Eric Roman authored
Use 0.0.0.1:1 in place of 0.0.0.0:8000 as the address of the proxy server. The test expects connections to the proxy server to fail - however connecting to the ANY address (0.0.0.0) can succeed. The new literal should fail consistently since: (1) 0.0.0.1 is a reserved IP address. (2) We disallow connections on TCP port 1. Bug: 996367 Change-Id: I54ce278e75983110961da0cc49dd923decdd5ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765662Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c55b355580f..7f90416c08be git log 4c55b355580f..7f90416c08be --date=short --no-merges --format='%ad %ae %s' 2019-08-22 ehmaldonado@chromium.org depot_tools: Use git-checkout instead of git-rebase. Created with: gclient setdep -r src/third_party/depot_tools@7f90416c08be The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:996359 Change-Id: I31f04d609746e82cdc60e6ecedaba6f87a2bdeed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765989Reviewed-by:
-
Erik Chen authored
Previously, WebView was created by RenderView, but destroyed by RenderWidget. The call to destory the WebView in RenderWidget was shared with a call to destroy other WebWidget subclasses, even though that semantically represents a very different operation. This CL is a refactor with minimal intended behavior change [slight destruction timing change]. It makes the RenderView both create and destroy the WebView. Change-Id: I1d84f2c5cc1eff9558ffcbf4b5384f2f10a8d71b Bug: 995981, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764757 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#689613}
-
Justin Donnelly authored
Both are committers, have been on the omnibox team for over a year, and have demonstrated good knowledge and judgement in code reviews. Change-Id: I88c1aa50cff969a4afb6a958e5ac2c01b69a385f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765658Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#689612}
-
W. James MacLean authored
This CL removes existing code that was intended to prevent OOPIF over-rendering by limiting LayerVisibleRect() for the OOPIF's content layer to the viewport intersection sent from the browser. This is being removed in advance of new work to fix the problem by making |device_viewport_size_| on LayerTreeHost a gfx::Rect instead, and having it define the required intersection. Bug: 852348 Change-Id: I15426c08cfc7eb09a99b30811421b0ab613ab8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764238Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#689611}
-
Bettina authored
There was a check for tests where primary account is not syncing and we should not show a modal warning on password reuse. However, this should not be the case since when not syncing, there is no primary account. Bug: 914410 Change-Id: Ia2ece03990aba58501d207f96c6fd1c5ed5b0abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762829 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#689610}
-
