GitLab

Check if ContentCaptureReceiver is valid before start capture.
Also, add a DCHECK() to the other call site of
ContentCaptureReceiverForFrame().

Bug: 1029678
Change-Id: Iaed486b6a7e9b322174e06fc0469defd5babb2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947284Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720729}

This CL provides an API to the embedder for receiving crash notifications,
and triggering upload or deletion of crashes.

It is designed so that the notification can be used to trigger an upload
job to execute later (potentially in a different process) without fully
initializing weblayer.

A number of things in the minidump_uploader (chiefly MDUploadCallable ->
MinidumpUploader) have been forked. The intention is to unfork immediately
after this patch. Doing so will address existing TODOs in the component,
and address some existing separation of concerns issues.

Bug: 1027076
Test: run_weblayer_support_instrumentation_test_apk -f '*CrashReporterTest#*'
Change-Id: I86b9b37830014c468fd69cf99a67f6f00809f9fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940271
Auto-Submit: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720728}

This makes the usage a little more clear, especially in a future world where
(hopefully) no one is running the `cros chrome-sdk` scripts directly, subsequently
making the phrase "cros_chrome_sdk" meaningless.

As we replace/deprecate Simple Chrome, this arg will start showing up in many
build files, so it's important that its purpose is clear in its name.
eg: http://crrev.com/c/1922977/9/ui/events/ozone/BUILD.gn

Bug: 937821
Change-Id: I967aa9498ed04e351b9423bc75939632ad01fd7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925330
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720727}

Make sure to add a renderer-side safebrowsing throttle in order
to check renderer initiated url loads using the safebrowsing API.
This also ensures that resource requests for e.g. .js and .svg
files are also checked. This approach matches the behavior in
WebView and Chrome. Due to the addition of methods the original
safebrowsing initialization sequence is slightly changed (see
below for details). Additionally the ResourceContext destruction
has to happen on the IO thread (see below for details).

In particular in this patch:
- Add and implement ExposeInterfacesToRenderer method to make
  sure renderer can execute safebrowsing calls.
- Move safebrowsing_service initialization to the
  ExposeInterfacesToRenderer() method because it is executed
  before CreateURLLoaderThrottles.
- Implement UrlLoaderThrottleProvider in weblayer/renderer/
  which amongst other things adds the
  safe_browsing::RendererURLLoaderThrottle.
- Implement RenderThreadStarted() and
  CreateURLLoaderThrottleProvider() methods for
  ContentRendererClient.
- Update build and deps files accordingly.
- Also make sure to destroy ResourceContext on the IO thread
  (otherwise profile destruction sequence can result in a
  DCHECK, see crbug.com/1029317).

BUG=1015418,1028659,1029317

Change-Id: I67482a450d1974a8b14cb07f4fbedd14e4983e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937173
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720726}

Bug: 875700
Change-Id: I81cd3b54b1119e9475ee4653efcd4817d4ea4a39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943786Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720725}

-VP9.2/3 decoder check has been moved into
 ContentRendererClient::IsSupportedVideoType ->IsDefaultSupportedVideoType
 -> IsVp9ProfileSupported

Bug: internal b/144324034

Test: Cast from Google Play Movie to Android TV and check the result of
VP9.2 query.

Change-Id: Idbfacd1feddcc6d65083c7c3d06778f8bbd0c569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927411Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720724}

This is a mostly mechanical refactor done with Android Studio, with a
few additional manual renames of symbols and comments.

TBR=twellington@chromium.org

Bug: 1029146
Change-Id: Ia57c2d2083a690cbc3dcc57e1901fe28fd4f4621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946790Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720723}

Implement SharedImageBackingD3D::ProduceSkia and supporting methods.

Bug: 1021118,1002316
Change-Id: Ia699bddfa08469b9e151018eca6c5206620cb731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938707
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720722}

Bug: 1018201
Change-Id: I7848d39c74e17a8c397847c0aa96e8612bc14669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933588
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720721}

This is just some followup cleanup from:
https://chromium-review.googlesource.com/c/chromium/src/+/1902474

Bug: 1022214
Change-Id: I2f7c53cfc74a1a482a931143c06d8457d98d16fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910810
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720720}

The fact that it isn't running appears to have been an oversight.

Bug: 1029936
Change-Id: I4c70311bca05f2088fd0e99112512a015524bd95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946875
Commit-Queue: Erik Chen <erikchen@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720719}

This reverts commit 6a52c6f8.

Reason for revert:

Findit has probably misidentified this CL as the culprit in those changes. If the error had
something to do with locales or binary size that would make sense, but this CL does not
touch the files involved.

It looks like this CL (https://crrev.com/c/1945994) has reverted a change that actually
affects the relevant file:

   /build/scripts/slave/recipe_modules/chromium/resources/ninja_wrapper.py

Original change's description:
> Revert "refactor android locales in locales.gni"

> This reverts commit 15204aaf.

> Reason for revert:

> Findit (https://goo.gl/kROfz5) identified CL at revision 720636 as the
> culprit for failures in the build cycles as shown on:
> https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzE1MjA0YWFmMDdlYWZmNTkzZDdhM2Q2ZDdlYjdhNjljOGI5MGE1NWEM
>
> Sample Failed Build: https://ci.chromium.org/b/8895149418482727520
>
> Sample Failed Step: compile
>
> Original change's description:
> > refactor android locales in locales.gni
> >
> > This CL refactors build/config/locales.gni but makes no actual
> > changes to what locales are used.
> >
> > The primary change is to remove android_chrome_omitted_locales
> > and replace it with android_non_bundle_locales.
> > This list should be used directly instead of subtracting omitted
> > locales from locales.
> >
> > Additionally the list all_chrome_locales was added as the superset
> > of all supported locales.  Platform specific lists are made by
> > subtracting from this list.
> >
> > No changes were made to the iOS and Mac locale lists names.
> >
> > Bug: 812837
> > Change-Id: I26e9c1b2d40397a6ed02777db55c44be93060050
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939962
> > Commit-Queue: Trevor  Perrier <perrier@chromium.org>
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Ted Choc <tedchoc@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#720636}
>
>
> Change-Id: I91d7824e9e0b292c3376556947cbe4aced6bd0be
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 812837
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947226
> Cr-Commit-Position: refs/heads/master@{#720650}

Change-Id: I29644d0edd27a9d8bc5f6c29d8bc86fe9b47322d
Bug: 812837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945998
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720718}

Extend --enable-text-fragment-anchor flag expiry to M83.

Bug: 919204
Change-Id: I0605d90747b9f891826ec1b8c7f5614990aa4454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946454
Commit-Queue: Nick Burris <nburris@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720717}

Transitive JUnit deps are now supported.

BUG=966644,951455

Change-Id: I274a55af55015b9287336164ae7caf9d12ebcdba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945359Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720716}

conformance/extensions/oes-texture-float-with-video.html
conformance/extensions/oes-texture-half-float-with-video.html
conformance/textures/misc/texture-upload-size.html
conformance2/textures/misc/tex-image-with-bad-args-from-dom-elements.html

Restrict the existing Win Intel Flaky suppression of
conformance/extensions/oes-texture-float-with-video.html
to D3D11, looking at crbug.com/825338, this is where it was reported.

TBR=bsheedy

Bug: 1026468
Change-Id: I37318e826f109d3a148b1e4f64262491aac324f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946878Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720715}

MessageLoop is going away soon.

This CL was uploaded by git cl split.

R=japhet@chromium.org

Bug: 891670
Change-Id: I20f6d248ef6e288252dad8462e0712a0b4974bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945811
Auto-Submit: Carlos Caballero <carlscab@google.com>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720714}

Regression introduced in https://chromium.googlesource.com/chromium/src/+/7752898dcc9445b41397a9a75bd7e5cb4f1c10bb

R=rch@chromium.org

Bug: 1026194
Change-Id: I5b1c3b193d2d4dcb0aa17af4d8b7a3eca82c33a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932419Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720713}

This reverts commit f8263a71.

Reason for revert: tree closure due to "undefined symbol: MediaAppUiBrowserTest::AppJsTestLibrary"
from https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Builder/16846

Original change's description:
> Hook up chrome://media-app as a file handler for image/*
> 
> Adds a consumer for window.launchQueue in chrome://media-app that
> opens the file and sends it to the existing loadBlob(), which sends
> the blob to the unprivileged guest app to load.
> 
> Adds an integration test that ensures launch params passed via the
> AppService OpenApplication() will correctly open an image in the media
> app.
> 
> SystemWebAppManagerBrowserTest is refactored away from extensions slightly.
> Rather than use extensions::browsertest_util::LaunchAppBrowser(), it uses
> LaunchService::OpenApplication(AppLaunchParams) directly. Mostly this just
> avoids having to fetch the Extension* only to use extension->id() to get the
> app_id back again.
> 
> Bug: 996088, 1023742
> Change-Id: I85624e93618d82ccce1c80d04d21d81303579a99
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913282
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720681}

TBR=xiyuan@chromium.org,tapted@chromium.org,ortuno@chromium.org

Change-Id: I06542d5e52317f7ac0bba6685822662366b4b689
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 996088, 1023742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947883Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720712}

Do not call -dismissViewControllerAnimated:completion: on
|self.baseViewController|, since the receiver of the method can be
dismissed if there is no presented view controller. On iOS 12
SKStoreProductViewControllerDelegate is responsible for dismissing
SKStoreProductViewController. On iOS 13.0 OS dismisses
SKStoreProductViewController after calling -productViewControllerDidFinish:
On iOS 13.2 OS dismisses SKStoreProductViewController before calling
-productViewControllerDidFinish: Calling
-dismissViewControllerAnimated:completion: on |self.baseViewController| on
iOS 13.2 will dismiss base view controller and break the application UI.
According to SKStoreProductViewController documentation the delegate is
responsible for calling deprecated dismissModalViewControllerAnimated: so
the documentation is clearly outdated and this code should be resilient to
different SKStoreProductViewController behavior without relying on iOS
version check (see crbug.com/1027058).

Bug: 1027058
Change-Id: Ib3918930b9950e79b088f14b3d0424e42d7b5c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928590
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720711}

As noted in the comment next to one of the DCHECKs,
RewriteUrlForNavigation has non-deterministic behavior in practice.

This is particularly relevant to Reader Mode, which includes a random
string into the distiller's URL, causing each call to the URL-
generating method to be different.

Bug: 992073
Change-Id: I78eb582adc48c9fe90a460adeeab9efc66d9fea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873957
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720710}

This analyzer is specific to chromium/src, so
it can be added to the chromium project config,
where it is a little more convenient to edit.

This CL is related to
https://chrome-internal-review.googlesource.com/c/infradata/config/+/2255124,
which removes the definition from

In addition to moving the definition, this also:
 - Changes the input type from FILES to GIT_FILE_DETAILS,
   since I believe the recipe doesn't use the FILES input.
   This means that the analyzer can start earlier.
 - Changes the component to one under Internals>Metrics
   to help the metrics team triage bug reports.
 - Organizes the file into sections, each ordered
   by analyzer name.

Change-Id: I3084e347d7f03dc1b6dbd9386bee82c79bbdf20c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947164Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720709}

This CL removes the gap between infobar and bottom sheet to make them work more
nicely. Bottom sheet's top shadow height dimension needs to be bigger.

Bug: 1025098
Change-Id: I0264d19b2ab75efbdee3a4cadc697ea7ebc1a9ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943783Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720708}

Disabling flaky tab drag tests needed to land field trial config change for compositor priority experiments.

Bug: 1027606, 1028386
Change-Id: I23b3794f8baf1e3f2ee12ff6456f570ef0ce3099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931540
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720707}

Bug: 1029152
Test: with Tast
Change-Id: I935c6b4feaa6e80e5c738a838c1329c4deb59036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940309Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720706}

I have made some change to support multi touch point actions, so we can
try to enable this test again to see if it is no longer flaky.

Bug: 1011225
Change-Id: I3b896e6afc842f4bb0e78c2f9f900c4d5e0a8c9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946986Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720705}

R=pfeldman@chromium.org

Bug: None
Change-Id: I47ed4d0296de3430511039348bfdc3016e4e32e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946789
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Auto-Submit: Asanka Herath <asanka@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720704}

- Added |removeFakeIdentity| method to SigninEarlGreyUtils and
SigninEarlGreyUtilsAppInterface.
- Other essential changes for eg2.

Bug: 987646
Change-Id: I247ed078f61401a0f0a5cb787af22a3534296e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915283Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720703}

This reverts commit f878a705.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Support compressed .json grit files, compress chromevox msgs (Take 2)
> 
> This provides support for type="chrome_messages_json_gzip" in
> grit/build.py, which compresses the output files (which should have
> .gz appended to the name, e.g. messages.json.gz).
> 
> This makes it fairly simple to convert an extension (e.g. chromevox)
> to use compressed l10n files.
> 
> Original CL:
> https://chromium-review.googlesource.com/c/chromium/src/+/1913610
> 
> For changes reviewed in the original CL:
> TBR=agrieve@chromium.org
> 
> Bug: 1023568
> Change-Id: Ibf8dfa374f5e759b3b459d007fde2423f83873a5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931097
> Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720686}

TBR=stevenjb@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org

Change-Id: I3f49b69d68d1bf5eb72ceb4b8927a14b29923f20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1023568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947190Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720702}

This is a reland of ed064683

Original change's description:
> android-pie-arm64-rel cq experiment to 100%.
> 
> Bug: 765833
> Change-Id: I9558db3934ebae0252f0fd4f2861c3c4441d7020
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871639
> Auto-Submit: Andrew Luo <aluo@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Aaron Gable <agable@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711093}

Bug: 765833
Change-Id: I699b5df3625ca61448f0c0dd7f40421139cd2573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900302Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720701}

Currently, if the "Daily text" label is too long in a language (e.g
Spanish MX), the text does not wrap and overlaps with the subsequent
toggle.  This CL ensures that if the label is too long it will wrap the
text to a maximum of 2 lines.

screenshots:
https://drive.google.com/open?id=16oh9vg3FVmgNbYwg-4bEUbw66KHTxj-l

Fixed: 1001901
Change-Id: I0d36a10b5d2ee5b4eb6e84bef313c58bb79230de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938367Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720700}

Bug: 1012203
Change-Id: I777d82887b16ebde005e4ff4d7638e5930cb359d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943143
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720699}

This CL ensures DBUS_SESSION_BUS_ADDRESS is set when running tests. This is
necessary because otherwise the dbus daemon will be autolaunched on attempted
first use. This is problematic because glib allocates memory between fork() and
exec() for the daemon, causing deadlock if the global malloc lock is held. This
is fixed by glib commit [1], but this workaround will be necessary until the fix
rolls into Chromium's CI.

[1] https://gitlab.gnome.org/GNOME/glib/commit/f2917459f745bebf931bccd5cc2c33aa81ef4d12

BUG=1027852
R=dpranke
NOPRESUBMIT=true

Change-Id: Iea6d702d4d4c724ad44d0aa82522175f6b3a78e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937507
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720698}

This time with tools/gritsettings/resource_ids. Why this is not in a PRESUBMIT
for all .grd files is a mystery.

The UI is behind the new crostini-webui-upgrader flag
(currently disabled by default)

The main areas for review are

calamity@:
html/js  - chrome/browser/chromeos/crostini_upgrader/
mojo and webui glue classes - chrome/browser/ui/webui/crostini_upgrader/

davidmunro@
crostini business logic - chrome/browser/chromeos/crostini/

In this CL, the optional container backup stage is stubbed, and will be
in a subsequent CL.

A suite of unit/browser tests are also currently lacking. I intend them for
follow-up CLs.


Bug: 930901
Change-Id: I5dd3f838e144c7f705ef2be1af5ac5f5afdf3f67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933583
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Auto-Submit: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720697}

This CL sets the status bar color to black on Android L if
android.support.customtabs.extra.TOOLBAR_COLOR is not specified in the CCT
launch intent.

BUG=1015835
TEST=CustomTabStatusBarColorProviderTest.*

Change-Id: I566080e469cecc50cc9adce2121e6571ada63015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942875Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720696}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b2efa52611c0..75ba8e350e55

git log b2efa52611c0..75ba8e350e55 --date=short --first-parent --format='%ad %ae %s'
2019-12-02 machenbach@chromium.org Add some infra ownership

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@75ba8e350e55

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1026215
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ic4f0ee4202d27c689014e72edfcda63322572637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946599Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720695}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=pbos@chromium.org

Bug: 1023677
Change-Id: I5a2789136fb35afc6f8d38f1339316018e4b3769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924963
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720694}

There are some unit tests that, with a little refactoring, will work
for both legacy background page-based extensions and service worker-
based ones. This CL is a start at refactoring and rewriting any tests
that are appropriate for both.

Bug: 1015136
Change-Id: I65baa3f8fa23ad1b25c067da216224b46925ea35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922923
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720693}

This helps to have backups for when bot temporarily die.
The movement of 7 bots to the weblayer config meant
that until now there were no backups.

Bug: 1022823
Change-Id: I8084caf797e74ac913c1204e09ec3e393a56a3da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941279
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720692}

* Make cancel hint normal color (not red)
* Add top margin to the paper progress
* Add top margin for progress message
* Apply oobe-illustration for update-illustration

Fixed: 1025648
Change-Id: Iab47187508d180ebb322d53c2141d1d8edc0d0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921979Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720691}

https://skia.googlesource.com/skia.git/+log/2e3be5648a9f..cdf1bc3bd32e

git log 2e3be5648a9f..cdf1bc3bd32e --date=short --first-parent --format='%ad %ae %s'
2019-12-02 stani@google.com Expose SkRuntimeShaderFactory class to clients
2019-12-02 jlavrova@google.com A new API call on Paragraph: a number of unresolved glyphs
2019-12-02 mtklein@google.com replace SkColorSpaceXformSteps::Required()

Created with:
  gclient setdep -r src/third_party/skia@cdf1bc3bd32e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bsalomon@google.com
Change-Id: If0320b6da7198edd169cb8bf28b7be214f1bf1e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946898Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720690}