- 03 Jan, 2018 40 commits
-
-
Matt Reynolds authored
The WifiPollingPolicy controls how frequently the network location provider will initiate Wi-Fi scans. Previously, the policy was attached to the WifiDataProvider, which is destroyed when there are no active geolocation API calls. Destruction of the provider causes us to lose track of our polling policy. The policy allows the first scan to be performed immediately and schedules subsequent scans at regular intervals. When the provider is destroyed and recreated rapidly it considers each scan to be "first", which allows many Wi-Fi scans to be performed in a short window. This change moves the policy state to a global instance so it can be saved when the provider is destroyed and recreated. The new policy allows the first-ever scan to be performed immediately, and subsequent scans may also be performed immediately if enough time has lapsed since the previous scan. In all other situations, the configured polling interval is enforced. BUG=764954 Change-Id: I00649dde2a707127e53e0330511172fef4a43471 Reviewed-on: https://chromium-review.googlesource.com/834988 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526782}
-
Miguel Casas-Sanchez authored
This CL rewrites two parts of VideoResourceUpdater::CreateForSoftwarePlanes() to take advantage of the faster libyuv library functions: - libyuv::Convert16To8Plane() was landed as part of libyuv:751 and is way faster than the C counterpart [1] - libyuv::CopyPlane() existed already and is also faster than the C counterpart. This CL is purely refactoring, functionality is covered by unit and browser tests. [1] https://bugs.chromium.org/p/libyuv/issues/detail?id=751#c11 Bug: 798485 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iead82969b13917aabdaacee47799f6816a164171 Reviewed-on: https://chromium-review.googlesource.com/848055Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#526781}
-
Dave Schuyler authored
This CL fixes some typos in comments. There are no logic changes or user visible changes. TBR=tommycli@chromium.org (code health) Bug: None Change-Id: I7772f14fa473d93e773179bfb5a66352da5aaeef Reviewed-on: https://chromium-review.googlesource.com/848374 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#526780}
-
Pavol Marko authored
This CL fixes sign-in behind an authenticated proxy. Two actual changes were necessary in this context: - SigninPartitionManager: copy auth data from the system request context into new StoragePartitions This makes SigninPartitionManager::StartSigninSession async, which made small changes necessary in GaiaScreenHandler and EnrollmentScreenHandler - SigninScreenHandler: Don't reload gaia immediately when auth details have been supplied. This was unnecessary (the URL Request will continue) and actually harmful, as now that we're using a new StoragePartition for each sign-in attempt, this discards auth data before we can copy them. To support the browsertest, testserver.py gets an argument to redirect CONNECT requests to localhost when proxying (in sign-in browsertests without proxy, we use RuleBasedHostResolverProc::AddRule to achieve this effect). Bug: 793524 Test: browser_tests --gtest_filter=WebviewProxyAuthLoginTest.* && unit_tests --gtest_filter=SigninPartitionManagerTest* Manual test: Setup: Setup an proxy server with Basic authentication Configure the device to use the proxy server. Make sure the user adding screen is shown. Test 1: Expect proxy auth dialog. Enter correct proxy auth data. Expect that sign-in screen is shown and sign-in works. Test 2: Expect proxy auth dialog. Enter incorrect proxy auth data. Expect that proxy-auth dialog is shown again. Test 3: Expect proxy auth dialog. Press Cancel. Expect that a network error dialog is shown. Press "try to sign in again". Expect proxy auth dialog. Enter correct proxy auth data. Expect that sign-in screen is shown and sign-in works. Change-Id: I78b5988b5ca4c6eaaf4e6f9443e299499d6f0f08 Reviewed-on: https://chromium-review.googlesource.com/837920Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#526779}
-
Xida Chen authored
This reverts commit 0346a3a1. Reason for revert: <INSERT REASONING HERE> Causing compilation failure here: https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20(dbg)/1592 Original change's description: > Adds predictable multimatch support in PreviewsOptimizationGuide > > Supports multiple hint matches with precendence given to the match > that occurs first in the configuration. Also, allows matches > without whitelisted optimization to be able to turn off whitelisting > for a host pattern (that otherwise would be whitelisted for another > matching pattern that occurs later in config). > > Bug: 783237 > Change-Id: I9239b74b170a1d5a19b13caccecc732f9715de90 > Reviewed-on: https://chromium-review.googlesource.com/847816 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526763} TBR=dougarnett@chromium.org,ryansturm@chromium.org Change-Id: I92772c5873d06af184449ae6347bb2ebacb5100f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783237 Reviewed-on: https://chromium-review.googlesource.com/848535Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526778}
-
Thomas Anderson authored
This reverts commit 0346a3a1. Reason for revert: Causing build failure on WinMSVC64 (dbg): https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20(dbg)/1592 Original change's description: > Adds predictable multimatch support in PreviewsOptimizationGuide > > Supports multiple hint matches with precendence given to the match > that occurs first in the configuration. Also, allows matches > without whitelisted optimization to be able to turn off whitelisting > for a host pattern (that otherwise would be whitelisted for another > matching pattern that occurs later in config). > > Bug: 783237 > Change-Id: I9239b74b170a1d5a19b13caccecc732f9715de90 > Reviewed-on: https://chromium-review.googlesource.com/847816 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526763} TBR=dougarnett@chromium.org,ryansturm@chromium.org Change-Id: If54e402cac060422cbff45a11ead41ca6c31d542 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783237 Reviewed-on: https://chromium-review.googlesource.com/849281Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526777}
-
Sergey Ulanov authored
--dry-run was broken after https://crrev.com/525224 because binary_name was no longer defined in _GetSymbolsMapping(), while still being used for dry-run. Change-Id: I76566e3e22007401a5c5d80daa5e7dc30af2c91f Reviewed-on: https://chromium-review.googlesource.com/848431Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#526776}
-
Eugene But authored
Make mutableCopy of http_request_headers_ to avoid crashes in AddHttpRequestHeaders and RemoveHttpRequestHeaderForKey. Bug: 798070 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaca5eb950f79b5936a75523392322036a37158a5 Reviewed-on: https://chromium-review.googlesource.com/846433 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#526775}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/aebad197dcaf..d9852cd27a76 $ git log aebad197d..d9852cd27 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 brianosman Remove obsolete comment 2018-01-03 brianosman Remove unused color from all distance field GPs and GrAtlasTextOp 2018-01-03 reed partial revert of https://skia-review.googlesource.com/c/skia/+/90026 for android 2018-01-03 reed update pipe for lattice and shadowrec 2018-01-03 caryclark refresh public includes 2018-01-03 caryclark support srgb flag in bookmaker 2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ d8724a947..93b059db4 (1 commit) 2018-01-03 rmistry Add Housekeeper-PerCommit-Bookmaker to cq.cfg with 100% experiment% Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ie824679dea9d0130e98f51792a0986501bd7aa06 Reviewed-on: https://chromium-review.googlesource.com/849154 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526774}
-
Thanh Le authored
Bug: 753594 Change-Id: Ie03bcba5d02c20fafce965cb3f48cb1dd976d211 Reviewed-on: https://chromium-review.googlesource.com/843205 Commit-Queue: Thanh Le <thanhdle@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#526773}
-
Xida Chen authored
This instance shows that this test could timeout on android. TBR=hiroshige@chromium.org NOTRY=true Bug: 755405 Change-Id: Ibbdad38e0812c6c162b732fbac200b002d2bb97d Reviewed-on: https://chromium-review.googlesource.com/848647Reviewed-by:
-
Andrew Grieve authored
Noticed that bloaty does this and I think it's a good idea. It enables you to distinguish templates from non-templates, while still allowing grouping. Also fixes template stripping of operator>> Change-Id: I6deddcf01464e191c64f6d4569f8479c628a2c94 Reviewed-on: https://chromium-review.googlesource.com/849133 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#526771}
-
Chris Mumford authored
Bug: 782015 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I877446e14fb53d0c6c0ea73b5eda8399821668fc Reviewed-on: https://chromium-review.googlesource.com/801235Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#526770}
-
Xida Chen authored
This instance shows that the virtual/threaded/fast/scroll-behavior/smooth-scroll/mousewheel-scroll-interrupted.html could time out on Linux. TBR=hiroshige@chromium.org NOTRY=true Bug: 665577 Change-Id: I65f1e8f70a180cdcc0f6d8e9263fd4897231bfeb Reviewed-on: https://chromium-review.googlesource.com/848035Reviewed-by:
-
Andrew Grieve authored
I think this started appearing when we added AFDO profiles. Change-Id: Icc17e00411368d3bd51ba6d3844e35228523e2e5 Reviewed-on: https://chromium-review.googlesource.com/848034Reviewed-by:
-
Henrique Nakashima authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1f2cddd7b8faade4c9913e08010ebe6be0dd12fe Reviewed-on: https://chromium-review.googlesource.com/842709Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#526767}
-
Sidney San Martín authored
This regressed in r492972 (switch to a custom window frame view class). When not using NSWindowStyleMaskFullSizeContentView (macOS <10.12, but it can probably be turned on back to 10.10), certain circumstances caused the tab strip background view to partially cover up the toolbar. The most reliable way to reproduce it, for me, is: - Be running macOS 10.11 or older. - Have multiple monitors connected. - Turn off "Displays have separate Spaces" in System Preferences. - Enter web content fullscreen (e.g. on YouTube). - Exit fullscreen by pressing Esc. Three things came together to make this happen: 1. |-[FramedBrowserWindow browserFrameViewPaintHeight]| returned a hard-coded value when not using FullSizeContentView. I believe it used to represent the height of the tab strip but no longer does, and I believe it was just kept out of caution when the full size content view path was added, but it's bigger than it needs to be and makes the tab strip background view slightly larger than necessary. (This value originally appeared in r40677). 2. |-[TabWindowController insertTabStripBackgroundViewIntoWindow:titleBar:]| explicitly inserted the background view behind all other views. 3. The immersive fullscreen path, which is only taken when multiple monitors are connected and "Displays have separate Spaces" is turned off (see |-[BrowserWindowController enterWebContentFullscreen]|) inserts the content view behind all other views on exiting fullscreen (see |-[BrowserWindowController moveViewsForImmersiveFullscreen:regularWindow:fullscreenWindow:]|), which means that it's now behind the tab strip background view. I'm fixing this with three changes: 1. Get rid of the special value in |-browserFrameViewPaintHeight| and return |chrome::kTabStripHeight| in both cases. 2. Hide the |visualEffectView_|/|tabStripBackgroundView_| in fullscreen always, not just when using FullSizeContentView — othersise, it can be seen visible on top of the content in fullscreen. 3. When setting up a window, insert the tab strip background view normally instead of behind its siblings. It just made these bugs harder to find (the strip would have appeared all the time, otherwise). Bug: 779082 Change-Id: Id9536dc6ff8593b3e7e2b3f38bbf9149418d0ac6 Reviewed-on: https://chromium-review.googlesource.com/848641Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526766}
-
Jun Choi authored
Previously, all U2F HID device requests would fail if a packet for different channel was received from hid device during channel allocation. Changed this behavior so that packets for different channels will be disregarded without causing request failure. Bug: 785337 Change-Id: Ibad715d4fd0024dd0d3ca35ac409e3d72ec0eb32 Reviewed-on: https://chromium-review.googlesource.com/770305 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
-
Mathieu Perreault authored
Bug: 488146 Test: existing Change-Id: I41d59690688ca8dbba01fee9260fd25497061ff5 Reviewed-on: https://chromium-review.googlesource.com/848056Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526764}
-
Doug Arnett authored
Supports multiple hint matches with precendence given to the match that occurs first in the configuration. Also, allows matches without whitelisted optimization to be able to turn off whitelisting for a host pattern (that otherwise would be whitelisted for another matching pattern that occurs later in config). Bug: 783237 Change-Id: I9239b74b170a1d5a19b13caccecc732f9715de90 Reviewed-on: https://chromium-review.googlesource.com/847816Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#526763}
-
Matt Menke authored
Previously, NetworkContext::ClearNetworkingHistorySince would tell HttpServerProperties to clear data, and then immediately inform the caller that the data was cleared. The data was deleted from memory by that point, but hadn't been written to disk, and we didn't even trigger a flush to disk, at that point. This CL makes changes that. We now pass in the callback to the HttpServerProperties, which writes the data to the pref store and then tells the pref store to flush data to disk. Only once the newly cleared data has been flushed do we invoke the callback passed to NetworkContext::ClearNetworkingHistorySince. Bug: 795877 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b1ed23eb5bdbab77871c79cdd068b95c0972535 Reviewed-on: https://chromium-review.googlesource.com/834393Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#526762}
-
Stephen Chenney authored
TBR=chrishtr@chromium.org, robertma@chromium.org NOTRY=true Change-Id: Ieaccbe40de8e60bce9ca24523f8445af71c08101 Reviewed-on: https://chromium-review.googlesource.com/848646Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#526761}
-
Mounir Lamouri authored
This is a fix around what looks like a race where `GetSensor` is called twice and leads to `OnSensorCreated` to also be called twice. However, the latter method doesn't expects this and has direct and indirects checks to prevent it. Bug: 798409 Change-Id: Ic2a3acd72eec2a49334551347cb3fd690377e3ed Reviewed-on: https://chromium-review.googlesource.com/847003Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#526760}
-
Erik Chen authored
The equivalent metrics are now uploaded by ProcessMemoryMetricsEmitter, except for all platforms rather than just macOS. Bug: 720541 Change-Id: I36ed3a888bb0021744e12df84587c796cfd80865 Reviewed-on: https://chromium-review.googlesource.com/837656 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#526759}
-
Dmitry Gozman authored
Bug: 789577 Change-Id: Idc8ac26283f863b280a50ec3036990630c6e81c3 Reviewed-on: https://chromium-review.googlesource.com/847853 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526758}
-
Reilly Grant authored
The only production implementations of the OnTunnelConnectCompleted, OnBeforeTunnelRequest and OnTunnelHeadersReceived are empty. They are used however in http_proxy_client_socket_pool_unittest.cc which has had to have some test expectations removed. This effectively reverts r294252 as DRP's custom HTTP headers are now added by the DataReductionProxyNetworkDelegate instead of the DataReductionProxyDelegate. Bug: 721403 Change-Id: Ifb683e7fc28e97efc7182df1a33bf46f1b74a7ec Reviewed-on: https://chromium-review.googlesource.com/846261Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526757}
-
Yuri Wiitala authored
A recent change(*) switched a shmem buffer Clone() call from READ_WRITE to READ_ONLY. New VIZ tab capture implementation depends on the special semantics of the READ_WRITE argument, only in-so-much as it avoids a crash due to what looks like a design flaw in base::SharedMemory (details in crbug). This change reverts the call point, until a long- term solution can be worked out. Testing: Confirmed that the change works with both tab capture and USB webcam capture. * See: https://chromium-review.googlesource.com/820011 and http://crbug.com/793503 Bug: 797470 Change-Id: I9bffdd0b71cbfa37b6b5bda03ce8863b560d8747 Reviewed-on: https://chromium-review.googlesource.com/848239Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526756}
-
xdai authored
It's a follow-up CL of https://chromium-review.googlesource.com/c/chromium/src/+/820854. Bug: 791654 Test: Manual, browser_tests Change-Id: I7e04a6839d1af6897a560a9875280ea7a2c18004 Reviewed-on: https://chromium-review.googlesource.com/833486 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#526755}
-
Daniel Bratell authored
There are two overloaded GetRestrictedCookieManager functions in different files which in certain non-standard jumbo configurations end up in the same translation unit. When that happens, base::Bind doesn't know which one to use and there is a compilation error. This patch renames one of them GetRestrictedCookieManagerForWorker so that there will never be any confusion. Bug: 746953 Change-Id: I7b3e6ba32aed44e575ee108111871e45b5e2689c Reviewed-on: https://chromium-review.googlesource.com/847010 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#526754}
-
Sky Malice authored
This results in a regression, in the sense that we're going to be worse at syncing custom tabs because of this change. The problem was that we could assign the same sync id to two seperate tabs on Android when the main windowed of Chrome was not fully loaded. To fix this, this CL stops giving out sync ids if we don't have full native data. While refactoring the checking for a tabbed window, realized that it's possible to get all null tab objects, and this should be treated as not having native data as well. Bug: 639009, 797452 Change-Id: I0f477326b9d2c3fa526399623f089a791f1b3046 Reviewed-on: https://chromium-review.googlesource.com/843574Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#526753}
-
bsheedy authored
Finally adds some Markdown documentation files about VR instrumentation and browser tests. Specifically: * The VR test framework * VR instrumentation tests and rule parameterization * Notable differences between VR instrumentation and browser tests Bug: 756261 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib55c034d2cc41a86ff095aba327ebf0f52a5b752 Reviewed-on: https://chromium-review.googlesource.com/848028Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526752}
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:628174 Change-Id: Ibee6850f5f58296eec80097dc2c74aa1237a6c31 Reviewed-on: https://chromium-review.googlesource.com/848321 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Proper MessageLoop::IsIdleForTesting() that corresponds to the actual idleness criteria for MessageLoop. A pre-requirement for a simpler ScopedTaskEnvironment::RunUntilIdle() implementation. R=fdoray@chromium.org Bug: 708584 Change-Id: I6c35d72868ab313788c166c76e179c8cd3ace438 Reviewed-on: https://chromium-review.googlesource.com/847752Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#526750}
-
Daniel Park authored
Sets attributes flags to secure if there is an incognito tab visible on the screen using TabModelSelectorObserver & OverviewModeObserver Bug: 764599 Change-Id: Iac33dd9cad83a697316f7f925bcbb80444e54b4a Reviewed-on: https://chromium-review.googlesource.com/809508 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526749}
-
Reid Kleckner authored
Created by patching in https://chromium-review.googlesource.com/c/chromium/src/+/835358 and manually editting the revision in update.py. TBR-ing rsesek@ again for the sandbox changes. TBR-ing bretw@ again for the ppapi adapter LLD warning suppression. I will manually build and test net_unittests after uploading to goma, but I've built this clang revision locally and they are not flaky for me. R=inglorion@chromium.org,hans@chromium.org TBR=rsesek@chromium.org,brettw@chromium.org Bug: 787920, 797267, 797168 Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_mips_dbg;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: Ifd25c014e79ad7a5d4533941ae7fd74a86860191 Reviewed-on: https://chromium-review.googlesource.com/845700Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526748}
-
Troy Hildebrandt authored
When updating the menu item spacing for the Chrome Home bottom navigation menu, we were checking the length of a potentially null array so a null check has been added. Bug: 796185 Change-Id: I1382aace706ad2b0ffb13e9c84bf78efc7284ceb Reviewed-on: https://chromium-review.googlesource.com/848242 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#526747}
-
danakj authored
This is a reland of 5c4d3d4a The IOSurface textures for RenderPasses do this, citing bug 146070. We can do the same for the RenderPass textures. This affects any pixel tests that have anti-aliasing, as the float value of texcoords is changed. So we have to add anti-aliased versions of a few pixel tests, and rebase a number. TBR=piman Bug: 146070 Change-Id: I7b1c86f821b86485c571d5b97e0e22f04705d99a Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/848354Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Invalid input should be thrown out not cause a crash of the browser. BUG=772626 Change-Id: I26128ff4491987cb6798f7f0f0078102c44dca43 Reviewed-on: https://chromium-review.googlesource.com/847305Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#526745}
-
Xianzhu Wang authored
I'm investigating the flakiness. According blink-dev discussion we should skip flaky tests instead of marking them flaky. Bug: 798116 Change-Id: I9d2fcf31ab2475169c97108bc0d2c02c242c7658 TBR: battre@chromium.org Reviewed-on: https://chromium-review.googlesource.com/848274Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526744}
-
Rouslan Solomakhin authored
Bug: 792961 Change-Id: I9643f51f355711af731e2e77021d50598099327c Reviewed-on: https://chromium-review.googlesource.com/849152Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526743}
-
