- 08 Apr, 2020 40 commits
-
-
David Van Cleve authored
At a fundamental level, TrustTokenStore requires that all of its url::Origin arguments have unique serializations, in order to key persistent state by their serializations. It currently enforces this by requiring that all of its operations' origin parameters be non-opaque and either HTTP or HTTPS. SuitableTrustTokenOrigin is a url::Origin wrapper encoding slightly stricter preconditions (IsPotentiallyTrustworthy and HTTP or HTTPS) under which an origin is suitable for use in a Trust Tokens operation. This change modifies TrustTokenStore's interface to take SuitableTrustTokenOrigins rather than url::Origins. SuitableTrustTokenOrigin's properties are not exactly the same as what TrustTokenStore needs to require in order to satisfy its contract (put in state keyed to an origin, get out state corresponding to the same origin), but all use of the store is expected to be of origins that satisfy SuitableTrustTokenOrigin's requirements, so the difference between the preconditions it enforces and TrustTokenStore's current interface seems mostly academic. This change makes the interface much simpler (not to mention safer) as preconditions can now be enforced implicitly rather than through method comments and DCHECKs. R=csharrison Bug: 1042962 Change-Id: I38db356efe0d85f76662d814ee973c0e2a5c9349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134598 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757577}
-
Evan Stade authored
Bug: 1025622 Change-Id: I3a704f734cb8c69bb5fc2ce14b0ac6ce71c630d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135898Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#757576}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/e998a6b46ddd..56e977406c83 git log e998a6b46ddd..56e977406c83 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 jophba@chromium.org Change mixin name from jessie to stretch 2020-04-08 jophba@chromium.org Move from jessie to strech 2020-04-08 jophba@chromium.org Add jessie mixin to arm64_debug trybot Created with: gclient setdep -r src/third_party/openscreen/src@56e977406c83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I741e3540a16587b8a50c9afce3e0f79fc6078297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757575}
-
Yu Han authored
Prior to this CL, the ordering of the manually assigned nodes is not preserved. Nodes were assigned in tree-order. In addition, assignment is not absolute. A slotable node can be assign to multiple slots, and where it appears is when the assigned slot first appear in a tree-order traversal, not the last slot the node is assigned to. This CL does two things. One, the order of manually assigned node is preserved. Two, assignment is absolute. The implementation uses a HeapHashMap, candidate_assigned_slot_map_, to keep track of assignment node -> slot. It uses this map during node assignment to find if another assigned slot exists. When found, the node is removed from the previously assigned slot. Preserving the ordering of manually assigned nodes is done in HTMLSlotElement::UpdateManuallyAssignedNodesOrdering(). This is called at the end of SlotAssignment::RecalcAssignment(). RecalcAssignment() walks the ShadowHost's children in tree-order, so the assigned node could be out of order from how these nodes were assigned. I thought about making a separate function for manually assigned nodes, looping though assigned nodes instead. But I decided against it at this point due to the complexity of the recalc function. For Reference: point 1 in this comment is addressed by this CL. https://github.com/whatwg/html/issues/3534#issuecomment-537802687 Bug: 869308 Change-Id: Idc45cb593313b00f13cd5f29df8972bfe246ecce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103403Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757574}
-
Sahir Vellani authored
With this feature enabled, the following changes will be in effect: 1) ResizeObserverSize inteface will be exposed 2) Content box, border box, and device pixel border box can be observed by the resize observer Intent to Prototype and Ship: groups.google.com/a/chromium.org/d/msg/blink-dev/_j6K_xSxWj0/fbn4kzx9AgAJ Bug: 1027684 Change-Id: Iea04bbfd24ad6508dad04bc8bb218709926cb6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138117Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757573}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ac1817c5d036..237b8541c13f git log ac1817c5d036..237b8541c13f --date=short --first-parent --format='%ad %ae %s' 2020-04-08 kahinds@microsoft.com Fix color contrast for string, symbol, and regex object values 2020-04-08 tvanderlippe@chromium.org Use typescript-eslint parser for localizability pipeline Created with: gclient setdep -r src/third_party/devtools-frontend/src@237b8541c13f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ife4b7a1900ad4b123f7ad5efcc2540f214ccaa76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142477Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757572}
-
Sergey Ulanov authored
Removed test-only methods from CastRunner, WebContentRunner and CastComponent that were previously used in cast_runner_integration_tests. 1. Removed CastRunner and WebContentRunner constructors that take web.Context. Now context is always created in WebContentRunner. 2. Removed test-only methods. 3. Updated TestComponentContext to allow initialization with all services cloned from /svc. The tests now inject a script into the frame in order to test functionality that was previously tested with the test-only methods. Bug: 1062351 Change-Id: I169651b68e0e9344d3450371db1485d9046c5c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135154 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#757571}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I76305d78e09b70a7a1f8be1b503137362a47e2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142472Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#757570}
-
Tina Wang authored
- Edit policy_templates.json to enable the policy on ios. - Add EGtest to verify that the policy sets the pref properly. - Encapsulate a helper function to verify bool type policy in EGtest. Bug: 1065143 Change-Id: I75b240a0f14dedf25819d0fd6160de999325cdbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138291 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757569}
-
garykac authored
This needs to move to a shared location so that the same code can be used by the Chromoting host. Change-Id: If860352ef8583d47f268d5cb5b964e3c7f0a2f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141214Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#757568}
-
Sujie Zhu authored
Add a private method NicknameAndLastFourDigits to return "Nickname ****1234" string and introduce HasValidNickname function to check whether the nickname is valid. Also introduce experiment flag and expose public method NicknameOrNetworkAndLastFourDigits(), it will return "Nickname ****1234" when experiment flag is on && nickname is valid and return "Network ****1234" when disabled or invalid nickname. Follow up will be update the credit card suggestion value/label using NicknameOrNetworkAndLastFourDigits(). Bug: 1059087 Change-Id: I92603d1ca8c4113dbafba017677b09c27b7010d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138154 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#757567}
-
Lily Chen authored
Bug: 1068792 Change-Id: I47df5c385a7b5fc67cca14ac92a94b2d1ceb32c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141142Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#757566}
-
Chris Lu authored
This change will allow Voice search to have access to a Browser in preparation for classes to be Browser-scoped. Bug: 790886 Change-Id: Ib80e432e1a84df0c868bcf5b12d4c98138028695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138169 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757565}
-
sauski authored
This reland adjusts the PrivacyPageTests cleanup function to ensure all tests start with a default route of chrome://settings/ Original change's description: > Ensure cookie_controls_mode is set with block_third_party_cookies > > To ensure that the two related preferences, cookie_controls_mode and > block_third_party_cookies remain in a consistent state, this CL updates > the existing block_third_party_cookies toggle located in settings > to update both preferences. > > Bug: 1068144 > Change-Id: Ia64cb37c766a3143c6ac986efc67e87283852a8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134261 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> > Cr-Commit-Position: refs/heads/master@{#757019} Bug: 1068144 Change-Id: Icfe851c8e0300f328e5441393ec3cc4aa8113def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141912Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#757564}
-
Peter Kotwicz authored
This CL makes home screen shortcuts and WebAPKs use CustomTabNightModeStateController as part of the WebAPK/TWA unification effort. BUG=1067105 Change-Id: Ifd6f06825a3a8ac4610ec4b0a53dfaf3941d98be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133379 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#757563}
-
Andrew Grieve authored
Although proguard is run in release, incremental install always uses the debug dex files, and we so we don't bother running proguard. This elimnates a FileNotFound log message when launching an apk that was build with is_java_debug=false incremental_install=true Change-Id: I5a955ca2b076ebd1bc0f13a28191b72364603ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142633 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757562}
-
Shengfa Lin authored
Modify session_commands Get/Set Window Position/Size to use Get/Set WindowRect from chrome Combine getWindowSize and getWindowPosition to getWindowRect. Change window_commands::ExecuteGetWindowRect to use it instead. Change-Id: Ifcc70bfaaab6c89908e404bac03decb8a6adacd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141612 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757561}
-
Piotr Bialecki authored
Other changes: - rename anchor and plane pose in mojo to mojo_from_xxxxxx to match convention - adjust samples to account for the possibility that anchors and planes can have their poses unknown - send null poses from device if tracking is paused - ARCore device now does not treat planes and anchors whose tracking is paused as removed - add DVLOGs all around to help with issue investigation - add test page for experiments with local space stability & drift Note: the test mentioned above is not exposed via proposals/index.html. Change-Id: I786e86d69b69badbace57ce62585e3d5fd1ae756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130778Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#757560}
-
Kyle Horimoto authored
This reverts commit 3e252473. Reason for revert: Original CL did not cause the flake; flake was fixed in separate CL: https://chromium-review.googlesource.com/c/chromium/src/+/2141113 Original change's description: > Revert "[CrOS settings] Fix printing new route in settings page" > > This reverts commit 4c027362. > > Reason for revert: Potentially breaking https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4672 > > Original change's description: > > [CrOS settings] Fix printing new route in settings page > > > > https://chromium-review.googlesource.com/c/chromium/src/+/2126332 > > Changes the routes to printing pages in settings. os_printing_page has a > > route that was missed. This CL updates the route in > > os_printing_page.html to match the new route, from /printing to > > osPrinting. > > > > Fix: 1068322 > > Change-Id: I2e9095ff805d2f94bf4c520717d3290fab912807 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138632 > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: jimmy gong <jimmyxgong@chromium.org> > > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > > Cr-Commit-Position: refs/heads/master@{#756949} > > TBR=khorimoto@chromium.org,jimmyxgong@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com > > Change-Id: I50d29f93d85233a198f62baec0e65b4c5eda9b4f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139172 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756973} TBR=khorimoto@chromium.org,jimmyxgong@chromium.org,hsuregan@chromium.org,melzhang@chromium.org,tjohnsonkanu@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Fixed: 1068322 Change-Id: I25cee2d65483a5a48b70d80c0469b6058d298f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142137 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#757559}
-
Jan Krcal authored
This CL deletes dead code and thus prepares the ground for removing code for favicon sync. Because of these future plans some sync-related unit tests (that used this dead code) are simply removed instead of keeping the dead functions and marking them ForTest. Bug: 978775 Change-Id: I05f4b00a354cfd3f8528d6899761592ec76c5bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142114Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#757558}
-
Guido Urdaneta authored
This test verifies that both key and delta frames are sent and received. Bug: 1068468 Change-Id: Idef4a4769de436504eef0e3e1709f6b6f7787a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142266Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#757557}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/475c8941a1ee..5d56a75005e3 git log 475c8941a1ee..5d56a75005e3 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 bsheedy@chromium.org [Telemetry] Fix GetFile quoting Created with: gclient setdep -r src/third_party/catapult@5d56a75005e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055225 Tbr: eseckler@google.com Change-Id: Ib1b9ae59096c0d903ff7630ade1de0c48c3be178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142475Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757556}
-
Mugdha Lakhani authored
This gets ChromeSecurityStateModelDelegate through ChromePageInfoClient, thus removing the need for (Chrome)SecurityStateModelDelegate.java. All references to the above have been removed. This goes towards removing chrome:// deps from PageInfoController.java so it can be componentized. Bug: 1052375 Change-Id: Ib254f9b9a7f274dc8da11095bfbd48d1bee362ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134305 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#757555}
-
Aaron Leventhal authored
Bug: None Change-Id: I561ffe518dbd54a896a99e3d97bc0e03b919589e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140099 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#757554}
-
Garrett Beaty authored
The following changes were made to the console ordering: * The windows debug category appear before the windows release category, which matches the order for the other OS categories in the console. Bug: 1067057 Change-Id: I34e4ce8196742587a401019ef526a98ee8bfc0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140068 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#757553}
-
Charlie Hu authored
This CL lets DocumentPolicyParser::Parse return early when the input is empty. This avoids initializing static maps when there is actually no need to initialize them. Change-Id: I2ac3b7c6e9995c35fef97e76bc4969e236b6b6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140199Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#757552}
-
Stephen McGruer authored
This was resolved in https://github.com/web-platform-tests/wpt/pull/21641 Bug: 1049607 Change-Id: I20aace27d2637d62a3433140697fc7a8b5a4071a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046714Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#757551}
-
Wei-Yin Chen (陳威尹) authored
When needing to use waitForView() on the whole view hierarchy, the API of waitForView() requires more boilerplate code than ideal. This CL makes it possible to write shorter code. Bug: None Change-Id: Ic97f67df1e833a2c38a5a7e09133170e79910b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138964Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757550}
-
Rayan Kanso authored
Moves the generic web tests to the wpt folder. Minor changes were made to them (using wpt resources, not checking for specific error messages). The tests that were checking for specific chromium error messages were duplicated and kept. As were tests using testRunner functions. Change-Id: I79d1d3c5cf2092753ef7b0bfbbfa7b227395f8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142214Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#757549}
-
Wez authored
Fuchsia's package cache not longer makes non-base-image packages available unless the device/VM is online, with connectivity to the package server. Keep the Target's Amber repository live while the test runs, to work around that limitation. Bug: fuchsia:49704, fuchsia:44527, fuchsia:44529 Change-Id: I9aadf6823634d04bc292c80fac86cc9b7da5e0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142412 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#757548}
-
Xianzhu Wang authored
Update canvas filter quality when recording the foreign layer. Change-Id: I7a5ae65eb45664718be6bf56ff80c6057b1bca28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141611 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757547}
-
Peter Kotwicz authored
BUG=1068692 R=hartmanng TBR=yfriedman (for trivial LaunchMetrics.java change) Change-Id: I747d76539830241f2175c83c458b439c9ab74065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141122 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757546}
-
Bo Liu authored
In-process GPU has lower stability guarantees as it cannot be restarted. It does not have a watchdog timer. Establish channel timeout is not useful as it's only waiting for a thread to start and do work. So it can really only trigger for false positives. So disable the timeout for in-process GPU. Bug: 1068670 Change-Id: I047e07c29d74e8b68a8bcf2ecdb333f066c377fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140818Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757545}
-
Xiaoqian Dai authored
In rtl, the user needs to swipe from the right side of the screen to go back. Bug: 1031766 Change-Id: I732992fa7f7546358c42e75deb2f5244ededb81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140997Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#757544}
-
Ayu Ishii authored
This change adds behavior for opaque origins specified here [1], and wpt to validate its behavior. [1] https://wicg.github.io/cookie-store/#CookieStore-get Change-Id: Id947c964910857ba85dffdc6d7c1e45ef8b49029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137926 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#757543}
-
David Bokan authored
If we're at an offset that can't be represented at an int then the page probably isn't usable but it's better to saturate than overflow here. Bug: 1068200 Change-Id: I07afcf9b0486fac3311c0a128a1932b768b69d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137827 Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757542}
-
Brian Geffon authored
This change allows core scheduling to be turned on when renderers start and before entering the sandbox. By doing it before entering the sandbox it cannot be disabled. There is a flag we can use to disable this if necessary via a finch kill switch should bugs in the kernel be encountered. BUG=b:152605392 Change-Id: I0f3b81a03eac2e3603bff8514e0c58e0d4e286c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140066Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#757541}
-
Wei-Yin Chen (陳威尹) authored
Reuse a single string literal for Finch parameter "thumbnail_aspect_ratio", so that it's easier to cross reference. Bug: None Change-Id: Iff9434ec4b3d759f40d40b799ec0a3c27f8c33c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139431 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757540}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a5187a88958..3150d88ba4ca git log 6a5187a88958..3150d88ba4ca --date=short --first-parent --format='%ad %ae %s' 2020-04-08 mtklein@google.com add Pixel CPU Test jobs 2020-04-08 egdaniel@google.com Update gpu flush semaphore contract. 2020-04-08 senorblanco@chromium.org Dawn: staging manager rewrite. 2020-04-08 fmalita@chromium.org [SVG] Fix spec links 2020-04-08 mtklein@google.com stifle leaks in terminator_CreateDevice() 2020-04-08 mtklein@google.com get skvm/llvm building again 2020-04-08 mtklein@google.com narrow use of fast_unwind_on_malloc=0 2020-04-08 mtklein@google.com shard ASAN bonusconfigs bot 2020-04-08 jvanverth@google.com Use fuzzier definition of zero-length segments in compute_intersection. Created with: gclient setdep -r src/third_party/skia@3150d88ba4ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Id362a0f080c0c8fa7965eba71e557cdfdd7875fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142479Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757539}
-
Nnamdi Theodore Johnson-Kanu authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/2128928 changed the route path name and route constant from kAccessibilitySubPage to kOsAccessibilitySubPage. This change caused the settings tray to not route to the appropriate location. This CL corrects that issue, updating the system_tray_client.cc to point to the right constant name. Bug: 1068971 Change-Id: Ia42ce2d197eb04a4a8a2076defdfd84c81485b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142142Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#757538}
-