- 08 Oct, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8389aa11092..eacaa9a164a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com,olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131415 Tbr: tluk@google.com,olka@google.com Change-Id: I6b37a942f7856d4ee8b80e6016d9f05c759a1136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461956Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815182}
-
Corentin Wallez authored
SPVC has been removed from Dawn and that flag is now a noop. Bug: dawn:521 Change-Id: I52d2887b373c22376f9cd0664e4b6740299a9bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461330 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#815181}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010080700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/ccPNzyZsy8IYqEUjkXTCupUsZ6yj49ysyBQKh1jDG28C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Id8997478c137f45830be0488c86ae642b93b13f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461405Reviewed-by:
-
Stepan Khapugin authored
Original CL by marq: crrev/2424125 - Adds a cleanup step to EarlGreyTestCase that closes all but one window. - Adds test utilities for closing all (but one) windows, counting windows, and waiting for a specific window count. - Adds a test utility to check for multiple window support. - Adds a simple test of the tools menu "New Window" item. - Updates & reenables the history and bookmarks EG tests to wait for a window count (and to skip the tab-closing step, which wouldn't have closed the window in any case). Bug: 1126893 Change-Id: Id6b3ab02058e0db036045b0653a716fe19271b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450096 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#815179}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9fb07662e436..31b44b3a70ed 2020-10-08 fmayer@google.com Improve docs about runtime signalling. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifea0db3c1d6058c50bc71eff79521bc553ddc2f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815178}
-
Gauthier Ambard authored
This CL makes sure that the correct URL (i.e. the one of the page that created the error) is used instead of the error page file URL. To do this, this CL uses IsLoadingErrorPage with the new error page workflow. It allows to have the URL of the loaded page (not the URL of the error page) and having the navigation marked as being a navigation to an error page. Then the callbacks can act on it. The main difference with the non-JS workflow is the back-forward navigation. Because the URL of the page is the URL of the file page that is displaying the error, we need to mark the navigation as a error page navigation. Then the navigation to the real page starts, and it is a new context so it is no longer an error page navigation. Bug: 991608 Change-Id: I4362d1cc50262ea86db1e211bfaec619f008625e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449391Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815177}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/28ae1471bf2c..66377ce9be54 2020-10-08 dj2@everburning.com Add Inspector to doc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: kainino@google.com Change-Id: I154fe365544f11cd9a59070175ef325564c642e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461915Reviewed-by:
-
Kushagra Sinha authored
Add a Mojo interface - AccountManagerObserver - for ash-chrome to send account update notifications to lacros-chrome. Bug: 1117478 Test: unit_tests --gtest_filter="*AccountManagerAshTest*" Change-Id: I986676d3a635bdc3e50abd9d7489ea0645c2286d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453259 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#815175}
-
Jesse McKenna authored
This change removes an unused variable from UpdatePlatformShortcuts(). It also removes a stray whitespace. Change-Id: Ib2fa8cf9b87bd4971c5da6e07d7916db4009040f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459065Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#815174}
-
Gang Wu authored
Lets custom view binders check if their sub view needs to be highlighted. This CL needs to be merged to M87 because the CL caused this bug is in M87.(put R.id.downloads_menu_id into a submenu.) https://chromium-review.googlesource.com/c/chromium/src/+/2420256 There is also an issue with ChipView, but since ChipView in AppMenu will be enabled in M88, so we will fix it later. Bug: 1133105 Change-Id: I7cce43ff0a2c5ce32222141d54ae8ece09bfc3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458447Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815173}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I25928585781ed1f89fc0048846c6cd4c7e48e889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456028 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#815172}
-
arthursonzogni authored
Adopt the common convention: * kNone => The strictest policy. * kAll => The laxest policy. * kScripts => Allow nothing except script execution. * The laxest policy stricter than A and B => A & B. * The strictest policy laxer than A and B => A | B. E.g. (1s == disallowed, 0s == allowed) There were some parts using the complementary convention where (1s == allowed, 0s = disallowed). This patch removes them. Bug: 1135586 Change-Id: I2bbdbdf7fb506d3345a9e4227b0f9b8c8d4cc738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454654 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#815171}
-
Edward Lesmes authored
Metadata is moved from the OWNERS file into the new DIR_METADATA file. R=grt@chromium.org Bug: 1113033 Change-Id: I9becaddab5bf49486fed4eaa3cb0d21d8727e902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454691 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#815170}
-
Peter Kotwicz authored
This CL adds tests to monochrome_apk_checker checking that: - <uses-library> is not in the MonochromePublic.apk's AndroidManifest.xml - MonochromePublic.apk does not call into org.apache.http BUG=1115604 Change-Id: I295a97022f146c66ccd78eee6f54640a344e2589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462035 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#815169}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d43858ed21a..6a204db32c49 2020-10-08 brianosman@google.com Change interface block's fVariable from ref to pointer 2020-10-08 ethannicholas@google.com moved SkSL Ternary data into IRNode 2020-10-08 ethannicholas@google.com moved SkSL If data into IRNode 2020-10-08 ethannicholas@google.com changed various SkSL structs into classes 2020-10-08 johnstiles@google.com Remove dedicated name from SymbolTable entries. 2020-10-08 robertphillips@google.com Add HW-filtered masks to thread-safe cache 2020-10-08 kjlubick@google.com [canvaskit] Update npm to 0.19.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: jvanverth@google.com Change-Id: Id23ccede5a1fe460e63b9ae8d452faa07300c1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461401Reviewed-by:
-
Seokho Song authored
ScrollableArea with Preserves3D context should be painted in PaintInGraphicsLayer. But currently, it doesn't. Therefore, In this patch, ComputeBackgroundPaintLocationIfComposited will check parent's Preserves3D styles and if it is, The function returns kBackgroundPaintInGraphicsLayer. Change-Id: I7fb2b283e0992b8825e95e08ef718bd0e056858c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434016 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815167}
-
Ramin Halavati authored
Startup browser creator is updated to support ephemeral Guest profiles. Ephemeral Guest profiles are not off-the-record and will deprecate OTR Guest profiles. This change is behind disabled EnableEphemeralGuestProfilesOnDesktop flag. Please see go/guest-on-disk for more context. Bug: 1125474 Change-Id: I7af1cbf8e799e7387a6a96ca018bc772009d1205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449335 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#815166}
-
Andrew Grieve authored
The stored .apks files no longer contain language splits. Bug: None Change-Id: Ia7a21f3e19510080e95926b960a8e0be46f5295d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459697 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#815165}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010080700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/BzVQGnSCwNeprjjkFkqzj_GZUxAVI1K5DBja9inASBwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/158515526,b/169021817,b/169624582 Tbr: media-app@grotations.appspotmail.com Change-Id: I5ee09fe2c774334ed4bbf723549bcdf686fe1724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461402Reviewed-by:
-
Aaron Leventhal authored
No need to update layout if we're just checking if the doc is loaded. R=dmazzoni@chromium.org Bug: 1134597 Change-Id: I27b2a81ada534e614318885387c704fe64799152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459172 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#815163}
-
zhaoyangli authored
Removed unnecessary functions. Re-formatted incorrect code format after removing EG1 & EG2 macros. Addressed unresolved comments from crrev/c/2433584, except for header removals. Bug: 1102995 Change-Id: Id16bc6ba05f4a13d0debc866264bbead7accb582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454294Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815162}
-
Olivier Robin authored
When Protected data is not available, access NSUserDefault can freeze the application. Pause all the data collection based on notifications on that period. Bug: 1129779 Change-Id: I2d304e410b2e2068b71ab3363e548e43e66b973c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454088Reviewed-by:
-
Dominic Mazzoni authored
This is a quick fix to merge. I'm going to follow up with a patch to explore the underlying cause. Bug: 1135103 Change-Id: I7f5f7a63b34e7391873755f0917ac6b971e8b0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459008Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#815160}
-
Fabio Rocha authored
Remove scoped feature list from PendingAppInstallTaskTest in pending_app_install_task_unittest.cc, now that kDesktopPWAsWithoutExtensions is always true. Bug: 1065748 Change-Id: I8ba6afa8f1d3e33133175e37a9a9dfc72f93f406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459189Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815159}
-
Maksim Moskvitin authored
New class wraps network logic and allows sending GET and POST requests, indicating that both request and response content types should be serialized protobufs. Bug: 1113598 Change-Id: Iccb65cd734025bde6df7bf927698d90d19b5b0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404796Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#815158}
-
Fabio Rocha authored
Remove scoped feature list from WebAppIconManagerBrowserTest in web_app_icon_manager_browsertest.cc, now that kDesktopPWAsWithoutExtensions is always true. Bug: 1065748 Change-Id: I49fb16c4c4b3fbcdc791654cff60912fb848c3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459806Reviewed-by:
-
Fabio Rocha authored
Remove scoped feature list from SystemWebAppManagerTest in system_web_app_manager_unittest.cc, now that kDesktopPWAsWithoutExtensions is always true. Bug: 1065748 Change-Id: Ibf6dc5e53a5ea1a6c37d479a2f17d5efafc8fd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459687Reviewed-by:
-
Mohammad Refaat authored
Also make sure that the restore prompt doesn't show if the user already restored. Bug: 1136307 Change-Id: I733202c348923224c20d5e8728cbab9cd21466d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459804 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Ghazale Hosseinabadi authored
This CL fixes the flakiness of DeveloperPrivateApiTest. InspectInactiveServiceWorkerBackground. Bug: 1134506 Change-Id: Iaba317d3995da20fda2548b00da6579db4b91059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458107Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#815154}
-
Mugdha Lakhani authored
Bug: 1087486, 1091211 Change-Id: I9c4ed3d09cce8c9e4fc7e708f1c94b990d8e93af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454169Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#815153}
-
Mohammad Refaat authored
This fixes the problem when crash happens as there is no active webstate when the new window opens. Also this is consistent with the behavior of single window/multi-window when we don't show the restore prompt when there is external intent (opening chrome from another app with url parameter). Bug: 1135459 Change-Id: Ia979db92f3d938f57a7b7a5f4821075a82b396fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454250 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
sandromaggi authored
Refactors the |WebController::GetOuterHtml| to take an |ElementFinder:: Result| instead of a |Selector|. Also adds UT for the action. Bug: b/168107066 Change-Id: Ie5d9688e2c1389bbb9d7a9bff0f8c38b145a88aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455346 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#815151}
-
Torne (Richard Coles) authored
When referring to Android surface objects, use a JavaRef instead of a bare jobject, to make sure we manage reference lifetimes correctly. This changes the following interfaces: - ScopedJavaSurface::AcquireExternalSurface - GpuSurfaceTracker::SurfaceRecord::SurfaceRecord - Compositor::SetSurface Most of the callers of these functions already had JavaParamRef objects and were relying on the implicit conversion to jobject, which is no longer necessary with this change; the remaining callers have been updated. Change-Id: Ic667ad98974bbe8b0674afbce3c0eb6072001468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453270Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#815150}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I0335dc8f0094b8b8bf6c6ef68c668cdcdb00ddd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457546 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
David Bienvenu authored
Also some lint fixes and other cleanup; no functional changes Bug: 1010217 Change-Id: Ia41657b7e1892056074ba6a21488b78e4ddc65da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459062 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#815148}
-
Alex Rudenko authored
ClearInspectTool was not clearing inspect_tool_ in the expected order (DisableFrameOverlay checks inspect_tool_ via IsVisible method), thus, breaking hideHighlight functionality. This was broken in https://crrev.com/c/2397735 Fixed: 1136455 Change-Id: I97dc444cffee98cb41a8ac8285f4e7d0cc797715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460732 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#815147}
-
Tanmoy Mollik authored
Bookmark is not loaded in default maxout time which is 3 seconds. Increasing it to 4 seconds in order to check if the crash persists. Bug: 1133426 Change-Id: If4fcc9230803c781adff4ba88db36038bfcc11e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456111Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#815146}
-
Bruce Dawson authored
The reason for the timeouts on this test are believed to be understood and resolved in crrev.com/c/2209755 so it's time to try reenabling the test. Bug: 974787 Change-Id: I17e587da4446beb352ceeeac09d7fd1e0cfb5f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459788 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#815145}
-
Eric Willigers authored
Calls like https_server()->GetURL("app.com", "/ssl/google.html") generate GURL values. We now store such values by value instead of by reference. Bug: 1136278 Change-Id: I1267e9bdf77c062d1ae83c6dc231dc4dc3b7da6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459546Reviewed-by:Caroline Rising <corising@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815144}
-
Olga Sharonova authored
[sheriff] Disable flaky RenderWidgetHostViewChildFrameBrowserTest.VisualPropertiesPropagation_RootWindowSegments on Mac and Linux TBR=acolwell@chromium.org Bug: 1089994 Change-Id: Ic20c5e88c3f2b3b0df1c39cbf981ab787c9ef7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461329Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#815143}
-
