- 05 Nov, 2019 40 commits
-
-
Sammie Quon authored
This cl makes WindowCycleItemVIew inherit WindowMiniview. Also moved OverviewCloseButton to OverviewItemView. Makes WindowMiniView no longer a button. This required some accessibility changes - OverviewItems are now considered windows, which I think is more suitable than Button. TBR=aboxhall@chromium.org Test: manual, ash_unittests Bug: 1017912 Change-Id: Ia2b50e5b874b8db8ff4b335f38ab7a03710e3756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880956 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#712642}
-
Mitsuru Oshima authored
* It observes widget's destruction instead of observing compositor's in CompositorChecker. This allow CAR to continue running even if the widget's compositor changes. * Re-enable on chromeos Bug: 1019536 Test: Covered by unittests. Change-Id: Ia3a3201408b93d70b98339e79b7e9ffd6db22e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890493Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#712641}
-
Bailey Berro authored
crrev.com/c/1893511 fixes the regression in this test caused by crrev.com/c/1774637. Test: Verified locally Bug: 1006101 Change-Id: I2fd04f03a2a11af65a0a8cbeaca17b3d322fc21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898332 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#712640}
-
Martin Kreichgauer authored
Changes the fingeprint enrollment dialog on the security keys settings subpage to iron-announce upon successful completion of a fingerprint enrollment. Bug: 974046 Change-Id: I61e4fc17d55bd16d2de299084586ec078829acc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898433Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#712639}
-
Peter K. Lee authored
Some EG tests use TestChromeBrowserState and they need blocking IO in some scopes. Bug: 1020027 Change-Id: I7766071a724967860cffe4139f00bd3f5bb2dcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898539 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#712638}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0da64443b6c7..51a6086ce618 git log 0da64443b6c7..51a6086ce618 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 rsavitski@google.com Merge "Bump googletest version to match external/googletest in aosp" Created with: gclient setdep -r src/third_party/perfetto@51a6086ce618 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I9a3a27fa64b7e22e2cad989c9a4e821acfe0f323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712637}
-
Martin Kreichgauer authored
Also reorder the fingerprint enrollment and reset items on the security keys settings subpage. Bug: 974046 Change-Id: Ia2b3deb6ceb5ab57f06e555216d007f52b130571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894483Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#712636}
-
Marc Treib authored
It seems that signin::MakeAccountAvailableWithCookies, previously used by these tests, doesn't reliably make an unconsented primary account available. This CL changes the ProfileMenuClickTests to use helpers from secondary_account_helper:: instead, since several other browser tests use these and seem to be fine. If this resolves the flakiness, a followup item is to investigate what the relevant difference is between these helpers. Bug: 1015429 Change-Id: I2be36f30e08827911e7492fd69a6d531563eed34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899871Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#712635}
-
Connie Wan authored
We've gotten enough feedback on this that PM and UX have suggested that we remove this behavior. This change removes the groups that are magically created when the user opens a new tab via a link. Tabs opened from an already-grouped tab will still be opened within that group. Bug: 997344 Change-Id: Iad1ede15edc06356db9728bbcf5e4f59a4eae207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898620Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#712634}
-
Antonio Gomes authored
... left over of https://crrev.com/c/1884931. BUG=787254, 919392 R=haraken@chromium.org Change-Id: I5742b6938342e25583108b6bc70964b4bbd07a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899787 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712633}
-
Philipp Hancke authored
The code for generating the DTLS 1.0 deprecation warning is in the wrong method which is not called when the transport gets connected. Moves the code to the internal state change event and fixes punctuation in the warning. This can be tested with a peer that creates the OpenSSL context with the DTLS_method() and then does SSL_CTX_set_options(ctx, SSL_OP_NO_TLSv1_2) to disabled DTLS 1.2. Bug: webrtc:10261 Change-Id: Ib11851b7a104e4d3b6ba77eeb78bed3f1c4d0588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894006Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#712632}
-
Denis Kuznetsov authored
Bug: 893934,955194 Change-Id: Ie97de2f2034f2169c5c473a55c7a88388e6ae725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872056Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712631}
-
Takumi Fujimoto authored
Add CastMediaNotificationProvider, which is responsible for providing MediaToolbarButtonController with notification items for Cast, which are represented by the CastMediaNotificationItem class. MediaToolbarButtonController::MediaRoutesObserver has been merged into CastMediaNotificationProvider. Bug: 987479 Change-Id: I258674c6d5541a581e79f4d91d2568c239931be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888533Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#712630}
-
Tim van der Lippe authored
Bug: 1011466 Change-Id: I1187389e33f3bf97a51ed27f09d0e5a57b0f7831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899504 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712629}
-
Michael Lippautz authored
This patch unifies weak and strong handling of ephemerons and adds support for "reverse" ephemerons (strong key w/ weak value) to the heap snapshot. It also removes dependencies on Trait::kWeakHandlingFlag in ephemeron tracing. Bug: 1019191 Change-Id: Ic3429a6fb45663ab7fe3c59790a72384066a1892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897834 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712628}
-
Slav Ishutin authored
This CL allows using protoc_convert with cross-compilation. Change-Id: I20dd15a3ac56bed6deee2c66d0f09c2b9982c156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898070Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712627}
-
Leszek Swirski authored
Use the StreamedSource constructor taking a unique_ptr<SourceStream> rather than the raw pointer version, which is less clear about ownership and so is deprecated. Change-Id: I8d95d8049b60925ea11f16249ba18ba5044908d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899848 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712626}
-
Joshua Pawlicki authored
TBR=rbpotter@chromium.org Bug: 1021545 Change-Id: I50c82dbae1ba6ebc08fcbbfa478b2d15bbe126bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899308Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712625}
-
Livvie Lin authored
Follow-up to crrev.com/c/1793260. Bug: 1017406 Change-Id: Ic7823f6a630d0cd4cbd7e64d0999b81d964b9129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894043Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712624}
-
Andrew Luo authored
Test: Upload to gerrit > open file > click "gitiles" Change-Id: I57a31e628e7aca2f73031603765b84ab88bcc4f9 Bug: 918221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894102 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712623}
-
Joshua Pawlicki authored
TBR=afakhry@chromium.org Bug: 1021553 Change-Id: I6d6170beb77d08da192d24e7ebb7246a83926a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899334Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712622}
-
Sorin Jianu authored
This is a reland of 08aba315 Original change's description: > Register the updater app id in registry (Windows). > > Send both the updater and Chrome app ids in the "update apps" use case. > With this change, --install and --ua commands work as expected, meaning > the app ids and the versions are sent during update checks. > > There is a edge case, not handled currently, where the app id for > the updater is not available until the first update check has happened. > This is going to be resolved in a future CL which lands as part of > fixing this CR bug. > > R=waffles > > Bug: 1020285 > Change-Id: I2856a795ed61f590f85d792e4d5e1493bd23b84f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894833 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712315} Bug: 1020285 Change-Id: I697899571376170de6b70b547a04b56fbd4a7647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898810Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712621}
-
Joshua Pawlicki authored
This reverts commit b0985684. Reason for revert: Speculative revert. Suspect this is causing renderer crashes for webaudio/AudioBuffer/huge-buffer.html webaudio/dom-exceptions.html https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/58083 Original change's description: > [arraybuffer] Switch backing store from DataHandle to v8::BackingStore > > With this CL we finally use v8::BackingStore as the backing store > implementation of blink::ArrayBuffer. > > Changes: > * Use v8::BackingStore as the backing store for ArrayBufferContents. > * Remove ArraybufferContents::DataHolder and > ArrayBufferContents::DataHandle. > * Replace all uses of DataHolder in ArraybufferContents with uses of > v8::BackingStore. > * Replace the use of DataHandle in the V8 bindings. > * Add an exception to the presubmit check to allow std::shared_ptr in > ArrayBufferContents. It is contained there and does not escape. > > R=haraken@chromium.org, ulan@chromium.org > > Bug: chromium:1008840 > Change-Id: Iffa31e889daf4ae54de96f55b4612833d096a884 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886858 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712571} TBR=ulan@chromium.org,haraken@chromium.org,agrieve@chromium.org,ahaas@chromium.org Change-Id: I88668a9d2d582ef38ccb82f1c87139da4c74db62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1008840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899413Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712620}
-
Mark Cogan authored
Change-Id: I252546eaea91551d7a2d08f0f8290a2cb62f8278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893065 Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#712619}
-
Roman Sorokin authored
As we introduced paddings of the buttons inside oobe dialog - external overlay is not displayed properly (see bug for screenshots). Also use the overlay on the enrollment screen Fixed: 1013337, b/143346960 Test: manual on the device Change-Id: I22a1cf67c39221c378b0a5a6f0c7d5ab978287af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892963Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712618}
-
Tricia Crichton authored
Add the text of the open alert when returning UnexpectedAlertOpen. Bug: chromedriver:3184 Change-Id: Ifcd0e59c0d5d32089fca20b01b6f626ea5b4e741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898385Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#712617}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/198345898168..4c04d8e10c3c git log 198345898168..4c04d8e10c3c --date=short --no-merges --format='%ad %ae %s' 2019-11-05 mbonadei@webrtc.org Fixing autoroller/roll_deps.py. 2019-11-05 sprang@webrtc.org Reland "Refactors BitrateProber with unit types and absolute probe time." Created with: gclient setdep -r src/third_party/webrtc@4c04d8e10c3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ie50f27e666748794a698b6972133d42f7658ae22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899331Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712616}
-
Avi Drissman authored
Bug: 925323 Change-Id: I02b3d2cf43b30f4fb3a8cb6f5f23fd7387439826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894706 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712615}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a05f421623d7..6e71a5063590 git log a05f421623d7..6e71a5063590 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 perezju@chromium.org [tracing] Rename 'tir_label' to 'grouping_label'. Created with: gclient setdep -r src/third_party/catapult@6e71a5063590 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:974237 Change-Id: I8866579b93d14f47b951deb340ed6fcabaaeabf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899330Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712614}
-
Vadym Doroshenko authored
Bug: 1014583 Change-Id: I687791397584b780d46b7674abe337a0fb72d5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899780Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#712613}
-
Andrew Grieve authored
Not sure if something has changed, but it seems to work fine now even with Annotation Processors. Change-Id: I3c803c0170e883b5266726418d0980d5e23fa1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898277 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712612}
-
Maksim Moskvitin authored
FakeServer state isn't restored after pre-test, so commit error isn't set in the beginning of main test. It means that we can't assert server Nigori to have implicit passphrase type after SetupClients() call. Bug: 1021539 Change-Id: If1cae01f3c66c8f569023bd5055e3dbd2a76d3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899776Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#712611}
-
Michael van Ouwerkerk authored
Get NotificationDisplayService lazily so that browser tests can use NotificationDisplayServiceTester. Bug: 1020582 Change-Id: Ifc85c2e63e6ca1c17eb29fdbfa91624802220ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899847Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#712610}
-
Morten Stenshorne authored
A block that has zero block-size fits within zero space, so if we have exactly zero space left in a fragmentainer, the block shouldn't be pushed to the next fragmentainer. Discovered this while working on column-rule support; fast/multicol/span/triply-nested-multiocol-zero-height-inner-with-spanner.html started to fail, because we had one column more than expected. fast/multicol/transform-inside-opacity.html will regress with this change, because we're really bad at fragmenting floats, and now the poor float ended up exactly at the end of the first column (instead of (incorrectly but oh so helpfully) being pushed to the beginning of the next by its parent). Bug: 829028 Change-Id: I66d44699c44cf7e7371f196babd424a971bfd65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899769 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712609}
-
Michael Ludwig authored
This removes the constraint for all bypassed RenderPasses to have an opacity of 1 and src-over blending. As long as the inner content's blend mode is a coefficient blend mode, we can reason about how it would have combined with the implicit transparent black of the RenderPass's initial clear color. Bug: 1013735 Change-Id: I8d1849db254c4eff3f33b57f32204d6d439f0b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862662 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#712608}
-
Scott Sheehan authored
Pass |true| for |delay_initialization_until_set_client| when creating the NetworkService in-proc so that the |NetworkServiceParams| passed in |SetClient| are honored. Change-Id: I4869ec227b2a7ed9d9fa07d74b2e45a2e962ef66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897490Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Scott Sheehan <ssheehan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712607}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dab93995. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 1b0a991d "Force error page to be classified as cross-document." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I68a95b2f4e679efe44e1076aea1086a94e49a159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898184Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712606}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb9146ffc7fc..cfa4f60270cf git log fb9146ffc7fc..cfa4f60270cf --date=short --no-merges --format='%ad %ae %s' 2019-11-05 mtklein@google.com simpler uniforms() api Created with: gclient setdep -r src/third_party/skia@cfa4f60270cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I545414e608b963bade2f8f94e271032227b1373a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712605}
-
Colin Blundell authored
This CL whitelists the strings needed to show SSL error interstitials for non-overridable SSL errors (i.e., errors where the user is not allowed to proceed). To test: Visit badssl.com in weblayer_shell on Android, tap on "mitm-software", and test that an SSL error interstitial shows wherein the buttons are "Reload" and "Advanced", and clicking on "Advanced" does not present an option to proceed. In particular, the app should not crash :). Change-Id: I4cb8b4aa2289bc0830eaa7e035779e64e3498fb8 Binary-Size: Increase is due to translations and so cannot be avoided. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899608 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#712604}
-
Ben Kelly authored
The CacheStorageAddAllRejectsDuplicates feature was fully launched in M72 and the backing code was removed in M75. The runtime feature entry was missed in the removal of the feature code. Bug: 720919 Change-Id: Ie6d2fe0d044fe1216fb2724a6c5fdc78f9376529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895396Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#712603}
-