- 29 Jul, 2020 40 commits
-
-
Jan Wilken Dörrie authored
Following making invoke() constexpr this change also adds constexpr support to ranges::for_each. This is done by no longer dispatching to the std:: implementation, but rather implementing the loop ourselves. This change furthermore reduces the delta to C++20 by using the right return type for ranges::for_each, as well as adding an implementation of range::for_each_n. Bug: 1071094 Change-Id: Ic619f0c9926ef9c3e9fda4a67ab5e02bb5262402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325920Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#792848}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/53be1753dea9..3273521f4089 $ git log 53be1753d..3273521f4 --date=short --no-merges --format='%ad %ae %s' 2020-07-28 anujv Fix static compilation with Visual C. 2020-07-28 wl Formatting, improving comments. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: I769d982f8905adcbc18561810474204f02e8a572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327131Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792847}
-
Steven Bennetts authored
Forgot to remove the 'hr' class when moving the toggle to Advanced in the previous CL. Bug: 971704 Change-Id: I4167393fc2883dd54b86cc7f61b15973ff31d6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327271Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792846}
-
Brandon Wylie authored
Bug: 1110939 Change-Id: I036b69711124ea89b4d2c008e31997000abb475d TBR=mahmoudi@chromium.org Change-Id: I036b69711124ea89b4d2c008e31997000abb475d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326770Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792845}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I1af1d0a3e595d1bc1dc6ab380743834a71b03777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324214 Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792844}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Iced94df0bfda68ba8f04792a88dd136395621ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324900Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792843}
-
Avi Drissman authored
Because content is not used by iOS, this migrates defined(OS_MACOSX) -> defined(OS_MAC) Bug: 1105907 Change-Id: Ibf85273fea9c5566594ca00f2589b890515be6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321210 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#792842}
-
Avi Drissman authored
Because /chrome is not used by iOS, this migrates defined(OS_MACOSX) -> defined(OS_MAC) Bug: 1105907 Change-Id: Ia85816af50aced9b21492bb5b6b2ceb7c5364692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321509Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792841}
-
Sven Zheng authored
CI/CQ bot are being added and there are name conflicts. So we need to rename the fyi bot first. Bug: 1104291 Change-Id: Id36bf46a0b184e33f459195183d6f3809ff3d441 Ignore-CQ-Freeze: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321336 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#792840}
-
Peter Marshall authored
Change-Id: I25ce97dfbab621bacc5818cb4b04c1778f39513f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323290 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792839}
-
Scott Little authored
This cleanup CL changes no functionality, it just cleans up some functions in components/language/core/common/locale_util.cc to use base::StringPiece instead of std::string where needed, as well as updating the callers of these methods accordingly. This CL also moves language::ContainsSameBaseLanguage into an anonymous namespace in the single file that it's called from. Change-Id: Ia2f8be1361b976e96aba95d78c59b88697343729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316811 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#792838}
-
Adrienne Walker authored
When transactions are aborted, any get all operations should still send an error with a valid receiver. This avoids a dcheck (and probable crash later) from mojo due to passing a null receiver. Bug: 1110781 Change-Id: If142072cae93f29dc3d4c1ac388bc27a3f3939f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324525 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#792837}
-
Wei Li authored
Make MenuItemView's delegate an optional argument in its constructor so it can be default constructed. Its delegate can always be set thru the existing set_delegate() function. Also need to add a few more checks for the return delegate pointer. Bug: 1108460 Change-Id: Ie90709271c971cadccf3e13166df0c240d73dfca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321526Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#792836}
-
Michael Crouse authored
This is a reland of f672068e The tests timeout with closing the tab right after the navigation, so wait to close the tab until after the histograms are recorded. Original change's description: > [LiteVideo] Rework UKM to record on DidFinish and WCO destruction. > > This change resolves the UKM recording and ties it just to the > mainframe decision and result. It also flushes when the web contents > observer destructs. A future change will update the event on > rebuffers and consider more events for subframes. > > Bug: 1109068 > Change-Id: Iacd04920811d96c4eedd3290309a8bad93777b58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321520 > Auto-Submit: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792513} TBR=tbansal@chromium.org Bug: 1109068 Change-Id: I99b458c593ea1b430fe5f35cbd8af4554942a3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325247 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#792835}
-
Brandon Wylie authored
Bug: 1110965 Change-Id: Ieb3ef6f6d76e8dc9ce1d5a0e50e029e3378bf641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327310Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792834}
-
David Grogan authored
When a flex item is a relayout root, it gets neither the flexed nor stretched dimensions from the parent flexbox. Though this problem seems to manifest only when the flex item is a legacy layout node. This change causes a 5% regression in the change-text-css-contain perf test, even though it doesn't use flex, probably just because we test for flex-item before deciding that a node with `contain: layout size` can be a layout root. Bug: 1108675 Change-Id: Iec0d35557ebfbf3136bd66fe986ba2456e0d92ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322074Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792833}
-
Avi Drissman authored
Because /chrome is not used by iOS, this migrates defined(OS_MACOSX) -> defined(OS_MAC) Bug: 1105907 Change-Id: I96d640781fb66f8ff16129736de112025a9508ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321407 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792832}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8c02e882a3f2..4a89ed360b5f 2020-07-29 janscheffler@chromium.org [TypeScript] Migrate `front_end/source_frame` to `devtools_entrypoint` 2020-07-29 jacktfranklin@chromium.org Copy sourcemaps into resources/inspector in is_debug mode. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2fd74219fe792fd7184ded977a84af41964d156e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327390Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792831}
-
Nate Fischer authored
This adds setSafeBrowsingAllowlist (behind the DEV_SUFFIX) and deprecates the setSafeBrowsingWhitelist boundary interface. These are functionally similar, although setSafeBrowsingAllowlist accepts a Set<String> since this is a more appropriate data type. This adds an UMA counter for the new API and adds missing enum labels for other APIs. This CL also renames a couple references to the old API to be SET_SAFE_BROWSING_ALLOWLIST_DEPRECATED_NAME instead, to minimize non-inclusive terminology. Fixed: 1108667 Test: N/A Change-Id: I49ef11e4346e631e14b822943abb6482837d60a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321523 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792830}
-
Boris Sazonov authored
Removes ChromeSigninController assert from PassphraseActivityTest. This assert was verifying that addAndSignInTestAccount succeeded, which is already ensured in SigninTestUtil.signIn. Bug: 1046412 Change-Id: Ib54efe5bbe3eb7434cdea161514d48f97387562c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316083Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792829}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e5f80a2e..cdda9dfe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4820379ed64d35ffe0e1189984ef2763f0bf462e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325781Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792828}
-
Hesen Zhang authored
This reverts commit dd04950b. Reason for revert: Need to hide the query tiles internals WebUI in Incognito mode. Alternative CL: https://chromium-review.googlesource.com/c/chromium/src/+/2327374 Original change's description: > Fix crash of query tiles internals in incognito mode. > > - TileService not support incognito profile. > > Bug: 1110285 > Change-Id: Ief1c8025b74ec5df94c5e811d213a6679fd6069c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324938 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792500} TBR=dtrainor@chromium.org,qinmin@chromium.org,hesen@chromium.org Change-Id: I7126c77cc412de10f9a6af2495d408dd7153fc1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327313 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792827}
-
Ken Rockot authored
This is a reland of 596311e0 Original change's description: > [WebLayer] Use NetErrorAutoReloader > > Navigations which fail with network errors may attempt to > auto-reload in some cases, in order to more seamlessly recover > from transient failures. > > This behavior was previously implemented renderer-side and copied > verbatim from Chrome. The Chrome implementation has been moved > browser-side (see bug for why) and also made into a reusable > component. > > This changes WebLayer to use the same component implementation > and deletes all the corresponding renderer logic. > > Fixed: 1098578 > Change-Id: I10c337abcae36f64be47f31b89e36c7393989077 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311371 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792028} Tbr: mmenke@chromium.org Change-Id: I4dd0aaef47650d14c52b6b2ddcf35cee27d2ef35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324934 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#792826}
-
Sophie Chang authored
Bug: 1108610 Change-Id: I427b51c39b8b62a33ad262d8b8e21b864709bff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324995 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#792825}
-
Mike Dougherty authored
This reverts commit 1fbe4cc4. Reason for revert: Xcode 12 beta 3 takes more than 25 seconds to start loading content in WKWebView. Original change's description: > Roll bots to Xcode 12 beta 3 > > Bots rolled with the following script: > git grep -l '12a6163b' | xargs sed -i '' -e 's/12a6163b/12a8169fg/g' > > to update: > infra/config/lib/builders.star > infra/config/subprojects/chromium/master-only/ci.star > infra/config/subprojects/chromium/master-only/try.star > testing/buildbot/mixins.pyl > testing/buildbot/waterfalls.pyl > > then configs were generated with: > ./infra/config/main.star > ./testing/buildbot/generate_buildbot_json.py > > CIPD packages: > infra_internal/ios/xcode/mac 12a8169fg > infra_internal/ios/xcode/ios 12a8169fg > > Bug: 1108576 > Change-Id: I0edaaf6d945e0f1e061d930d16194f01b17fd851 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315436 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792067} TBR=dpranke@google.com,michaeldo@chromium.org,lindsayw@chromium.org,gbeaty@chromium.org,kimstephanie@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108576 Ignore-CQ-Freeze: Changes do not affect CQ. Change-Id: I94996e3092c9a4f4d5961fc497c8c3e1fade0a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327190Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792824}
-
Brian Sheedy authored
Includes the hermetic Xcode binary directory as a data dependency for Telemetry tests on Mac. Xcode is required in order to symbolize minidumps on Mac, and this previously worked by accident due to Xcode previously being installed system-wide. generate_breakpad_symbols.py already supports using the hermetic binary, so we just need to ensure that it's available on a swarming task. Also re-enables the tests that were disabled due to the missing Xcode binaries. Bug: 1110441 Change-Id: Icb703e08c65c27c4b6300710033be138a0bd4da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324883 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792823}
-
Dominic Mazzoni authored
The Switch Access feature on Chrome OS needs to explicitly control scrollable containers. Expose the current scroll position via GetAccessibleNodeData, and implement the required accessible actions to set the scroll offset or scroll by one page in any direction. Bug: 1108941 Change-Id: Icaf36b762b6651f04feb497012d7a029d87062ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319545 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#792822}
-
Lan Wei authored
We will add a new input source type to simulate the mouse wheel scroll to the Webdriver Action API, https://github.com/w3c/webdriver/pull/1522. In this CL, we are adding the wheel input source in the ChromeDriver's ExecutePerformActions function, which implements the Webdriver Action API in Chrome and we will use Devtool's input protocol, Input.dispatchMouseEvent with a type of "mouseWheel". Bug: 1040611 Change-Id: Ieb46c24466b6149d9f398385652a5779b0fd2adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324972Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#792821}
-
Robbie McElrath authored
We changed how we store the seed date in October 2019 and included fallback logic to handle the old date format. This CL removes that logic now that the change has been in prod for a (long) while. Bug: 1013390 Change-Id: Ie860871aa77c7d1018f62559742045b3238a1342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317717Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#792820}
-
Daniel Rubery authored
This metric is used to ensure that we aren't clearing too many events, which would cause a regression in the accuracy of referrer chains. Fixed: 1095051 Change-Id: I5c2b79d3de3b0815d8a05798613b5227766db1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321228Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#792819}
-
Manas Verma authored
This CL creates the JavaRef for AuthenticatorImpl when request is made, rather than in constructor. Bug: 949269 Change-Id: I43244cafde4f2e98d69caa7adfe347ee1334af5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314030 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#792818}
-
Toni Baržić authored
This reverts commit 9bc4b728. Reason for revert: Suspected cause for ChromeSessionManagerTest.OobeNewUser flakiness. see BUG=1110996 Original change's description: > cros oobe: Make Gaia screen a part of wizard controller screens > > This CL modifies code in a way that GaiaScreenHandler is owned and > handled by GaiaScreen. > > TBR=alemate@chromium.org > > Bug: 1079199 > Change-Id: Idea2f8b9a2974007286e9e8562d1bcee0f2df423 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279800 > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792674} TBR=antrim@chromium.org,alemate@chromium.org,rsorokin@chromium.org Change-Id: I7e677d7b35b414b3ef18023a8fc4052c25fec3cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1079199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327314Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#792817}
-
Dale Curtis authored
This remove the "8" suffix from method names and plumbs the previously hard-coded kGray_8_SkColorType as a variable to the YUV decoding path. During the "IsYuv" query stage the YUV bit depth is now passed up to the image decoding cache. The cache will then choose to enable high bit depth YUV decoding if the necessary texture capabilities are available (specifically the R16_EXT or LUMINANCE_F16 extensions). For high bit depth decoding, if R16_EXT is available, the new SkColorType is kA16_unorm_SkColorType otherwise for LUMINANCE_F16 it will be kA16_float_SkColorType. Fixed: 1008448 Tests: Updated unittests. Change-Id: I42a11524d85ab59f57bd59082aec0e5156933815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316332 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792816}
-
Xiaocheng Hu authored
This patch triages the following WPT failures: external/wpt/css/css-pseudo/selection-input-011.html external/wpt/css/css-pseudo/selection-textarea-011.html external/wpt/css/css-pseudo/selection-intercharacter-011.html external/wpt/css/css-pseudo/selection-intercharacter-012.html external/wpt/css/css-pseudo/selection-contenteditable-011.html Bug: 1110286, 1110495, 1110504, 1110512 Change-Id: I975519913dad329eb883b31140210615c7cf932d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324940 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#792815}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1da974976b2a..52a98ac3af69 2020-07-29 mmortensen@google.com BuildAPI: Add UnmountPath to SDK controller. 2020-07-29 zhuohao@chromium.org kukui-tablet: Adds new builder and signer type 2020-07-28 pceballos@google.com licensing: Allow Google-TOS for sys-firmware/falcon-firmware 2020-07-28 vapier@chromium.org virtualenv_wrapper: emit a short error message when venv fails If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I859d94cfdf697c35cab0abe4574a83d37e79d5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792814}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Id90af91b2a1bf1db17f0a814a077e42a92c05ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325098Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792813}
-
dpapad authored
Initial approach where the sidenav gets hidden/shown without any animation. Also there is a visible flash in the plugin area as a result of repainting after the sidenav is closed, which will have to be addressed in follow up polish. Bug: 1110015 Change-Id: I879198d6d90d2f384998be56186a3fd7f1aabd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324202 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792812}
-
Andrew Grieve authored
* Properly parse foo="value with spaces" * Hardcode list of tags that are allowed to be multi-line * Make android:name attribute first. Bug: 1064151 Change-Id: I375e80ba9c9de63995d436c3249ca277280a96fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324973 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#792811}
-
Sam Sappenfield authored
Create a new state and event within the component type. Within the UpdateEngine and UpdateClient create SendRegistrationPing that calls for registration event to be sent. The execution path for the the registration ping is not taken by the code inside the component updater The change is needed for the code in //chrome/updater. Bug:1096733 Change-Id: I0f239d8d837eb22dda49165ae04698d896860578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290195Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Samantha Sappenfield <t-sasap@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792810}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f587337c306..96d6c6f04dcb 2020-07-29 fmalita@chromium.org [skottie] Re-enable inval tracking in viewer 2020-07-29 elliotevans@google.com Fix SIMD CanvasKit build to output to the expected directory. 2020-07-29 adlai@google.com Migrate MakeFromYUVATexturesCopy* to GrRecordingContext 2020-07-29 jvanverth@google.com Reland "Metal: Hold refs for input buffers from bindBuffer calls." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I93af0965b62eb39f0598b59031a555e4156c4a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792809}
-