GitLab

I want to change a function prototype and I'm scared of getting
it wrong in a subclass.

Review URL: http://codereview.chromium.org/7569022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95702 0039d316-1c4b-4281-b951-d872f2087c98

TEST=build with touchui=1, drag selection handles.
Review URL: http://codereview.chromium.org/7569024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95701 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses memory access violations on GPU Valgrind Mac.

BUG=91889
TEST=Valgrind bots turn green on Mac.
TBR=thakis@chromium.org

Review URL: http://codereview.chromium.org/7582023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7570001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95698 0039d316-1c4b-4281-b951-d872f2087c98

P2PSocketClient may DCHECK in Close() if Close() is called immediately after Init() because delegate_message_loop_ is initialized on the IPC thread. Initialize it in the constructor instead.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7584011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95697 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91835
TEST=Close the window at various points and check that you are prompted (or not) according to whether or not there is a connection pending or in progress.

Review URL: http://codereview.chromium.org/7583018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95696 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77730
TEST=browse to chrome://settings/languages, click on a language and verify no outline on whole list
R=estade@chromium.org


Review URL: http://codereview.chromium.org/7460013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95695 0039d316-1c4b-4281-b951-d872f2087c98

- RequestFocus in LoadURL so that WebUILoginView is focused after window creation;
- Override TabContentsDelegate::TakeFocus and forward the focus back to web contents; This gets rid of the mysterious tab stop;

BUG=chromium-os:18466
TEST=Verify fix for chromium-os:18466.

Review URL: http://codereview.chromium.org/7506004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95694 0039d316-1c4b-4281-b951-d872f2087c98

We now ensure cached passphrases are always used. In addition, encryption now
happens after configuration, allowing us to make use of the
pending_encrypted_types to know if we're waiting for encryption (which
affects how we prompt for passphrase). This is dependent on sync_setup_flow.cc
always calling EncryptDataTypes before configuring the new datatypes and setting
pending_encrypted_types_ appropriately, which then gets consumed on
SYNC_CONFIGURE_DONE.

BUG=91314
TEST=see bug

Review URL: http://codereview.chromium.org/7551024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95693 0039d316-1c4b-4281-b951-d872f2087c98

TBR=apatrick@chromium.org
BUG=84419
TEST=None

Review URL: http://codereview.chromium.org/7583019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95692 0039d316-1c4b-4281-b951-d872f2087c98

* Check available quota before storing anything
* Inform quota manager of storage updates
* Evict an origin when quota manager requests

BUG=83652
TEST=llvm/Debug/unit_tests --gtest_filter=IndexedDBQuotaClientTest.* && llvm/Debug/browser_tests --gtest_filter=IndexedDBBrowser*

Review URL: http://codereview.chromium.org/7470008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95691 0039d316-1c4b-4281-b951-d872f2087c98

Self-assignment was broken and would lose the reference. I uncovered this when
running a test. It outputted a warning to the console, but we never looked at
it. I made a more explicit test.

This also fixes output exceptions. The OutException helper class detected
whether the existing object had an exception or not incorrectly. This was
exposed when var assignment was fixed.

TEST=included
BUG=none
Review URL: http://codereview.chromium.org/7511026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95690 0039d316-1c4b-4281-b951-d872f2087c98

OptionsPage.showTab could be called with wrong 'this' so remember activeNavTab in parent tab bar instead.

BUG=chromium-os:18662
TEST=Verify fix for chromium-os:18662.

Review URL: http://codereview.chromium.org/7572047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95689 0039d316-1c4b-4281-b951-d872f2087c98

If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.

BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95611

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=95631

Review URL: http://codereview.chromium.org/7572031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95686 0039d316-1c4b-4281-b951-d872f2087c98

Relanding 95542. Reverted due to issue caused by 95496.

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/7480032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95685 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95684 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses leaks introduced with r95572 related to BrowserAccessibilityManager.  More suppressions.

BUG=91845
TEST=Valgrind and HeapCheck bots turn green.

Review URL: http://codereview.chromium.org/7582021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95683 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87632
TEST=Official Windows Chrome logs show Remoting webapp being built.

Review URL: http://codereview.chromium.org/7461144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7582006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95681 0039d316-1c4b-4281-b951-d872f2087c98

Convert MetricsServices' child_process_stats_buffer_ while
I'm at it.

Review URL: http://codereview.chromium.org/7583016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95680 0039d316-1c4b-4281-b951-d872f2087c98

Destroy the underlying WeakPtr right before the owner thread is destroyed.

Remove suppression for the leak in the bug.

BUG=91465
TEST=

Review URL: http://codereview.chromium.org/7572010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95679 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7541054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=tony@chromium.org

Review URL: http://codereview.chromium.org/7569012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95677 0039d316-1c4b-4281-b951-d872f2087c98

The test verifies that in-progress XHR is still loading after transfer.
BUG=55200


Review URL: http://codereview.chromium.org/7550021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95676 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds tab sync performance tests, similar to the tests for the existing datatypes in live_sync/performance.  Changes to LiveSessionsSyncTest were required - most significantly the addition of AwaitSessionPropagation, which waits until a vector of urls can all be found in the model associator.  This type of wait loop previously existed as part of OpenTab, and worked with a single url.  AwaitSessionPropagation supports multiple urls, and is called from OpenTab, OpenMultipleTabs, and SessionsSyncPerfTest::UpdateTabs.

BUG=none
TEST=sync_performance_tests, sync_integration_tests

Review URL: http://codereview.chromium.org/7575026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95675 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=andreip
Review URL: http://codereview.chromium.org/7550044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95673 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95672 0039d316-1c4b-4281-b951-d872f2087c98

Whitespace change: http://codereview.chromium.org/7576017

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7575020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=sync_performance_tests

Review URL: http://codereview.chromium.org/7541052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95670 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91851
TEST=unit_tests:OmniboxView.*
Review URL: http://codereview.chromium.org/7585016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95669 0039d316-1c4b-4281-b951-d872f2087c98

Properly scope ScopedPlatformPaint so that the native drawing layer and Skia are in agreement on the state of the pixels. Also fix Windows to not return completely transparent bitmaps when the source image has color depth < 32 bpp.

BUG=86085
TEST=Copy an image from MS Paint and paste it into Gmail using 32bpp for the display color depth.

Review URL: http://codereview.chromium.org/7471008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95668 0039d316-1c4b-4281-b951-d872f2087c98

Also sprinkle in some OVERRIDEs.  It's not strictly necessary in this
case since it's a pure virtual method, but it doesn't hurt and may help
for future refactorings.

BUG=23581


Review URL: http://codereview.chromium.org/7461136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91734
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/7585019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95662 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95661 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses leaks introduced with r95607 related to BrowsingDataQuotaHelper.  More suppressions.

BUG=91836
TEST=Valgrind and HeapCheck bots turn green.
TBR=tzik@chromium.org

Review URL: http://codereview.chromium.org/7585018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/7541050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95659 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95658 0039d316-1c4b-4281-b951-d872f2087c98

984:
Avoid specifying multiple conditional entries when the value is the same for all
configurations.

985:
mac/make: Use libtool -static instead of ar crs to create static libraries. Faster.

BUG=none
TEST=none
TBR=evan

Review URL: http://codereview.chromium.org/7491064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95657 0039d316-1c4b-4281-b951-d872f2087c98

The Remoting Host plugin is built for Linux but not ChromeOS.  This is a
temporary fix until we can update the stage_build script to deal with this
missing file on official ChromeOS build.

This is a partial revert of r95103.

BUG=91549
TEST=Official ChromeOS build (staging) no longer fails.

Review URL: http://codereview.chromium.org/7589001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95656 0039d316-1c4b-4281-b951-d872f2087c98