- 12 Oct, 2020 40 commits
-
-
Julie Jeongeun Kim authored
This CL introduces AwPrintManager::UpdateParam() which updates |settings_|, |fd_|, and |pdf_writing_done_callback_| in order to reuse AwPrintManager avoiding creating it every time. It fixes a regression issue by crrev.com/c/2326857. The problem is that WebContentsFrameReceiverSet is created always along with AwPrintManager but WebContentsImpl::AddReceiverSet() expects that it's called once for an each interface. So, this CL doesn't create AwPrintManager always like other print managers such as PrintViewManager or HeadlessPrintManager. Bug: 1137016 Change-Id: I11c176009ccdad643ebf495cc4b983209ba8b1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463270Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#816141}
-
Rune Lillesveen authored
Bug: 1068610, 1136862 Change-Id: Iecebc6f71099695a60ee65eb4899c1bd2437704c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463920Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#816140}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26d93a4d..66b5d4eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I811f8d7526b825a24db210c963797ae911a10f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465983Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816139}
-
Reda Tawfik authored
Bug: 1104132 Change-Id: I9a1d60eaa56b985e0a4f605f2b5f607ed935acc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463578 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#816138}
-
Koji Ishii authored
This patch implements |HyphenationComponentInstallerPolicy|, a component updater for hyphenation dictionaries. The code is tested locally, but this patch: * Does not pass `install_dir` to the hyphenation engine yet. * `RegisterHyphenationComponent` is not enabled on any platforms yet, as there are no platform that use the `#if` combination yet. Bug: 652964 Change-Id: I9afc09dfff166d5d903372bd5af2471635d90f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437314Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816137}
-
Denis Kuznetsov authored
Bug: 1134114 Change-Id: I6f85ad53b5be40dd53485efde930362fc73188e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452473 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#816136}
-
Maksim Moskvitin authored
top_level_permanent_item_ids_ wasn't persisted and could potentially introduce problems with PRE_ tests. It was used only for Nigori and it's safe to replace it with LoopbackServerEntity::GetTopLevelId() (because permanent items are permanent). Bug: 1104225 Change-Id: Ie92a54b0cfc80d671be96922c6dc265ed62594f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465846 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816135}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6c3da3dc5b87..936ef0a5f21e 2020-10-12 hao.x.li@intel.com Query API: Timestamp Query on Metal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I32cddc5010f679dcedddb9260821bc41ba9cf8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465923Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816134}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 445fb131. With Chromium commits locally applied on WPT: a46c52a5 "Clean ImageCapture web platform tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I359795825eec6e2b6df780e3b26e350cce6381f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465679Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816133}
-
Marc Treib authored
It was always empty in the USS world (the concept of data type association doesn't really exist anymore). Bug: 1102837 Change-Id: Ib8e9fbc13b94bafd8fddde253fde514d1c65f6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463917 Commit-Queue: Rushan Suleymanov <rushans@google.com> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#816132}
-
chrome://sync-internalsVictor Hugo Vianna Silva authored
This debugging page hasn't been used by the Sync team in a while, so this CL removes it. Consequently, SyncInternalsMessageHandler no longer needs to implement TypeDebugInfoObserver. This unblocks the removal of such observer interface in future CLs (chrome://sync-internals was its last "real" implementation). Bug: 1102849 Change-Id: Idb2ed8af56c9133a884b79ccfa131dce630fa1bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465743Reviewed-by:
-
lonyele authored
When selection is happening, apply text-decoration-color from selection pseudo style to the selected element Bug: 1110393 Change-Id: I3829c7071b85458c43975d622f0913b8f8c64fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383212Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#816130}
-
Nico Weber authored
Normally, we allow running several links in parallel if there's enough memory, since links tend to be memory- and io-bound, not compute bound. However, in LTO builds the linker does codegen for every linked translation unit, which needs a lot of CPU. Previously, we used to hardcode 8 threads per link for thinlto builds, which makes builds needlessly slow on machines with many cores. Instead, automatically use all cores for a thinlto link, but only run one link in parallel at once. chromeos-chrome-9999.ebuild in the Chrome OS build and link_jobs_32 in mb_config.pyl currently manually set the number of threads per lto link to the number of cores. Once this change here is in, we should stop explicitly setting the arg there and then we can turn this from a gn arg to a regular variable that's not settable in args.gn Bug: 1132930 Change-Id: If2fda3e38b2b1827beb2da844f024f52211210db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464782Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#816129}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6892611036fe227ce0b4437dd8206494367e1571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465686Reviewed-by:
-
Igor authored
This will disallow the usage of Lacros browser by default to managed users. For unmanaged users Lacros will be available. Also it will be available for users where the admin set the policy LacrosAllowed to true. BUG=chromium:1136199 TEST=Manual test on device Change-Id: I60554ab7ed7813207aa602eb17801a4e82be47d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456808 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#816127}
-
Stephen Chenney authored
For tiled image painting the image was not correctly oriented. Fix it by pre-orienting the image before creating the tiling shader. The test still fails due to a lack of fuzzy matching, but the result is now correct. See external/wpt/css/css-images/image-orientation/image-orientation-background-properties.html Bug: 1066634 Change-Id: Ie0a2f534bf760174d337fdaa6838e82b33280d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464902Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#816126}
-
Yuki Shiino authored
This is a follow-up of https://crrev.com/c/2418513. We need to intercept getcwd and realpath, which allocate memory internally. The reason is the same as 2418513. Bug: 1111332 Change-Id: I50c43056609b69020dc84bf181ec6247067cb982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438093 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816125}
-
Anders Hartvoll Ruud authored
This is only used by test code, and it's standing in the way of implementing tree-scoped references, so this CL removes this capability. Most of the tests could be fixed with just a simple Reset (for example: BasicCycle). This means that the cascade is empty after each Reset, so those tests are no longer implicitly testing that declarations appearing later overwrite those that appear earlier. But that's OK, there are still loads of tests which cover this explicitly. RevertInKeyframeResponsive is supposed to test what happens when --x changes during an animation that depends on --x _via_ revert. So here we can't just do an plain Reset, we need to re-add all the other declarations as well, to simulate a situation where only --x changed. Then there were a few tests which for some reason calculate the animation update and _then_ Add stuff to the MatchResult (for example: AnimatingVarReferences). This does not happen in production. Moved the Add calls to before the first Apply call. Change-Id: I00c3b26cbd7b9581e1bd61b5cd27163ebe651b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464935Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#816124}
-
Ehimare Okoyomon authored
Screenshot: https://crbug.com/1136533#c1 Bug: 1136533 Change-Id: I6140f9e49a723afd0dd4ae22b059784b2cf73d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461308 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#816123}
-
Eric Seckler authored
Currently, base::CPU::GuessCoreTypes() is called in multiple places and executes the same code multiple times, even though the result is constant. There's already some static caching in different places. This patch moves the static caching into base::CPU::GuessCoreTypes() and renames it to base::CPU::GetGuessedCoreTypes(). Bug: 1081760 Change-Id: Ifaff01cc19abc48a36d5fe19bc4cb9a9cfa4fd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463309 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816122}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9024c3764962..ac0366e76f36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: amraboelkher@google.com Change-Id: If146743d69e69ea72e8f52539482c7cfbbe0e4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465922Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816121}
-
Marc Treib authored
It was unused. Bug: 647505 Change-Id: I19b16e8a5c99d0c490e8e0df05ec29985d98b7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463918Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816120}
-
Finnur Thorarinsson authored
This change of function contract is the by-product of a discussion on fixing issue 1130909, where we decided to do a bit of additional cleanup as well. Bug: 1130909 Change-Id: I28d0e244ead44b8f6525bf1e0d86633256d06281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456786Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#816119}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68bd685a7643..dec35c569444 2020-10-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 77bfcdcd to efbcef25 (569 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Change-Id: Ib16c6154813710d0a5b60de4b176b7f1dbdc0cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462740Reviewed-by:
-
Victor Hugo Vianna Silva authored
The code to migrate sync.local_device_guids to the new sync.local_device_guids_with_timestamp has been active for 1 year (crrev.com/1827435), so it can be removed now. TBR=treib@chromium.org TBR=droger@chromium.org Fixed: 994339 Change-Id: If6fed35ada178808a4171d790f51451f5a8192df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464934 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#816117}
-
Fredrik Söderqvist authored
This allows "content negotiation" to detect support for SVG favicons. Bug: 1026564 Change-Id: I612a08872f16bdb0dc71b9779090b5759806f815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926312 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#816116}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/07b0b1dc..26d93a4d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib963131764aef6cec54151d7f9ea26f6bd8e1859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465670Reviewed-by:
-
Victor Hugo Vianna Silva authored
Before this CL, screenreaders would read the buttons in the sync consent dialog, but wouldn't read the text content unless the user focused it with the mouse. With this CL, we ensure that at least the dialog title ("Turn on sync?") is read once before the buttons. Screencast: crbug.com/1130433#c3 Fixed: 1130433 Change-Id: I2dbdae2489be7672bd871a63384db2885d1bfcc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465842Reviewed-by: -
Paula Vidas authored
This is necessary for two client tests that use the new invalidations system. Different clients need different tokens because the (fake) server will use the tokens to determine invalidations recipients. Bug: 1135167 Change-Id: I0f60de8d27ad6b6a338818cde530df2f860c056f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461012Reviewed-by:
-
Anders Hartvoll Ruud authored
As far as I can tell, this check exists to ensure that complex Shadow DOM v0 selectors don't cross any boundaries they shouldn't (see Issue 360679). The problem is that for e.g. ::part(foo):is(:focus), the :focus part is detected as an illegal boundary crossing, since the TreeScope of context.scope and context.element are different. This function doesn't seem entirely right to me, but at this point I want to touch Shadow DOM v0 as little as possible, since it's very close to being removed. Hence I'm basically just disabling the check for :is/:where. Bug: 568705 Change-Id: I2febcd37c9772b11f91ae93df87acb7649a8de91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464263Reviewed-by:
-
sandromaggi authored
This CL adds a new web-action to get the attribute of an element. This is required for extending the |GetElementStatusAction| to also handle the text content of an element. The attributes can be nested. Bug: b/169924567 Change-Id: Id5ff86d907d34d8cbf8e56aa8dfd377fe8f934bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463233Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#816111}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3326535126e4..72cc54c5b852 2020-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9ef87d94..c67306a2 (815958:816064) 2020-10-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d97ea1b0..9ef87d94 (815854:815958) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1fa3a78ee3b705d6cf952a196a77023c03c059b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462739Reviewed-by:
-
Marc Treib authored
The hope is that this will resolve test flakiness; see linked bug. Bug: 1136758 Change-Id: I78697c296d21a4202e69b1aa9f9eb264f676317d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463562 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#816109}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602448744-d06fc1e3f11f340d5ab319c12d5a6fb4491c2b6c.profdata to chrome-win64-master-1602482293-b6c9af61d9b709e1e409c88a2a609d5546a5c2ce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib43a9e444cc25ec682c130f18dbad17f21008559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465644Reviewed-by:
-
Morten Stenshorne authored
Bug: 294205 Change-Id: Ief9e9bc948019a6d74ec15781e96dd3917879794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462261Reviewed-by:
-
Victor Hugo Vianna Silva authored
ProfileSyncService mostly creates the task runner and passes it to the engine, so this CL moves the creation to the engine. The one use of the runner by ProfileSyncService is replaced with posting a task to the thread pool. Bug: 1123881 Change-Id: Ifef2806b527424b30e2a0d6ef07cfca026ee07b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461325Reviewed-by:
-
Dmitry Gozman authored
Bug: 1137143 Change-Id: I0e28864a58cfd558e899eaa5c8ee4cebff559098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463605Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816105}
-
Jiewei Qian authored
This is a reland of de6bbcbc The reland deletes EXPECT_DCHECK_DEATH to all launch tests, because death tests aren't reliable in browsertest. And manually test LaunchSystemWebApp behaves correctly in debug / DCHECK builds. Test=Manually verified debug build and release build behaves correctly. - When DCHECK is on: DCHECKs when launching with a wrong profile - When DCHECK is off: launches into an appropriate profile Original change's description: > system-web-apps: better handle incognito in LaunchSystemWebApp > > LaunchSystemWebApp used whatever profile is provided in the parameter to > create SWA windows and launching SWAs, even if the profile may not > suitable to host a SWA window. > > This CL adds logic to determine the appropriate profile if the provided > one is unsuitable. This serves as a mid-term solution for launching > SWAs, and acts as a safety net to prevent chrome crashing if unsuitable > profiles are provided. > > Specifically, it catches these two types of profiles: > - Guest session "original" profile: launch into guest session's > primary off the record profile (which is used for guest session > browsing and SWAs). > - Normal session incognito profile: launch into the original profile, > because we don't support incognito SWAs. > > Fixed: 1109594 > Change-Id: Ibe4a3b1bf7c811ef1ee02fd967307ad9bf070ee7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423760 > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814602} Change-Id: I5766a26c5376c7e59180e4d9dd2befe015c13e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459010 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#816104}
-
Eric Willigers authored
Remove #include from source files that do not use ScopedFeatureList. Bug: 1137231 Change-Id: I61cdb2b1909662f048832e85cedffbe9dbaca18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463266 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816103}
-
Jérôme Lebel authored
ForceStartupSigninPromo flag should should not present the promo when being signed in. The flag test is moved after authentication test. Change-Id: Ib4cf710988b39726b9f4dbef80d44eb8f16fde98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462133 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#816102}
-
