- 30 Sep, 2020 40 commits
-
-
Xiaohui Chen authored
Previously ambient mode will trigger lockscreen on screen dimm and then rely on lock screen idle to show screen saver. This works in some cases, but in suspend case the time between screen dim and cpu suspend is too short. Screen saver was not able to enguage. The reason we have the set up is because the screen saver was sharing the same window constainer as the lock screen, it cannot show before lock screen is ready. Now screen saver has its own window container, we changed the flow to show ambient mode immediately when idle. This will prevent cpu suspend because screen saver will take a wake lock if charging. Screen saver will still lock the screen in the back if user reference indicated lockscreen after wake. Bug: b:169442907 Test: unitests and manual tests Change-Id: I1a5df2c58c976bba492c709e0a61dd5a6314d084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435334Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812397}
-
Roman Arora authored
Bug: 1133575 Change-Id: I0664480f31d008136f005f3ab44bd66ca40e0f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441333Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#812396}
-
Yue Ru Sun authored
Instead of blink Document generating its own UKM source id and calling the UKM API to associate the source id to the URL, move the source id generation to NavigationRequest and plumb it down through RenderFrameHostImpl to the blink::Document that will be created in the frame (when possible). UKM source is created when navigation successfully commits. Source creation for failed navigations are not in scope for this patch. In case of empty initial Documents and iframes without src, the blink::Document will still generate its own source id. Since they are not associated with any navigation nor represent real-world metrics, we are not interested in them. This moves the creation of Document-type UKM sources and the recording of "DocumentCreated" events from the renderer to the browser process. Bug: 1070793, 961847 Change-Id: I4820f98ec41fcd606dc31160c6d69c446554c742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163851 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#812395}
-
Dave Tapuska authored
Remove unnecessary includes of web_float_rect.h Change-Id: I4f3ec23efc55358f3af74eca714410c68eaafcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431554 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#812394}
-
Henrique Nakashima authored
Allow disk reads so the test running handleSynchronousStartup() does not trigger strict mode violations. Bug: 1131373 Change-Id: If3e0ccd0fa51c7f6a492bcf7793b40ee88e84d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441649Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#812393}
-
Mike Wittman authored
Implements the infrastructure to allow different platforms to selectively enable the profiler on different threads. Retains the enabling on all supported threads in the default configuration and sets the state to disabled on all supported thread for Android, pending launch on that platform. Bug: 1129939 Change-Id: Iaec50b3aca4d3d7e2a75aa2015a09da53bfb80b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431456 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#812392}
-
Miriam Zimmerman authored
This new branch will be used when we start attempting to remove already-uploaded crashes. BUG=chromium:1060019 TEST=CQ Change-Id: I94fc85bc9299e42facc5945df757710b63c30d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422321Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#812391}
-
Becca Hughes authored
Adds a histogram to record every time a navigation occurs from Kaleidoscope. BUG=1110373 Change-Id: I76b9dd84ebc66fd2202a8bf1748b8a13cfc802e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441527Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#812390}
-
Ian Kilpatrick authored
We currently have relayout logic to detect when a flex-items scrollbars change (to relayout) as this typically changes the min/max sizes. However this didn't account for an arbitrary descendant changing scrollbar state. This resulting in inconsistent sizes between a flexbox and a flex-item. Bug: 1127415 Change-Id: Ib2427f655437b1aa82dda2e0340fe950b079667f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424899Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#812389}
-
Francois Doray authored
This histogram is used to assess the impact of the IntensiveWakeUpThrottling experiment. Bug: 1075553 Change-Id: I8ff08aa7e93799a8507f138d5006e45843e9d575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426603 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#812388}
-
Alex Newcomer authored
Log the index activated in the multipaste menu. Will be used to help UX determine if we should show more items in the menu. Bug: 1099338 Change-Id: I28533ed7628fe54fde2e182e76ab5f6466d3b1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427406 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812387}
-
Daniel Classon authored
Adds a new virtual function to OS Settings Sections that takes in a mojom::Setting and an optional Value and logs the corresponding metrics. Left unimplemented in most sections for now. Bug: 1133553 Change-Id: I5784fa827e7c3a2b5b960b6dd309f8fed0960183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439498 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812386}
-
danakj authored
The current Insets::Scale() methods scale and then do a static_cast to integers. This does not provide the same functionality that now exists for other geometry types. We add ScaleToFlooredInsets(), ScaleToCeiledInsets() and ScaleToRoundedInsets() to replace the Insets::Scale() method when scaling from integers to integers, to make the operation being done explicit. This also means we provide explicit conversions with ToFlooredInsets(), ToCeiledInsets(), and ToRoundedInsets(). We also add ScaleInsets() for InsetsF to allow for floating point scaling. We update the ConvertInsetsToDips/Pixels helper methods to use the new ScaleInsets() method, and return an InsetsF, similar to other conversion helpers. And we update callers to Insets::Scale() to either use the device scale helpers and ToFlooredInsets(), etc, or to use the ScaleToFlooredInsets() and friends. Unit tests are updated and added for the new scaling methods. R=sky@chromium.org Bug: 1130050 Change-Id: I86dbe8b4dd43b2fd18521c07f251178ded9c5dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429383 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#812385}
-
Tarun Bansal authored
Change-Id: I6da1c02731a1d7b8498ff27abe58212c2eec9bac Bug: 1126190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417303Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#812384}
-
Ali Juma authored
This makes SafeBrowsingBlockingPage record a metric when the user taps on "Back to safety". Metrics for the case where the user proceeds past the interstitial are recorded separately in cross-platform code. Change-Id: I915c0b58272fdedd3ec8205f7cd18e916f2acc6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431548 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#812383}
-
chrome://settings/securityBettina authored
Create a deep link in order to link from the Enhanced Protection promo on desktop. Bug: 1130722,1130735 Change-Id: I77984a09ba19652255321b92b43bd404a6e2eb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428830Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#812382}
-
Patrick Noland authored
This reverts commit 8fade486. Reason for revert: Test hasn't flaked in a week Original change's description: > [sheriff] Disable TabbedAppMenuTest#testHideMenuOnToggleOverview > > TBR=jianli@chromium.org > NOTRY=true > > Bug: 1131455 > Change-Id: Icb7efcdebfc9335a9538915c88ec80bee7068031 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441272 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812180} TBR=jianli@chromium.org,xidachen@chromium.org Change-Id: I720d3b4a2ac39bce92071835bb39a6d9a5351711 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441692Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#812381}
-
ckitagawa authored
This CL adds a timeout to compositor startup to prevent cases where the compositor takes a long time to load. Change-Id: I32156a2c2e4b89706a1c4b06685ee473590659ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438197Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#812380}
-
Claude van der Merwe authored
WifiSyncFeatureManager unittests were failing on ASan/LSan builds. This CL 1. Assigned GetHostWithStatus() to variable to remove duplicate call. 2. Assigned RemoteDeviceRef by value to fix reference error. 3. Re-enables WifiSyncFeatureManager unittests. Bug: 1117619 Change-Id: I3606294648aa3be3b33f5f83442dcbc584ecb143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435901 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#812379}
-
David Black authored
We would like to understand approximately how many screenshots users are taking per day and per week. This will inform how may screenshots we choose to show in the holding space feature currently under development. Bug: 1131266 Change-Id: I9b5bee010f80eeb47631f4be9d36dfe8b30a4c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436653Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#812378}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b531fa82..38d35cad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaf9f69bac5c72aa5ddf56582feddcf82c9145aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440264Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812377}
-
Mohsen Izadi authored
List of original events in EventWithCallback is a std::list which is efficiently movable and there is no need to complicate things with use of unique_ptr's. Bug: 1079116 Change-Id: I55ca74c8da276f0d91f9a68ee6c0e1d4de9abcee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432656Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812376}
-
Ben Goldberger authored
-Update chip color to match context menu in dark mode -Add support to disable on incognito with a param Bug: 1099982 Change-Id: I6892f847717e122ec065e3ef615bcdaac1072eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431561 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#812375}
-
Stephen Chenney authored
The feature is ready to ship so enable as many tests as possible. Bug: 785230 Change-Id: I35cc269c6c3dfe6dc0bff211634aa75eeaa11464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438970Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#812374}
-
Oystein Eftevaag authored
base::"MessagePumpForUI::ProcessPumpReplacementMessage PeekMessage" base::ScopedBlockingCall These two trace events are now Perfetto strongly-typed trace events which means they can be sent via the Chrometto pipeline without being stripped. Additionally updated the hardcoded list of TRACE_EVENT_EXECUTION events which get converted into strongly typed events internally within the Perfetto implementation. Change-Id: If90863d59758dec62431771e7603d0dcef77e472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424502Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#812373}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ad421a248adb..da5828c06b4c 2020-09-30 rharrison@chromium.org Add Tint SPIRV->SPIRV to fuzzing code path 2020-09-30 cwallez@chromium.org TextureFormatTest: Test components not present in the format. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If6bff572d5de7b98048f68ead4ad74a557535b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441547Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812372}
-
Istiaque Ahmed authored
This CL adds boolean histogram indicating whether extension's background service worker script registering and starting succeeded or not. This CL also adds timing for those. Bug: None Change-Id: I0fb31609b3c54bf21970b6ea39d7bcd50d369662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437786Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812371}
-
Mike Wittman authored
Extracts the logic for determining process type from command line into a location accessible to all users, and reuses it for all cases where we determine a process type. Bug: 1129939 Change-Id: Ie021aaf7275042d7ae271f3eafa315b1efac0df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427129 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#812370}
-
Thomas Guilbert authored
Currently, using the video.requestVideoFrameCallback() API to power immersive XR experiences only outputs 4fps. This is because there is no compositor emitting BeginFrame events. Painting video frames via xrSession.requestAnimationFrame() works fine however, since each call to paint queues an update for the next frame. This is wasteful, since the XR rate if often greater than the video rate (e.g. 90fps > 30fps) and we end up painting duplicate frames. This CL fixes the issue by using the XRFrameProvider's XRFrame updates to drive video frame updates. This queues a similar of frame updates as painting at the XR rate, but allows us to only paint new frames via the video.rVFC API. Bug: 1107578 Change-Id: I8a4984be191adeaaf83d4d4ef4712fe0459d8119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429974Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#812369}
-
David Bokan authored
This test was originally added to fix https://crbug.com/578554 which was that the autoscroll animation when holding down the mouse button over the scrollbar track would overshoot the cursor. The test added there was testing this in a round about way: it would click twice in the same location on the track, assuming that the animation would start but not finish before the second click. In this way, it was checking that the calculation logic was using the final position of the thumb. However, this makes an assumption about frame timing and animations. It likely became flaky in the threaded suite with the introduction of the compositor scrollbar controller, which would try to update the animation in this case. This CL replaces the test with a more direct check for the original bug by holding the mouse button down over the track and waiting for the scrollTop value to settle. Note, the test fails consistently on Mac with compositing enabled. This is due to the Mac-specific expectation for page scrolling. This specific value is implemented only on the main thread so when compositor threaded scrollbars are used, we get the same value as on other platforms. See https://crbug.com/1133538 Bug: 915926,901906,854910 Change-Id: I4e5774a0ee8452ac31b6d199b5d2c68d67feca7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438677Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812368}
-
Daniel Classon authored
Part of the set up for the metrics changes to OS Settings. Creates a wrapper class for the existing User Action Tracker so that it can stay alive outside of user sessions. Bug: 1133553 Change-Id: I9f3db611f893dcfc78638c007b27b1099f63f3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439021 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812367}
-
Ahmed Mehfooz authored
Bug: 1131258 Change-Id: Ic42c6d2765af94b79f79f5f138c7c1691cdedfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436772 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812366}
-
John Chen authored
The chromium.chromedriver builders were retired a long time ago. Clean up config. Change-Id: I77c64a7eda7639aa6d0483ff7cbf2c3738d7d01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441318 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#812365}
-
Mark Schillaci authored
This CL updates the behavior of Checkbox on Android. With this change, the mixed state of a Checkbox will now be announced during swipe navigation or when a node is initially selected. Until now the mixed state has been synonymous with false. We append the state of the Checkbox in the stateDescription element of the node's corresponding AccessibilityNodeInfo object. This CL also updates associated unit test expectations. AX-Relnotes: Checkboxes on Android will now announce "partially checked" when in a mixed state Bug: 1121750 Change-Id: Iec434d20b41ec71b4708b1815c78d3cf7b2497fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432089 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#812364}
-
Guillaume Jenkins authored
Add a simple unit test case for BrowserReportGeneratorIOS class. The test generates a basic report and checks that the values in the proto make sense. Bug: 1114853 Change-Id: I18dc1114c5785a4063483614b308b1f327ce1bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439785 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812363}
-
Jordan Oroshiba authored
Instead of opening the full site settings, change the individual setting in a dialog directly and provide the option for removal of the override. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1130668#c1 Bug: 1130668 Change-Id: Ib1a0da6f637288b6a62a6b898de34fe4f647d7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422499 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#812362}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsInternetDetailPage* Change-Id: I4a713bea34443f9a834b79a769b09f67adf0495f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436783 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812361}
-
Christian Dullweber authored
Copy message about https image compression from old UI to the new UI. We need to improve the design later on. Screenshot: https://crbug.com/1077766#c64 Bug: 1077766, 1101489 Change-Id: I8f68ab51388b1604372dea3815d4d999393d75fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440619 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#812360}
-
Stephen Roe authored
as the bugs motivating disabling the tests are fixed. The net_unittests suite is running successfully on other fuchsia FYI and CI builders. Bug: 780652, 877248, 844416 Change-Id: Id7b46e9a450aa937b09309dff972871f359dfb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436700 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812359}
-
Yao Xiao authored
Also removes the base::Feature kInterestCohortAPI, as there's no plan for finch. Bug: 1062736 Change-Id: I19d847b92ed57ae88a4fc99bc56039c7f4feaa9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434091 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#812358}
-