- 20 Oct, 2020 40 commits
-
-
Evan Stade authored
Without this change, only media-fling works. Even with these flags removed, the APIs are still disabled for clients that don't explicitly enable Media Router functionality. Bug: 1057099, 1057100 Change-Id: I7f63dd36798a499011ddd722ebeb682532f7ddda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486455 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#818996}
-
Fredrik Söderqvist authored
Mark external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-two-cue-layout-after-first-end.html flaky Tbr: mlamouri@chromium.org Bug: 1093188 Change-Id: I04de0550e232bbf6e0ff5d6a72540bb864b2b125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485795Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#818995}
-
Filip Filmar authored
A cosmetic change that brings the Chromium tests closer to what is being used in production in Fuchsia today. - Brings the unit test paths in sync with the correct path in Fuchsia: https://cs.opensource.google/fuchsia/fuchsia/+/master:src/lib/icu/tzdata/icu_tzdata_config_data.gni;l=11 - The loader code in icu_util.cc has been changed before to use the correct path, so no changes are required there. - The content of the tzdata directory is adjusted to match the contents that are provided by Fuchsia. This includes the newly introduced file revision.txt, which contains an assertion about what revision of tzdata is supposed to be packaged. Bug: 1139410 Change-Id: I80707a3daa0e492d747e9542b64593bf41a545c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480891Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Filip Filmar <fmil@google.com> Cr-Commit-Position: refs/heads/master@{#818994}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 32 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-01-18. TBR=chromium-metrics-reviews@google.com Change-Id: I40292736c72dd8378d28ff0d341b491e73609191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485643Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#818993}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/954fbcfe8ee7..3169c31f1f0e 2020-10-20 mmortensen@google.com Update requirements.txt for google-cloud-logging and deps. 2020-10-19 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-19 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-19 kimjae@chromium.org chromite: Remove use of offensive term from codebase 2020-10-19 evgreen@chromium.org chromeos_config: Remove hw test override for dedede 2020-10-19 inglorion@chromium.org cros_setup_toolchains: add dev-lang/rust-bootstrap 2020-10-19 bmgordon@chromium.org cbuildbot: Explicitly request chroot image type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I587472982d022c8e102d996a23fb86f16cc7577e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487215Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818992}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ic64283bf7d01aa919b47df2c31fe62db1ba3e146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472440 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#818991}
-
Fergal Daly authored
It appears to be causing crashing in canary. Bug: 1072817,1139104 Change-Id: I3d149aa338f6c11f5e5f9b65fd56aea55cda760e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486532 Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#818990}
-
evliu authored
This CL adds a speech recognition availability observer that will notify the Chrome speech recognition client when the user pref enabling the Live Caption feature changes. This will allow the feature to be enabled and disabled midstream without having to refresh the page. Bug: 1137086 Change-Id: Id9409b1666c74e2c835c65c311334b98ee56335b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469439Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#818989}
-
Chris Lu authored
If Smooth Scrolling is on, then the scrollview's origin is the same as the header's origin. Thus, |self.initialHeaderInset| is added to track the actual offset dragged by the user from the top of the page. When Smooth Scrolling is off, the scrollview's origin is the bottom left of the header, so adding that inset is unnecessary. Before refactoring fullscreen for MultiWindow, the ContentView's contentInset was set, but it is no longer needed and |self.initialHeaderInset| is the same value. Thus, not adding anything to contentOffsetFromTheTop is sufficient when Smooth Scrolling is off. Bug: 1128444 Change-Id: I5ada9f5cca5f8450572e0df6e689bd0f4cef47ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446782Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#818988}
-
Peter Kasting authored
Some of this cleanup will facilitate replacing ButtonListener with callbacks in a future CL. Bug: none Change-Id: Ieefc3be0238bdaa95fc171b7ee7c55e4f8e41a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472899 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/afa4d14527b8..615063999dd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mcnee@google.com,andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1140394 Tbr: mcnee@google.com,andypaicu@google.com Change-Id: I01cfa6d34af57d641afee1dc59f8fc85a36efcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487166Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818986}
-
Sean Kau authored
Currently, we're clearing the printers list anytime we get a network change event. This is fine, except this can include completing connection to a network and a change in signal strength. This can get out-of-sync with the ZeroconfPrinterDetector and cause our list of printers to be in an invalid state. Manifests as entries in settings that are reported as having "disappeared". Bug: 1137999 Change-Id: Ic89ce0e3e65a70d98a027019cd8b4e1fd626946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480825Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#818985}
-
Danyao Wang authored
Verbose logging messages can be turned on with the following flags: --enable-logging=stderr --vmodule=*/payments/*=2 Bug: 1130768 Change-Id: I9a76a9e7705d69a1f388ec3680b19ce1a46e261f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485538Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#818984}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010200700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/rzh7SSCNO_IMmZv7t7OIlOy_7XIZejdnXpj-Uh3IeGwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/169509246,b/170910313 Tbr: help-app@grotations.appspotmail.com Change-Id: I4c36081ae90186ae9f810ecb65a3075f9b05afe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487167Reviewed-by:
-
Erik Staab authored
Bug: 1135716 Change-Id: I8c77e6587d40aaa4e9a331f99ed40af5569d6e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485886 Auto-Submit: Erik Staab <estaab@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
Hui Yingst authored
- Move SetSelectedText() and SetLinkUnderCursor() to PDFEngine::Client. - Remove SetSelectedTextFunction since TestClient implements SetSelectedText() and SetLinkUnderCursor() as no-ops. Bug: 1113919 Change-Id: I788d08d850bcec80047f4869bf044ebec3a050d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469403Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#818981}
-
Brandon Wylie authored
Bug: 1140009, 1140047, 1140048, 1140049 Change-Id: Ic076b3f15bf7d8b243ee35ac4348eefa87292a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485214Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#818980}
-
Maciek Slusarczyk authored
screen_refresh_timer_ in ExistingUserController triggers update of the login screen when users are to be forced through the online flow. In the normal conditions it should be re-started after firing for a particular user. DCHECK that was previously introduced verifies that the timer is not running on its restart. This condition can be not met e.g. for managed devices. If device settings got changed UpdateLoginDisplay is called which may trigger timer restart. There are 3 possible solutions here: (a) remove DCHECK and allow to restart the timer with re-calculated timeout, (b) let the timer run unil it fires, or (c) add additional logic to check what triggered UpdateLoginDisplay. Option (a) was selected as the simplest one. Bug: 871109 Change-Id: I7b5a4ddb0a9fc698bb45eb6974d502f37bc1be86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485260Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Cr-Commit-Position: refs/heads/master@{#818979}
-
Mei Liang authored
This is a reland of ed41365b Reland note: reason for revert: Newly added tests testLayoutObserverNotification_ShowAndHide_TabSwitcher failing consistently on android-pie-x86-rel. This is due to: 1. Different Android AnimatorSet implementation Since Oreo. It listens for Choreographer periodic next frame callbacks. Choreographer always post callbacks to the thread that started the animation. With using TestThreadUtils.runOnUiThreadBlocking, StackAnimation would consider un-finished within the runnable. Therefore, the test timed out. 2. There is an AnimatorTestRule that can be used for testing, so the AnimatorSet does not rely on the Choreographer. However, it's in androidx library which it has not been migrated yet. The current solution is to disabled this test for api greater than N. Original change's description: > Introduce LayoutStateObserver to notify the state for all Layouts > > This CL introduces a generic LayoutStateObserver for getting > notifications from the Layout system about every supported layouts > show/hide state changes. This LayoutStateObserver is added to the Layout > system via the LayoutStateProvider. > > Additionally, this CL merges the SceneChangeObserver interface into > LayoutStateObserver: > * SceneChangeObserver#onTabSelectionHinted -> > LayoutStateObserver#onTabSelectionHinted > * SceneChangeObserver#onSceneChange -> > LayoutStateObserver#onStartedShowing > > Note: > 1. This CL breaks from crrev.com/c/2353875. > 2. This new notification system has been integrated to production > code with zero callers. > > Change-Id: I23bd2b5b1b674a6df554a2edd1ffbfb32da5d6b1 > Bug: 1108496 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463850 > Commit-Queue: Mei Liang <meiliang@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818290} Bug: 1108496 Change-Id: Ife05dfda9bd688359df43e8593b56c614af92489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486623Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818978}
-
Marc Treib authored
Inlining MarkDataTypeAssociationDone into its single call site makes it obvious that State::ASSOCIATING and associating_types_ only exist / are non-empty within StartAssociationAsync(). Bug: 1102837 Change-Id: I7b95ad3100001694b7a762d0ccae4b2c52cb16a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479423 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#818977}
-
Xing Liu authored
Deprecate metric "Download.ParallelDownloadAddStreamSuccess". Bug: 1127951 Change-Id: I534468866d00f42b00575c6143c282b05c3a2c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485840Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640, 763949, webrtc:10509 Change-Id: I7e586fe8f2dcb6de4cb29aafbb5490aa9835953b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485299Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#818975}
-
Justin Cohen authored
Adds a configurable GN flag |lock-to-version| to set the main plist CFBundleVersion to a constant MAJOR.MINOR.BUILD value and a variable 'MAJORPATCH' in the normal PATCH tuple. Bug: 1140474 Change-Id: I570a6502a438c60a5bd3822c60072ab5fd677ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485679 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#818974}
-
Nate Chapin authored
Bug: 1139878 Change-Id: I3a86211116391a536e4b3e7631e30c825cc162fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485628 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#818973}
-
Benjamin Beaudry authored
Some elements were skipped by Narrator because NormalizeTextRange called in AXPlatformNodeTextRangeProviderWin::GetAttributeValue modify the internal endpoints, while Narrator doesn't expect the range to be modified in a function like GetAttributeValue. In this CL, we now operate NormalizeTextRange on a clone of the |start_| and |end_| endpoint and use the normalized endpoints to get the attribute value. We do the same in FindAttribute. In ExpandToEnclosingUnit, Narrator does expect the range to be modified so I believe it makes sense to normalize the internal endpoints. Bug: N/A Change-Id: Ie202a7ee3e4b4e08c95c6361260c54b941c85b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481743Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Victor Fei <vicfei@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818972}
-
Xing Liu authored
We are still doing A/B testing for query tiles for different set of configs. This CL extends the expiration date to M91. Bug: 1125748 Change-Id: I6da6774bc3d9f59132016440e0047f6bc88680f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485876Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818971}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/429410096af9..cdba9badd3b3 2020-10-20 tvanderlippe@chromium.org Disallow editors of reading legacy file symbols 2020-10-20 andoli@chromium.org [ts] Typecheck snippets/ScriptSnippetFileSystem.js with TypeScript 2020-10-20 kimanh@chromium.org Adding linear memory inspector navigator component 2020-10-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-20 tvanderlippe@chromium.org Move startup files to GN If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1110202,chromium:1131500 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7a2de059204d637939973b394475590406297839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487168Reviewed-by:
-
Lukasz Anforowicz authored
Motivation for this CL ====================== Before this CL url_formatter::FixupURL could transform URLs of renderer-initiated navigations. This may have allowed an attacker to "launder" URLs past early filters (if the initial URL provided by the attacker looks benign, but after passing the filters is transformed by FixupURL into a malicious form). The following bugs in the past seem to have been at least partially enabled by this transformation: - Laundering a "javascript:" URL: https://crbug.com/1116280 and https://crbug.com/850824 - Omnibox spoof due to the modified url: https://crbug.com/449829 and https://crbug.com/657720 - Invariant violation due to a difference between virtual url and regular url: https://crbug.com/895065 Before this CL, url_formatter::FixupURL was called for renderer-initiated navigations via WillHandleBrowserAboutURL. This doesn’t seem necessary per the TODO in this function asking to "Eliminate "about:*" constants [...] then hopefully we can remove this forced fixup". Note that BrowserURLHandler::SetFixupHandler has been introduced in r316923 as a workaround to ensure URL consistency by adding FixupURL in one more place. If FixupURL wouldn’t be called from WillHandleBrowserAboutURL, then BrowserURLHandler::SetFixupHandler wouldn’t be needed in the first place. Finally, https://crbug.com/1130091#c3 points out that url_formatter::FixupURL should only be invoked on user input (e.g. URLs typed into the omnibox and used for browser-initiated navigations) rather than on arbitrary URLs. Summary of changes in this CL ============================= Based on the above, the CL: - Removes the FixupBrowserAboutURL call from WillHandleBrowserAboutURL - Removes the BrowserURLHandler::SetFixupHandler method and related code - Fixes tests so that they use the final URL form (rather than relying on the FixupURL call) - Adjusting expectations of tests that were testing laundering scenarios The CL also opportunistically: - Simplifies WillHandleBrowserAboutURL (path transformations were a no-op; early return for kChromeUISettingsHost and kChromeUIHelpHost can be consolidated) Testing ======= Manual testing: - Verified that "about:version" typed into the omnibox still ends up navigating to "chrome://version/" - Verified that renderer-initiated navigations to "about:version" are translated into "about:blank#blocked" by RenderProcessHostImpl::FilterURL Bug: 1130091 Change-Id: I9a9f32d4d9c0ec630c2110679efe0c1d18b4370b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441284Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#818969}
-
Vincent Boisselle authored
Change-Id: Ia01b8458da01d15fdf15beefbfa75c5b01a6fc12 Bug: 1138000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469517 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#818968}
-
Gang Wu authored
Bug: 1138729 Change-Id: I5c9b3cbf04e5bfebcc71d4ef1248da179f0ef8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481058 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#818967}
-
Wenbin Zhang authored
Before making changes on how to generate the shard map to run the same benchmarks on multiple devices, manually update the shard map to try things out. This also allow starting to work on merging results from multiple devices. Bug: chromium:1140389 Change-Id: Ic89b82e642d8fb11be889acd372edf22dd96c7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486576 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#818966}
-
Clemens Arbesser authored
This makes it easier to control the amount of data we send in the RPC. It's also cleaner this way, and furthermore, this is in preparation for a new RPC, which lite_service will communicate with, but service_impl will not. Bug: b/171178550 Change-Id: Idbab2402ede4f4473575baf4254ed0cc13d0c7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485254 Commit-Queue: Clemens Arbesser <arbesser@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#818965}
-
Jesse Schettler authored
For each scan source reported by lorgnette, use its scannable area to determine the page sizes it supports. Add these page sizes to each ScanSource reported by ScanService. Bug: 1059779 Change-Id: Id909260f2de8eeebf15d1d67776403c993b81c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481742Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#818964}
-
Dominik Röttsches authored
We still want to track DirectWrite stability and timings. Fixed: 1138262, 1138263, 1138264, 1138265, 1138266, 1138267, 1138268, 1138269, 1138270, 1138271, 1138272 Change-Id: I9515e25d26093bc98830b716311b4714e0c3d941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475795 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
According to the spec, it is expected that preedit_string is sent only when the preedit is updated. Bug: 1139731 Test: Test manually with SHIFT+LEFT + JP IME. Ran exo_unittests. Change-Id: I650ac18b585c00901671633e0f50221fd84ac66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485666Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#818962}
-
Dave Tapuska authored
A lot of the core functionality has moved into blink. Yet a number of using and include definitions were left behind. BUG=1097816 Change-Id: I03092d6f2944d1aab549c89673f7bc7e6cfbef81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487221Reviewed-by:
-
Victor-Gabriel Savu authored
Allow fake login to continue without an OAuth cookie to fix the fake enterprise enrollment. Bug: chromium:1140422 Test: tast run <ip> policy.SystemTimezone Change-Id: I75985607421c370c610336b1afbcf5b7c708da89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487268 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818960}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cd74dfa47721..13fa34606b78 2020-10-20 kjlubick@google.com [infra] Sync to latest infra repo. 2020-10-20 bsalomon@google.com Remove legacy SkImageGenerator YUV planes interface 2020-10-20 johnstiles@google.com Improve gencode for inlined blend and composition functions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I442fb2041043b59099020da2ad04969b4470ecf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487209Reviewed-by:
-
Tommy Li authored
This CL is a followup to: https://chromium-review.googlesource.com/c/chromium/src/+/2485561 It ports one more browser test to a unit test. Bug: 751031 Change-Id: I56928ef473e3a14982c2fec0d900176c3175de9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485562 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#818958}
-
Antonio Gomes authored
... and rename it to ImmersiveModeControllerChromeos. CL also adapts chrome::CreateImmersiveModeController(), the helper that create instances of ImmersiveModeController (see immersive_mode_controller_factory_views.cc). This is phase 3, on the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: I9d13060bae1098ff7026b65e21545373503cc4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486114 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
