- 20 Jan, 2021 40 commits
-
-
Roman Aleksandrov authored
Split skip UserAction, update ExitReason suffixes. Fixed: 1156172 Change-Id: Ice46677aa47673040029fe72f55807d6841e5fde Bug: 1156172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632689 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845401}
-
Henrique Ferreiro authored
This class is test and Chrome OS-only. Move it to chrome/browser/chromeos/login/test. The .cc/.h files are also moved to the build target //chrome/browser/chromeos:test_support, together with some of its dependencies. Bug: 1164001 Change-Id: I12331c093a8b1ec42153a07d20dd4397c1ed8d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632745 Owners-Override: James Cook <jamescook@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845400}
-
spdonghao authored
This CL ensures MV tile icon to be updated when a new icon is fetched. Besides, a test is added for the correctness of MV tiles order. Bug: 1166238 Change-Id: Ic6d7157c6f03d24b02d38171f0727bf2b6a56463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627748Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#845399}
-
Alison Maher authored
When Forced Colors happened at computed value time, caret-color would pick up the forced color through currentcolor. However, now that we are forcing colors at used value time, it appeared that caret-color regressed since it no longer picks up the forced currentcolor. This change adds caret-color to the properties that are adjusted in Forced Colors Mode, and forces it to use the forced currentcolor. I've opened a new spec issue to address this, as well as a few other color properties that I noticed would also be affected by this: https://github.com/w3c/csswg-drafts/issues/5873 Bug: 1166392 Change-Id: I239700441ed17bfd0b33443887a0c72793843cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627779Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845398}
-
Aleks Totic authored
Span attribute means that COL/COLGROUP span multiple columns. Old code incorrectly defined background geometry separately for each column. This happened because I just ported handling of "width". width attribute applies to each column within COL/COLGROUP. New behavior is intuitive, and matches FF. Change-Id: Ibdd397825ed363de2695f4ff43dd8dd4df065357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633438 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#845397}
-
Sigurdur Asgeirsson authored
It appears that dead shared and/or dedicated worker clients of a shared worker may have outstanding client registrations as the service worker starts. Bug: 1168113 Change-Id: Ie19f3fb90c9252502a29eadfa1bec52acd6e5f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637256 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845396}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/812c73cdc25a..0be184647794 2021-01-20 danilchap@webrtc.org Fix enabling DependencyDescriptor for VP9 with spatial layers 2021-01-20 brandtr@webrtc.org Add `.cache` to .gitignore. 2021-01-20 danilchap@webrtc.org Cleanup FakeRtcEventLog from thread awareness If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I77eefe3f5ed2bc58e611f69a034c24b4c3e19b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845395}
-
Mounir Lamouri authored
Fixed: 1167843 Change-Id: Ic4f3a5bcd88ea036a6ec82ddc91d0946622c7968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639654Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#845394}
-
Jeffrey Kardatzke authored
The RG16_EXT format was added to resource_format.h, but not added here. This is causing mojo validation errors with P010 surface because they are outside the allowed enum range. BUG=b:178022921 TEST=Mojo validation error is gone Change-Id: Ia8e5d9fa433e5bcfc30550fbd10a6e929a5199bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639219 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#845393}
-
Scott Violet authored
for testing. This was requested by Patricia. BUG=none TEST=none Change-Id: I88c61ae43d02a611efbfc868861a10250144b838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640813Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#845392}
-
Andres Calderon Jaramillo authored
Bug: 1167768 Change-Id: I3d237173fca7658d9e4ad9c88b51e4a899efd4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637726 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#845391}
-
Tom Sepez authored
These were fixed for standalone PDFium at https://pdfium-review.googlesource.com/c/pdfium/+/73015 but still persist in Chromium's version of /.gn Change-Id: I57fa0250a5a668935978988d949311d86f9bc244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640922Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#845390}
-
edchin authored
This CL makes it possible to further extract web_contents from the base classes of PasswordProtectionService and PasswordProtectionRequest which will be moved to /core. The content or ios derived class implementations of ShowModalWarning can extract WebContents or WebState respectively from the request object. Bug: 1147967 Change-Id: I1f2d4b580a2dc83b5ae23db6a79db59bf8303d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633968Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845389}
-
Theo Johnson-kanu authored
- This CL adds a sub label to cellular networks which have not yet been activated to indicate the user can click and activate that network. - Opens new cellular setup dialog when "click to activate" is clicked Screenshot: https://screenshot.googleplex.com/3hmXeFo7gPQhcBZ.png Bug: 1093185 Change-Id: I5f7df05123be56e97c74125313263ff50d0a0124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629989 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845388}
-
Frank Liberato authored
To help track down the cause of excess dxva usage from D3D11, this CL adds a sparse histogram of media::StatusCodes that are returned from D3D11VideoDecoder and the H264 / VP9 accelerators. Bug: 1168304 Change-Id: If2c3c1990cf50776c69958048b7b9c2969095c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638247 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Bug: 1164001 Change-Id: Ic4018a71196b0c6e0e9f616873aacaf826155cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640055Reviewed-by:
-
Josh Simmons authored
Also updating histograms in other/ to use my @google.com address, as that's what I use for code reviews. Bug: 1165257 Change-Id: Ic097d36841e66127859967fb2e844185079a1dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631331 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845385}
-
Jeffrey Young authored
This corrects two issues with suspend: * Ambient mode does not restart when waking up from suspend * Flash of old Ambient mode photo displays when opening lid from suspend Block Ambient mode from restarting after |SuspendImminent| until |SuspendDone| is received. Upon |SuspendDone|, also restart Ambient mode lock screen timeout if appropriate. Start Ambient mode, close lid while active. Reopen lid, wait 7 seconds, Ambient mode starts again over lock screen. BUG=b:177325727 BUG=b:177692036 TEST=ash_unittest --gtest_filter="AmbientControllerTest.*Suspend" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I8d52af80ab7dd49538998d0e8831ee3c10d2919a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625727 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845384}
-
Tomasz Wiszkowski authored
This change rearranges the steps of the SortAndCull to ensure the Matches with Headers are only grouped and demoted after the GroupBySearchVsURL completes. This update prevents the GroupBySearchVsURL from pushing the URLs below the search suggestions, including the matches with group headers. Bug: 1165941 Change-Id: I70ea0815ab2c2c8b652368819c2eef1c40f692ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626188Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#845383}
-
Esmael El-Moslimany authored
See https://bugs.chromium.org/p/chromium/issues/detail?id=1167463#c7 for screenshots of change. The total vertical space saving is 36px. Bug: 1167463 Change-Id: I82eb57e7a56202024b9fc1ed31ca2b3d2292fa21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637186 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
Makes the middle slot promo Finch-configurable. Flag is enabled by default. Bug: 1166869 Change-Id: If6d4e06577f99b635f04fbe406334b66f62210b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638934 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845381}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/40fbf5738639..80d2a97665e9 2021-01-20 tmathmeyer@chromium.org Hide overflow caused by excessively long urls. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I722855faa917d419713201a5dc7268b26709a844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640886Reviewed-by:
-
Sinan Sahin authored
This CL adds a feature flag and a common interface for the different Contextual Search panel implementations. Binary-Size: Increase is temporary while we experiment with refactoring Bug: 1147611 Change-Id: I7c0b264846c5a19c61a9830222f21525daf42b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638777 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#845379}
-
Torne (Richard Coles) authored
On Android we create the renderer main thread from Java instead of using the process's actual main thread (which is functioning as the Android looper). This means that rather than the stack size being determined by the kernel's defaults, it's determined by the JVM's defaults, which are considerably smaller, and we overflow the stack in rare cases that work on other platforms. Use the stackSize parameter to the Java Thread constructor to request a larger stack: 4MB in 32-bit processes and 8MB in 64-bit processes (to match crrev.com/c/2490667 which set this for Windows). This parameter is not required to be honoured by the JVM but ART on Android does use this as a lower bound on the thread's stack size on all the Android versions we care about. Verified that this works by inspection of /proc/$pid/maps on ToT Android, which gives names to the thread stack mappings that include the tid (earlier versions of Android do not do this and there's no easy way to tell how big non-main-thread stacks are). Fixed: 1151869 Change-Id: I42e0bd987abc4f57a65e1c25436568eb51d8ac02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625887 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#845378}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3c06205b28b..477bd92472cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I91669c7eb0ffb88696494a31b93471bc689f96f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639164Reviewed-by:
-
Matthew Denton authored
Add blink::ContainerNode::hasChildren() to shadow blink::Node::hasChildren() to avoid the virtual dispatch that leads to at least 7-12% regressions in some blink query-selector benchmarks, when we know the type statically to be ContainerNode. This is especially bad on Android, where the blink::Node::hasChildren() function is big enough not be inlined, so we miss out on extra optimizations. See the linked bug for a more in-depth analysis of the regression. Bug: 1149340 Change-Id: Ida1d8b609b23ada25ae5ed67826439c74633721c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633194Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#845376}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b1c73ad500b..8a9da73687e3 2021-01-20 johnstiles@google.com Fix overzealous optimization of short-circuits. 2021-01-20 fmalita@chromium.org [svg] Fix handling of root element position attributes 2021-01-20 johnstiles@google.com Optimize (boolExpr == true) and (boolExpr != false) into boolExpr. 2021-01-20 brianosman@google.com Add ExternalFunction support to SkSL-to-SkVM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I159c236bdb828e124fae600ca5c5508d42487da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640884Reviewed-by:
-
Wei Li authored
Bubble locking was used to prevent bubbles from being dismissed after deactivation. This CL adds general widget blocking by preventing widgets from being dismissed after deactivation. The impl extends the ways of disabling widget activation changes to achieve that. Bug: 1167285 Change-Id: I8b67a7d00e1f1fb9f598d51460e162d111b3110b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638000 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#845374}
-
Leonid Baraz authored
In ScopedReservation destructor did Reserve instead of Discard! This is now fixed; tests will be added separately. Bug: b:159361496 Change-Id: I6cf8932ff113e53a6c15564675135406d81fccc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640820 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#845373}
-
Alex Ilin authored
This CL leverages the already existing kIsOmittedFromProfileListKey preference in ProfileAttributesEntry to mark profiles that shouldn't be shown to the user. kIsOmittedFromProfileListKey was created for profiles in the middle of being set up as new legacy supervised users. The preference was dead because it was never set to true. This CL revives it and adds additional checks to profile_picker_handler.cc and profile_menu_view.cc to not display omitted profiles. Bug: 1126913, 1166809 Change-Id: Ieb05f31d8951f2971201351bead7c108eb874473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632752 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#845372}
-
Wojciech Dzierżanowski authored
With the previous set-up, MediaWebContentsObserver::BindMediaPlayerHost() contained a hidden assumption that a RenderFrameHost uniquely identifies a media element. When another element was created within the same frame, BindMediaPlayerHostReceiver() would reset the connection to the renderer that was set up previously. As a result, MediaPlayerHost messages for the media elements created earlier were not reaching the browser if a frame created multiple media elements. To fix this, we add support for multiple MediaPlayerHost connections from a single frame, one for each HTMLMediaElement, with each HTMLMediaElement calling mojom::MediaPlayerHost::OnMediaPlayerAdded() through a dedicated connection. The disconnect handler for MediaPlayerHost receivers is gone. It could have been reimplemented as a handler on the ReceiverSet, removing MediaPlayerHostImpl from MediaWebContentsObserver when the receiver set becomes empty. However, this removal is effectively a 'delete this' operation and it doesn't seem necessary. By the time there are no receivers, the MediaPlayerHostImpl object is just an empty ReceiverSet and two pointers. It is cleaned up upon render frame deletion. Bug: 1167154 Change-Id: Idd7873da91ee452c91b2f4667f29a1aa80831678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632691 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#845371}
-
Xing Liu authored
Keep the bookmark UI reading list page open after the user open a reading list page in CCT. Bug: 1163719 Change-Id: Ibfdd1045301bcf7de5dcb301877f2b4394181bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639220Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845370}
-
Austin Eng authored
Bug: 1164115 Change-Id: Id009288173d3a05c6c87f17a97eb9f359a58a17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640993Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#845369}
-
Russell Hawkins authored
Run set_adjust_if_offscreen(true) after group editor bubble is created so that it doesn't go offscreen. Bug: 1162253 Change-Id: Ic9161cc65ea2ae2a00a925c5db4c93514ee002ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638248 Commit-Queue: Russell Hawkins <thatguyrussell@google.com> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845368}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611153816-d2f18273110c533af9e6c4795ef7f831ac05328f.profdata to chrome-win32-master-1611165592-7dc454a3a93e8067ea7c07bb6e94372701a24ad7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6a1cd4dd776a0188707a785046c136b52abd4f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640882Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39ca1963aa25..15c630fcaa35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harringtond@google.com,gab@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968,chromium:1151505,chromium:1164189,chromium:1166926 Tbr: harringtond@google.com,gab@google.com Change-Id: I3959a8e5e8f1ee21da9e0422059678dfd52132e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640706Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845366}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chromeos/components/proximity_auth. Bug: 1007654 Change-Id: I55f3a3a1a4b30a628f106886ffa9937c01849fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637412 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845365}
-
Moe Ahmadi authored
- This is step 1 to transfer ownership of realbox to the omnibox team. - The next step is to move the realbox resources into their own dir. Bug: 1159934 Change-Id: I19c7eb5253524d393c1bed9e0c9b0a36ac23c4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595205 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Shane Fitzpatrick authored
Regression checklist: https://docs.google.com/spreadsheets/d/1RnMjwDc4KkvxIY9fbjCJnborlawdlJOVfBJWejl6DZM/edit#gid=486249825 Fixed: 1102458 Change-Id: I94f17817b56a3c435cd5561f275441a677a591d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638974Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Cr-Commit-Position: refs/heads/master@{#845363}
-
Bailey Berro authored
This change wires up the RoutineLog to SystemRoutineController so that the log is added to anytime a routine starts or finishes. Bug: 1128204 Change-Id: I2ff1e23fccb4a3f6891ffa8a7a8c118278618c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632872 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#845362}
-
