- 17 Jun, 2020 40 commits
-
-
Fredrik Söderqvist authored
These structures are trivially destructible (and constructible), so don't need to use DEFINE_STATIC_LOCAL here (replacing code space with data at a net reduction). Change-Id: I3b23a7daad9cf4e1fdc1db856b89f9ae3e01a021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247888Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#779287}
-
Alexander Hendrich authored
This CL adds permission warnings for these enterprise APIs: * enterprise.deviceAttributes * enterprise.networkingAttributes * enterprise.platformKeys Bug: 1080698 Change-Id: If8444762354f940fd4d592e6808da1bd6daf21c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203056 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779286}
-
Caitlin Fischer authored
In the below comment, it was requested that the corresponding Android test be removed. https://chromium-review.googlesource.com/c/chromium/src/+/1869007/12/chrome/browser/metrics/ukm_browsertest.cc#b646 Bug: 1049736 Change-Id: Iac3ff27fc4d8145bef53d45aecb54efeda5e55f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245049 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779285}
-
Oriol Brufau authored
This is a reland of a53560e3 The problem in the reverted original patch was that I forgot to clear marker_style_sheet_ in CSSDefaultStyleSheets::PrepareForLeakDetection. Then, when running tests with --enable-leak-detection, it could happen that EnsureDefaultStyleSheetsForPseudoElement would think that the UA rules for ::marker were already in default_pseudo_element_style_. But it would actually be empty, so the ::marker could get no rule, making HasMatchedProperties() be false, so PseudoStyleForElementInternal would return false, and PseudoStyleForElement would return a nullptr style. So there would be no ::marker. Original change's description: > [css-pseudo] Set default ::marker styles in a real UA sheet > > Before this patch, default styles for ::marker were assigned manually > when resolving the style. The problem was that, since the rules didn't > actually exist in any stylesheet, they were not exposed in devtools. > Also, devtools assume that if a pseudo-element exists, it must have some > rule. This could not hold for ::marker, and then trying to add styles > to it would fail. > > This patch fixes that by making the styles actual UA rules. However, > adding a '::marker' selector directly to the UA sheet for elements would > be bad: it would match every single element (even non-list-items) due to > the universal selector, and then it would set an internal bit for the > marker. So HasAnyPseudoElementStyles() would return true, which means > extra work when handling style changes. > > Therefore, this patch adds a new UA sheet just for pseudo-elements. This > sheet is not used for elements, ensuring that HasAnyPseudoElementStyles > is still false if there are no author styles for a pseudo-element. > > The selector parser was treating ::marker as invalid if the runtime flag > CSSMarkerPseudoElement was disabled. But now it's accepted in that case > for UA styles. > > There already was a kHasMarkerPseudoElement counter to track how widely > used is ::marker on the web. Now this counter will only be incremented > for author rules. > > Bug: 457718, 1082377 > > TEST=blink_unittests --gtest_filter=StyleResolverTest.CSSMarkerPseudoElement > TEST=blink_unittests --gtest_filter=UseCounterHelperTest.CSSMarkerPseudoElementUA > TEST=blink_unittests --gtest_filter=UseCounterHelperTest.CSSMarkerPseudoElementAuthor > TEST=http/tests/devtools/elements/styles-2/pseudo-elements.js > > Change-Id: Ib5583dc1952bfec2cce8f33fe8332cc39016c34a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239579 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Cr-Commit-Position: refs/heads/master@{#778303} TBR=mkwst@chromium.org Bug: 457718, 1082377 Change-Id: Ib6a2482ac474a424c3dfeb05fb2e2c00ce29b732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247790Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#779284}
-
Friedrich Horschig authored
This CL simplifies the string to avoid any misconceptions about the generated password and ensures consistency with the well-known button for sync users. Screenshot: https://photos.app.goo.gl/tBgMgFryH3zP9FhR9 Bug: None Change-Id: Ia7d9a5667319e86769f9ee764f9db441f373d11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248625Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779283}
-
Morten Stenshorne authored
We were setting the actual block-size of the multicol container correctly, but didn't include the block-end border and padding in the intrinsic block-size, which is stored in the layout result, and used by flex layout in some cases. Bug: 829028 Change-Id: Idae7ac501b35ed24f3d7fbace8378492dc8700d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247827Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#779282}
-
Roman Aleksandrov authored
Time is not guaranteed to always increase, this may cause mistakes in metrics recording. Bug: 1095058 Change-Id: I71e0333be9547c6b99e9e9c081754a5f8b20bb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247891 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779281}
-
Sylvain Defresne authored
New version of gn generates a single project file named all.xcodeproj, so fix the script to only look for that file. Also fix it to delete the old projects and workspace from output directory to avoid users opening the wrong project and being confused by the possibly incorrect list of files. Remove the code to wipe the code signing identity since this is now correctly set by gn in the project. Bug: none Change-Id: I4cc6bfd1a3d3be9ed3c8d1a07805b088068852d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248681 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779280}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6476d0bf02d2..a46fce2194df 2020-06-17 kron@webrtc.org Update rtp_utils to support two-byte RTP header extensions 2020-06-17 nisse@webrtc.org Delete MediaTransportInterface and DatagramTransportInterface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1ee1d9cce8c5ce2196646cee743551dcf06ad43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249700Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779279}
-
Yunke Zhou authored
Bug: 1095916 Change-Id: I87ff398744198ddfbe351c4f4b16e8e78bfe3404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240860Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#779278}
-
Luca Hunkeler authored
With this cl it's now possible to specify a list if ElementCondition in the ShowGenericUi action. This will start a WaitForDom that will regularly check the conditions and write the result into the model. Bug: b/156077960 Change-Id: I3fd8b21de50b8eb969a8b5a617ccbe8358b3da34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238827Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#779277}
-
Paul Lewis authored
As per https://web.dev/first-meaningful-paint/, FMP is a deprecated metric. This CL removes FMP from the test expectations ahead of its removal from the implementation. Bug: 1096008 Change-Id: I5eaad8dac97546632414c85105d6e3ce60c54e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247829Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#779276}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/340da1459b4d..9db618ccd9c6 2020-06-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 8cbee4107cf1 to 763957e6b4fc (8 revisions) 2020-06-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 52a5f074e9bb to a7112d544b2e (3 revisions) 2020-06-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 00965b9fa9a8 to 051c6fed884b (5 revisions) 2020-06-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 03d0006b6d5e to 04f0b691eb4c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I8b20a923efd408c2c6cabbaae7218a6514d78a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249636Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592318647-7dde799a5671d21565d3d7d630fb811f29f03533.profdata to chrome-win32-master-1592384236-ee91207a6b4e00f77c95555e5c7822ae3e4b8a11.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I267b60fd84821171e9954be0926bc6b815217e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249633Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592351803-4940076c03ac19da5d52d5b5b79c0e1485ea8a61.profdata to chrome-win64-master-1592384236-59c052c5d04aee966d200af8272c6f3b6edf1818.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I95c13e2c468b3ad0d7b8218066048ebd9fb1a386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249634Reviewed-by:
-
Nohemi Fernandez authored
- Removes the SigninInteractionCoordinator class and helpers and moves all relevant sign-in code directly in the SceneController. - Moves all testing code to the authentication/signin directory. This patch is part of a series of migrations to remove the old sign-in architecture as described in go/chrome-ios-signin-migration. Bug: 971989 Change-Id: I4d2b8ae90a1a7666fad0d60cab33f3fc001e3654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238046 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#779272}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I87f5aed54ba38b33ccfa47df2cfef73b0997daff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249585Reviewed-by:
-
Ioana Pandele authored
[Sheriff] Set expectations for flaky http/tests/inspector-protocol/target/target-expose-devtools-protocol.js TBR=hablich@chromium.org Bug: 1092975 Change-Id: I6bcf5986ad93a072cd7eeca4f4a89c6d41d113a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247796Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#779270}
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: I0b02f301bfc7fc16ba22e29ba0740d9cd83d708d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246591 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#779269}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/26c8e338b587..d76df5326646 2020-06-17 tvanderlippe@chromium.org Set defaults of insets to 0 to reduce binary size If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1095614 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifef719e1124cf5a06e86971605fd7483f0d90edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249637Reviewed-by:
-
David Munro authored
It's enabled by default and expired, so remove it and clean up the code. Bug: chromium:1094867 Test: Browser, Manual (install Crostini) Change-Id: I3c1c54c8c1053a33fd43b9336711b3c936d39947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245988 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#779267}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4db954eec112..6476d0bf02d2 2020-06-17 tommi@webrtc.org Consolidate creation of DataChannel proxy to a single place If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9bcca516e0953d817ef622afc3be698ebb79fbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249631Reviewed-by:
-
Alexander Hendrich authored
This feature was initially meant for testing of apps that were supposed to be added to the whitelist later on. However, this feature was never really used and we have other means (e.g. custom chrome image) to test this instead. Removing this feature allows the DeviceLoginScreenExtension policy to be restricted to the explicit list of whitelisted apps/extensions. Bug: 1091690 Change-Id: Ie1d490922724affa012295bb6dcb8e9431aa150c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232399 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
This CL adds a new API to read the device's local IP and MAC address if it is connected to a network. This API is only available to force-installed extensions in an affiliated context. Bug: 1081333 Change-Id: I5d8cb5f20b8dfabf8be503b99ac264a8ea6b03b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197117 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
This feature toggle disables commits of bookmarks if favicon is still loading. Bug: 1061411. Change-Id: Ie7f1a6f3ad4a809e1c1cb3e112a0582ca0bf38f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235692 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#779263}
-
Julian Pastarmov authored
Now it returns error messages that contain the actual error code of the OS level issue that caused the call to fail. BUG=1095648 TEST=unit_tests:EnterpriseReportingPrivateGetPersistentSecret* Change-Id: I26a8e5110e75d6c694db33e1f161340108b9c816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247884 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779262}
-
Ioana Pandele authored
This reverts commit 7811e701. Reason for revert: This broke the bots again after the internal change landed. TBR=chouinard@chromium.org Change-Id: I7dadfcf3ae19508156369e1877385be7e54f73ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247730Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#779261}
-
Fergal Daly authored
Add - decl in .h file and impl in .cc - hint about needing CONTENT_EXPORT Change-Id: I463315e961c2c80e713f1aee8e1da72b6d86a5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237436 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#779260}
-
Rayan Kanso authored
Change-Id: I23c43c704aaf3484d495560f0f1659bcc7534916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248565 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#779259}
-
Ioana Pandele authored
TBR=smcgruer@chromium.org Bug: 1095969 Change-Id: I7c7e5bec55dc945b56539f09061598f2208e32bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248682Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Icd6683a7cd408a81b08b02060ecb1b76fc196bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249698Reviewed-by:
-
Christian Dullweber authored
Show account-scoped passwords in Clear Browsing Data. Also some cleanup of other counter code. Bug: 1086433 Change-Id: I4f0fcdb26325d21a080b84cbad909a4c6d4c449a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237932 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
Before this CL, the list of fields to ignore that we've gathered so far in //tools/clang/rewrite_raw_ptr_fields/fields-to-ignore.txt had two sections: 1) fields manually added to the list 2) fields automatically added to the list, during one of previous runs of the rewriter. This CL removes the second section of the file, because: A) that section has been growing stale B) it is easy to accidentally include the stale section during a rewrite. When we are actually going to start the SomeClass -> CheckedPtr<SomeClass> rewrite, *then* it should be okay to once again save the automatically generated fields-to-ignore.txt (preserving knowledge of the fields that were actually excluded at the time of the rewrite). Bug: 1069567 Change-Id: I9d0a9f411709d7c8a2caebc16e64ef1695a9f410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247143 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#779255}
-
Jose Dapena Paz authored
std::unique_ptr requires including <memory>. Bug: 819294 Change-Id: I0da9f4affbdfd7a55f54e0e1f744b8f4483d386b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248678Reviewed-by:
-
Maksim Ivanov authored
Avoid assert'ing on the "location" header being non-empty, and restore the original handling (before r746703/r745762) that was treating this as not having the "choose what to sync" option enabled. This header happens to be empty in some browser tests, and also it might potentially be empty in real-world usages. Bug: 1033936, 1054394 Change-Id: I65aaa1a71cd86b5cf80be57a9407bcea41c80bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248192Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
This CL updates included files so that the .cc file doesn't rely on included files in v8_trusted_type_policy_options.h. Bug: 839389 Change-Id: Ieb26048f908b5d019902d2159fbae490d140c5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249401 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#779252}
-
Mohamed Amir Yosef authored
This is a reland of 3a58dbb7 after initializing |destination_dropdown_| which caused failures like here https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8877299825241158736/+/steps/unit_tests/0/logs/Deterministic_failure:_PasswordSaveUpdateWithAccountStoreViewTest.OnThemesChangedShouldNotCrashForFederatedCredentials__status_CRASH_/0 Original change's description: > [Password] Add the Account Storage Promo to the Save Bubble > > Screenshot: https://screenshot.googleplex.com/NdctJthyEtR > > Bug: 1044038 > Change-Id: I32a70d3ab46302c1fd2311f79b48c8558fee2e7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220048 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778946} TBR=vasilii@chromium.org,twellington@chromium.org,bcwhite@chromium.org, Bug: 1044038 Change-Id: Ib727d1e9d2c8fad4b38708d3a99dcf37e9910440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247887Reviewed-by:
-
Sylvain Defresne authored
Downstream code has been converted to overload the version of the method taking base::Time parameter. Remove old int64_t version of the method. Bug: none Change-Id: I744fb0c345aeec963c2ca1f8010713a591680271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245909 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2b2b0b86339..26c8e338b587 2020-06-17 patrick.brosset@microsoft.com Introduce a few unit tests for the grid overlay logic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I65bf774752f4ed7cd7d680ae9a51c0084efe88ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249629Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I037c5fa71738596b1527d3e01295a9f7d80594f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249628Reviewed-by:
-
