- 24 Sep, 2019 40 commits
-
-
Eric Stevenson authored
Current can result in unused GN variables if set. Bug: 1005836 Change-Id: I56eef0b9e2c94ee44071c373cc71c0fa4409ce02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822323 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#699523}
-
Robert Ogden authored
"Lite page" is an overloaded term so this moves everything related to the lite page redirect preview into a better named file/class (generally, *lite_page* => *lite_page_redirect*). Note: The LitePageInfobar was not renamed because it is used for all HTTPS-based previews, although it was originally for the redirect previews. Note 2: TRhere are no behavioral changes except for removing an unused mojo datapipe in previews_lite_page_redirect_serving_url_loader.cc, since that was generating warnings. Bug: 1005295 Change-Id: I75ac37ec7555e098a211be35336ab7f0f042b091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819522Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#699522}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the blink.mojom.DisplayCutoutClient interface, and adapt tests. Bug: 955171, 978694 Change-Id: I48cc1a9129b3796a60ff510d18d36a0ad37bd28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817883Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#699521}
-
Sadrul Habib Chowdhury authored
INPUT_EVENT_LATENCY_FORWARD_SCROLL_UPDATE_TO_MAIN_COMPONENT and LATENCY_BEGIN_SCROLL_LISTENER_UPDATE_MAIN_COMPONENT components were only being set on ui::LatencyInfo objects, but were never being used for anything (especially after the 'main_thread_scroll_latency' metric was removed from telemetry). So remove these components. BUG=849719, 1000697 Change-Id: Ia264d06598970fb32a0f21cbb7b2d15f25ffc28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800727 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699520}
-
Sammie Quon authored
It wasn't working as expected, if the screenshot was kept alive, you can still see the top window. A patch [1] was added to make this not the case, but the compositor still draws the frame where the top window was hidden (seen as a flash) even with compositing locks applied. This is OK for enter tablet animation as the entire animation will cover the top window anyways. I will look into a way that works for exit tablet animation. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1797482 Test: manual Bug: 948706 Change-Id: Ic3b7843c70a5f71ac5c5ad0c2e7290af81d01551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804523 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#699519}
-
Jesse McKenna authored
This relands crrev.com/c/1810242, reverted by crrev.com/c/1815802. Unit test ShellUtilRegistryTest.AddFileAssociations was failing on Windows 7 bots when checking for registry key HKCU\Software\Classes\<progID>\Application, because this key is only created by ShellUtil::AddFileAssociations() on Windows 8 and later. I changed this CHECK() to only take place when on Windows 8 or later. Original change description: When an application is registered as a handler for a file type, the name that is displayed in the "Open With..." menu for that file type is controlled by registry value HKCR/<application ProgID>/Application::ApplicationName. This change extends ShellUtil::AddFileAssociations(), which will soon be used to register Progressive Web Apps (PWAs) as file handlers on Windows, to set ApplicationName. This enables PWAs registered as file handlers to appear in the "Open With..." menu with a readable display name such as "My PWA". Bug: 960245 Change-Id: I0790faa2b3eedec82ace2c324ff582515af048aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818429 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#699518}
-
Joel Hockey authored
Change install-linux-package control to use the same FileTasks FileHandler filtering as import-crostini-image. Replaces some of the code from CL:1712667 CL:1730907 CL:1752825 Bug: 1006112 Change-Id: Iba1a6e7bf99f19bad1cd1adb1c858c0c5d1751cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820400 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#699517}
-
liberato@chromium.org authored
Send in MediaLog to MCVD, and use it to log errors during init and decoding. Change-Id: Ia4e0b4689475e5b7fc0cb3bdc1a0ff3a25f6dcf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816133 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699516}
-
Michael Thiessen authored
No functional changes intended - please revert if something breaks. There were many differing callsites of PackageManager#resolveActivity and queryIntentActivities, some of which handled possible Exceptions, some of which handled StrictMode violations, and none of which handled all of these. A followup change will attempt to introduce a presubmit check so that new direct usages of these functions aren't added. Various packages that can't depend on base were not changed. Change-Id: Ibbf7eb4e4aa0b6a80974df898f5418b94e2d1426 Bug: 1006819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816978 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699515}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c2146f2ca2a..b5037ca88923 git log 4c2146f2ca2a..b5037ca88923 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 nihohit@gmail.com Add comment explaining that using mirrors might break git cl. 2019-09-24 fmalita@chromium.org [skottie] Tweak skottie_tool --threads meaning 2019-09-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-24 fmalita@chromium.org [skottie] Multi-threaded skottie_tool 2019-09-24 brianosman@google.com GrGLProgramBuilder cleanup 2019-09-24 robertphillips@google.com Remove compressed format support from the GrGpu::createBackendTexture code path 2019-09-24 bsalomon@google.com Remove workarounds for osmesa 2019-09-24 ethannicholas@google.com Fixed integer divide / remainder in sksl interpreter 2019-09-24 robertphillips@google.com Fix accessing off end of pixmap for R16G16_float in SSE2/SSE4.1 mode 2019-09-24 scroggo@google.com Move is_orientation_marker into its own file 2019-09-24 robertphillips@google.com Clean up cruft left over from addition GrGpu::createBackendTexture chokepoint 2019-09-24 jvanverth@google.com Remove MoltenVK configs from the bots. 2019-09-24 nigeltao@google.com Enable Codec_GifInterlacedTruncated test for Wuffs 2019-09-24 reed@google.com support gpu for skottie2movie Created with: gclient setdep -r src/third_party/skia@b5037ca88923 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:1005615 Change-Id: If0b7c0e8d3ca34dac3cc2f655c01e28f7163e986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699514}
-
Anushruth authored
Without this flag, VM image for betty-pi-arc is not downloaded when gclient runhooks is run. This is reland of crrev.com/c/1815882 as it was reverted in crrev.com/c/1819056. Added parentheses for 'OR' and this should hopefully fix the issue R=bpastene@chromium.org Bug: 1000513 Change-Id: I92792f0ca2b470edb34e8eb5d399afa2dfba5df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820020Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#699513}
-
Akihiro Ota authored
This change adds metadata for the battery and rich text hotkeys so that they appear in the ChromeVox menu, where the user can find details on how to activate them. It also renames the commands so the internal and external naming is consistent. Change-Id: I3e5f53a40660eb7bd83b55c0e180457b3be69f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817154Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#699512}
-
Rouslan Solomakhin authored
Bug: 952283 Change-Id: I462775028293c384f4e87a1a3afe88c844e792b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822720 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#699511}
-
Sky Malice authored
Bug: 1003608, 986836 Change-Id: I7412fed30fbe5d294534d648a82816689e45a444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802518Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699510}
-
Eric Stevenson authored
This CL was partially created by //base/android/jni_generator/jni_refactorer.py. The tests were refactored manually to use JniMocker. This allows us to get rid of ContextualSearchContextForTest. Bug: 929661 Change-Id: I5dcfc91df003d26cefad9aaa2bb2bf0b2afcabf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817117 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#699509}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb4818bc4652..30eeb0c5bf9c Created with: gclient setdep -r src-internal@30eeb0c5bf9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I5f1add89dc782195c50a6a871567287aa6564052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822799Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699508}
-
Shimi Zhang authored
Previously setWebMessageListener(jsObjectName, allowedOriginRules, listener) configured |jsObjectName| and |allowedOriginRules| have a different life cycle than the |listener|. This caused a lot confusion. This CL introduces addWebMessageListener() to replace setWebMessageListener() to allow multiple JavaScript objects to be injected for each call of it. It also resolves an ugly unsetWebMessageListener() API, now removeWebMessageListener() has a clearer syntax. Design: - We will give each frame a JsToJavaMessaging mojo interface per each listener, which is still associated to legacy IPC as the PendingAssociatedRemote is passed through another associated remote. - JS object will use JsToJavaMessaging AssociatedRemote to communicate back to the browser process. - Introducing a WebMessageListenerHolder to hold a listener. Bug: 918065 Change-Id: I5a8e4cc2ff05f2475de92fdbaa7c2579caf08b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770504Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#699507}
-
Elly Fong-Jones authored
We are still using these to tell whether usage of specific a11y features is rising or falling as new OS releases roll out, so let's hang onto them for now :) Bug: None Change-Id: I59aea7044e0443eae7ab4a3620ef89c40c71beac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821977 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#699506}
-
Matthew Mourgos authored
Allow app_list_view and other code within app_list to access the current shelf size where needed. This has become necessary because, when the hotseat flag is enabled, shelf size can change during runtime. Bug: 973483 Change-Id: I90b52cae00ccb90d9d151283804444226fd4a097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815601 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699505}
-
Gabriel Charette authored
One such problematic pref at the moment is kHintsFetcherHostsSuccessfullyFetched found while diagnosing unexpected failures in https://chromium-review.googlesource.com/c/chromium/src/+/1818219 which makes microseconds-since-epoch a realistic (very large) number in unit tests. R=miu@chromium.org Bug: 1004987, 1007427, 634507 Change-Id: I5ebf6a0ef46e2aea704ab5c54372ae77cbe64afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822840 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#699504}
-
Miguel Casas authored
This CL makes chromeos_with_codecs* compile without VA-API hardware acceleration (used for video and image dec/encoding), which is a legitimate target (at least to compile) that in the past has been inadvertently broken. Note that the cros_chrome_sdk* bots (e.g. chromeos-amd64-generic-rel, based on simplechrome checkouts) still compile with the official respective chromeos args.gn, that includes use_vaapi (or use_v4l2_codec). Bug: 1006266 Change-Id: I322fe10cac403fbee0e2ef17732fe38e88c2b564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815846Reviewed-by:
-
Eric Roman authored
(1) Remove null checks for NetLogWithSource::IsCapturing() (2) Inline NetLogWithSource::IsCapturing() This also results in a binary size reduction (546 bytes for Android Arm). Bug: 1006900 Change-Id: I9a947885b3690f4bd8b6f429b5104998f9a3a346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819946 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#699502}
-
Joshua Peraza authored
CrashUploadListCrashpad is meant to be used with a Crashpad report database, but ChromeOS still uses its own report storage and upload tools. Bug: 942279 Change-Id: I805c8ca90491e926207275253d1b4d134e8b1a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822719Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#699501}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba5bc99b6ab9..8b95534d333c git log ba5bc99b6ab9..8b95534d333c --date=short --no-merges --format='%ad %ae %s' 2019-09-24 apolito@google.com [git-cl] allow setting the bug during force mode Created with: gclient setdep -r src/third_party/depot_tools@8b95534d333c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1001709 Change-Id: Ib68963cdb8eb485ee6e017dd46d805bbf3bc3fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823137Reviewed-by:
-
Lei Zhang authored
Global std::map / std::set constants have to be initialized when the program starts. Instead, make them static locals within ValidateAttribute() so they are initialized on first use instead. This remove 123 static initializers. Bug: 537099 Change-Id: I5a3509dc097c214d6e0bd961244cb4c74603500b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820637Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699499}
-
Tommy Steimel authored
This CL adds a new MediaToolbarButtonObserver class for observing events on the MediaToolbarButtonView. This currently only includes the GlobalMediaControlsInProductHelp and the GlobalMediaControlsPromoController, but will be used to make the interactive UI tests cleaner. Bug: 993879 Change-Id: I28d09d926ec7e10379e7e10b6e35c0d328973f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820100 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/410370705505..a8bbe3b252a5 git log 410370705505..a8bbe3b252a5 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 sadrul@chromium.org rendering: Remove some dead code. 2019-09-24 ntfschr@chromium.org Devil: autogenerate markdown docs 2019-09-24 bpastene@chromium.org devil: Roll the fastboot binary-dependency from eac51f2bb6a8 to 28.0.3. 2019-09-24 rmcilroy@chromium.org Revert "Reland "Reland "[Telemetry] Adds the --skip-typ-expectations-tags-validation""" Created with: gclient setdep -r src/third_party/catapult@a8bbe3b252a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:849719,chromium:994517,chromium:1005894,chromium:999335 Change-Id: Ia52582afbea6e4e20b550244cd7c069adbfeb9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822898Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cbf276fd..c38bb894 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iebfd7d4ce71422995b4c0461842a52db5f7281d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822997Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699496}
-
Joel Hockey authored
Enterprise policy can disable crostini backup and restore. When it is disabled, we remove the 'import-crostini-image' FileHandler from FilesApp. Bug: 1003944 Bug: 1006112 Change-Id: I46a58a751002c308eeae3e07be796b956dba5818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808979 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Tom Anderson authored
BUG=419673 R=thestig Change-Id: I89433586961352e0f74d58c4f78caa0c5da61e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820024 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
ssid authored
Trace metadata is almost always discarded in discard buffer mode of perfetto tracing. For this case, add metadata at beginning of the trace. Handles cases when generators are added while tracing. Change-Id: I911794fba1e7b460ca1a7a3a54599a8c05678d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812248 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#699493}
-
Reid Kleckner authored
Note, this is a functional change! The boolean condition as written simplified to be always true. I updated the code to work as I believe the author intended it to work, and am assuming that tests will catch any undesired change in behavior. R=qinmin@chromium.org Bug: 1007367 Change-Id: I87ca8c91f4b65bf8a28164d301bbbf242f5fdc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822717 Auto-Submit: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#699492}
-
Carlos Caballero authored
MessageLoopForIO is going away soon. Using SingleThreadTaskEnvironment will not work here as this code just needs to forward tasks to the real TaskRunner registered in a different shared library. See function comment for JNI_CronetTestUtil_PrepareNetworkThread for all the details. Bug: 891670 Change-Id: Ia9c99c4617338a2cfcd5be33fee49afd19e04eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795425Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#699491}
-
Leonard Grey authored
This reverts commit 933fab83. Reason for revert: Test was reverted in r699467 Original change's description: > Sheriff: Mark external/wpt/webxr/xrWebGLLayer_constructor.https.html leaky > > TBR=alcooper@chromium.org > > Bug: 1007304 > Change-Id: I6c05567f32e02a9d17c429ed8eaa9e03b0cac7b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822739 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699484} TBR=lgrey@chromium.org,alcooper@chromium.org Change-Id: I554fe7fe99f1e2579c2861f914ac02b6bec87b55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822826Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#699490}
-
Eugene But authored
The test is flaky on device and simulator. TBR=javierrobles@chromium.org Bug: 1007455 Change-Id: I55c4b98dbaa890cfc841350785b8e08a18c9488f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823319Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#699489}
-
Leonard Grey authored
These are currently disabled for a subset of bots but have been flaking generally: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVAsSBUZsYWtlIkljaHJvbWl1bUBjb250ZW50X3VuaXR0ZXN0c0BJbmRleGVkREJEaXNwYXRjaGVySG9zdFRlc3QuUHV0V2l0aEludmFsaWRCbG9iDA https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYQsSBUZsYWtlIlZjaHJvbWl1bUBjb250ZW50X3VuaXR0ZXN0c0BJbmRleGVkREJEaXNwYXRjaGVySG9zdFRlc3QuT3Blbk5ld0Nvbm5lY3Rpb25XaGlsZVVwZ3JhZGluZww TBR=dmurph@chromium.org Bug: 995716, 989723 Change-Id: Ib8c97339ee28aad8c803acba47dccf10e1ec0d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822825Reviewed-by:
-
Kurt Horimoto authored
This CL adds OverlayRequestCancelHandler, an object supplied to the OverlayRequestQueue that can cancel an individual request. A default option is available that cancels requests for all committed, document- changing navigations. Other overlays that may want to cancel using different heuristics can supply a custom cancel handler subclass. Bug: 1005613 Change-Id: I1113e26a52f9b910195be2a5a35416f3cc994dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812362 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699487}
-
Christopher Thompson authored
Add component installer, configuration API, and the various plumbing to add it to Chrome. The installer and configuration is largely based on the existing Safety Tips component (i.e., safety_tips_component_installer.h/cc and safety_tips_config.h/cc). Bug: 989607 Change-Id: If48016acc8032eacf2eb0393795fc5e66dcc892c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769634 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#699486}
-
Khushal Sagar authored
R=fserb@chromium.org Bug: 900706 Change-Id: Ib58c4bf7125493786418731d4882c711fce9900a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820014 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699485}
-
Leonard Grey authored
TBR=alcooper@chromium.org Bug: 1007304 Change-Id: I6c05567f32e02a9d17c429ed8eaa9e03b0cac7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822739Reviewed-by:
-
