- 25 Jul, 2018 40 commits
-
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/17fb50f21647..09f0990a2db0 git log 17fb50f21647..09f0990a2db0 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 dhanyaganesh@chromium.org cbuildbot/stages: Serialize DebugSymbols to run after UnitTest 2018-07-25 lannm@chromium.org Annotate failed CommitQueueHandleChanges with CL counts Created with: gclient setdep -r src/third_party/chromite@09f0990a2db0 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I45a4215fae8592006e2f580e2fc363e09e5e1ed7 Reviewed-on: https://chromium-review.googlesource.com/1149544Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577840}
-
vitaliii authored
USER_EVENTS is a special datatype, because it is commit-only. Therefore, it is handled in a special way in a processor. As a result, when the datatype is disabled (e.g. in Sync settings), it does not stop recording. This was not a problem before, because there was no user visible way to disable user events recording (except through history, but that works well), however after unified consent there will be a separate toggle in settings. This CL adds a temporary workaround (explicit check in the user event service for the datatype) for M69 and only when USER_CONSENTS type is enabled. Once we improve handling of commit only types (https://crbug.com/830535), this workaround won't be needed anymore. Bug: 860616 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idac71d1d8d8d5a504940ffb1e09d6a7173989c57 Reviewed-on: https://chromium-review.googlesource.com/1143475 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#577839}
-
Vaclav Brozek authored
As discussed in person, vabr@ accidentally failed to consult other owners when adding ioanap@ in password manager OWNERS, and introduced an inconsistency compared to how other team members are being added. This CL therefore removes ioanap@ from that OWNERS file for the time being. Bug: None Change-Id: I532f3abc060908241432c9ee8c493149207e173d Reviewed-on: https://chromium-review.googlesource.com/1149880Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577838}
-
Gemene Narcis authored
These tests are supposed to validate the behavior that bubble has when a user has blacklisted a site from a type of form and then login successfully from another type of form from the site. For tests were used HTML and HTTP auth forms. The bubble will not be shown if in the PasswordStore exists an blacklisted entry with the same signon_realm as submitted form. Even if the submited form has different Password::Scheme, if the signon_realm is the same as blacklisted one, then the bubble will not be shown. Bug: 456158, 862930 Change-Id: I7b07bb6164be315f43fe1609f4ac167233b76869 Reviewed-on: https://chromium-review.googlesource.com/1148560 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577837}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/90d0244a..ef17db9d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If18a9c834d7739d625bd31754ae2968ed6f64d41 Reviewed-on: https://chromium-review.googlesource.com/1149710Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577836}
-
vitaliii authored
Change-Id: I82c9e136952dbc13c3ac6452300100f4d5645bef Reviewed-on: https://chromium-review.googlesource.com/1149877Reviewed-by:
-
vitaliii authored
Change-Id: I1b4cc5a4b24d602e3c6a26e204a50199517726c4 Reviewed-on: https://chromium-review.googlesource.com/1149875Reviewed-by:
-
Vadym Doroshenko authored
Bug: None Change-Id: I0680e554a50a299ae2f35cb95e44cdb0e3b4e38c Reviewed-on: https://chromium-review.googlesource.com/1148450Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#577833}
-
Olga Sharonova authored
BUG=858987 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic61830a546ffe6873fef4db18a49d03031293fe7 Reviewed-on: https://chromium-review.googlesource.com/1119914Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#577832}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f79ab3845a7e..d35e4d092bb2 git log f79ab3845a7e..d35e4d092bb2 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 perezju@chromium.org [long term health] Add M69 branch number Created with: gclient setdep -r src/third_party/catapult@d35e4d092bb2 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863390 TBR=sullivan@chromium.org Change-Id: Ie32474dce72a98954aa802bf861ed708896a183c Reviewed-on: https://chromium-review.googlesource.com/1149345Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577831}
-
Farah Charab authored
Add waterfall config for ResourceFetchPriorityExperiment (cl/205238352) and FrameTypePriorityExperiment (cl/205235818). Change-Id: I1aea7bb1129c996d3a373254c7fca7f3661a428a Reviewed-on: https://chromium-review.googlesource.com/1143473 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577830}
-
Matt Falkenhagen authored
This should really just be the registration of the controller. Slim down some of the meaning so it's more like that. Bug: 866353 Change-Id: I98a412dd4456e5600125ea7fccb44d6e0e049faf Reviewed-on: https://chromium-review.googlesource.com/1149439Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577829}
-
Hajime Hoshi authored
This reverts commit c4f37ecd. Reason for revert: Build bot failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/475 [ RUN ] SaveCardBubbleViewsFullFormWithShippingBrowserTest.Upload_SubmittingFormWithConflictingNamesRequestsCardholderNameIfExpOn [12092:9475:0719/223002.758479:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated. 2018-07-19 22:30:02.956 browser_tests[12092:1670186] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug. [12092:89883:0719/223003.745535:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: /favicon.ico BrowserTestBase received signal: Segmentation fault: 11. Backtrace: 0 browser_tests 0x00000001129fb9bc base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests 0x0000000112fab7f5 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229 2 libsystem_platform.dylib 0x00007fff7de00f5a _sigtramp + 26 3 CoreFoundation 0x00007fff55c0c8e6 _CFAutoreleasePoolPop + 22 4 browser_tests 0x0000000112faae2b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491 5 browser_tests 0x0000000112aabf47 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4375 6 browser_tests 0x0000000112aaad2e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 7 browser_tests 0x0000000111512c23 content::BrowserMainLoop::PreMainMessageLoopRun() + 67 8 browser_tests 0x0000000111901147 content::StartupTaskRunner::RunAllTasksNow() + 39 9 browser_tests 0x00000001115113c8 content::BrowserMainLoop::CreateStartupTasks() + 712 10 browser_tests 0x0000000111514f80 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96 11 browser_tests 0x000000011150f4f4 content::BrowserMain(content::MainFunctionParams const&) + 180 12 browser_tests 0x00000001128e1578 content::ContentMainRunnerImpl::Run(bool) + 824 13 browser_tests 0x0000000114664651 service_manager::Main(service_manager::MainParams const&) + 2849 14 browser_tests 0x00000001128e05c4 content::ContentMain(content::ContentMainParams const&) + 68 15 browser_tests 0x0000000112faaa59 content::BrowserTestBase::SetUp() + 2697 16 browser_tests 0x0000000112a31853 InProcessBrowserTest::SetUp() + 723 17 browser_tests 0x00000001109bfefd testing::Test::Run() + 109 18 browser_tests 0x00000001109c0b90 testing::TestInfo::Run() + 320 19 browser_tests 0x00000001109c1107 testing::TestCase::Run() + 279 20 browser_tests 0x00000001109cc737 testing::internal::UnitTestImpl::RunAllTests() + 871 21 browser_tests 0x00000001109cc3ad testing::UnitTest::Run() + 109 22 browser_tests 0x0000000112a4be76 base::TestSuite::Run() + 166 23 browser_tests 0x000000011293dc65 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37 24 browser_tests 0x0000000112fcb898 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 552 25 browser_tests 0x000000011293e13d LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 333 26 browser_tests 0x000000011293dbde main + 94 27 libdyld.dylib 0x00007fff7daf2015 start + 1 28 ??? 0x000000000000000d 0x0 + 13 Original change's description: > [Autofill] Show Sign-in/Sync promo after saving a card locally and Manage Cards bubble. > > A sign-in promo pops up right after a card is saved locally. This also introduces > a "Manage cards" bubble, with a footnote of a sign-in promo. > > An organized list of the diffs -- > https://screenshot.googleplex.com/kMBPkpWZYsq.png > > A rough doc I quickly put together of the changes in this CL -- > https://docs.google.com/document/d/1DarGyLBDSBWcsumcxhpojuvugUTUU6r5j6uI0RZZAo0/edit?usp=sharing > > Here are different screenshots explaining why we chose to have the promo not display a title -- > Using promo's title (The string isn't updated in this screenshot): > https://screenshot.googleplex.com/kiYnAynyedD > Empty promo title, using main bubble title: > https://screenshot.googleplex.com/rT3F9RETsgq > No promo title, using main bubble title: > https://screenshot.googleplex.com/nMXOdNvysbR > > This is what the mocks were like (with the old UI): > https://screenshot.googleplex.com/AhXfxONG0sO > > > Additionally, this is what the sync promo looks like: > https://screenshot.googleplex.com/J3huQ06Y5X8 > Sign-in promo on the Manage Cards view: > https://screenshot.googleplex.com/MJqf5Fbhnpa > Sync promo on the Manage Cards view: > https://screenshot.googleplex.com/cNLy78Ts80k > > > Metrics, additional browser tests, and omnibox icon animation to follow. > > Bug: 855186 > Change-Id: I74ecdd802da960120baacfdd771c90cb126fbd10 > Reviewed-on: https://chromium-review.googlesource.com/1134514 > Commit-Queue: Jared Saul <jsaul@google.com> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#576769} TBR=pkasting@chromium.org,isherman@chromium.org,mathp@chromium.org,estade@chromium.org,msarda@chromium.org,jsaul@google.com,dlkumar@google.com,manasverma@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 855186 Change-Id: Ibc7785f8f85b60a241d838c57a0bd385480dbd14 Reviewed-on: https://chromium-review.googlesource.com/1149740Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577828}
-
Jochen Eisinger authored
All other use cases are meanwhile migrated or disabled R=msarda@chromium.org Change-Id: Ieff03c3a46a9ef8fec5c9de8a1aa041a97d9afbf Reviewed-on: https://chromium-review.googlesource.com/1148211Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577827}
-
Justin Cohen authored
Various safe area tweaks to correct the layout of fakebox on rotation when presented under another view controller. Bug: 866864, 862208 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7fda5c1ae564825c203566add4c7e738bcb38eb8 Reviewed-on: https://chromium-review.googlesource.com/1149100Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577826}
-
Michael van Ouwerkerk authored
Bug: 866937 Change-Id: Ifc6e7824491f6b89de24d97800852d2288cc9d28 Reviewed-on: https://chromium-review.googlesource.com/1148565Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#577825}
-
Maajid authored
Bug: 865912 Change-Id: I6dee22391a7216d183aad06831c6db25e4dff2d7 Reviewed-on: https://chromium-review.googlesource.com/1145080 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#577824}
-
Matthew Cary authored
Uses the new WritableUnalignedMapping class, which changes the ownership semantics. See the bug for details on the overall plan. Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie3379f1dabb0c0fa7fae7451534bd5fa1b01416e Reviewed-on: https://chromium-review.googlesource.com/1117696Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#577823}
-
Timothy Loh authored
This patch adds support for app icons when used as file handlers in the file manager. As there is no place to store the CrostiniAppIcon objects, a IconLoadWaiter is added which manually manages it's lifetime and deletes itself after an icon is loaded (or fails to load). This is a re-land of https://crrev.com/c/1127204, but with the longer deletion time-out removed. It turns out the longer time-out is not needed, and it was causing LSAN to detect a leak as the objects were not cleaned up by test completion. BUG=822513 Change-Id: Id04730ee2ea18f6f5004624471e40bcd13e9974b Reviewed-on: https://chromium-review.googlesource.com/1149432Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577822}
-
Wei-Yin Chen (陳威尹) authored
Bug: 866720 Change-Id: Ie3de731b94e6db978acbb0ef2d951b4399c2e25b Reviewed-on: https://chromium-review.googlesource.com/1147670 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#577821}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dbe25137..90d0244a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7f1083de5b8e0eccb2554c2bda57f48eeb13f21 Reviewed-on: https://chromium-review.googlesource.com/1149613Reviewed-by:
-
Vasilii Sukhanov authored
The CL is a next stage of removing "Smart Lock" branch from the password UI. We do the following: - Change the behavior of IsSmartLockUser(). Those syncing with the custom passphrase should see the same UI as normal sync users. - Use "passwords.google.com" site from the string resource instead of the constant. Thus, it's possible to change it via Finch. - Add a footer to the save/update password bubble. For signed-in users it clarifies that the credentials are stored in the Google Account. TBR=hcarmona@chromium.org Bug: 865437,862269 Change-Id: I3a58e26319191b0e24fbc1ac793d6028b1828e1e Reviewed-on: https://chromium-review.googlesource.com/1146648 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#577819}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df0e48fed437..096c5296c3b0 git log df0e48fed437..096c5296c3b0 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 jmadill@chromium.org Blit11: Refactor for error returning. 2018-07-25 jmadill@chromium.org TextureStorage11: Pass more Context around. 2018-07-25 jmadill@chromium.org TextureStorage11: Don't use gl::ErrorOrResult. 2018-07-25 jmadill@chromium.org D3D11: Don't use ErrorOrResult in TransformFeedback11. 2018-07-25 jmadill@chromium.org D3D: Make computeOffset not use ErrorOrResult. 2018-07-25 jmadill@chromium.org D3D11: Make createStagingTexture return Error. Created with: gclient setdep -r src/third_party/angle@096c5296c3b0 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ia94edca7552266bd5af8b9f42cba47f430d01844 Reviewed-on: https://chromium-review.googlesource.com/1149344Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577818}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c7a750e5543..15020ea2cf44 git log 4c7a750e5543..15020ea2cf44 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ddd6e8746851..096c5296c3b0 (10 commits) Created with: gclient setdep -r src/third_party/skia@15020ea2cf44 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I6f5bd3bcd69200d8ffea74d85ede5e179c5a72f9 Reviewed-on: https://chromium-review.googlesource.com/1149543Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577817}
-
Jinsuk Kim authored
A few callsites of |Tab.getContentViewCore| were replaced by |Tab.getWebContents| in https://crrev.com/c/989515 but the former was not simply returning the required object but also checked if the tab is showing native page or not, in which case returns null. This check should have been preserved in those callsites to show some resources like icons correctly in tab switcher mode. This CL fixes it by putting back the checks. Bug: 863841, 863809 Change-Id: I423d637687cf6140196fc525f7f2cc29aa4c8002 Reviewed-on: https://chromium-review.googlesource.com/1146130Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I2b60ed9e4394eb7c72d3219f025a5a44e11ed1de Reviewed-on: https://chromium-review.googlesource.com/1149702 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577815}
-
Noel Gordon authored
Add support enabling zip/unzip in the integration test base class. Any derived class can request support in test by overriding method: GetNeedsZipSupport() The default implementation returns false. Add ZipCase derived from the TestCase class, and an overriden method, in the FileManagerBrowserTest class. Future TODO: write test to exercise zip/unzip support. Bug: 864256,865197,836412 Change-Id: I3dc5b17023506ef3a2fa57611fff16ee68ead43e Reviewed-on: https://chromium-review.googlesource.com/1149438Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577814}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/70ddc1ca22ad..84d3394d88c4 git log 70ddc1ca22ad..84d3394d88c4 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 art-snake@yandex-team.ru Fix hint tables parsing. Created with: gclient setdep -r src/third_party/pdfium@84d3394d88c4 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I708980aaec069480a78688ef7c527dc2f2b6a206 Reviewed-on: https://chromium-review.googlesource.com/1149542Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577813}
-
Giovanni Ortuño Urquidi authored
Adds code to BookmarkAppShortcutInstallationTask to get the necessary icons from the DataRetriever. And Adds code to BookmarkAppDataRetriever to generate all icons necessary to install a Bookmark App. In the future, BookmarkAppDataRetriever will take a list of icon URLs to download, download the icons, resize them and generate icons for any missing sizes. But for now we just generate all icons. Bug: 864904 Change-Id: Ia90e67174e89fa6e92b54bee812ab337fed821c6 Reviewed-on: https://chromium-review.googlesource.com/1147899Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#577812}
-
Ricky Liang authored
We should clone the capture settings in CameraDeviceDelegate::TakePhoto(). Also identify the TakePhotoCallbacks that have a corresponding buffer registered in StreamBufferManager to remove a race condition that may lead to duplicated buffers being registered for the same TakePhoto request. While we're at it, change the video_capture_unittests to only start CameraHalDispatcher once. BUG=b:111661065 TEST=unit tests TEST=Make sure continuous shots works in camera app. Change-Id: I8ce8028f902c14d8b955d1b72af185097ddf5451 Reviewed-on: https://chromium-review.googlesource.com/1145980Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#577811}
-
Sam McNally authored
Change-Id: I98704eca528ed2ab56c96f6688e7232b92c831fd Reviewed-on: https://chromium-review.googlesource.com/1149660Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#577810}
-
Scott Violet authored
And move some code to test only. BUG=852439 TEST=none Change-Id: I690fa56d770b27aa147c32e4d5634208d95a6786 Reviewed-on: https://chromium-review.googlesource.com/1149099 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Enables tracking of why a particular script was not parsed / compiled by the ScriptStreamer. BUG=865098 Change-Id: I1a1b033689d0f12df4f28ff5c4bb21243cbec197 Reviewed-on: https://chromium-review.googlesource.com/1143762 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#577808}
-
Takuto Ikuta authored
By this CL, we remove absolute path from obj files in windows build with goma. And this allows to share build result even if it is built in different directory. This will give faster build time to windows developers and also let goma team focus on cache hit build more. This change removes absolute path from obj files, but lld linker absolutizes the path not to confuse debugger. Also this CL enables the feature by default only for lld with goma build on windows. Build stats of chrome on Z840 windows with -j1000 * is_debug=true and symbol_level=2 cache hit: 658 seconds non-cache hit: 728 seconds * is_debug=false and symbol_level=0 cache hit: 275 seconds non-cache hit: 411 seconds TODO: add build speed comparison of cache hit/no-hit build in symbol_level = 0 and symbol_level = 2 Bug: 712796 Change-Id: I88532a43addf693f93b30c96d08c8e93515d4344 Reviewed-on: https://chromium-review.googlesource.com/1143663 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#577807}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0359b6977caf..df0e48fed437 git log 0359b6977caf..df0e48fed437 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 jmadill@chromium.org Buffer11: Don't use ErrorOrResult. Created with: gclient setdep -r src/third_party/angle@df0e48fed437 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Icf4f5652eddb34fbff190c8478093a5c274bf0b3 Reviewed-on: https://chromium-review.googlesource.com/1149343Reviewed-by:
-
Ramin Halavati authored
Policy preferences are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Bug: 866422 Change-Id: I3d5eea500c6801a89547bb38608f187675b73681 Reviewed-on: https://chromium-review.googlesource.com/1148053Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#577805}
-
Marina Ciocea authored
This flag will be reused to enable sandbox on Mac in an experiment, hence dropping the "Windows" from flag name. Bug: 850878 Change-Id: Idc46f244b29425b60c42bf1b7288023206cffc19 Reviewed-on: https://chromium-review.googlesource.com/1148449Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 8260 8263 8272 8276 8279 8292 2 lines were removed and 4 lines were deflaked by consecutive results since 8217. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4c26c84bee0225b5ed6bb1e72e0f40fe84b60b41 Reviewed-on: https://chromium-review.googlesource.com/1147892 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577803}
-
Nigel Tao authored
Upcoming changes will refer to these types without being associated with "policy" per se. Change-Id: I1d3e98592686ee640fb5a22f24b180f267d43381 Reviewed-on: https://chromium-review.googlesource.com/1149422 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/36b2059cae7f..70ddc1ca22ad git log 36b2059cae7f..70ddc1ca22ad --date=short --no-merges --format='%ad %ae %s' 2018-07-25 art-snake@yandex-team.ru Use document size instead of file size while parsing. Created with: gclient setdep -r src/third_party/pdfium@70ddc1ca22ad The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I528ab175def896454e1680319e4b2a9dfaab7a4a Reviewed-on: https://chromium-review.googlesource.com/1149540Reviewed-by:
-
