- 22 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c8d4d4254ca1..4584a9c2ccb9 git log c8d4d4254ca1..4584a9c2ccb9 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 sugoi@google.com Handle new device extension properties Created with: gclient setdep -r src/third_party/swiftshader@4584a9c2ccb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/144945388 Tbr: swiftshader-team+autoroll@google.com Change-Id: I58afe1273165df11ffc2c295bc245314b9e37153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931274Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718326}
-
Nick Diego Yamane authored
This diverged from original implementation, which did not use such 250ms delay, and is potentially causing issues when xrandr and scale factor change events come in a short interval, as observed in crbug.com/1019344. Rationale: With delayed update, events are coalesced thus leading to issues when DisplayObserver is waiting only for display metrics changes, e.g: scale factor changes. This is what RenderWidgetHostViewAura does, in order to react to system's scale factor changes and sync with the compositor, etc. In this specific issue, the delayed display list update behaves as follows: Assuming display list initially has a single display (Display 1). XRandR/Gtk events start coming: 1. Display 2 added 2. Display 1 removed 3. Display 2 metrics changed (scale factor) Then they are coalesced into (and delivered through DisplayObserver interface): 1. Display 1 removed 2. Display 2 added So, RenderWidgetHostViewAura::OnDisplayMetricsChanged() is never called and it gets out of sync with the compositor. Bug: 1019344 Change-Id: Ic6a7b1264b5656d36a0b25fd7e3bc07ab419568a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930853 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#718325}
-
Torne (Richard Coles) authored
Explain the change to the isFallback attribute in the configuration file for AOSP. Change-Id: I3ade53829a8b3726434c0dc7a982505715a6be95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931197 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#718324}
-
Devlin Cronin authored
LoadMonitoringExtensionHostQueue was a wrapper around a SerialExtensionHostQueue that also recorded metrics about the extension hosts in the queue. We no longer need this data, so remove the wrapper and mark the metrics as obsolete. Bug: 1025804 Change-Id: I862caf2140c08a45a782df7f5cf690ef113f3b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927312Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718323}
-
Torne (Richard Coles) authored
Include details about how to use TrichromeWebView prerelease channels in the documentation. Bug: 1016502 Change-Id: Ifb7b8878f6a85d57e01a637922036f8870923d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929519 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
--iron-icon-fill-color was being set directly for a <cr-icon-button>. Even though the <cr-icon-button> currently uses a <iron-icon> which defines and uses --iron-icon-fill-color, variables of components contained within a component should not be used directly. If there is <cr-icon-button> CSS variable what was is needed, that should be used (which in this case there is one --cr-icon-button-fill-color). If one does not exist, I think it makes sense to create one and use that internally to set the CSS variable for the contained element. Bug: 1027466 Change-Id: I317a0dff63af9c5000596a16c6bc3038492d6c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929105Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#718321}
-
Yue Li authored
Bug: 1024103 Test: Manual Test Change-Id: I323573a32c3b3925e9840f1cabfe8029d5b5ac9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928195Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#718320}
-
haozhe authored
Firefox passed Chrome failed. Bug filed: https://crbug.com/375982 Bug: 900581 Change-Id: I33488661e2938c3fae6bef27ea6672b77047de84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925347Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#718319}
-
Clark DuVall authored
This is a follow up to http://crrev.com/c/1926920 which adds a use_webview_provider arg to instrumentation_test_apk. Unfortunately, the use of --use-webview-provider in gn_isolate_map.pyl for webview_cts_tests could not be converted to the gn arg because they do some tricky things and don't use instrumentation_test_apk. Change-Id: I7843d1210072f989b60bf08561786ac939eee2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930100Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Maggie Chen authored
This CL modifies the previous code that adds 60 more seconds in the GPU watchdog timeout on Windows. Instead of killing the GPU main thread at the end, allow the GPU main thread to continue and write histograms for all different events. This experiment is now extended to all platforms. Below are UMA histograms for different platforms. The numbers are still unreasonable. ChromeOS : 58% of hangs is within 1 minute. Android: 21% of hangs is within 1 minute. 14% after foregrounded. Linux: 47% of hangs is within 1 minute. Windows: 18% of hangs is within 1 minute. 87% makes progress after wait for a minute. Bug:988344 Change-Id: I309f72944ff8eb180a009e4320b7a5e4cacf2ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928232 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:Brian White <bcwhite@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718317}
-
Rohit Rao authored
Adds Attach/Detach as virtual methods on MessagePumpCFRunLoopBase so that they can be called unconditionally from SequenceManagerImpl. BUG=1002087 Change-Id: I8263188aa388a449c799b7bde17e7dac8b44d3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826517 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#718316}
-
Elly Fong-Jones authored
This is a reland of 48a84a2f Original change's description: > views: internalize DialogClientView > > DialogClientView is now unknown outside of //ui/views. This change > makes it unknown outside of DialogDelegate - all use of it is via > the public API DialogDelegate exposes. This will make fixing > DialogClientView itself easier, and is also a neater API design > across the board. Woo! > > Bug: 1011446 > Change-Id: I7abe8d29a44a73b78227440dec6e529165149a32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929981 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717994} Bug: 1011446 Change-Id: I834cca98a40ca89c7333dd9541649106e87e7a27 Tbr: robliao@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931382Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#718315}
-
Peter Kasting authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1532997 . When these SetFocusBehavior() calls were added, they were necessary on Mac, and I think ACCESSIBLE_ONLY didn't exist. Later LocationIconView::Init() was added and overrode all this, but the (effectively dead) code here wasn't removed. When I removed Init() early this year this code became live again, but isn't desirable any longer. Also does a few other trivial cleanups. Bug: 1027110 Change-Id: I2a55c6d47db0fcb71160d4dda2e61eec82386b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930327 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#718314}
-
Mikel Astiz authored
Encryption keys can contain non-utf8 binary content and are better represented by ArrayBuffer being adopted in the API. The patch also reorders the parameter order for future expansion options. Bug: 1000146 Change-Id: I7d1da9320c7e5c512f657deb5b211d3cf46d06d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919935 Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718313}
-
Daniel Hosseinian authored
For small maps and sets that contain efficiently moveable items, base::flat_[set|map] performs inserts better than std::[set|map], because the former avoids mallocs. Additionally, base::flat_[set|map] has a smaller overhead than its STL counterpart. Usage recommendation can be found at base/containers/README.md. All the substitutions in this CL are made on containers that are expected to be small (< dozens of entries) and that hold light and easily moveable items. Change-Id: I2fe35182cd7c85479db4b7b6343ea9af031031ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925438 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#718312}
-
Caleb Raitto authored
At frame unload, report the number of attempted font family matches by the frame, broken down by success / fail, system / web font, and top-level vs. subframe. For example, say font family C is present on the system, but font families A, B and D are not. For this definition: font-family: A, B, C, D; font family A and B would be considered as unsuccessfully attempted, font family C would be considered successfully attempted, and font family D wouldn't contribute to the UKM counters. Only the counts of font families match attempts are uploaded -- font family names are not. Duplicate attempts to match the same font family name are de-duplicated. UKM privacy review doc (Google internal): https://docs.google.com/document/d/1YtF7GvIhApgp1V7_9X8tSy4mZ-T9cssbMR3bVWw7AOE/edit?usp=sharing Bug: 1025945 Change-Id: Id285d7a0dbe6a22db7e2ebb6d62d424e17285085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907147Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#718311}
-
John Lee authored
This CL sets overflow of the tabs container to hidden so that when the last tab animates out and its max-width goes to 0, the container's width also shrinks. Moving the gap internally to TabElement makes more sense in terms of consistency since it's also included internally in the animation of slideIn and slideOut. Also, previously, having 16px margin on all tabs except the last tab caused the 16px to snap into place when the last tab slides out and a new tab becomes the last-child. Change-Id: Ia0bec1c6c86ab0aa2bfd769fc488429419ff9613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924619 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#718310}
-
Guohui Deng authored
Change |video_geometry_setter_receivers_| from mojo::ReceiverSet to mojo::Receiver because a single receiver is more appropriate. Bug: 925450 Test: Cast youtube with and without VizDisplayCompositor enabled. Change-Id: I7bd60820297a54e3a84bf268a015cb4625da7199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927223Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#718309}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ccb488f8..dd8cccb7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1a0250d0df76e81a70e7d057f68b1261ae233c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929521Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718308}
-
Tarun Bansal authored
Bug: 1026117,1009862 Change-Id: I0792903c54299e6169472e20129850f479813b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928037Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#718307}
-
Alex Vallée authored
Add field to log when the extension request is made. Bug: 1006899 Change-Id: I21093c7ede9a6d1e823abf302be50c04973a43f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930182 Auto-Submit: Alex Vallee <avallee@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718306}
-
Michael Spang authored
Bug: 1019015 Change-Id: I496f28a4b162bca993d378dc962405d85e09fba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930687 Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Michael Spang <spang@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#718305}
-
Yue Ru Sun authored
The browser test UkmBrowserTest.EvictObsoleteSources checks that UKM sources id are properly marked as obsolete and deleted by navigating to and leaving a few example sites, and it began to fail recently due to external change in one of the sites used in the test case. This is because source ids in the tests were obtained from web contents, which could differ from the navigation source id, for example if the site executes a same-document navigation (e.g. history.pushState/replaceState) in the case of https://www.google.com used in the test (https://screenshot.googleplex.com/xofrBc6JHB8.png). This CL updates the test to get the source id associated to the last committed navigation from the navigation handle instead, which is consistent with the id being marked by SourceUrlRecorderWebContentsObserver::DidFinishNavigation that we aim to test. https://cs.chromium.org/chromium/src/components/ukm/content/source_url_recorder.cc?type=cs&q=+MarkSourceForDeletion&g=0&l=237 This also changes to use an embedded test server to not depend on external content anymore. Bug: 1004296 Change-Id: I08d7f225588598655dd946f8661d32a8dbdf53ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929018Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#718304}
-
Lambros Lambrou authored
The permissions-wizard checks host permissions by running the (Me2Me or It2Me) host binary with a command-line parameter. This CL ensures that the binary triggers a fake capturer in this situation. This causes the Security & Privacy screen to include the app in the list, so the user can check its box. Bug: 1027317 Change-Id: Icb38737170c5dcaa544499c9708d907845b95845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930546 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#718303}
-
Moe Ahmadi authored
This CL adds logic to "remember" the user pressing 'Enter' when autocomplete matches are stale. This happens if the user types too fast and presses 'Enter' immediately. Currently, the realbox either does nothing or navigates to a stale result. After this change, the realbox does nothing until up-to-date results have arrived. it then navigates to the default match, if one exists, assuming that navigation to the default match was the user intent, signaled by typing too fast and pressing 'Enter'. Bug: 1024109 Change-Id: I67e434419e586d3488b1239b9fa37da8aaa4fec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928214 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#718302}
-
David Bokan authored
This is a small refactoring to make it clearer that the inner and outer viewport scroll nodes' existence is linked. That is, if either one is non-null, then the other one must be as well. Viewport scroll nodes (and others like page scale, elastic transform, etc.) are only created for the renderer's main-frame compositor. In an OOPIF renderer or the UI compositor, these property nodes are never registered and will always return null. In the main-frame renderer, we can always assume they're non-null. Bug: 1016229 Change-Id: Ie022d3d9cb937848a0ceb6560e936ce1ff06142f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871329 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#718301}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea02a5d30e4f..e75a355406dc Created with: gclient setdep -r src-internal@e75a355406dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:992974 Tbr: jbudorick@google.com Change-Id: I2dfa5bef80799f6fe9fa96527e9dd3c36c43d4fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928028Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718300}
-
Reilly Grant authored
Bug: 1007633 Change-Id: I0a020fa00b0d48a5cdcddb75062bad878b17e183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931263 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#718299}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3944e7cd71d6..693bde6a69a2 git log 3944e7cd71d6..693bde6a69a2 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 anubmat@microsoft.com DevTools: Fix Debugger hover tips not working Created with: gclient setdep -r src/third_party/devtools-frontend/src@693bde6a69a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1015367 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I562cc2e2fd8a31f361b4ff773c002be1a5de77e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931165Reviewed-by:
-
Jonathan Ross authored
On Mac AMD this test has begun failing again. These suppressions overlap with older Sierra ones, and new ones being seen on ASAN. I'm updating the entire set to point to the lasted bug, and incorporate [ mac amd no-passthrough ] There have been changes to Mac GPU selection, so suppressing until the root cause is determined. TBR=ynovikov@chromium.org TEST= deqp/functional/gles3/transformfeedback/* webgl2_conformance_tests Bug: 1027605 Change-Id: I5a73bfd52a97413d31a0c5f8bf5372f398eee759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930256 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718297}
-
danakj authored
These tests do not have network access, but InstanceID attempts to make network queries when asked for a token (via getToken()). The prefetch service posts a task during startup that ultimately asks for a token, which causes the task to fail with a network timeout eventually (after 30 seconds). This causes tests that use a base::TaskEnvironment to be very slow as their destruction waits for the 30 second task to complete. This halves the time spent in each unit_tests shard on the bots. R=avi@chromium.org Change-Id: I84815b07d167446e827df8777506f3d171bcfba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928297Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#718296}
-
Eric Stevenson authored
This will prevent old files from hanging around and causing misleading error messages. Change-Id: I928f3ac2a5e87e9ba71097ecc7a7894b7ca4d04c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922605 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718295}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/189c98042f16..db80f6936cbc git log 189c98042f16..db80f6936cbc --date=short --no-merges --format='%ad %ae %s' 2019-11-22 ethannicholas@google.com SkSL now supports functions defined in sksl_gpu.inc 2019-11-22 reed@google.com Revert "Reland "Revert "Use flat version of path-direction enum""" 2019-11-22 robertphillips@google.com Add utility for creating test-only GrProgramInfos 2019-11-22 kjlubick@google.com [skolo] Remove internal hardware 2 2019-11-22 reed@google.com remove LEGACY_CONVEXITY code -- no more clients Created with: gclient setdep -r src/third_party/skia@db80f6936cbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I47ad424c55b5b2bd771607d88ad8f64aaea09fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931269Reviewed-by:
-
Jérôme Lebel authored
Renaming: +[SigninEarlGreyUI signinWithIdentity:] +[SigninEarlGreyUI signinWithIdentity:isManagedAccount:] -[SigninEarlGreyUtilsImpl addIdentity:] -[SigninEarlGreyUtilsImpl checkSignedInWithIdentity:] -[SigninEarlGreyUtilsAppInterface addIdentity:] to: +[SigninEarlGreyUI signinWithFakeIdentity:] +[SigninEarlGreyUI signinWithFakeIdentity:isManagedAccount:] -[SigninEarlGreyUtilsImpl addFakeIdentity:] -[SigninEarlGreyUtilsImpl checkSignedInWithFakeIdentity:] -[SigninEarlGreyUtilsAppInterface addFakeIdentity:] Change-Id: Ib9f814b779bdefe953724e3d4a712c4a11f3826e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931077Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#718293}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8b455af32e5abe7842b35b726b4f6d7f9ff4bf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931164Reviewed-by:
-
Owen Min authored
Retrieve DM Token from BrowserDMTokenStorage doesn't have to wait for async storing process finished because we are always reading from memory. Change-Id: I86aa534323fb73f736aacc05946448ac60c93293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931356Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718291}
-
zhaoyangli authored
This will prevent unnecessary dependencies from being pulled to EG2 tests. Bug: 1015907 Change-Id: I45c5ec755761f1903b405542967c8a7321500ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929761Reviewed-by:
-
Archana Simha authored
Bug: 987014 Change-Id: Id8b75318fba5382077523114781d29f8f45a301e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819353 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718289}
-
Jasper Chapman-Black authored
Bug: 978298 Change-Id: I2e1a00223a2313511667f93063192b4e98475346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931078 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/26b030de1b76..e87972e30da4 git log 26b030de1b76..e87972e30da4 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 tsepez@chromium.org Fix downcast in CXFA_FFTextEdit. Created with: gclient setdep -r src/third_party/pdfium@e87972e30da4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1026918 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I99f2443f4efdb0ab23268e332a4e8036b5ceec75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931163Reviewed-by:
-
