- 24 Jan, 2019 40 commits
-
-
Xiaohan Wang authored
- Remove the origin trial - Mark the status as "stable" Blink intent-to-ship approval at https://groups.google.com/a/chromium.org/d/msg/blink-dev/w0jNaAhyTV0/3oDkR_ASAQAJ TBR=timvolodine Bug: 709348 Test: Manually tested to make sure the API is available by default. Change-Id: I84306dc0e17f104043fa2205529e650e255e7175 Reviewed-on: https://chromium-review.googlesource.com/c/1423090 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#625807}
-
John Rummell authored
When debugging it is nice to knwo the reason that requestMediaKeySystemAccess() failed. BUG=924991 Change-Id: I352beb27f9a0c2fb82444ae92a4d740a886fa8e0 Reviewed-on: https://chromium-review.googlesource.com/c/1435219Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#625806}
-
Nate Fischer authored
No change to production logic, only to an FYI bot's filter. Although WebView does not intend to support OOP NetworkService, we do intend to support in-process NetworkService even when WebView runs an OOP renderer (on Android O & above). The test filter currently filters out OOP-renderer tests, but cites OOP NetworkService as the reason, so this is probably a mistake. R=jam@chromium.org Bug: 841556 Test: see bot Change-Id: Id81637c879d205e65595d0a9999c1ea5b809865e Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1423115 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625805}
-
Wei Li authored
Some accessibility unit tests were accidently removed from BUILD file on r5da1d21f, so they can not be tested. This CL adds them back so we can still check on the results from these tests. BUG=none Change-Id: I1b495cc614b4402c4a360cd1c29dd3b174db61d8 Reviewed-on: https://chromium-review.googlesource.com/c/1432833Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#625804}
-
Min Qin authored
on M and L, detaching a notification from foreground service is not supported. As a result, the current implementation just put the notification in a sharedPreference and persist it across service restarts. However, the recent introduction of stopSelf() will remove the notification, and service will not restart. The logic for M and L really complicates the implementation, and the only side effect it tries to save is the notification flicker when pausing a download. This CL removes the notification persisting logic for L and M. When stopping the foreground service, we simply kill the existing notification, and launch a new one. BUG=919026 Change-Id: Ie9df5d17714d7ff9c54eed8f9b3ca1ddfaaf3199 Reviewed-on: https://chromium-review.googlesource.com/c/1432875Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625803}
-
Tim Volodine authored
Match the threading of AndroidStreamReaderURLLoader (NS code path) to that of AndroidStreamReaderURLRequestJob (current code path). In particular make sure to open the input stream on a background worker thread. The input stream can be provided by the embedding app, so it's important to respect the original thread model. The AndroidStreamReaderURLLoader is also used for loading android assets, android resources and content scheme urls. Add ThreadChecker same thread DCHECKs in AndroidStreamReaderURLLoader. Add OnInputStreamOpenFailed delegate method to be called on the IO thread with the necessary restart logic. Add threading checks for OpenInputStream and OnInputStreamOpenFailed in the unittest. BUG=913524,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: I23da72265ab0db8f0236bc1760d09826102317ef Reviewed-on: https://chromium-review.googlesource.com/c/1422698 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
-
Becca Hughes authored
We should use url formatter for source title now the overshadowing issue has been fixed as this is the recommended way for displaying origins in the UI. BUG=923078 Change-Id: I36d57e38a82295ffd0308a7e8d15260305e10f60 Reviewed-on: https://chromium-review.googlesource.com/c/1432712Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#625801}
-
Weiyong Yao authored
When to change source during a tab sharing session, the new picker will only be available on the tab which starts the session. If that tab is not on the front, user may probably miss the picker. This cl is to bring the tab up to front before showing the picker for easy notice. If use selects to cancel the source changing, this cl will activate the previous shared tab to continue the sharing session. Bug: 892201 Change-Id: I51c6436095df37f3afb3d28aebbfb9e4bb03f3a5 Reviewed-on: https://chromium-review.googlesource.com/c/1423700Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625800}
-
siyua authored
Server side config https://critique.corp.google.com/#review/230617773 Bug: 897998 Change-Id: I1cd43e99351cae54e63dea14280bd973e3caf2fd Reviewed-on: https://chromium-review.googlesource.com/c/1434176Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#625799}
-
Nicolas Ouellet-payeur authored
With the new managed UI rolling out, the duplicate 'managed by' messages were confusing. Bug: 925026 Change-Id: If75ab103f41c67730aa27b4dca71e3dfb26f2054 Reviewed-on: https://chromium-review.googlesource.com/c/1434082Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#625798}
-
chrome://historyNicolas Ouellet-payeur authored
The icon was "error-outline", but the mocks use "info-outline". Bug: 924933 Change-Id: I12c8a7c455e19e1a0adc2e68e32cdd7363a243d1 Reviewed-on: https://chromium-review.googlesource.com/c/1434216Reviewed-by:
-
Andrew Grieve authored
Change-Id: Ia16fce0879a5a1005c0273f9959b475dfde69cf6 Reviewed-on: https://chromium-review.googlesource.com/c/1434434 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#625796}
-
Greg Kerr authored
This CL adds access to system resources that are showing up in crash reports for the V2 GPU Sandbox. Bug: 915934 Change-Id: Ie1b9faa0fd5cacaf6fbd74f0c5a9500a55bede1f Reviewed-on: https://chromium-review.googlesource.com/c/1434920Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#625795}
-
Leonard Grey authored
No specific bugs, this is from pairing with namratakannan@ - Update background color for autofill footer - Fix a button in the profile menu sign in UI Change-Id: Iafdddd6d6703cbb97bc633dca9b43e232d0a9028 Reviewed-on: https://chromium-review.googlesource.com/c/1434895Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#625794}
-
Dan Beam authored
Screenshots: https://imgur.com/a/cjIHN3N R=dpapad@chromium.org BUG=924387 Change-Id: Iaebbe018941ef26392cf12e3ea28447865db5b45 Reviewed-on: https://chromium-review.googlesource.com/c/1433499Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625793}
-
Elly Fong-Jones authored
Bug: None Change-Id: I9893f16efc9a61fb8c75c606a593fcff8bb1c537 Reviewed-on: https://chromium-review.googlesource.com/c/1434800 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625792}
-
Nate Fischer authored
This adds miscellaneous tips for working with the emulator: * Explain which image to choose, and what "Google APIs" really means (this especially matters for WebView development) * Tips for running from CLI (headless, writable system) * Change install instructions for `virtualgl`, point Googlers toward relevant documentation. * Formatting, restructuring docs R=agrieve@chromium.org Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ie634516d1a19f9653e21a2e0586410618b7eefb7 Reviewed-on: https://chromium-review.googlesource.com/c/1432837Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625791}
-
Jérôme Lebel authored
Screenshot: https://screenshot.googleplex.com/7Bp9z54Le5s Bug: 914059 Change-Id: I12ed57a7b2e456f542c14647b959396617ea61c4 Reviewed-on: https://chromium-review.googlesource.com/c/1416144 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#625790}
-
Siddhartha authored
The assets were not added since we checked "can_unwind_with_cfi_table" value, which depends on "build_secondary_abi" build arg. So, explicitly add the asset for 64-bit monochrome apk, which contains 32 bit library. BUG=924842 Change-Id: I6488d5c4e5a80787735c5b09134b013a87b5c553 Reviewed-on: https://chromium-review.googlesource.com/c/1432836 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
-
Tanja Gornak authored
Currently, there is no metric, which surfaces the problems in token retrieval. This Cl adds such metric. Bug: 801985 Change-Id: Iafcf1d5179798e3032eb8e5dcbeeab8644a8e385 Reviewed-on: https://chromium-review.googlesource.com/c/1433625Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#625788}
-
Mikel Astiz authored
Minor refactoring to inject more narrow dependencies and adopt const pointers which is otherwise non-trivial. Bug: 922971 Change-Id: I4e7068cb042bae8b23052d0318ca86ea4358990c Reviewed-on: https://chromium-review.googlesource.com/c/1433234 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#625787}
-
Kyle Milka authored
This is a reland of 5d52425f Initialize the int memebers of SearchSuggestData to 0. The uninitialized values were causing separate failures than the previously flaky test. Original change's description: > Reland "[NTP] Cap search suggestion impressions" > > This is a reland of 41e54be1 > > One of the checks is converting the times from ms->s. In practice > seconds is plenty precise but in the test 800ms ended up being 0, > so increase it to 1000ms (similar to ImpressionCountResetsAfterTimeout > which was not flaky). > > Original change's description: > > [NTP] Cap search suggestion impressions > > > > The parameters for capping suggestions impressions are provided as part > > of the update proto. Read and update the local pref on each fetch. Use > > these prefs to determine if the impression cap has been reach or if > > fetching is frozen due to an empty response. > > > > Bug: 904565 > > Change-Id: Ib5539a99f18e9da2ac1223ecc7aff65cb909bca8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1395188 > > Commit-Queue: Kyle Milka <kmilka@chromium.org> > > Reviewed-by: Kristi Park <kristipark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#624994} > > Bug: 904565 > Change-Id: I424cb51d2a9c1738c0e5168f58ef52b73ed4b223 > Reviewed-on: https://chromium-review.googlesource.com/c/1431472 > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625437} Bug: 904565 Change-Id: I01e2c868d36ce1ab5d7ffd91b86e40d8573f121e Reviewed-on: https://chromium-review.googlesource.com/c/1434081Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625786}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b2bab1fee534..13a5f9e46a5d git log b2bab1fee534..13a5f9e46a5d --date=short --no-merges --format='%ad %ae %s' 2019-01-24 tsepez@chromium.org Remove ampersands from element_attributes.inc function name entries Created with: gclient setdep -r src/third_party/pdfium@13a5f9e46a5d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia1183044c29b9e489a762dbf86e442208657dd45 Reviewed-on: https://chromium-review.googlesource.com/c/1434874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625785}
-
khmel@chromium.org authored
This unifies using user type filtering for extension based and web default apps via json file declaration. DD: https://goto.google.com/web_app_default webapp support was added here: crrev.com/c/1401508 crrev.com/i/784837 - update default app list for all boards. These are only apps that has child_users in external_extensions.json and no managed_users are used currently in external_extensions.json crrev.com/c/1407458 - update script that generates default extensions. TEST=Locally, set of apps as expected on nocturne for different user types. Unit test added BUG=921121 Change-Id: I655c1e3bf1e9974aed52e0b74d544a7d41450214 Reviewed-on: https://chromium-review.googlesource.com/c/1407498Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#625784}
-
James Zern authored
minor encoder speedups and roll up to pick up local fuzzer cherry-pick fixes the failure causing the revert in commit cd19bf0a: Reason for revert: Suspect compile failure on Win32-rel https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/10047 the unicode changes to [cd]webp have been removed in this change. Bug: 922319 Change-Id: Ib2627a3a06410d551f2be56f30a3e16dbe973253 Reviewed-on: https://chromium-review.googlesource.com/c/1431193 Commit-Queue: Urvang Joshi <urvang@chromium.org> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625783}
-
Shivani Sharma authored
Adds a UKM log when an entry is marked as skippable. Test: browser_tests --gtest_filter=*SkipOnBack* Bug: 907167 Change-Id: I419ee317e496dfa96123af2871b1c45e92a644ef Reviewed-on: https://chromium-review.googlesource.com/c/1384630Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#625782}
-
Ken Rockot authored
Removes the check which disallows android_apk_or_module targets from depending on other targets with "manifest" in their name. Bug: None Change-Id: I2c2dc39b4c4991ddbc86f3e0d2aba590e2c1b14c Reviewed-on: https://chromium-review.googlesource.com/c/1434797 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Andreas Butler authored
When a transaction is explicitly committed, there may yet be unhandled errors that the browser has sent but the renderer has not yet seen. This can cause strange behaviour (see the Github discussion link below). This patch keeps track of the 'handled errors' in the renderer and the 'sent errors' in the backend. The 'handled errors' number is sent when the transaction is explicitly committed, and the browser can compare this with the 'sent errors'. If they don't match, the transaction is aborted GitHub Discussion: https://github.com/w3c/IndexedDB/pull/242 Bug: 911877 Change-Id: I7ea7b9e20c70528de3f363e961f87a3d8f5798d3 Reviewed-on: https://chromium-review.googlesource.com/c/1378806Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Andreas Butler <andreasbutler@google.com> Cr-Commit-Position: refs/heads/master@{#625780}
-
Fredrik Söderquist authored
Dead since fd75e994. Change-Id: I6490435071e027119a27cfcd29f99845c6769d9d Reviewed-on: https://chromium-review.googlesource.com/c/1434354 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#625779}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f68a7687983a..1fc4082ba1db git log f68a7687983a..1fc4082ba1db --date=short --no-merges --format='%ad %ae %s' 2019-01-24 lalitm@google.com Merge "trace_processor: surface priority and end state information in sched tables" Created with: gclient setdep -r src/third_party/perfetto@1fc4082ba1db The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I68ea0548aacaffb86ecc280b0d7b857fd2a5c23b Reviewed-on: https://chromium-review.googlesource.com/c/1434814Reviewed-by:
-
Mason Freed authored
The prior code incorrectly cropped the backdrop-filtered content on the ChromeOS Shelf. This fixes that problem. Bug: 920296, 923022 Change-Id: Idfee932a67b4f8baa2ad9351268384b3b059d72b Reviewed-on: https://chromium-review.googlesource.com/c/1415171 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625777}
-
Ben Pastene authored
And add it to swarmed cts tests. Bug: 924545 Change-Id: I882d480de3e9f6f2507e76a9ef83db7601d8404e Reviewed-on: https://chromium-review.googlesource.com/c/1431114 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#625776}
-
Lei Zhang authored
All the implementations are effectively empty. Fix a nit as well. Change-Id: I25fbcda63e7a814fd2a441acb74f2fd8b8be0a19 Reviewed-on: https://chromium-review.googlesource.com/c/1433596Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625775}
-
Matthew Jones authored
This patch adds the different variation names for the edit-url suggestion. The default is the share and edit icon version. Bug: 901952 Change-Id: Iee24874c87b3f52e5c3b4eca7e2d2db7990ee9e3 Reviewed-on: https://chromium-review.googlesource.com/c/1419617 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#625774}
-
Matthew Jones authored
This patch also disables the feature for one location bar test and updates the suggestion layout to use app compat src for K devices. Bug: 901952 Change-Id: Iaaf11d3eba7e9a5a37230c01ce044be2b8f86942 Reviewed-on: https://chromium-review.googlesource.com/c/1426941Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Tatiana Buldina authored
Bug: chromedriver:2744 Change-Id: I246a3797793f0e498601f5cdb68f417618349a25 Reviewed-on: https://chromium-review.googlesource.com/c/1431192 Commit-Queue: Tatiana Buldina <buldina@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#625772}
-
Yi Su authored
This CL renames 2 functions LargeIconService. This is a prerequisite work for adding LargeIconService::GetLargeIconRawBitmapOrFallbackStyleForIconUrl in this CL(http://crrev/c/1384366). Bug: 903617,910525 Change-Id: Id46811309646955fd2b8888d829f94918e5b910a Reviewed-on: https://chromium-review.googlesource.com/c/1429959 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#625771}
-
Findit authored
This reverts commit 48246c46. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 625435 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDgyNDZjNDZjYzUxNjQzOWJkNjJjOGEyYmQwZGFmM2NkZmQyMGRhYQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/6542 Sample Failed Step: browser_tests on Ubuntu-16.04 Sample Flaky Test: LocalCardMigrationBrowserTest.ClickingSaveClosesDialog Original change's description: > [Autofill] Added browser tests for local card migration flow (part 1) > > The previous browser tests CL got reverted twice due to flaky tests, > so I will try to break the browser tests into several CLs. Listed the > following tests to be added in the TODO in the browser tests file. > > > Bug: 897998 > Change-Id: Ib3c99de27028530e2f8bce7b616d7d5a9dae4cd3 > Reviewed-on: https://chromium-review.googlesource.com/c/1364695 > Commit-Queue: Siyu An <siyua@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#625435} Change-Id: I45450945906bbcdef982bca45310722c7a9fd968 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897998 Reviewed-on: https://chromium-review.googlesource.com/c/1435216 Cr-Commit-Position: refs/heads/master@{#625770}
-
Christopher Cameron authored
Change OpenApplicationWithPath to return the NSRunningApplication instead of just its pid. Use this in LaunchShim to detect when the process terminates, and issue a callback, which lands in AppShimHost::OnShimProcessTerminated. In AppShimHost, treat OnShimProcessTerminated just like a failure in OnShimProcessLaunched -- attempt to recreate the app bundles and launch again, and if that fails, close the app's windows. Ensure that only the first call to AppShimHost::LaunchShim do anything. Handle IsAcceptablyCodeSigned failing by closing the shim process and re-launching. This makes us re-generate app shims when they are not signed by the following sequence - The launch will attempt to launch from the Applications folder - If this is signed, success - If this is not signed (more likely), then it will fall through the same path -- the second AppShimHost::LaunchShim call will do nothing, and the shim process will terminate. - This termination will cause us to launch again, this time re-creating the shim, whereupon it should now be signed. Add tests for this sequence. Bug: 924482 Change-Id: I915c8fb3b9ee9b8fe109e7330d16673a4192e30a Reviewed-on: https://chromium-review.googlesource.com/c/1433442 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#625769}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6588e2f70fe8..bb3f9060c4ea Created with: gclient setdep -r src-internal@bb3f9060c4ea The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If5863f0eb6608c0f6ab6fbc9eec29f73e8640b92 Reviewed-on: https://chromium-review.googlesource.com/c/1434774Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625768}
-
