- 18 Aug, 2016 40 commits
-
-
vitaliii authored
BUG=638189 Review-Url: https://codereview.chromium.org/2244123004 Cr-Commit-Position: refs/heads/master@{#412777}
-
guidou authored
The failure seems to occurs on Win10 only, but these tests already had entries and it was not possible to add a new Win10-specific entry. TBR=ericrk@chromium.org BUG=638843 Review-Url: https://codereview.chromium.org/2242173007 Cr-Commit-Position: refs/heads/master@{#412776}
-
j.isorce authored
Revert of Fix ineffective --disable-gpu-driver-bug-workarounds (patchset #11 id:200001 of https://codereview.chromium.org/2195743005/ ) Reason for revert: Cause failures on Nexus 9 GPU bot https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%209%29/builds/1385 Original issue's description: > Fix ineffective --disable-gpu-driver-bug-workarounds > > It was hidden to the user since chrome://gpu was not showing > any workarounds, but they were still applied in the gpu process. > > Also add a gpu test that sets > --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing > and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND > in both browser and gpu processes. > > BUG=359367 > > R=kbr@chromium.org, zmo@chromium.org > > TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 > Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd > Cr-Original-Commit-Position: refs/heads/master@{#409197} > Cr-Commit-Position: refs/heads/master@{#412685} TBR=kbr@chromium.org,zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=359367 Review-Url: https://codereview.chromium.org/2253413002 Cr-Commit-Position: refs/heads/master@{#412775}
-
lizeb authored
BUG=633185,633229 Review-Url: https://codereview.chromium.org/2253073002 Cr-Commit-Position: refs/heads/master@{#412774}
-
vabr authored
Every time PasswordFormManager is constructed in production code, FetchDataFromPasswordStore is called on it immediately after construction. It makes sense to automate calling FetchDataFromPasswordStore. Doing so will also help keep the change of fetching credentials in FormFetcher instead of in PasswordStore smaller. (See the overall plan in https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#bookmark=id.cbgso0v3oogv This CL: * Adds a call to FetchDataFromPasswordStore at the end of PasswordFormManager constructor. * Removes the after-construction calls to FetchDataFromPasswordStore. * Adjusts tests. BUG=621355 R=vasilii@chromium.org Review-Url: https://codereview.chromium.org/2256703002 Cr-Commit-Position: refs/heads/master@{#412773}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#412772}
-
yosin authored
This patch converts "editing/deleting/delete-block-merge-contents-01[2-7].html" to use w3c test harness to simplify test script for improving readability, and consolidates into "delete_block_merge_whitespace.html" since samples of them are similar. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2255073002 Cr-Commit-Position: refs/heads/master@{#412771}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#412770}
-
tkent authored
Only Node and Frame used it, and it didn't make sense because they are not ref-counted. This CL has no behavior changes. Review-Url: https://codereview.chromium.org/2259763002 Cr-Commit-Position: refs/heads/master@{#412769}
-
rockot authored
ShutdownOnIOThread may be called more than once. If this happens, the MessageLoop observer will be null during the second call. This ensures that we don't dereference it in that case. BUG=None TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2259753002 Cr-Commit-Position: refs/heads/master@{#412768}
-
alph authored
This is a followup after r412613 to support legacy format loading. Review-Url: https://codereview.chromium.org/2248963005 Cr-Commit-Position: refs/heads/master@{#412767}
-
yawano authored
Revert of arc: avoid checkbox AutomationNode issue (patchset #1 id:1 of https://codereview.chromium.org/2254673003/ ) Reason for revert: https://crbug.com/638840 Original issue's description: > arc: avoid checkbox AutomationNode issue > > Avoid checkbox AutomationNode issue https://crbug.com/638498 > > BUG=638501 > BUG=b/30906810 > TEST=tested as described in the issue > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f > Cr-Commit-Position: refs/heads/master@{#412740} TBR=xiyuan@chromium.org,khmel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638501 Review-Url: https://codereview.chromium.org/2257073002 Cr-Commit-Position: refs/heads/master@{#412766}
-
keishi authored
BUG=591606 Review-Url: https://codereview.chromium.org/2050463003 Cr-Commit-Position: refs/heads/master@{#412765}
-
fukino authored
BUG=636289 Review-Url: https://codereview.chromium.org/2229333002 Cr-Commit-Position: refs/heads/master@{#412764}
-
wangxianzhu authored
1. Distinguish PaintInvalidationNone and PaintInvalidationProbablyNone, so that callers of ObjectPaintInvalidator::computePaintInvalidationReasion() can treat them differently to avoid unnecessary overriding cases that definitely no paint invalidation is needed. 2. Check emptiness of newBounds and oldBounds earlier. This avoids unnecessary object and layer paint invalidations when both oldBounds and newBounds are empty but we computed a non-none paint invalidation reason. 3. Renamed LayoutObject::paintedOutputOfObjectHasNoEffect to paintedOutputOfObjectHasNoEffectRegardlessOfSize because it doesn't check for empty size. The behavior is required to do correct paint invalidation when the size changes to empty. Now the name is better suited to the actual behavior. These changes will help spv1 paint invalidation and GeometryMapper-based spv2 paint invalidation to produce the same result. BUG=510908 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2247543003 Cr-Commit-Position: refs/heads/master@{#412763}
-
rjwright authored
Manually revert all of https://codereview.chromium.org/2251583002/. NeedsRebaseline tags were removed by rebaseline-o-matic - adding them back to reset test expectations to former state. Replaces https://codereview.chromium.org/2251393002/ which could not auto-merge BUG=638822 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=ericrk@chromium.org,vmpstr@chromium.org Review-Url: https://codereview.chromium.org/2251863005 Cr-Commit-Position: refs/heads/master@{#412762}
-
oka authored
BUG=627697 TEST=opened a file and moved to the next with <Right> and checked chrome://histograms. Confirmed 1 FileBrowser.QuickView.FileTypeOnLaunch is exported and 2 FileBrowser.QuickView.FileType are exported. Review-Url: https://codereview.chromium.org/2252723005 Cr-Commit-Position: refs/heads/master@{#412761}
-
j.isorce authored
Otherwise Chromium claims supporting video/mp4 and fails to play some YouTube video without falling back to video/webm even if supported by the server. BUG=571417 R=jrummell@chromium.org Review-Url: https://codereview.chromium.org/1569053002 Cr-Commit-Position: refs/heads/master@{#412760}
-
rjwright authored
Mark inspector/editor/text-editor-search-switch-editor.html as skip on Win7, Mac10.11, and Linux debug. Example failures: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6954 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8908 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3999 BUG=638618 TBR=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2251373002 Cr-Commit-Position: refs/heads/master@{#412759}
-
yhirano authored
This CL fixes a violation for a DCHECK that states |m_workerLoader| should be cleared before the MainThreadLoaderHolder's destruction. BUG=635436 Review-Url: https://codereview.chromium.org/2256103002 Cr-Commit-Position: refs/heads/master@{#412758}
-
sashab authored
Removed Wrap-Flow and Wrap-Through from ComputedStyle's StyleRareInheritedData, since they are no longer used. Also removed some additional unused ComputedStyle initial value methods. BUG=628043 Review-Url: https://codereview.chromium.org/2223133004 Cr-Commit-Position: refs/heads/master@{#412757}
-
peria authored
Before this CL, file names to include were decided with the path of original IDL files. This behavior could mislead us as if we included generated files for partial interface and non-partial interface in one aggregation file, although we aggregate files for all partial interfaces into one file. This change make it obvious in .gn/.gyp files to aggregate files for (non-)partial interfaces. BUG=634231 Review-Url: https://codereview.chromium.org/2259463002 Cr-Commit-Position: refs/heads/master@{#412756}
-
ricea authored
The --csv argument makes find_unmapped_histograms.py report unmapped histograms in CSV format instead of logging them. This makes it easier to digest the output in other software. R=isherman@chromium.org BUG= Review-Url: https://codereview.chromium.org/2245263004 Cr-Commit-Position: refs/heads/master@{#412755}
-
dominickn authored
This CL: - Renames PermissionInfobarDelegate to PermissionInfoBarDelegate (this is the only delegate class which doesn't follow the InfoBar naming convention). - Removes redundant requesting_frame_/requesting_origin_ members in PermissionInfoBarDelegate subclasses - Moves ShouldShowPersistenceToggle's feature query into PermissionUtil in preparation for the desktop and grouped infobar implementation - Moves ignore count incrementing after ignore action UMA, to be consistent with dismiss count UMA in PermissionContextBase. BUG=638076 Review-Url: https://codereview.chromium.org/2250053002 Cr-Commit-Position: refs/heads/master@{#412754}
-
thestig authored
Review-Url: https://codereview.chromium.org/2250953004 Cr-Commit-Position: refs/heads/master@{#412753}
-
thestig authored
Review-Url: https://codereview.chromium.org/2255013002 Cr-Commit-Position: refs/heads/master@{#412752}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8be763db2940..1383b507de4f $ git log 8be763db2..1383b507d --date=short --no-merges --format='%ad %ae %s' TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2257443003 Cr-Commit-Position: refs/heads/master@{#412751}
-
qinmin authored
When a download is cancelled/failed/removed, it should be removed from auto resume list. Otherwise, resumption will be retried over and over as it is never removed from auto resumption. BUG=636724 Review-Url: https://codereview.chromium.org/2248963002 Cr-Commit-Position: refs/heads/master@{#412750}
-
yosin authored
This patch converts "editing/undo/4063751.html" to use w3c test harness to simplify test script for improving readability. This patch also renames it to "redo_rebalance_whitespace.html" to provide a hint what this test script verifies. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2249833003 Cr-Commit-Position: refs/heads/master@{#412749}
-
mek authored
This adds a check to make sure that the origin of the service worker is allowed to run in the context of the "first party for cookies" (i.e. top-level document) before starting it to handle a foreign fetch event. This makes sure service workers with foreign fetch can't be used to bypass third-party cookie blocking. BUG=540509 Review-Url: https://codereview.chromium.org/2255713003 Cr-Commit-Position: refs/heads/master@{#412748}
-
Dan Beam authored
TBR=asanka@chromium.org BUG=long OOOs ;) Review URL: https://codereview.chromium.org/2251383002 . Cr-Commit-Position: refs/heads/master@{#412747}
-
pkotwicz authored
webapk_installer.cc sets the scope URL to a default if the Web Manifest scope URL is empty. This CL sets the scope URL from the fetched Web Manifest to the default if it is empty prior to comparing the scope URLs BUG=624834 TEST=ManifestUpgradeDetectorTest.* Review-Url: https://codereview.chromium.org/2205953006 Cr-Commit-Position: refs/heads/master@{#412746}
-
hans authored
BUG=636558,637866 Review-Url: https://codereview.chromium.org/2241413003 Cr-Commit-Position: refs/heads/master@{#412745}
-
tkent authored
Follow the current Blink style. This CL doesn't have any behavior changes. BUG=583200 Review-Url: https://codereview.chromium.org/2257683002 Cr-Commit-Position: refs/heads/master@{#412744}
-
yosin authored
This patch converts "editing/deleting/delete-3857753-fix.html" to use w3c test harness to simplify test script for improving readability., and renames to "delete_keep_style.html" to provide hint about what this test script verifies. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2255723002 Cr-Commit-Position: refs/heads/master@{#412743}
-
yosin authored
This patch converts "editing/deleting/delete-4083333-fix.html" to use w3c test harness to simplify test script for improving readability., and renames to "delete_link_at_end_of_sentence.html" to provide hint about what this test script verifies. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2255733002 Cr-Commit-Position: refs/heads/master@{#412742}
-
drcrash authored
Because the value of a certificate profile is sent straight to cryptohomed, it needs to match what is in CertificateProfile in the cryptohomed source code. See CryptohomeClient::AsyncTpmAttestationCreateCertRequest. BUG=624187 TEST=none Review-Url: https://codereview.chromium.org/2256643003 Cr-Commit-Position: refs/heads/master@{#412741}
-
yawano authored
Avoid checkbox AutomationNode issue https://crbug.com/638498 BUG=638501 BUG=b/30906810 TEST=tested as described in the issue CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2254673003 Cr-Commit-Position: refs/heads/master@{#412740}
-
jaydasika authored
BUG=638297 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2254543004 Cr-Commit-Position: refs/heads/master@{#412739}
-
ianwen authored
This CL introduces bottom controls to compositor. Once the height of the bottom controls is specified, a resize signal will be sent to cc and renderer with a shortened view port height. Upon user scrolling, the height of the bottom bar is computed by applying the shown ratio of the top controls to the bottom controls. Since bottom control is less sensitive, it will react to scrolling even if top controls is constrained. Also please note that the shrinking and expanding of the bottom area do not need to be pixel perfect, as such perfection cannot be observed by human vision. TODOs: 1. Implement main thread scrolling, like what we did for top controls. 2. Investigate to conduct standalone scrolling animation if the top controls is totally absent. BUG=581227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2106753004 Cr-Commit-Position: refs/heads/master@{#412738}
-