- 08 Aug, 2019 40 commits
-
-
John Abd-El-Malek authored
Make a bunch of permission checks in ContentBrowserClient use BrowserContext instead of ResourceContext. Many of the source of these calls was the UI thread anyways, so there's no need to hop to the IO thread. Bug: 908955 Change-Id: I63c63491d51182498c511d827fe622d13ee33272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742806 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#685087}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/f35ea98e9c0a..092d8219e053 $ git log f35ea98e9..092d8219e --date=short --no-merges --format='%ad %ae %s' 2019-08-07 bnc Handle closing pending streams. 2019-08-07 renjietang Allow QpackStreamSenderDelegate to be set dynamically. 2019-08-07 fkastenholz Put Google QUIC Connection Close code in the extracted code field Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I6ec13dbc05e66e0ba4b1e42195b43f1f655f8ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741645 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#685086}
-
dpapad authored
Bug: 986481 Change-Id: Id2b8a83b8accf28d360828c1d340b0e6d28999ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740830 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#685085}
-
Kent Tamura authored
This CL reduces binary size by 110KB on macOS x64. Change-Id: I77b9d7d847e62adf5212959578539a5fa7264502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732676 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#685084}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a01c1215ddbe..0bbcb5b8e80b git log a01c1215ddbe..0bbcb5b8e80b --date=short --no-merges --format='%ad %ae %s' 2019-08-08 dberris@chromium.org Pinpoint: Support other android-webview names Created with: gclient setdep -r src/third_party/catapult@0bbcb5b8e80b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:989933 Change-Id: I71d1890951a708db1ff360e66520302032631232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743407Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685083}
-
Alexandre Courbot authored
A buffer cannot reference itself. We have a DCHECK() for ensuring this in the decode surface's ToString() method, but this means we won't perform any check unless the debug level is high enough to have this method call. Add a sanity DCHECK() when we set the reference frames of a decode surface, so such errors are caught in time. Bug: None Test: VDA unittest passing on Minnie and Kukui. Change-Id: Iae1097a6e6992231ed26fdbf088d9c40dd663b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741747Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#685082}
-
David Munro authored
Instead of logging a console message, we now show a toast to the user for 5 seconds the first time (per session) they focus a Crostini app while in tablet mode. ./out/Default/unit_tests for one and only one toast Bug: chromium:962848 Test: autoninja -C out/Default chrome unit_tests && Test: Play around with tablet mode and Crostini on an Eve device, check Change-Id: Ie70a847372f2a65d3f71fc39e29cb1165992ab3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743232 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#685081}
-
Sophie Chang authored
Bug: 969558 Change-Id: Ie0076160878e5cffdead18afb6aab0dc331c8767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742726 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#685080}
-
Matt Falkenhagen authored
The crash bug was introduced in https://crrev.com/c/1705478 because ServiceWorkerControlleeRequestHandler::MaybeCreateLoader changed such that the |context_| check below was removed: if (!context_ || !provider_host_) { ... return; } provider_host_->UpdateUrls(...); The desired behavior is a bit subtle. The only reason |context_| could be destroyed while the provider host is still alive is if the provider host transferred contexts using the context copy mechanism we want to remove per https://crbug.com/877356. In this state, we end up with a provider host that's fairly useless: it can't serve container host messages etc., because there are early returns for !IsContextAlive(). However, it seems scary to have an inaccurate URL in the case of a cross-origin redirect. The previous behavior before the CL mentioned earlier would keep the old URL in the normal case, but in the |skip_service_worker| case it would attempt to update the URL via NavigationUrlTracker. This CL makes the decision to update the URL as far as possible, and just avoid touching |context_| if it's null. The real solution would be to remove the context copy mechanism. Bug: 988551, 877356 Change-Id: I692b0c73dd10cf4af24275eb709382b6ebbf73e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743230 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#685079}
-
Ken Rockot authored
In the absence of Mus+ash this is no longer particularly useful for development. Given that it's a developer-facing feature with no active users, and given that we're moving all services away from Service Manager, we might as well just delete this instead of porting it. So...DELETE. Bug: 977637 Change-Id: I10c690cf290849dbe96a223890d8ead6b89980fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740129 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#685078}
-
Gyuyoung Kim authored
As a step to reduce uses of Platform::Current()->GetDataResource, this CL replaces all uses of Platform::Current()->GetDataResource with UncompressResourceAsBinary. UncompressResourceAsBinary introduced by this CL returns a vector of characters to append a decoded IDR resource to |data| directly. Additionally, this CL makes GetDataResourceName returns a resource ID matching the existing file as well as changes the name with GetDataResourceId. Bug: 983396 Change-Id: Ib8062e5e7958021122ac35d549fa6d9c80f02f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739238 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#685077}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I98d192c755ff06da914bfb9fe7e001216561e0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742808Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685076}
-
Sajjad Mirza authored
We do not want to mark shards with corrupted profile output as invalid because doing so could retry "SUCCESS" shards. Bug: 991725 Change-Id: Ibf0d8c72dad4625fa6502bc408f28ced39bafb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742852 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#685075}
-
Jeonghee Ahn authored
Convert list: snav-not-below snav-not-rightof snav-offscreen-content snav-overlapping-elements snav-simple-content-overflow Bug: 803086 Change-Id: Ib193d14fec20be8d64817ce560613315ef3fdb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736895 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#685074}
-
Michael Giuffrida authored
DemoExtensionsExternalLoader loads apps from Offline Demo Mode Resources, then promptly overwrites them with apps it has cached. This means that if the device is offline and hasn't cached the demo apps, the apps will become uninstalled shortly after being installed. As a quick fix, prevent loading from the cache in Offline Demo Mode. This is intended as a highly mergeable, low-risk fix that we can merge into Stable. Afterwards, a proper fix would allow us to still use the cache. Bug: 991453 Change-Id: I51679f3667191f17c1dc3af3711cc36b6a9a34e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743252Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#685073}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/991aed28815f..71f3bc34cc28 Created with: gclient setdep -r src-internal@71f3bc34cc28 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9e563974f72fc6677b6682411c3472f8cc2d8b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742964Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685072}
-
Jacques Chen authored
-Since Brotli isn't widely used, make grit target optional -Change compress="true" to indicate gzip instead of brotli Bug: 826858 Change-Id: I14045669fd69525b13fb95b2ef1b539b4c5e23ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730838 Commit-Queue: Jacques Chen <jacqueschen@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#685071}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f10e9cb. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id50bd7fa51d2c763b1b9047c369c0e33c7432d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742119Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685070}
-
Jason Majors authored
Bug: 974844 Change-Id: If4c07ecfa2e80ab1c0e8122296b3ff36352d8987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666089 Commit-Queue: Jason Majors <jmajors@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#685069}
-
Gayane Petrosyan authored
Add a wrapper around 'bg-sel-tile-bg' and pull titles out and always select 'bg-sel-tile-bg' instead of 'bg-sel-tile'. Bug: 990734, 990946 Change-Id: I0c86318b9cca7abd13bcaac2cbe76701e3df7410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741310 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#685068}
-
Ken Rockot authored
Moves all uses of the Printing Service away from Service Manager APIs and over to direct service process + mojom usage. Introduces a GetPrintingService() function in chrome/browser/printing which returns a Mojo Remote that can control the sandboxed Printing Service process. The process is started lazily as needed and automatically shut down when no longer in use. Bug: 977637 Change-Id: I8bef36947163be3ed05a22eaac473e52e1e11395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738631 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#685067}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I675271adfc283b688de99d41e7eb236e908c0223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742961Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685066}
-
rbpotter authored
Patch IronA11yAnnouncer to prevent a compiler error about assigning a const to the result of Polymer() when polymer_pass is set to false (this is the case when compiling Polymer 3 elements, see [1]). [1] https://cs.chromium.org/chromium/src/third_party/closure_compiler/closure_args.gni Bug: 965770 Change-Id: I497a6c9197d2034a3f2ef4fac498e2ba87585f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742841Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#685065}
-
Chris Hall authored
R=aboxhall Change-Id: I33c80408fc72e4766614635e39417f1b07dbce99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735778Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#685064}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/231d2da44bf6..171da61e7635 git log 231d2da44bf6..171da61e7635 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 saklein@chromium.org Build API: Additional controller_util functionality. 2019-08-08 xiaochu@chromium.org dlcservice: check image size 2019-08-08 saklein@chromium.org Build API: Compile most outstanding proto changes. Created with: gclient setdep -r src/third_party/chromite@171da61e7635 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I73c2cd2300549f14ade63de34f4042e2ba83163c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742962Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685063}
-
Stefan Zager authored
Root margin is specified in CSS pixels, so it needs to have the zoom factor applied to it. BUG=966884 R=christhtr@chromium.org Change-Id: I44d2f1dcf1069426046c1d070b90f30fe9917589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741006 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#685062}
-
Melissa Zhang authored
BUG=984840 Change-Id: Id2cff2cf474399595700bbea05a9ff240218891e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739236Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#685061}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/421584173cae..bb10a9187623 git log 421584173cae..bb10a9187623 --date=short --no-merges --format='%ad %ae %s' 2019-08-07 enga@chromium.org Fix leak of AttachmentState Created with: gclient setdep -r src/third_party/dawn@bb10a9187623 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I3c6d72d1b693fd5acb87a2c6ff552e18d74867a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685060}
-
Chih-Yu Huang authored
We plan to enable new VideoDecoder implementation per board, instead of enable all boards at the same time. We won't enable boards that are not supported yet. This CL remove the fallback video decoder if "kChromeosVideoDecoder" feature is enabled. Then we could catch any initialize or runtime failure of new VideoDecoder implementation. BUG=chromium:984482 TEST=open crosvideo.appspot.com on Kevin and elm, with or without "kChromeosVideoDecoder" feature. Only elm with "kChromeosVideoDecoder" feature fails Change-Id: I6a3d6d0a0782ed4d7ea0ffb7527344c8c673da00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739231Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#685059}
-
Alan Cutter authored
This CL refactors TwoClientAppsSyncTest to split out the Extension app tests from the web app tests as separate files; TwoClientExtensionAppsSyncTest and TwoClientWebAppsSyncTest. The new web app tests file no longer depends on Extensions to reflect the ongoing refactor (BMO https://docs.google.com/document/d/19082NmfYNL1KEZDy2yOl7apaduNFYZaGB7YzbfwrJpU/edit) to pull web apps off the Extensions system. Bug: 926083 Change-Id: I5d076a295413211931d35f545f59e0ac5533f1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730514 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#685058}
-
Josh Nohle authored
Adds helper enums and functions for metrics logging related to individual tasks in CryptAuth v2 Enrollment and v2 DeviceSync flows. Currently, these metrics track whether async tasks succeed, timeout, or return with an error. For API calls, the error state is subdivided by the network request error. Bug: 899080, 951969, 933656 Change-Id: I6d0f0a24dbdb702efc03790071f05cffda30ba6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741642 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#685057}
-
Jinsuk Kim authored
The reported bug shows ChromeActivity.getFullscreenManager can be called while the activity is being destroyed, which will cause an IllegalStateException. Such incidents should be prevented from happening by checking the activity state before calling the API. This check existed in TabWebContentsDelegateAndroid (https://crrev.com/c/1547745) but removed in the course of refactoring (https://crrev.com/c/1621466). This CL puts it back. Bug: 990987 Change-Id: I0d9700e6d60acd129904a9f23488d211df795731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743286Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#685056}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0ec0db70f91..991aed28815f Created with: gclient setdep -r src-internal@991aed28815f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Iac4e42e3a5c9013017aa062c1808721753abbe8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742958Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685055}
-
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Bug: 968369 Change-Id: Icd7d6dad30afc319cf72a81351704756c3606bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741587Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#685054}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7c7dec01ce34..7424fe8b79c3 git log 7c7dec01ce34..7424fe8b79c3 --date=short --no-merges --format='%ad %ae %s' 2019-08-07 ynovikov@chromium.org Skip BufferDataOverflowTest.VertexBufferIntegerOverflow 2019-08-07 iannucci@chromium.org [infra/config] Bump OS X SDK on mac builders to version 10.1 2019-08-07 jdarpinian@chromium.org Remove all global constructors and exit time destructors. Created with: gclient setdep -r src/third_party/angle@7424fe8b79c3 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:973721 Change-Id: I98bc1632acb0739ac0e79dd140e18183ecb76ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685053}
-
Bartek Nowierski authored
https://chromium-review.googlesource.com/c/chromium/src/+/1355885 appears to accidentally change the counter to atomic_int. Since there are lots of nodes created, this can degrade performance. The counter is only accessed from the main thread, so no synchronization is needed. Change-Id: I0094b79375760e9dcf26d266c6e7fdaadd15a361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741433Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#685052}
-
S. Ganesh authored
We now check the input file for CRX and signature validity before copying to the secure location. This is to prevent us from copying unintended files, including files that may be private to a particular user or group. Bug: 991125 Change-Id: I9f3092c9fa32b822c4d7249598b0753b4c4a1fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742302 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#685051}
-
Yulun Wu authored
Temporarily disabling CrOS release notes for Browser tests due to Locale specific spacing issue. http://crbug.com/991767 Bug: 968372 Change-Id: Ia9ce5903b68a8b60085967aeb310196be4c7ae25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741478 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#685050}
-
Patrick Noland authored
It wasn't sufficient to call updateAccessibilityVisibility, since that doesn't account for SuspendedTab obscuring the WebContents, only SadTab. Rather than moving knowledge of SuspendedTab into Tab.java, we can just directly mark the WebContents as obscured ourselves. Bug: 978596 Change-Id: I725a153b61124385cb746d2f557695620185dac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741311 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#685049}
-
Hongchan Choi authored
This is a follow-up CL of: https://chromium-review.googlesource.com/c/chromium/src/+/1726957 This CL introduces the actual event hooks between the WebAudio module and the devtool frontend. This CL completes the backend for the graph visualizer. On top of this change, the graph visualizer is ready for the implementation. Bug: 970898 Change-Id: I76fae9d19d501158fac3c13cb6226d72fccb798c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728265Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#685048}
-