- 21 Jul, 2017 40 commits
-
-
Ryo Hashimoto authored
Currently, ObjectProxy::CallMethod is implemented by creating ErrorCallback from ResponseCallback. This does not work with OnceCallback because it's not allowed to create two callbacks from one OnceCallback. To solve this, this change introduces CallMethodCallbackInternal to ObjectProxy which takes either Response* or ErrorResponse*, and dispatches the response to the appropriate callback. Also, Gmock does not allow directly mocking functions which take move-only arguments. https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#mocking-methods-that-use-move-only-types To workaround this, add DoCallMethod to MockObjetProxy. BUG=740015 TEST=build Change-Id: I1a98b5fd1d6d70f69674102a3d66bcec0c13214c Reviewed-on: https://chromium-review.googlesource.com/578541 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Cr-Commit-Position: refs/heads/master@{#488615}
-
tzik authored
This CL makes base::{Thread,Sequence}CheckerDoNothing noncopyable, so that they are consistent to base::{Thread,Sequence}CheckerImpl, and an accidental copy of SequenceChecker causes a compile error even on DCHCEK-disabled build. Change-Id: I3ac37d87302712ab3decf693d056376c0c2abb91 Reviewed-on: https://chromium-review.googlesource.com/578751 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#488614}
-
Bugs Nash authored
Rewritten from https://codereview.chromium.org/2897833004, this version does not use the memory optimisation which has since been removed from the code. This patch - Split property specific parsing logic for background components into the case statements in CSSPropertyParser::ParseSingleValue, using the general ConsumeCommaSeparatedList template instead of ConsumeCommaSeparatedBackgroundComponent so that CSSPropertyID no longer needs to be passed. - Delted ConsumeCommaSeparatedBackgroundComponent (now unused). NB - ConsumeBackgroundComponent is still currently used in ConsumeBackgroundShorthand and so cannot be deleted. - Some bool literals are passed in this patch, violating the style guide. These arguments were not introduced in this patch and so will not be fixed in this patch. They will be converted to enums when the APIs are implemented. Bug: 668012 Change-Id: Ie364b810e10f0df3b3053e337d47fd60118cc985 Reviewed-on: https://chromium-review.googlesource.com/575253Reviewed-by:
Renée Wright <rjwright@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#488613}
-
Jeremy Roman authored
The argument is always equal to the |this| pointer. We can just use the latter. Change-Id: Ia14c0858b18c61bc500e3f276e36dc270a8e8232 Reviewed-on: https://chromium-review.googlesource.com/579961Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488612}
-
Yuki Shiino authored
MutationCallback holds a ScriptState and accesses it assynchronously. So, MutationCallback should check the context if it's alive before the uses. Bug: 738299 Change-Id: Ib16b37b2e90e5ba87117d7c6e1218f9df6d69a41 Reviewed-on: https://chromium-review.googlesource.com/574509 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#488611}
-
Kent Tamura authored
Rebaseline calendar-picker-appearance-zoom125.html and calendar-picker-appearance-zoom200.html for Mac10.9. TBR=qyearsley@chromium.org NOTRY=true Bug: 743068 Change-Id: I6b7e9bae599f22c80bdb420d76d2f238408e37af Reviewed-on: https://chromium-review.googlesource.com/579902Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488610}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/d60609d3a12f..4d02e904b015 $ git log d60609d3a..4d02e904b --date=short --no-merges --format='%ad %ae %s' 2017-07-20 drgage Change "Sel" abbreviation to "Selection". Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Icc508c39f951b785e5475611f484e38cd8539efd Reviewed-on: https://chromium-review.googlesource.com/580316 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488609}
-
Koji Ishii authored
Following bot results are included. 769 775 781 782 785 788 789 790 791 792 795 796 798 799 155 lines were removed by consecutive passes since 753. TBR=eae@chromium.org NOTRY=true BUG: 591099 Change-Id: Ib343eeaf4540ed94747f68724adedcecc175dac4 Reviewed-on: https://chromium-review.googlesource.com/580732 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#488608}
-
Mike Dougherty authored
The manual layout of the toolbar items for ios_web_view_shell is outdated and no longer works with iOS 11. Update the UIButtons to UIBarButtonItems and automatically lay them out with setItems: instead of adding items as subviews to the UIToolbar. Bug: None Change-Id: I800ade863253ac244cb8705a4afec0b09a0a2198 Reviewed-on: https://chromium-review.googlesource.com/578239Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#488607}
-
yhanada authored
Test: It builds. No behavioral change. Change-Id: I786bc492ff79fd3220bd1974d72f0e9703a1ccc2 Reviewed-on: https://chromium-review.googlesource.com/580453Reviewed-by:
Keigo Oka <oka@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#488606}
-
Adam Rice authored
Maximum stack space exceeded exceptions within the WritableStream and ReadableStream implementations can lead to slots being undefined that are expected to contain Promises. This in turn leads to CHECK failures. Protect all calls to V8 Promise intrinsics with checks that the expected Promise is present, and throw an exception if it isn't. Also add a test to verify that a CHECK failure does not occur. Bug: 743082 Change-Id: Iaf89aa2a694600d129021e7e902c6bc02401c8b4 Reviewed-on: https://chromium-review.googlesource.com/579628 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#488605}
-
Patricia Lor authored
Since a driving factor behind releasing the "Site Details" page as part of MD Settings is to replace default permissions in the Page Info bubble, the list of permissions shown in "Site Details" should include all permissions shown in the Page Info bubble. Add MIDI-SysEx to match it. and check one of the permissions listed there is "MIDI devices". Bug: 656758 Test: With #enable-site-details turned on, navigate to Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic111c09c17aef557990ae4f522151b294ab84842 chrome: //settings/content/siteDetails?site=https%3A%2F%2Fpermission.site Reviewed-on: https://chromium-review.googlesource.com/578758 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#488604}
-
Naina Raisinghani authored
This patch reduces the tree size for slower performance tests ensuring they don't time out. Bug: 747001 Change-Id: I3e87f1b68b3effcd04c8da2e673bd3e05f2374ed Reviewed-on: https://chromium-review.googlesource.com/580011Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#488603}
-
Yoshifumi Inoue authored
This patch introduces enum class |SelectionModifyDirection| as replacement of |SelectionDirection| since it is used as a parameter of |SelectinModifier::Modify()| for improving code readability. Change-Id: Ib249d01106503138811214895c7e8018e48758c5 Reviewed-on: https://chromium-review.googlesource.com/579248 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#488602}
-
Jia authored
This reverts commit 51c2bff2. Reason for revert: causing a crash on clusterfuzz (crbug.com/746769) Original change's description: > Implement API for shorthand properties animation and transition. > > This cl is a resubmission of an earlier cl (crrev.com/c/549675), which > was reverted to fix a crash on one specific version of Google Pixel. > The difference between this cl and the previous cl is in the > implementation of CSSPropertyAnimationUtils::ConsumeAnimationShorthand: > - The old version is a templated function that uses function callback > and variable number of args. > - The new version uses a function pointer, which is simpler than a > callback. > > The original crash was not reproducible using the old patch. > But it is probably better to use function pointers instead of > a callback function with variable number of bugs. > > Have run this new patch on a pixel phone and there was not crash. > > Bug: 668012 > Change-Id: I183df5f3a168fffbed253a8b47b177fa72cd06b4 > Reviewed-on: https://chromium-review.googlesource.com/569505 > Commit-Queue: Jia Meng <jiameng@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487372} TBR=alancutter@chromium.org,jiameng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746769 Change-Id: Ie93a301b97d599e593fcc4dac8c3a30ca972fcf3 Reviewed-on: https://chromium-review.googlesource.com/580588Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#488601}
-
Siddhartha authored
The test was broken because enabling tracing no longer enables MemoryDumpManager. Directly use memory tracing api for checking the dump values instead of trace file analyzer. BUG=746124 Change-Id: I950a1e43a63b6424afd67f0c6d30e0c50722fe24 Reviewed-on: https://chromium-review.googlesource.com/580338 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488600}
-
yoshiki iguchi authored
Previously, the buttons are on the dedicate widget to show them above the ARC notification (NativeViewHost). This CL moves them to a view. In addition, this CL adds a hacks for ARC notification which manipulates the hierarycy of layers to show the buttons at top most. Bug: b/62771497 Bug: 717455 Bug: 747217 Change-Id: I876c653e01d4a4237055bd4f763aa55017ba38ef Reviewed-on: https://chromium-review.googlesource.com/579107 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#488599}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e11a4d0d822c..f9e1294920ec $ git log e11a4d0d8..f9e129492 --date=short --no-merges --format='%ad %ae %s' 2017-07-20 benjhayden Add support for story tags to results.html. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I56c720fc77b14091d33eaab04baa4631de385558 Reviewed-on: https://chromium-review.googlesource.com/580310 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488598}
-
Keishi Hattori authored
Adds Blink's instance count data to memory infra Bug: None Change-Id: I6c814846017e0e7906f014c93b4ffbf7adaccb88 Reviewed-on: https://chromium-review.googlesource.com/577471 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488597}
-
Kinuko Yasuda authored
No BUILD.gn for now as it doesn't have actual files yet, but I plan to add that in the next patch. Bug: 740070 Change-Id: I6e45e864f84a27561718a144fe51bd902482ae59 Reviewed-on: https://chromium-review.googlesource.com/566794 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488596}
-
Nicholas Verne authored
I will be on-hook for populating this directory in the short term. Bug: 738768 Change-Id: I01a1ef5456f3dacb4eec645df8d12cf762d7fc52 Reviewed-on: https://chromium-review.googlesource.com/580013Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#488595}
-
Bugs Nash authored
This patch - Implemented the parsing logic for the single property APIs for the following properties - offset-distance - offset-rotate - -webkit-box-flex - -webkit-border-image - Removed the legacy parsing logic for these properties from CSSPropertyParser.cpp - updated CSSProperties.json5 so that the generated header files for the property APIs are updated diff for generated files: https://gist.github.com/BugsNash/8844b947b4e7e165b7475684b04da92c/revisions Bug: 668012 Change-Id: I144a82c9ba6727af9387a59a6d57427fd223327b Reviewed-on: https://chromium-review.googlesource.com/578757Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#488594}
-
Hidehiko Abe authored
Now the lifetime problem was fixed. So, the check is no longer needed. BUG=672829 TEST=Ran trybots. Change-Id: I918d2c3bdec6cbc9a0758e18a8ffee856211e19b Reviewed-on: https://chromium-review.googlesource.com/578917 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#488593}
-
Yutaka Hirano authored
Bug: None Change-Id: I4c566a86a9fdbe9f580fe3cf41879707969d5553 Reviewed-on: https://chromium-review.googlesource.com/575611 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#488592}
-
Yoshifumi Inoue authored
This patch makes |AdjustSelectionToAvoidCrossingEditingBoundaries()| in |VisibleSelectionTemplate| as static function to avoid modifying member variables, |start_| and |end_|, of |VisibleSelectionTemplate| for improve readability and a preparation of removing |start_| and |end_|. Bug: 230267 Change-Id: I1f5824f71ba115d3a11a3c534cf2f5024e715bbc Reviewed-on: https://chromium-review.googlesource.com/578908 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#488591}
-
Pavol Marko authored
Make policy-forced migration to ext4 report the new FIRST_SCREEN_START_AUTOMATICALLY UMA stat value instead of FIRST_SCREEN_RESUME. The introduction of EncryptionMigrationMode was required to distinguish between these cases. BUG=722371 Change-Id: I112406048e82c31762123a32775be445e6e731ab Reviewed-on: https://chromium-review.googlesource.com/579382Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#488590}
-
Ramya Sharma authored
This CL: 1. Removes the concept of primary view, since there is only one single view, the folder view that is shown as content. 2. Removes code that removes and adds primary view to the view hierarchy on each menu item update. This is not necesary, since the primary view does not change anymore. Bug: 705339 Change-Id: I8f73a26a3a315cde48f319bb3a55373dd85c4cbc Reviewed-on: https://chromium-review.googlesource.com/575305 Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#488589}
-
https://chromium-review.googlesource.com/c/578572/Peter Kasting authored
Bug: None Change-Id: I8b2e886fcb7bc2d47f149f3628fa52b92f74f0ee TBR: gab@chromium.org Reviewed-on: https://chromium-review.googlesource.com/580644Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#488588}
-
xzhan96 authored
Use std::unique_ptr instead of deprecated linked_ptr. BUG=556939 Change-Id: Icf51f7747b2467afe7ffe3995cd7d4e749b31e11 Reviewed-on: https://chromium-review.googlesource.com/578302 Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488587}
-
Matt Giuca authored
Fixes a thread-unsafe call to gfx::Image::AsNSImage on an image object from a resource bundle owned by the UI thread. Bug: 746815 Change-Id: I0eb06aab2823ff1b42c4fb35df3806f32169c744 Reviewed-on: https://chromium-review.googlesource.com/578539 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#488586}
-
yoichio authored
Since integers returned by SelectionStartEnd() don't relate each other except start LayoutObject == end LayoutObject. To emphasize that for readability, we should split SelectionStartEnd to each SelectionStart and SelectionEnd. Bug: 739062 Change-Id: Iacb552ea21ea36fc1769d295eaaadec59b8b20b4 Reviewed-on: https://chromium-review.googlesource.com/577986Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#488585}
-
Kent Tamura authored
We don't need to create new string with StringBuilder to collect digits. Also, use ParsingUtilities functions to simplify the code. Change-Id: Id98ff2298db5c447f53e13a21c1d9e597e971098 Reviewed-on: https://chromium-review.googlesource.com/580211Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488584}
-
Yoichi Osato authored
That condition is used to consider "if LayoutObject state is still same but offset is changed, we should invalidate it". However since |new_selected_map| includes start and end LO, even if we don't invalidate in this loop, we invalidate them in just below loop. Bug: 739062 Change-Id: I6ab6770565b8852260a226f208923d3b20492af9 Reviewed-on: https://chromium-review.googlesource.com/578968 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488583}
-
flim authored
BUG=737323 Review-Url: https://codereview.chromium.org/2962373002 Cr-Commit-Position: refs/heads/master@{#488582}
-
Kent Tamura authored
Introduce NumberParsingOptions, which is a set of parsing behavior flags, and CharactersToFoo{,Strict}() pass options to ToIntegralType(). This CL has no behavior changes. This CL is a preparation to merge CharactersToFoo and CharactersToFooStrict. Bug: 746157 Change-Id: I34d001bb193928288b99afcd0d531536105ce7e0 Reviewed-on: https://chromium-review.googlesource.com/580170Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488581}
-
Yoshifumi Inoue authored
This patch makes |Editor::CanCopy()| to work with detached IFRAME to follow up of the patch[1], which found this issue. [1] http://crrev.com/575324: Use a safer pattern for auto resetting RenderFrameImpl members Bug: 746181 Change-Id: If00b1d22476264a042806ff9870ca32229041908 Reviewed-on: https://chromium-review.googlesource.com/578913 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#488580}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 52e8a532. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/350 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dom-dev@chromium.org: external/wpt/html TBR=qyearsley@chromium.org No-Export: true Change-Id: I0314cd6481d409755c72c75eb85344c7a25990fe Reviewed-on: https://chromium-review.googlesource.com/580619 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488579}
-
Chung-Sheng Wu authored
ZRam has changed its sysfs interfaces since kernel version 3.18. (https://github.com/torvalds/linux/commit/c87d1655c29500b459fb135258a93f8309ada9c7) If file "/sys/block/zram0/mm_stat" exists, use the new interfaces, otherwise, use the old one. Bug=chromium:740438 Change-Id: Ief192baeb76824e06c78744a1a5010b3d8d682fa Reviewed-on: https://chromium-review.googlesource.com/566796Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Zhong-sheng Wu <chungsheng@google.com> Cr-Commit-Position: refs/heads/master@{#488578}
-
rlanday authored
Currently, this method does a linear scan over all spell check markers contained in the text node(s) containing the selection. This takes about 0.553 ms on the source for the "List of Australian treaties" Wikipedia page. This CL refactors this method to instead use the newly-added DocumentMarkerController::FirstMarkerIntersectingRange() method, which is more efficient as it uses binary search. With this change, we now spend about ~0.02 ms in this method doing the same test. BUG=736181 Review-Url: https://codereview.chromium.org/2947093003 Cr-Commit-Position: refs/heads/master@{#488577}
-
Makoto Shimazu authored
This is 7th patch of script streaming project split off from https://chromium-review.googlesource.com/c/538477. Design doc: https://docs.google.com/document/d/1BbETxB2K1GeGUv4XIvGGforAJRRgYSNX5x4vPTGsCPU/edit This patch implements SWInstalledScriptsSender to push the installed scripts over mojo pipes from the browser to the renderer. The sender is started when ServiceWorkerVersion asks EmbeddedWorkerInstance to start the worker. That means that scripts will be received on the io thread immediately after binding the Mojo interface. From this patch, "--enable-features=ServiceWorkerScriptStreaming" takes effect. When LayoutTests under virtual/service-worker-script-streaming fail, please add TestExpectations and report it to https://crbug.com/683037. Bug: 683037 Change-Id: I5aef2cff6026ae3afa004932f77064f24ba8bfc7 Reviewed-on: https://chromium-review.googlesource.com/563144 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#488576}
-