- 28 Nov, 2019 40 commits
-
-
Chris Sharp authored
This reverts commit 702cbe72. Reason for revert: The modified tests broke on linux-chromeos-google-rel Original change's description: > Add HTTPDangerWarning experiment to field trial testing config > > Bug: 1027626 > Change-Id: I70ddfb8cb18b7e045e8c6f30ce7d398d0c2f1c1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929862 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719730} TBR=bcwhite@chromium.org,holte@chromium.org,carlosil@chromium.org,livvielin@chromium.org Change-Id: I1f1812c6dcdc8d78c505e39c8a14440279ae0111 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1027626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942808Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719975}
-
Antonio Gomes authored
.. instead of base's RefCountedThreadSafe. BUG=787254 R=guidou@chromium.org Change-Id: Ie5e62f2920814444abf5ce4fa28855963b6319bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940928 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#719974}
-
Olivier Robin authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/8e8b719e061c..4695792710cf git log 8e8b719e061c..4695792710cf --date=short --no-merges --format='%ad %ae %s' 2019-11-25 wenyuz@google.com Merge branch 'release-candidate' into stable 2019-11-14 wenyuz@google.com Merge branch 'release-candidate' into stable 2019-11-13 galiak@google.com Merge branch 'release-candidate' into stable 2019-11-08 andrewoverton@google.com Merge branch 'release-candidate' into stable 2019-11-07 rsmoore@google.com Merge branch 'release-candidate' into stable 2019-11-06 galiak@google.com Merge branch 'release-candidate' into stable 2019-11-01 featherless@google.com Merge branch 'release-candidate' into stable 2019-10-30 yarneo@gmail.com v93.2.0 (#8686) 2019-10-30 yarneo@gmail.com Merge branch 'release-candidate' into stable 2019-10-28 andrewoverton@google.com Merge branch 'release-candidate' into stable 2019-10-25 rsmoore@google.com Merge branch 'release-candidate' into stable 2019-10-23 andrewoverton@google.com Merge branch 'release-candidate' into stable 2019-10-21 rsmoore@google.com Merge branch 'release-candidate' into stable 2019-10-16 andrewoverton@google.com Merge branch 'release-candidate' into stable 2019-10-09 yarneo@gmail.com Merge branch 'release-candidate' into stable 2019-10-08 yarneo@gmail.com Merge branch 'release-candidate' into stable 2019-10-07 featherless@google.com Merge branch 'release-candidate' into stable 2019-10-04 randallli@randallli-macbookpro2.roam.corp.google.com Merge branch 'release-candidate' into stable 2019-09-24 rsmoore@google.com Merge branch 'release-candidate' into stable 2019-09-23 randallli@google.com Merge branch 'release-candidate' into stable 2019-09-20 wenyuz@google.com Merge branch 'release-candidate' into stable 2019-09-19 bryanoltman@google.com Merge branch 'release-candidate' into stable Change-Id: I159aabff99fcfc7037cf51f431b4d858ca233437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940173Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719973}
-
Jan Wilken Dörrie authored
This change modifies the const overload of base::Value::GetList() to return the newly introduced base::CheckedContiguousRange() instead of base::span. Furthermore this change updates callers to use this new return value and performs some minor simplifications. TBR=treib,stevenjb,blundell,benwells,noyau,agl Bug: 990059 Change-Id: Iaf4577820fc579872d12d403cf8dd1aa9425b939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915759 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#719972}
-
Florent Castelli authored
Those parameters are soon to be removed in WebRTC and shouldn't be referenced from Chrome anymore. Bug: webrtc:7580 Change-Id: I68d11d9f77657a39f531027b062a513a3d3fee63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940155Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#719971}
-
Eric Seckler authored
Given his contributions to system tracing this feels justified :) Change-Id: I2e0127426be0fb713a8f703eba1c5d3058ea4bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942727 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#719970}
-
Roman Sorokin authored
Bug: b/129546015, b/129545535 Change-Id: Ie680314181f7cabcacc54818184bc41d9c068440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942048Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719969}
-
Greg Thompson authored
Unregistering ends up posting tasks to perform cleanup in the Encryption db. Let these tasks run during TearDown so that all files have been closed by the time the test fixture's ScopedTempDir is torn down. BUG=546640 Change-Id: Iaea6142c74cf4db65809403ecc681ebd1243ddb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942427 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#719968}
-
David Roger authored
This reverts commit 896db5d1. Reason for revert: as this is intended to be cherry-picked on beta, we want to minimize risks. After discussion we decided to go for an even smaller change, to be extra safe. Original change's description: > [Identity Pill] Don't freeze the animation during password bubble > > This CL reverses part of the change introduced in: > https://chromium-review.googlesource.com/c/chromium/src/+/1826678 > > The reason is that we don't want the pill to stay open while the > password bubble is displayed, as the user may mistakenly believe that > their password is uploaded to their google account. > > TBR=pbos > > Fixed: 1027112 > Change-Id: I77bbcb8793369579e96597bb6e72be89e852227b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940238 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719949} TBR=droger@chromium.org,pbos@chromium.org,tangltom@chromium.org Change-Id: Ice039caa9f1592a629148d0df4de5f92a9dffbc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942430Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#719967}
-
Igor authored
The powerwash was forbidden for enrolled devices initially to fix an enrollment escape bug where users could revert to older Chrome OS version and apply the weaknesses from the old version. After this change lands, powerwash will be allowed for enrolled devices in the following cases: 1 - Admin didn't set any value for the policy powerwash_allowed 2 - Admin set the powerwash allowed policy value to true 3 - Admin set the powerwash allowed policy value to false and the value of policy allow_tpm_firmware_update to true and the device needs to update the tpm firmware. In case of point 3, the powerwash is allowed only to explicitly update the tpm firmware. At the same time, the option to powerwash and revert remains disabled for enrolled devices. The CL from session manager to allow this on Chrome OS side: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1924409 BUG=chromium:923296 TEST=Check that ctrl+shift+R brings powerwash screen, and second press of the keys doesn't bring the "powerwash and revert" screen. Change-Id: I870a2c59c6989d041ad58dddf2c8ae40f20d94d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924193Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719966}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6cbbaee824c4..8b1980c87d08 git log 6cbbaee824c4..8b1980c87d08 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 ilkos@google.com Merge "Add statsd subscription id to trace metadata" 2019-11-28 ilkos@google.com Fix cost estimation for single row Created with: gclient setdep -r src/third_party/perfetto@8b1980c87d08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:145338821 Tbr: perfetto-bugs@google.com Change-Id: I41bcb3df478967c0a78a4bac3066c03c27580749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719965}
-
arthursonzogni authored
This CL: 1) Align the two ContentSecurityPolicy struct in between content and network::mojom 2) Add a content::ContentSecurityPolicy constructor from a network::mojom::ContentSecurityPolicy 3) Add several TODO for the frame-ancestor CSP checked out-of-blink. This allows the future follow-ups: 1) Replace content CSP by network::mojom CSP for every mojo IPC. 2) Remove (gradually) every content CSP by the network::mojom ones. Change-Id: I1b1e0658f77ce3141d263d7de09272d225a4f756 Bug: 1021462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926141 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719964}
-
Alex Clarke authored
There are no current plans to run WebLayer on desktop. We currently build it there to ease development. Change-Id: I725ca8a6da7011db06e25c0adb1f66332b6d1486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940268Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#719963}
-
sczs authored
- Adds a public flag to SaveCardTVC (supportsEditing), if YES then cardholder name, expiration month and year will be editable. - Implements updateSaveCardButtonState which checks the correctness of the Data: No empty cardholder name, and a valid expiration date. meaning that the year is the current one or older, and the month has a valid value for the selected year. - If one of the previous check doesn't pass then the Save Card button is disabled. Bug: 1014652 Change-Id: I61625a504a7da9617f842436862d58a32871882d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932799 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#719962}
-
Thomas Tellier authored
Bug: 900351, b/145275297, 1025736 Change-Id: Ic00d70ff5521ca9b9f10eead8fab17c1d590e23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939790 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#719961}
-
Anton Bikineev authored
This gives the following advantages over the existing binary tree: 1) Improved cache locality. When performing stack scanning the whole map can be held in memory and no indirections need to be performed. 2) The map is always balanced, whereas the binary tree can become unbalanced, e.g. if mmap happens to return memory in anscending order. This improves stack scanning by another 8% (after bloom filter). The use of base::flat_map implies that insertion and deletion of page regions is O(n), but since the value_type is trivially copy-constructible, this reduces to simple memcpy. Please note that insertion/deletion only happens when a new page region is allocated/deallocated, so this is not a frequent operation. In facebook_infinite_scroll story only up to 30 regions are allocated. Change-Id: I865495cf0288d6763ff1970043e4951d08de32b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940187 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719960}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dafa00edc4b3..b97d4ceb42b4 git log dafa00edc4b3..b97d4ceb42b4 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 fancl@chromium.org Fix showing wrong revision in bisect Created with: gclient setdep -r src/third_party/catapult@b97d4ceb42b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029025 Tbr: rmhasan@google.com Change-Id: I26226176cb6f5cb48e08ea5c5a4c81b40392531e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941084Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719959}
-
Maggie Cai authored
Currently the scroll view has a max size, while the label button lives in the scroll view doesn't have a max size. When the font size is larger than expected, the label button view will become higher than the scroll view, which generates a scroll bar. This CL changes the scroll view height settings to fix this situation. BUG=959671 Change-Id: I651934e84e4d96123b026f31d31825f231d9d9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939007 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#719958}
-
Peter Marshall authored
- Change how protocol messages are dispatched to/in the renderer. Previously the browser process would send 'interrupting' messages using a different DevToolsSession, io_session_. This mojo channel was bound using a task runner on the IO thread in the renderer process, meaning messages would still be processed even when the main thread was blocked. The IO thread would then post a task to the InspectorTaskRunner, causing it to interrupt V8 execution and run the posted task. To simplify this as much as possible, the browser now always uses the io_session_, but the IO thread will post a (non)interrupting task as appropriate for the message. This removes the need to keep the list of interrupting tasks in sync across the browser/renderer. Messages in-transit now always go via the IO thread and get posted to the InspectorTaskRunner, meaning pending messages can be tracked clearly using tracing, rather than sitting in a mojo channel somewhere waiting to get processed. - Add a new task queue for interrupting tasks only. Previously during an interrupt callback, we would run all tasks in the task queue, which could cause tasks that we not meant to be interrupting to be run during an interrupt. Now we run all tasks only from the new queue. - Remove IgnoreInterruptsScope. This was mistakenly applied to all running tasks during a refactoring. There used to be two ways to run tasks, one was refactored to call the other, but then they both used this interrupt scope. We actually don't need it at all because we now only run 'interrupting' tasks during interrupts rather than flushing the entire queue, which might contain non-interrupting tasks. - Remove the use of IgnoreInterruptScope in LocalWindowProxy::Initialize. The comment there doesn't apply now that we ensure we don't run non-interrupting tasks during interrupts. We don't have any calls that can cause JS to run in the ShouldInterruptForMethod list, so no JS will run there. - Add trace events to show how protocol messages are dispatched in the renderer process. These were really useful for debugging all of these issues. - Remove InspectorTaskRunner::IsRunningTask which was not used. Remove all the associated state handling around running_task_. - Remove InspectorTaskRunner::WaitForAndRunSingleTask which was not used. Remove the condition variable and all the handling for it as it was only used from this unused method. Bug: 1010534, 992560 Change-Id: I58c9193ecd1fc784cda22b054a9c5b7bc2f09969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926588Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#719957}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9cce7d1..241ab903 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie9a867ada4b13243a569a4b93a7db4eced30a68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941373Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719956}
-
Mohamed Amir Yosef authored
This class encapsulates the logic for updating/saving for Butter for Passwords efforts. Change-Id: I03ac490ad272576f4613df172a333b2c97a01919 Bug: 1012203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876409Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#719955}
-
Raphael Kubo da Costa authored
Small simplification that should not have any user-visible effects. Change-Id: I93764d578de2e6e84c013f5e8a44392d0938835b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941887 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#719954}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/editing as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. Bug: 939691 Change-Id: I84e4f60aac33de14ae43671a6dd77fa161a8b29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940004Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#719953}
-
Gyuyoung Kim authored
This CL converts SpellCheckPanelHostPtr|Request to the new Mojo types. Major changes are as below, - Convert mojom::SpellCheckPanelHostPtr to mojo::Remote<mojom::SpellCheckPanelHost> - Convert mojo::SpellCheckPanelHostRequest to mojo::PendingReceiver<mojom::SpellCheckPanelHost> - Convert mojo::BindingSet to mojo::ReceiverSet Bug: 955171 Change-Id: I2e8934227b97a685cb02c9c1a7a00b2ed0b3c746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935967Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#719952}
-
Raphael Kubo da Costa authored
The former was introduced in C++14 and is slightly more concise than the latter. This has no user-visible changes. Change-Id: Iaabfb3cd52f7d577ab2d26ec6b162dc25292536b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940184 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#719951}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2f875b2946bb..6cbbaee824c4 git log 2f875b2946bb..6cbbaee824c4 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 treehugger-gerrit@google.com Merge "Create views and table only if they do not exist" Created with: gclient setdep -r src/third_party/perfetto@6cbbaee824c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idd3bb1f37bfbe3e83fb4bc6f8740f3c5134dc19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719950}
-
David Roger authored
This CL reverses part of the change introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/1826678 The reason is that we don't want the pill to stay open while the password bubble is displayed, as the user may mistakenly believe that their password is uploaded to their google account. TBR=pbos Fixed: 1027112 Change-Id: I77bbcb8793369579e96597bb6e72be89e852227b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940238 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#719949}
-
Antonio Gomes authored
... by webrtc::StatsReport::Value::Type directly. Enums are 1:1 mapped. BUG=787254 Switch RTCLegacyStats away from WebString The CL also changes RTCLegacyStatsMemberIterator similarly. BUG=787254 R=guidou@chormium.org Change-Id: Iba87df118c032f71ae363f0c44e25de010308dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940430 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#719948}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/068f95675eec..b2e8e6e030c9 Created with: gclient setdep -r src-internal@b2e8e6e030c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Iba818bf377222f5766ab234966de34d4b4b7d5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941576Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719947}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7bb0115cecb6..7fd3ad466b4d git log 7bb0115cecb6..7fd3ad466b4d --date=short --first-parent --format='%ad %ae %s' 2019-11-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src f31f26f73930..b334829a91d6 (4 commits) 2019-11-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 6f6e3371c92a..979b531e9fff (1 commits) 2019-11-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 663dcefa22ea..d6e903bdc9ef (4 commits) Created with: gclient setdep -r src/third_party/angle@7fd3ad466b4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None,chromium:None Tbr: cwallez@google.com Change-Id: I133a8773a6fd35691dbf393699695440ca7eec6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719946}
-
Peter Kasting authored
* Use tints to compute frame colors in more cases * Pull dark mode computation out to a temp to make it easy to reuse later * Separate "shouldn't theme" and "should theme but can't" frame cases Bug: none Change-Id: I093e0e88c99fc061a04be69e15203ee3f16d2fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941169 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#719945}
-
Per Åhgren authored
This CL -Updates the multi-channel processing activation flags to match the the intended use in WebRTC. -Makes sure that the APM in the audio processor complies to properly run capture-side multi-channel processing. Note: This CL can only land once the WebRTC CL https://webrtc-review.googlesource.com/c/src/+/160707 has been landed and imported into Chromium. Bug: webrtc:10859 Change-Id: Ied2b185d36e43187d90b5d608243702ec929ec1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937030 Commit-Queue: Per Åhgren <peah@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#719944}
-
Oleg Davydov authored
After https://crrev.com/c/1937958 was landed, on some build configurations ImageProcessor became large enough for chromium style checked to forbid inline destructor. This commit moves destructor to image_processor.cc file, after that this is no more issue for style checker. Change-Id: I36efb3601fc9305ef61af1705618e6156528489a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941313 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719943}
-
George Zhang authored
The main purpose of the java heap profiler is to obtain a heap dump in the form of an hprof file and then parse the hprof file. Currently, there exists a parser that does one pass and keeps track of all the different instances and fields associated with them such as object_id, name, etc. With this CL, we pass over all the instances we just stored. The purpose if that is that we are able to connect references between two different instances. Bug: 1012072 Change-Id: I03180731ab5ce347383f64d1103d5dd750326a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907281 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#719942}
-
Fredrik Söderquist authored
Tbr: schenney@chromium.org Bug: 583097, 633012, 674797, 1029104 Change-Id: I4bc7c650f3d7737d5e974c1049d0fc6b52055223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939804Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#719941}
-
sczs authored
- Creates Mobile.Messages.Confirm.Accept.Time histogram. - Records the new created Histogram for Restore Infobars and Block popups. Bug: 1028951 Change-Id: Ifc33e345b9a78989a1584776e8e141ad14a7be16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939976 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719940}
-
Roman Sorokin authored
We need to save the flag in the local state because TokenHandleUtil::CheckToken might fail on the login screen due to lack of network connectivity. Bug: 998410, b/143986150 Change-Id: Iff38194d8fc714fcf486424c721f919992ae79f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938949Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719939}
-
Oriol Brufau authored
- Remove GridTrackSizingAlgorithmStrategy::GetCachedGridTrackSize in favor of GridTrack::CachedTrackSize. - Remove comment that no longer applies. - Remove the flex_factor parameter of NormalizedFlexFraction, since it can be obtained from the track. - Let GridTrackSizingAlgorithm::RawGridTrackSize return by reference for the same reasons as in r715665. The changes have no effect in practice. Change-Id: Ife54b87c85508a4e1be3a19775408fe06f74200b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940107Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#719938}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ef9ae256. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I8df6fff69df7187a2d8162221d79391ad67b4bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941371Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719937}
-
Yifan Luo authored
Adjust the wpt tests for application cache according to https://chromium-review.googlesource.com/c/chromium/src/+/1926478/20/third_party/blink/web_tests/external/wpt/fetch/metadata/appcache.tentative.https.sub.html#24. Bug: 1024198 Change-Id: I8bf6d94fbd12e5dd5ef65aea8a317a4694057c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938908Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Yifan Luo <lyf@google.com> Cr-Commit-Position: refs/heads/master@{#719936}
-