- 17 Jun, 2020 40 commits
-
-
Alexander Cooper authored
android-pie-arm64-dbg routinely takes (on average) 2.5 hours to compile, though sometimes it can take over 3 hours. This change attempts to mitigate this by bumping the number of goma jobs from 80 (the default) to 300, which matches what other android arm64 builders use. Bug: 1040644 Change-Id: I9b4810a65c1fafbee8a26951e6a2c83b4a2903be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250261Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#779413}
-
Olivier Robin authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2248681 Version of gn used still set an incorrect value for the code signing identity, so clear it while converting the project. This is needed until landing https://chromium-review.googlesource.com/c/chromium/src/+/2248761 Bug: None Change-Id: I2af4d1e10e92972e9f6f57a4ea41674b90990e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250060 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#779412}
-
phillis authored
Adds install_time to WebApp and saves to local database. Publish install_time update via WebAppsBase. Bug: 1093025 Change-Id: Ibfb77329f075b53fcc91b72e9064c33be0520c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247121Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#779411}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Two use cases of these functions in c/b/media are updated to use the new API. This CL does not change any behavior. Bug: 1060940 Change-Id: I11dbf3845c32c6fd0cdebc542b85efc312e78b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238830Reviewed-by:
Evan Liu <evliu@google.com> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#779410}
-
Marc Treib authored
In some situations, FormFetcherImpl triggers an automatic migration of credentials from an HTTP origin to the corresponding HTTPS origin. However, this functionality was missing from MultiStoreFormFetcher. This CL adds the same logic to MultiStoreFormFetcher (though still only for the profile-scoped store - migration in the account-scoped store is left as a potential followup). This required introducing a new PasswordStoreConsumer::OnGetPasswordStoreResultsFrom() method, which is similar to the existing OnGetPasswordStoreResults(), but also receives the PasswordStore as an additional parameters. Bug: 1095556 Change-Id: I1b01ba6b723c9c4716f5d4f44569aa59ee94cd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249898Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779409}
-
Xiaoqian Dai authored
Bug: 1071236 Change-Id: If37eb5af5c976ad7d713cb7519ade25fa2f32984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249393 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779408}
-
Olivier Li authored
Using the alias instead of T directly to make this class more similar to ScopedGeneric<T> to which it is similar. Also switch to taking const elemen_type& instead of element_type in the == operator to avoid copies but also be more idiomatic. Change-Id: Ia366b19f52b9b566319df300d75f5187152e3a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245885Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#779407}
-
Takumi Fujimoto authored
Use the QUEUE_UPDATE Cast v2 message type instead of QUEUE_NEXT and QUEUE_PREV, given the latter two are deprecated. Bug: 1078601, b/155890949 Change-Id: I573df3df96a868dacd0db13ca5cc4d93d6075c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240302Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#779406}
-
Wenyu Fu authored
Bug: 1094998 TBR=yusufo@chromium.org, yuezhanggg@chromium.org Change-Id: Ic9c8772da9285bef59b10d44bd08a2414843fd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250259 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779405}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I187e1202b3c47f65a29753c6b31df6192911bc4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248573 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#779404}
-
Peter Kasting authored
The first change here is to set the font and color in the typography provider, letting DownloadItemView work in contexts and styles instead of physical attributes. This is not a complete conversion (yet) since the existing FontList members are still present, but I'll remove those in a future patch. The biggest effect of this change is to make the file name once again be 13 pt instead of 12 pt. It also makes the dangerous download and deep scanning labels use the same font as the file name. The second change is to lay out the text using full label heights instead of baselines and (strange) single-dip offsets. Using baselines dates back to the original work on Material Design top chrome in 2015, and I can't find a spec (though bugs from the time mention one). This was questioned by sky@ (the reviewer) when it landed, and it looks both semantically questionable and hazardous-for-i18n to me. As demonstrated in the screenshots on the bug, using standard Harmony line heights and putting the labels flush results in a very similar appearance to the old behavior (which wouldn't be the case if we made the font change without also making this change), except perhaps slightly less buggy. Bug: 1095970 Change-Id: I53f9876d9b7bc5523adb9cd910a659a00717d130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249583Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#779403}
-
Darwin Huang authored
This may be especially helpful for folks who don't know what all the docs are or where they might be. Also, removes some trailing spaces. Change-Id: Idaac216fbae1f077c1aa483c8b34c62cd2c6eacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244657 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#779402}
-
David Roger authored
Bug: 1076880 Change-Id: If3da0121cfbcc014267914e17c41de9b3183ed34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236394 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779401}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I0e8ccb83f217a2c7861373b2a967a3eb49922dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249759 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#779400}
-
Arthur Wang authored
R=bsheedy@chromium.org, tvanderlippe@chromium.org Bug: 1060399 Change-Id: Id3f5ec43beb735ac44ecf4b4a6723225a9da9a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247329Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#779399}
-
Sunggook Chue authored
Enable InstalledAppProvider after LGTM from TAG bug: 1096127 Change-Id: If15f22d939dc9fd017ab454880ea57ded9fe4adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248133Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779398}
-
Sammie Quon authored
This is a reland of eb8dddbb. Deletes the flaky test. See discussion at crbug.com/1095387. Original change's description: > wm: Reland #2 improve cross fade animation. > > Reland crrev.com/c/2224990, including a fix for failing builders and > a fix with tablet screenshot related. > > It seems the problem was Minimize animation also recreates layers so > when we do destroy the window, calling stop animation on the current > window layer would not stop the layer we originally observed. This > patch also caches the correct layer and stops the animation if the > window is recreated. > > Test: none > Bug: 1088169, 1088039 > Change-Id: I502e83ac22470c892b2c4a06f8feb86af1fff59f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242742 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Mitsuru Oshima (slow:gardening) <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778527} TBR=oshima@chromium.org Bug: 1088169, 1088039 Change-Id: Ia83357a4ac40fc16190a3de2c2f8ad4f81810046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247915Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#779397}
-
Rohit Rao authored
BUG=None Change-Id: I69cc5d6165aa3a63bb38ab357ee6cf9bac249392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236200Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779396}
-
Peter Wen authored
These files are intended to be used during the build only. They should be automatically generated for each build according to the current state of the internal factory java files. This way these generated files are always up-to-date and do not suffer from bit rot. Clean up unused imports of android_library_factory_tmpl.gni and make other uses consistent with (updated): go/how-to-modularize-clank Bug: 1095805 Change-Id: I5a8256da7035131e44b1b3b8039a6ff6c21e0c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248748Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779395}
-
Nodir Turakulov authored
https://chromium-review.googlesource.com/c/chromium/src/+/2244653 disabled ResultDB integration. Re-enable on dev first. Change-Id: I1778b31732876ce93cf9c626b55402d159ab0b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248674 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#779394}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I1d225674c41774f32ef8f3102e119a59e63d2b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247897 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779393}
-
Aya ElAttar authored
Updated PolicyMap::Set references in Device Policy Decoder. Bug: 1092469 Change-Id: I401d0d93e1a929a8ff8275e7c2b25a26e7b84938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246595 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#779392}
-
Jochen Eisinger authored
I will revert this CL after a few canaries. Bug: 839751 Change-Id: I823ec7c2eb47df905869d3f4f74c89e59a1433be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246596 Auto-Submit: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779391}
-
Dana Fried authored
Tab group header title chips are not centered in the tab group header. Instead, they "tuck into" the stroke on the left side of the first tab in the group. This looks good when the group is expanded, but bad when the group is collapsed, because the title (unlike the underline stroke) looks off-center. We considered two approaches to fix this: 1. center the title in the existing header size 2. expand the header so the margin on the right side matches the left We chose (2) because it prevents visual jitter in the title chip when expanding and collapsing, as well as automatically aligning the title with the stroke. Bug: 1094040 Change-Id: Ie5e6252b56f7fdf612c580d403bd1b198bb2710c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249055 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779390}
-
Emily Stark authored
This CL hooks up the Always Show Full URLs option via OmniboxEditModel to the path-hiding omnibox UI experiments. Users will now be able to opt out of reveal-on-hover and show-on-interaction to always show the full URL without any elisions. Bug: 1094760 Change-Id: I3d5f15e7fcb6863701f00042daee9867fcbcf0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246863 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#779389}
-
Peter Kasting authored
This will be useful in some download item cleanup. Bug: none Change-Id: Iac4793db8fc13cdb935cee0360aee1f128fb8d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245346Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#779388}
-
ckitagawa authored
This test is passing, but doesn't actually do anything for a couple of reasons: 1. The first POST commit used a deprecated style of navigation without a NavigationEntry this fails automatically with bad message 216 since cross-document navigations require a NavigationEntry in RenderFrameHostImpl::DidCommitNavigationInternal(). This is fixed by using NavigationSimulator. 2. In NavigationControllerImpl g_check_for_repost is set to false for all tests. Even if a repost happened in this test the repost dialog would never show or increment the counter. This is fixed by adding a Scoped*ForTesting class similar to those for thread restrictions to permit showing a repost dialog in a test. I'm surprised the bad message didn't trigger a test failure... Bug: 1095727 Change-Id: I32906017fe2b931d459544b27c437691b92e08a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247079Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#779387}
-
Kevin Ellis authored
Opacity is sampled based on iteration time, which in turn is calculated from the animation clock. As the clock has microsecond precision and floating point rounding errors can further reduce the precision, a relaxed tolerance is required for the opacity calculation. Bug: 1094141, 1094473, 1094561 Change-Id: I59710951a5cb167362d2c6ec18710530d487a1b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248754Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#779386}
-
Mason Freed authored
This CL contains manual modifications to a handful of tests that use Shadow DOM v0 and Custom Elements v0, to attempt to upgrade them to WCv1. This CL also includes the movement of several tests (which turned out to be V0 only tests) to the web-components-v0-only folder, which will eventually be deleted. Bug: 937746 Change-Id: Ibf0bc44ad0e7e97b79e489abad29463496888161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248496 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#779385}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cac292283bfa..99f100357776 2020-06-17 tvanderlippe@chromium.org Fix node output for Ninja actions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I84e19075b4046bc88a4bf6ef1edb81b366b98f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779384}
-
Xiyuan Xia authored
Bug: 1021774 Change-Id: Idbcc46bdd1cf942221ac9c986fa010fd35fd4c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248545Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779383}
-
Koji Ishii authored
This patch changes |RecalcFloatingDescendantsVisualOverflow| to use |PostLayoutChildren| when traversing fragment tree, to avoid reading stale |NGPhysicalFragment|. This patch is speculative. Bug: 965639, 1095577 Change-Id: I86d8f054832f921d91bb8949f3aa956e940de7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249281Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#779382}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I10a179268fdcefe85d414ad37917e0cc0f9ec999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248631 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#779381}
-
Anatoliy Potapchuk authored
Previously, arc kiosk had a different autolaunch workflow than other kiosks, this made it much harder to debug autolaunch issues for different kiosk types. We are changing that. Bug: 1015383,1085104 Change-Id: If71456cf7312ef233e3dccd1f1be69be8cd3d3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231065 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779380}
-
Viviane Yang authored
Changed const char to constexpr char Bug: None Change-Id: Ib52da28f638cfb6030aebaf659027fd64e9a6f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247736Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#779379}
-
Roberto Moura authored
Bug: 1094335 Change-Id: I44617ec720910a8b5b1e03af27375089d48f23be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240868 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#779378}
-
Jeroen Dhollander authored
At the moment Marble does not return text responses, but only TTS. This will only be supported in a future release. To allow teamfooding of the Marble on ChromeOS feature using today's 1.46s branch, this CL introduces a |enable_on_device_assistant_tts_as_text| flag that converts the Marble TTS to text that is displayed to the user. Bug: b/157169287 Change-Id: I2870a02c8c1ebe4f48e6dea9c1ede0337de030f9 Tests: manually tested. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240309 Auto-Submit: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#779377}
-
Colin Blundell authored
This CL does the following: - Adds the ability for InfoBarCompactLayout.java to prepare infobar icons. This support is copied in from //chrome's InfoBarCompactLayout.java now that InfoBarLayout.java is available in //weblayer. - Uses the now-componentized translate infobar icon in //weblayer's translate infobar. BUG=1025620 Change-Id: I2d7cf05a0ec629017c715b4a690210e99ae4722a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238167 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#779376}
-
chrome://termsBen Mason authored
Bug: 1061575 Change-Id: I8744e057675cc8f4e7bca79c6d4bce4cfcf6acd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248727 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#779375}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20aa34ea8ddc..e2fbb30f588e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mmentovai@google.com,ioanap@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mmentovai@google.com,ioanap@google.com Change-Id: I9bad31881d765b8948735eee673097914ed052be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249712Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779374}
-