- 02 Apr, 2020 40 commits
-
-
Zhongyi Shi authored
This change is to verify that integer value of quic flag is handled correctly. Bug: 1005610 Change-Id: I8cdbf1e365ed4cb3afa3e892b09ef3000fd9d06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133226Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#755895}
-
Daniele Castagna authored
crrev.com/c/2103721 added a flag to toggle the optimization. The flag was disable by default so that it can be merged back (hopefully without any conflict) to 81. This patch reenables the feature on ToT by default. Bug: 1061708 Test: viz_unittests without scopedfeature Change-Id: Ibabc573a42c0750552982d02d3471798f59eb0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103722 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Reviewed-by:
Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#755894}
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Bug: 1033652 Change-Id: I1ea1ee51b19500aa99bbb318a8124abfce7abef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115517 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#755893}
-
Jonathan Backer authored
Skia added a new API to surface VK_ERROR_DEVICE_LOST to us. SharedContextState::MakeCurrent is called regularly before different clients (e.g. SkiaRenderer and OOP-R) access Skia. This should be frequent enough. Bug: 1066140 Change-Id: If03e72ca493b3d76b11bdee612f95f01cfaff5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134486 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755892}
-
Robert Ogden authored
Most of the metrics are coming from the TabHelper's Metrics struct, but the prefetch usage enum comes from the interceptor, by way of the TabHelper. prefetch_usage is read on commit since that value is set between navigation start and commit and does not change afterwards. prefetch_metrics is trickier. It may update numerous times while a user is sitting on a Google SRP page and won't stop getting written to until the following commit (or tab destruction). Since PLM's OnComplete is called after the following commit (not helpful) or at tab destruction (helpful), the PLM observer can't read prefetch_metrics during OnComplete because the metrics would be wrong whenever another navigation happened in the same tab. The implemented solution to this timing mess is to make the prefetch metrics struct into a RefCounted class. Then the PLM Observer will get an additional ref (only by being a friend) and hang on to it until all needed metrics have been recorded, which happens after the tab helper has moved on to the next page. Triggering the PLM Observer to get a ref to the metrics class is done with a PLM Event. This is done for two reasons, 1) because we can't rely on the order in which |DidFinishNavigation| is called for WCO's and 2) because using a PostTask off of OnCommit was still too early in my testing. Furthermore, using a PLM event allows the observer to only take the metrics ref when it will actually be used. This is done by only sending the event when an eligible navigation prediction is made and is being acted on. Bug: 1064726 Change-Id: I5de582650e2d29f7d62f2871cd1b7db5a72144fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129231Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#755891}
-
Jose Lopes authored
This closure is run as part of a factory method, therefore it can be run repeatedly: * https://source.chromium.org/chromium/chromium/src/+/master:media/base/mock_filters.cc;drc=d9b91db0b32bcaed524db17b05f614c7e86326bc;l=232 This is part of the base::Callback migration. Context: http://doc/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA#heading=h.uxpxu8vg4k4r Bug: 1007805 Change-Id: Ied0c7ed6476c29577bf02821a54c71fdf361dd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111096 Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755890}
-
behdad authored
If reporter in in Commit stage, the OnFinishImplFrame should flag the reporter, so that in case of submit the Impl portion of reporter would be ready for submission. Bug: chromium:1067245 Change-Id: I05b9888e37d74b4b9346965153616e9b29e0b078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133875 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#755889}
-
behdad authored
All latency which is reported without specifying the interaction should also be reported under MissedDeadline category TBR=schenney@chromium.org Bug: none Change-Id: I81c6b40c5d4579cbfdee32809c4c465fe94a2d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133878 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
-
Wenbin Zhang authored
Add another argument to separate tester workflow and processor workflow. Bug: chromium:1045256 Change-Id: Ib9971ea5f194d1dc6bf8663e4a0c69e5911e027c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133374 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755887}
-
Lukasz Anforowicz authored
The only test (BrowserAction*Test.BrowserActionPopup) that used to rely on ExtensionActionTestHelper::GetPopupSize was disabled for a long time. In the meantime, GetPopupSize stopped working (e.g. it would crash with a null dereference when not being able to find a native widget associated with the popup). This CL re-enables the test (the focus-related flakiness should be fixed by r754788) and makes the test use content::WebContents::GetContainerBounds instead of ExtensionActionTestHelper::GetPopupSize. After this CL, the GetPopupSize helper test method is no longer needed and can be removed. Additionally, the CL removes one additional cause of test flakiness by making sure that the resizing of the popup has actually propagated all the way to the content::WebContents::GetContainerBounds by 1) waiting until layout happens (by having the test go through requestAnimationFrame) and 2) by waiting until the layout results have gone through compositing (by having the test wait for MainThreadFrameObserver). Bug: 1021172 Change-Id: I84cdd6934d621dfed9ec783fbd0e21d172387fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129211 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#755886}
-
Lily Chen authored
Bug: 1066615 Change-Id: I661d23b59caa5d7d6e1a42b4c78575115048151f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133080Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#755885}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c6b2f34f358b..55c991cc81ae git log c6b2f34f358b..55c991cc81ae --date=short --first-parent --format='%ad %ae %s' 2020-04-02 marinaciocea@webrtc.org [InsertableStreams] Save the transformer to be set on Reconfigure. 2020-04-02 ilnik@webrtc.org Calculate video padding for vp9 in the same way as for vp8 2020-04-02 sakal@webrtc.org Delete legacy MediaCodec HW codec integration. 2020-04-02 titovartem@google.com Extract test peer creation into separate file Created with: gclient setdep -r src/third_party/webrtc@55c991cc81ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052765 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I657effd393041139590d6737c7aebae11fb48c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755884}
-
Renato Silva authored
- Enable marketing opt-in screen for clamshell mode. Previously disabled. - Change command line switch to feature. - Enable the marketing screen by default - Update the styles on the marketing opt-in screen. - Prepare the screen to be attached to the new ChromebookEmail component that will be added. - Fix broken tests. Fixed: 1023370 Change-Id: Iaa4f7b595452afafd5d501ca28991b06ea204b1e Bug: 1023370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127926 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755883}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eafb2c3665f7..ca6b5b7a1781 git log eafb2c3665f7..ca6b5b7a1781 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-02 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-01 bhthompson@google.com Make 3rd release branch build on Mondays and Wednesdays at 7 UTC 2020-04-01 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-01 skau@chromium.org licensing: Add empty package exemption Created with: gclient setdep -r src/third_party/chromite@ca6b5b7a1781 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: If62de7566a87361c882324e54f8322b1aaaf50b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134354Reviewed-by:
-
Anatoliy Potapchuk authored
This CL tests whether we have existing presubmit check to remove includes that are not needed Change-Id: I821b3cefdc82c8bddf8be20a711af5b121822d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879922Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#755881}
-
Guido Urdaneta authored
The use case to be supported is efficiently running Streams of RTCEncodedVideoFrame in a Worker. In this case, RTCEncodedVideoFrame are serialized to the Worker. Serialization is supported only in the same process as a shallow copy where the underlying webrtc frame is shared among the original and the deserialized object. See https://github.com/alvestrand/webrtc-media-streams/issues/5 Bug: 1052765 Change-Id: Ie236cb3d0e0537ac55b07f030eee028cb5706217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132156 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#755880}
-
Xiyuan Xia authored
- Fix the AutotestPrivateGetPrinterListFunction threading issue; - Update assistant disallowed state value from DISALLOWED_BY_ACCOUNT_TYPE (8) to DISALLOWED_BY_NONPRIMARY_USER (3) after https://crrev.com/c/2091649; - Fix flaky acceleratorTest by adding a short delay before verifying a browser window is closed on accelerator Ctrl+W. - Remove histogram tests because it is moved to metricsPrivate api in https://crrev.com/c/2108219; Bug: 1032993 Change-Id: Icb53d6cbacf239ed1d1ccf6e2d29947534c98050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132683Reviewed-by:Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755879}
-
Aaron Leventhal authored
Lifecycle changes should not occur during a11y serialization. This adds a safety check that triggers a DCHECK when that occurs. Bug: 1025740 Change-Id: I858b7e437eeb97e3d0284192bda39128c16b6b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113076 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#755878}
-
Bo Liu authored
Some debug border are sized to the size of a layer which can be arbitrarily large. It will fail deserialization if the area overflows int. Simply drop these borders to avoid renderer being killed. Bug: 1066139 Change-Id: Ie51e327383fd594ac5cb551a94b945f9645fa7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134187Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755877}
-
Andrey Zaytsev authored
Bug: 1066929, 1015841 Change-Id: I457629cf885c669a9fe67440e3a30e2f61f6ed82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134371 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#755876}
-
Brett Kilty authored
Adds the ability for non-public Android Chromecast to pass a flag to disable sandboxes on utility process creation. This targets the ability to use this flag so it cannot be used accidentally. Bug: b/118772032 (internal) Test: Local builds including using the flag verification. Change-Id: I17bd1318796f4fed6400e2b2486954af384ba494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122469Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#755875}
-
Nina Satragno authored
WPTs testing navigator.credentials.get() webauthn extensions were expecting errors incorrectly: * Unrecognized extensions are ignored instead of failing the request https://w3c.github.io/webauthn/#sctn-extensions * null, empty array, and non sensical objects evaluate to dictionaries with undefined key values, which means they should also be ignored https://heycam.github.io/webidl/#es-dictionary Fixed: 875444 Change-Id: I5b2cd3d421dc3cddc7010ff3f365314e25cf2a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133159Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#755874}
-
Mikhail Khokhlov authored
Also fix the test type for mac and win bots. Bug: 1050517 Change-Id: I2df12f92e5775b6b3af71cdcaef6844d877d1fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134227Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#755873}
-
Brook Hong authored
The task runner (`base::sequence_manager::internal::TaskQueueImpl::TaskRunner` -- child of `base::SingleThreadTaskRunner`) being held in `unfreezable_message_filter_` refers to an object of `base::sequence_manager::internal::TaskQueueImpl::GuardedTaskPoster`, which holds an object of `base::internal::OperationsController`, which then holds an object of `base::WaitableEvent`, which finnally holds an open mach port. The issue also impacts other systems like Windows / Linux. Bug: 1063577 Change-Id: I5e34c71953835d9312360d349072ec4809f00d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132536Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#755872}
-
Robert Sesek authored
They should just match //sandbox/OWNERS. Change-Id: I98c4de76dbc05481d64893d985a29b4b6f832e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134526Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#755871}
-
Sahel Sharify authored
With this cl Android native payment apps can declare a list of supported delegations in their manifests. The Pay intent sent to these apps is populated with paymentOptions and/or available shippingOptions (if needed). The received response is then parsed to construct the payer data according to the requested payment options. This cl covers sections 1 to 3 of the design doc: https://docs.google.com/document/d/1YKQxCrhWlACt9KNSMYvdOx6bNuu9YPJj9cY8CFKdTD4/edit?usp=sharing Bug: 1026667 Change-Id: I5e2e2e80abd395cef386e2f3bfcbd3181f1d685f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129954Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#755870}
-
Yuki Shiino authored
HTMLOptionElement's NamedConstructor's arguments should have default values of "" (empty string) instead of IDL null. (It's not allowed to initialize non-nullable DOMString with IDL null.) Bug: 839389 Change-Id: Ifab7058697b98be497c7e794ee173165dcaf10cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134027Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
dpapad authored
#cr_define_end is a special comment leveraged by polymer_modulizer() and js_modulizer() BUILD.gn rules, when auto-converting files to JS modules. Bug: 1045266 Change-Id: Ia1be68bf63753be9fd38c3066246d34f58afc3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133234Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#755868}
-
Behnood Momenzadeh authored
This CL triggers a lookalike safety tip if enabled by a feature parameter. The set of TLDs searched for is also configurable via feature parameter. This code is trivially changeable to trigger the Lookalike interstitial instead of a Safety Tip. A Safety Tip was chosen since we already have experiment infrastructure (i.e. feature flags) and we're not yet sure about the false positive rate of the heuristic. This CL also slightly also changes the target embedding logic. Target embedding is now no longer detected if the eTLDs overlap, such as in google.co and google.co.uk. This reduces false positives. TBR: cthomp@chromium.org Change-Id: I3b9a97d613b90b10ee85426c0ee27aab9adcf1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119374 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#755867}
-
Peter Kasting authored
This test tried to use a service whose factory is null in test mode. It would work if run standalone because the factory was _also_ not properly registered on startup, so the testing factory would never be set to null. However, if run in a batch with other browser tests, a previous test's access to the factory would register it; the next browser startup would null its testing factory; and then this test would crash. This fixes both problems: registers the factory, and sets a non-null testing factory. Bug: none Change-Id: I877cb9b7c58e82de17888b52d7d6ddc34f5bec27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133626Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#755866}
-
Wenyu Fu authored
Bug: 1052060 Change-Id: Idc3dc5220a822234222dc77f583ba119558ccce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095771 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#755865}
-
Arthur Wang authored
R=jbudorick@chromiums.org Bug: 1065848 Change-Id: I9fada9d16a5a5cb468777160fab9662a05c76016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133150Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755864}
-
Antonio Gomes authored
BUG=1063749 R=jfernandez@chromium.org Change-Id: Ide065e86f3a9950ba0ff7f8ce177ee37f41b6af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133910 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#755863}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c980dbf22c82..7b793647316c git log c980dbf22c82..7b793647316c --date=short --first-parent --format='%ad %ae %s' 2020-04-02 surma@chromium.org Fix size calculations in ExpandableTextPropertyValue Created with: gclient setdep -r src/third_party/devtools-frontend/src@7b793647316c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1024721 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8f322feb682f3b47cbc5b2edbb8c21c64f371bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134350Reviewed-by:
-
chrome://omniboxTommy C. Li authored
This records the group ID and header text of suggestions in the additional_info field of AutocompleteMatch. That way, we can show this extended metadata in chrome://omnibox in a lightweight way (without adding a whole new column or something). This will be useful for Moe and I (and others) to debug the header text feature as we are developing it. I really like the extensible additional_info dictionary by the way. Bug: 1052519, 1052522 Change-Id: I1409b6e6fd775149f6ca9c67e793f49c031c7251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132958 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#755861}
-
Koji Ishii authored
|LayoutText| and |LayoutInline| has functions to check whether they produced inline fragments or not in slightly different ways. Also we have |DCHECK| to do it for |LayoutBox|. This patch adds |HasInlineFragments()|, unifying these code. This is also used when associating |NGFragmentItem| with |LayoutObject| in <crrev.com/c/2117558>. This patch has no behavior changes. Bug: 982194 Change-Id: Ie2bee2531189b7707773aab388ca51d5d112c030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133535 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755860}
-
Andrew Xu authored
This CL records the smoothness for shelf icon animations which are usually triggered by adding/removing a shelf icon. In detail, there are three kinds of icon animations: (1) Move icons (2) Fade in an icon (3) Fade out an icon. This CL should be landed after https://crbug.com/1051490 is fixed. Bug: 1049702 Change-Id: I8c47ba3a3111a2bc8a7361ddcc12420d45308cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105675 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755859}
-
Rushan Suleymanov authored
This change initiates bookmark reuploading for pre-existing bookmarks which are stored locally. A new field is introduced to BookmarksMetadata to determine if local bookmarks were reuploaded. To prevent the case when the bookmark specifics is committed without favicon the entity is marked as unsynced after it was committed. In this case the entity will be committed again when the favicon is loaded. Bug: 1061411 Change-Id: I4a26a2babceb99a0f6532d2357884c75aff9fc05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127032 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#755858}
-
Abhijeet Kandalkar authored
After clicking the toggle button to enable/disable the extension, the icon of the next extension is getting selected. This issue is a regression from[1]. [1] https://crrev.com/c/1567561 Bug: 1060114 Change-Id: I14c4f713e6819267724baec6d9cbdcba7de74f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133986Reviewed-by:
-
Guido Urdaneta authored
The use case to be supported is efficiently running Streams of RTCEncodedVideoFrame in a Worker. In this case, RTCEncodedVideoFrame are serialized to the Worker. Serialization is supported only in the same process as a shallow copy where the underlying webrtc frame is shared among the original and the deserialized object. See https://github.com/alvestrand/webrtc-media-streams/issues/5 Bug: 1052765 Change-Id: I1e2d9bcd2e24ef6aa6a7688f34283a81e6d23172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083297 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#755856}
-
