- 23 Mar, 2020 40 commits
-
-
Benoit Lize authored
This reverts commit 113ebf6d. Reason for reland: fixed the Android release builds. Original change's description: > base/allocator: Improve PartitionAlloc perftests. > > Add: > - Comparison with the system allocator > - Better concurrent workloads for competing threads (identical as the > test) > - Reporting of the total allocation rate, and the worst thread > - Varying number of competing threads > > This is useful to evaluate the performance of PartitionAlloc with > various changes, such as changing its locking to base::Lock, or > implementing a thread cache. > > Bug: 998048 > Change-Id: I4c5f837f9e1b5af19b2f80bd79f3d3181166d930 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111160 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752077} Bug: 998048 Change-Id: Ife2cf7e33eb17c56d25f9f66ceeee87db617d3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113973Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752406}
-
Fredrik Söderqvist authored
Rather than having FEImage resolve the element reference on every operation that may involve it, have the creator of the FEImage (the SVGFEImageElement) resolve the reference and pass it to the FEImage. Bug: 1028063 Change-Id: Icabe881d980abe995a96dbf54df81da151e0e610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111157Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#752405}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a80b423b2136..c591f1048c69 git log a80b423b2136..c591f1048c69 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 sigurds@chromium.org [issues] Don't clear issues that logically belong to current navigation 2020-03-23 bmeurer@chromium.org Fix DESIGN_GUIDELINES.md link in README.md. Created with: gclient setdep -r src/third_party/devtools-frontend/src@c591f1048c69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1060628 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifce41974f345172ad5fc194c3e3f8ef9a6d38cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114846Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752404}
-
Vadym Doroshenko authored
This reverts commit fccf3a8f. Reason for revert: This CL breaks on Linux MSan bot FidoCableDiscoveryTest.TestDiscoveryFindsNewAppleDevice FidoCableDiscoveryTest.TestDiscoveryFindsIncorrectDevice First failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22909 Original change's description: > Give the desktop a public key in QR handshakes. > > This change switches the QR-based handshake from NNpsk0 to KNpsk0. I.e. > it gives the desktop a public-key. That key is included in the QR code > and means that an attacker who sees the QR code cannot impersonate the > desktop and pair with the phone. (The other direction is still possible, > however, and seems fundamental without the user entering a confirmation > code on the desktop.) > > BUG=1002262 > > Change-Id: I7254a8aa17df71d2bcabb4371a1c18914ed20641 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109032 > Commit-Queue: Adam Langley <agl@chromium.org> > Auto-Submit: Adam Langley <agl@chromium.org> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#752196} TBR=agl@chromium.org,martinkr@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1002262 Change-Id: Id75ad0bab2862b3dafe73d20cf762883cc24faf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113771Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#752403}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be8affce16ac..b41fb280f77b Created with: gclient setdep -r src-internal@b41fb280f77b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I55fd5a3257ceac7e2f42dd1948c3de63dce94b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114845Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752402}
-
Gauthier Ambard authored
The button is no longer used for search, it is now used for opening new tab. Fixed: 974751 Change-Id: I7de359e3c8801ec3f936a19cdb6b16358a48c47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106851 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752401}
-
Ian Struiksma authored
This test is failing due to a Javascript processing change. The test should work if re-recorded but not looking to update the password test cases cipd instance for just this single failure. Disabling for now until other tests are added/updated for a cipd batch. Bug: 1061553 Change-Id: If459e5cac54234459cd423d7599e77f0b72afc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111390 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#752400}
-
Eric Leese authored
Both tests rely on internals that we shouldn't be testing and make it harder to change devtools. Bug: chromium:670180 Change-Id: I35934db8cfafa418f12ea096f5f1d971ac34d4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112554Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#752399}
-
Clemens Arbesser authored
Bug: b/152013302 Change-Id: I3bfc9628c01c130e49630bfddf08898ce9b68838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111319 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#752398}
-
Ian Struiksma authored
A couple changes to product code caused some failures. Re-recorded 1 test (walmart_ca) after javascript processing caused WPR failure and needed the fresh site. Altered: cvs dsw home_depot gamestop neiman_marcus pizzahut_uk rei rakuten tractorsupply recipe .test files to expect different formatting for credit card after blur/focus changes from crrev.com/c/2023496 dsw, home_depot, gamestop needed extra click events added to their recipes to handle this change as well. Bug: 1061126 Change-Id: I5a5426b283e2decdaca2531c3869ff91c060609a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112963 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
-
Tomasz Moniuszko authored
It's not used on Windows anyway as there's platform-specific implementation in chrome/browser/ui/views/color_chooser_win.cc. Change-Id: Ic799890799f70141ae1e245e3a62df5cf707947c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108141Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#752396}
-
Patrik Höglund authored
EngProd haven't touched these tests in years, so I don't think we need to be owners of them anymore. Bug: None Change-Id: I02383eee2adf0cecd32c2e7dfd314bb21bccba18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109757 Auto-Submit: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#752395}
-
Side Yilmaz authored
ContextualSearchSceneLayer. Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates ContextualSearchSceneLayer class. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Ic8946777cbc4d6d9d585b89f67578dc6ff930719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107861 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#752394}
-
Gauthier Ambard authored
https://chromium-review.googlesource.com/c/chromium/src/+/2024895 https://chromium-review.googlesource.com/c/chromium/src/+/2027787 Bug: none Change-Id: I4f8ae1753f557f5dd5d9216619a94d7dc9d40d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111094Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#752393}
-
Rune Lillesveen authored
The print preview UI used HasCustomPageSizeStyle() to decide if the CSS dictates the given page size, or if a UI to change the page size should be available when printing to PDF. We returned true when the size descriptor only contained an orientation, which does not give the user an opportunity to select if "size:landscape" should print to Letter or A4. Instead, replace HasCustomPageSizeStyle() with a GetPageSizeType() to pass the page size type out of Blink instead of a boolean to make it possible for the printing UI to disable the UI for selecting page size and orientation separately. The testRunner API for hasCustomPageSizeStyle() is removed since it was only used for a single test which we now have coverage for in unit tests. This CL should not have any behavioral changes. Bug: 1016235 Change-Id: Id12c4310f87fc99b17660c355913150f12ff3e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107598Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752392}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6a431038c911..13c0df80dca5 git log 6a431038c911..13c0df80dca5 --date=short --first-parent --format='%ad %ae %s' 2020-03-22 ramakrishnan.nikhil@gmail.com [docs] Fix building docs if `srcdir' != `builddir'. 2020-03-21 ramakrishnan.nikhil@gmail.com [docwriter] Drop support for Python < 3.5. Created with: gclient setdep -r src/third_party/freetype/src@13c0df80dca5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I43a54d99663fc8cca2acd0896e90ce56a518bb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113204Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#752391}
-
Anatoliy Potapchuk authored
Currently, AccessibilityControllerImpl is mid-way of the refactoring for feature controls. This CL makes other features be controlled by their own Feature or FeatureWithDialog instance. We will remove/rename redundant methods in the following CL. Bug: 1051892 Change-Id: I840a2d64ff20e51e67656c55a4572ae2aff479bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108020Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#752390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57af8b538c0c..be8affce16ac Created with: gclient setdep -r src-internal@be8affce16ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4b481f1b3e80a1d1f7fb431f786bfd0d691ef594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114837Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I6041045479150048ab5c5da3ad7a72d53d51c45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114971Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752388}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c23bd5e4e38d..f04f21a5c913 git log c23bd5e4e38d..f04f21a5c913 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1c9f24263e6c..22d73d15e778 (1 commits) Created with: gclient setdep -r src/third_party/skia@f04f21a5c913 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Id8c326e3d860450a45ac4043168827b614bd855a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114839Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4481dd59..d67bef80 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8ece03547dcb8f80770c52aa9921be17061bfd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114930Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752386}
-
Krishna Govind authored
This reverts commit a33032ad. Reason for revert: Breaks canary, crbug 1063647 Original change's description: > [WebLayer] Delete browserservices.Origin > > This is the last CL to move browserservices.Origin to > //components/embedder_support so it can be used by WebLayer. This was > split into multiple CLs to avoid breaking Clank. > > Bug: 1058597 > Change-Id: I1964b9fc54c378528ba4935e2385da99fc663e70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106889 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752248} TBR=boliu@chromium.org,yusufo@chromium.org,rmcelrath@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=rmcelrath@chromium.org Bug: 1058597 Change-Id: I02ed8bfea70aa7e4913d8e27bc058f05185509f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114970 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#752385}
-
Noel Gordon authored
When keyboard is being used to interact with FilesApp, the html element gains a .focus-outline-visible class. That class is removed if the user clicks anywhere in Filesapp [1]. Add a test for this behavior. [1] See cr/ui/focus_outline_manager.js, which is available in FilesApp, and initializes html.focus-outline-visible on creation. CSS like: html.focus-outline-visible some-element:focus { outline: 1px auto -webkit-focus-ring-color; } can be used to show focus rings only for keyboard interaction. Test: browser_test --gtest_filter="*keyboardFocusOutlineVisible" Bug: 1062902 Change-Id: Ieec9d66c328b4f9b64ded0d34c060493454892c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114772Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#752384}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I355345e48d1c491cf02efff6a2a240e1669aacb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114597 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#752383}
-
Alan Cutter authored
This CL updates the Extensions API chrome.management.generateAppForLink() to function with the new web apps backend by translating the installed web app's properties into an equivalent ExtensionInfo return value. Bug: 945205 Change-Id: I250659fb6e6c210ca467558e95c00a779104f763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094852 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752382}
-
Luciano Pacheco authored
In Files app we added a title inside the list, when clicking in the title it throws an exception in the assertInstanceof() in getListItemAncestor(). This CL fixes getListItemAncestor() to not raise in this condition, instead it returns null as the description says. It also fixes event handlers that calls this function to check if it has returned null. Test: browser_tests --gtest_filter="WebUIResourceBrowserTest.ListTest" Bug: 1063184 Change-Id: Icf92cc30bb0a346c7e19660f847a994286abfea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111252 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#752381}
-
Manuel Rego Casasnovas authored
In ShapeResult::OffsetToFit() when the size to fit matches result.origin_x we were returning the left_character_index only if Direction() was RTL. However if line_direction is RTL we also want that index. With this change css/css-ui/text-overflow-028.html starts to pass on Linus and Windows, we add new tests here too (the RTL ones were failing before this patch). BUG=1063319 TEST=css/css-overflow/text-overflow-ellipsis-001.html TEST=css/css-overflow/text-overflow-ellipsis-rtl-001.html TEST=css/css-overflow/text-overflow-ellipsis-vertical-001.html TEST=css/css-overflow/text-overflow-ellipsis-vertical-ltr-001.html Change-Id: Idbaed07a63d4ec6335e722b7fb7b4e91f4076564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111152Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#752380}
-
tby authored
We've got some very spammy vlogging to debug an issue we've fixed, let's remove it. Bug: 959679 Change-Id: Iff5bbbe4f3745b3d44059e591c137276b141c8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114773Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#752379}
-
Yuki Shiino authored
No prod change. This patch makes changes only on the new bindings generator, which is not yet shipped. Bug: 839389 Change-Id: Ic36d910d20c5d497639979fa106cb315db3519c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114590Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#752378}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/538e358b0d82..c23bd5e4e38d git log 538e358b0d82..c23bd5e4e38d --date=short --first-parent --format='%ad %ae %s' 2020-03-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src e0f773c5..be0a271f (446 commits) Created with: gclient setdep -r src/third_party/skia@c23bd5e4e38d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I98d51af09d120a36aa63d21032a0a146fddacc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114835Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/94f264655d7b..a80b423b2136 git log 94f264655d7b..a80b423b2136 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@a80b423b2136 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I58ba5d9d657976448fcc34e94fc22728f4eb28e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114836Reviewed-by:
-
Joel Hockey authored
Bug: 1057591 Change-Id: Ibae5f698d1c9b27ea72e006ff7b274ace7524578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114476 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#752375}
-
Gyuyoung Kim authored
Remove tests marked as flaky on Mac. Because they don't make flakiness now. Bug: 1060175 Change-Id: I6a4c192421f6f9688375246e91fff1015bcb2ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102990Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#752374}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/221bbbc58554..57af8b538c0c Created with: gclient setdep -r src-internal@57af8b538c0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6047d4a4704ffc6df7e39087fa77c0accac6420c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114832Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic2785caff657e97de8f0fd553f6a3e71d6b7373f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114834Reviewed-by:
-
tby authored
The first step to supporting 'projects' (several events tied together with one key) is to add a section to the structured.xml file for projects, and then link that information together with events. This CL: - Updates the XML model to add a <projects></projects> section. - Updates the codegen for event builder classes to include a kKeyNameHash member. This will be used to do key lookups instead of the event name hash. - Creates a 'namespace' for event names and project names, so that there's no way eventual key lookups will get confused between a project and an event with the same name. - Updates the unit tests to use the correct hashes with these new namespaced event names. - Adds compile-time validation to ensure that any projects referenced by an event actually exist. Specifying a project for an event is optional, if not provided the event receives a key based on its name-hash as-is. If a project is provided for an event, we check that it exists in the <projects> section and otherwise fail to compile. Follow-up CLs will: - Change the key generation logic to use kKeyNameHash instead of kEventNameHash as the identifier for a key. - Add more presubmit validation to double-check all project references are correct, and that the projects section of the XML file doesn't have any problems. - Add new tests to check the kKeyNameHash is set correctly. Bug: 1034842 Change-Id: Id1d2303ee5c7a25df1fac565f6df123bf078c7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112370Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#752371}
-
Robert Ma authored
Bug: 1048470 Change-Id: I3f524b1aa4c129c9ff1abfbe8b2d99903f9005e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113443 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4e36ac84996b..94f264655d7b git log 4e36ac84996b..94f264655d7b --date=short --first-parent --format='%ad %ae %s' 2020-03-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@94f264655d7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3078567e3b587065ba6c1cd7fa90d1af2792702c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114833Reviewed-by:
-
calamity authored
Bug: 1063736 TBR=mcrouse@chromium.org Change-Id: I85974b2938ad575100039fd943c38ebbf55f717a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114632Reviewed-by:
-
Jinsuk Kim authored
mEphemeralTabCoordinatorSupplier.get() (not the supplier itself) can be null, so it should have been guarded with a null check to prevent the reported NPE. This CL fixes it. This reverts commit edafb249. Bug: 1063264 Change-Id: I6aa5dfee9bf822055fc1fd3ee04062de4a459c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113590Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#752367}
-
