GitLab

This reverts commit fab0d10e.

Reason for revert: this patch contains refactoring of client tag based
model type processor. To prevent too many changes in one release it is
better to reland this patch after M83 will be branched.

Original change's description:
> [Sync] Remove setting of cache GUID for old clients.
> 
> This patch removes old logic of setting cache GUID for old clients which
> had no this field. Clients must have set this field after one and a half
> years. Clients that haven't migrated will remove sync metadata (treat as
> cache guid mismatch) and go through download and merge procedure.
> 
> There is one more little change: ConnectIfReady is removed from
> OnPendingDataLoaded because it does nothing and seems to be obsolete.
> 
> Bug: 947044
> Change-Id: I72a441c5ed9bfa2d77a58494aaa2181a1df54d3b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062277
> Commit-Queue: Rushan Suleymanov <rushans@google.com>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#752072}

TBR=mastiz@chromium.org,rushans@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 947044
Change-Id: I3479fa8d35d851d7852225f5fda69e8ccfb022c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127209Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#755292}

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: I666b8ade1cd0ea9043df7978a01eb4537fbbc713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109396
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755291}

Adding adding content edge insets for the skip button in the user
sign-in coordinator.
Updating the skip button title, to always be in upper case, to match
the old implementation (MDCButton seems to always have upper case
title).

Before:
https://drive.google.com/open?id=1a1worTgClUtfs3p3YUwp45vH3-DhCflJ
After:
https://drive.google.com/open?id=19MrZ6a-lP1LBUWonredKKY3zxM4SbsGQ

Bug: 971989
Change-Id: I0eddfc2d855413926e794af1713aedc916a82656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130549
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755290}

We missed a few tests in [1], which were helpfully pointed out in
https://github.com/httpwg/http-extensions/issues/1136.

[1]: https://chromium.googlesource.com/chromium/src.git/+/77df41c01dc3c89253eae90080ff37cf05dfa1a1

Bug: 1037996
Change-Id: I9674bb8cb66b0989bc77c3cc4e34061b0e675e98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129528
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755289}

Add a test for video flow when the negotiation is started by the remote
side.

Bug: 1065836
Change-Id: I56a89f4977516694c1ac8ab50860d940b1171ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127927Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755288}

This converts backref from BackgroundParser to HtmlDocumentParser to use
GCed abstractions for weak references (WeakPersistent).

Bug: 1066694, 522357

Change-Id: I8b25f5d7452d0faf62b6d04eee1f69de2d77b646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130209Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755287}

Per guidance, all the hardcoded colors in this file have new
native color IDs.

Bug: 1056950
Change-Id: I7477466b64250d049969cf3efa635e42fb819d19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111774Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755286}

For https://github.com/whatwg/html/issues/4924

Bug: 1064920
Change-Id: I3837bd2dab635ec0d09d68362a5e4f13b6f44582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121936
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755285}

This CL replaces both PluginParameters::FindStringInNames and the
MapDataParamToSrc function in html_object_element.cc with a dedicated
PluginParameters::FindStringInNames method, based on feedback from
Frédéric and Mason in <https://crrev.com/c/2113394>.

Like the old version, the code proposed here only adds a “src” param
when there’s a “data” param but no “src” param, doing nothing if both
“data” and “src” parameters exist (regardless of mutual order).

Change-Id: I143ea81c5711c6f20cb5e1f6e791bf446ff33b02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121937
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755284}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e157435c1e77..1fff36235504

git log e157435c1e77..1fff36235504 --date=short --first-parent --format='%ad %ae %s'
2020-04-01 cepheus@frii.com Build warning: Fix #2167: Remove nested reuse of 'unreachable'.

Created with:
  gclient setdep -r src/third_party/glslang/src@1fff36235504

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Bug: None
Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com
Change-Id: I2ee56ce72f255e18175a6f883051aabad2a79a7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131505Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755283}

TBR=benmason@chromium.org

Change-Id: I9e67f0a246dc8532942caf6265aa287a0697e100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131361
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755282}

Previously we used a invisible overlay ontop of the guest iframe to hold
two green buttons for navigating forward and backwards in the current
directory. Since then we have moved the navigation ui down into the guest
frame (see cl/304099160) for better behavior, UX and a11y. This Cl
removes this invisible overlay and the two buttons as they are no longer
needed.


Bug: 996088
Change-Id: Ic9307d90f9fb3ecd1f5a5ef30d4e078810625833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131676Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Zain Afzal <zafzal@google.com>
Cr-Commit-Position: refs/heads/master@{#755281}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43d002a2caf2..4f30cf017965

git log 43d002a2caf2..4f30cf017965 --date=short --first-parent --format='%ad %ae %s'
2020-04-01 iannucci@chromium.org [man] Followup: Fix order of depot_tools in PATH in html docs

Created with:
  gclient setdep -r src/third_party/depot_tools@4f30cf017965

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Id70d4baffcf1fd73b8d50e940e90c1c0e5841e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131503Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755280}

Before this patch, invalid view definitions would sometimes crash debug
builds due to a failed DCHECK in show_generic_ui_action.

Bug: b/145043394
Change-Id: Icbd392cb929a0145e72bb1fb3434a0a10df26bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126667
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Marian Fechete <marianfe@google.com>
Cr-Commit-Position: refs/heads/master@{#755279}

No styling yet.

Bug: 1045454
Change-Id: I05155cd76c88cdaf828c62627914dffc0a1a7475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129536Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755278}

In preparation to associate |NGFragmentItem| with
|LayoutObject| in <crrev.com/c/2117558>, it needs to call
this function from outside of |LayoutText|.

Bug: 982194
Change-Id: I14a1892d9494ae43748ab4c0145e68e2a21565e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131175Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755277}

CRWWebViewScrollViewProxy also now returns the default values of the
properties instead of zero values when the underlying scroll view is
absent. Update unit tests to reflect the change.

Change-Id: I3023999c420b1f1bdf47d1133029ca454046e91a
Bug: 1023250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102093
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755276}

This gives us APAC coverage. The current owners are all PST.

Bug: 994911
Change-Id: I0a291b7eae6c4bc0ab60ac48905bd4ab077c0ba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129506
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755275}

This CL removes an unnecessary lazy load WPT expectation file for a test
that no longer exists. The test was renamed in
https://github.com/web-platform-tests/wpt/pull/21918/, but for some
reason the old expectation file stuck around.

R=kinuko@chromium.org, sclittle@chromium.org

Bug: N/A
Change-Id: I9eb79d6eca2bcd5b149cf09bcc889863deecb5d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130406Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755274}

This CL modifies the V4L2 and VAAPI video decode accelerators to handle
the case where the visible rectangle is not (0, 0). This can happen with
some H.264 videos.

The solution is to make sure that when we create the GL image for a
frame, the size should include the visible rectangle plus the
non-visible area to the left and on the top of that rectangle. This way,
the compositor can calculate the UV coordinates correctly so that we can
sample only the visible rectangle.

V4L2VideoDecodeAccelerator is unchanged. The reason is that the
assumption that the visible rectangle starts at (0, 0) will be harder to
remove there. We currently have a check that deals with that case [1].

CL:2041712 + (CL:2122484 + this) make it possible to handle exotic
visible rectangles in most Chrome OS devices (the ones that use
V4L2VideoDecodeAccelerator still need work). [2] contains before/after
tests for this CL for a variety of devices (where before is 822a983f minus
CL:2122484).

[1] https://cs.chromium.org/chromium/src/media/gpu/v4l2/v4l2_video_decode_accelerator.cc?l=2272-2277&rcl=10aaea0473eb652966b359c2b751974b97c5ab13
[2] https://drive.google.com/open?id=1wtX7jDkzvIxCMmsQlIV7zjwaWMrmikUy

Bug: 1062002
Test: H.264 with unusual rect in kevin, kukui, eve, hana, nyan_kitty.
Change-Id: Iac712fbf1b2cea3556b39fc38f5639c91c73b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128707
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755273}

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Ie9d5865ff5be6203eadb71687a37b501cea51540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109576Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755272}

This CL adds a check in
V4L2SliceVideoDecodeAccelerator::CreateOutputBuffers() to ensure that
the visible rectangle is contained within the coded size. Note that
there are analogous checks in VAAPI [1] and V4L2VDA [2].

[1] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/vaapi/vaapi_video_decode_accelerator.cc;l=455-458;drc=43a49df1600f4828a16317757aab3b2eb1478287?originalUrl=https:%2F%2Fcs.chromium.org%2F
[2] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/v4l2/v4l2_video_decode_accelerator.cc;l=2262-2266;drc=008125344bd4814259607c541da5e6a792dc06ff?originalUrl=https:%2F%2Fcs.chromium.org%2F

Bug: 1062002
Test: normal playback still works on kevin and krane.
Change-Id: I5dd13e92822b20bb6dadbbea6b48a4bc06ed7a20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131416
Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755271}

When a node becomes ignored or unignored, the events fired by
AXEventGenerator should match the same events that would have been
fired if the same tree change occurred via real nodes appearing or
disappearing. Otherwise that results in subtle platform bugs.

The specific fixes are:

* Don't fire a STATE_CHANGED event just because the ignored status
  is changing.
* Don't fire CHILDREN_CHANGED on the node that toggled its ignored
  state. If it's being ignored, we shouldn't be firing events on it,
  and if it's being unignored, then it's basically a "new" node to
  the platform.
* Do fire a SUBTREE_CREATED event on the root of a local tree when
  a node is unignored.

These were caught by writing a test to iterate over every possible
change to trees up to a certain size. I'll follow up with that test
once the fix is in.

Bug: 1065144
Change-Id: I08a6be994cce6ffb056ae2a7f830cbbdbd28d75d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125235
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#755270}

[SendTabToSelf] Fix issue where omnibox self-share icon doesn't show when kSendTabToSelfOmniboxSendingAnimation flag is turned on.

Bug: 1007536
Change-Id: Ib17efb7f120f0d4edaa453de66a830be30f644c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130816Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Sophey Dong <sophey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755269}

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Icf65cb3d9e62f1eb51fddce41ff3dcadd6b637ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108403Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755268}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0169ff39..de31800c

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia7b62bf0d1c987a3f06db2dd4af8755f24652a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130431Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755267}

Bug: 1049056
Change-Id: Ic6736fa67155b432a4dca4725be254fc316d037a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105681Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755266}

This CL does the following:
  * Updates tab to use the standard list item, modern_list_item_view
  * Adds a grey circular background for favicon

Change-Id: Ia7222a434c4d0bf585e59bdeebd6ed2184c5a567
Bug: 1042890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107795
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755265}

https://chromium.googlesource.com/angle/angle.git/+log/4b94d7bb4fbe..7d8c2f2e3322

git log 4b94d7bb4fbe..7d8c2f2e3322 --date=short --first-parent --format='%ad %ae %s'
2020-04-01 ynovikov@chromium.org Hide SwiftShader OS Window in dEQP and end2end tests
2020-04-01 ynovikov@chromium.org Skip SwANGLE GLES31 tests which flakily crash with Win 32-bit Subzero
2020-04-01 cclao@google.com Vulkan: Avoid renderpass break for occlusion query

Created with:
  gclient setdep -r src/third_party/angle@7d8c2f2e3322

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I84706dc38dc4638751dc862372462150d1af9e54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131490Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755264}

Originally, we were targeting disabling both impl thread and main thread
latency recoveries for DisableLatencyRecoveryDesktop experiment.
However, current Finch experiment results on canara/dev and beta show
that this config would likely have some regressions and the config with
the least regressions and the most improvements would probably be
EnabledImplDisabledMain, i.e. disabling latency recovery on main thread
only.

Bug: 993895,1060144,1060321,1060519,1060535,1062789
Change-Id: I47d3dc6de0e395ee1cd42f1993a51cdeebdf96c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121465Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755263}

The stream parsing method should only do that - parse the stream.
Workarounds can be applied independently of it, so move them outside of
the method so we can move it around more easily.

BUG=b:149663704
TEST=vdatest passes on Hana.

Change-Id: I9f1305463424d14678f64d9056a54a5f761a39fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130453
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755262}

This CL adds a test that verifies GbmSurfacelessWayland receives and
sends Swap and Presentation callbacks in right order according to local
swap id.

Shortly speaking, this test shows that we have the following behaviour:

Commit[0]
OnSubmission[0]
OnPresentation[0] <- can happen at any time after onsubmission.
SwapCompletionCallback[0]
PresentationCallback[0]
----
Commit[1]
OnRelease[0]
OnSubmission[1]
SwapCompletionCallback[1]
OnPresentation[1] <- can happen at any time after onsubmission.
----
Commit[2]
OnRelease[1]
OnSubmission[2]
OnPresentation[2] <- can happen at any time after onsubmission.
SwapCompletionCallback[2]
----

Test: WaylandSurfaceFactoryTest.GbmSurfacelessWaylandCheckOrderOfCallbacksTest
Bug: 1055755
Change-Id: I769d2d54c9fccb72fc59cb348e6ad743f3ce3062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078013
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755261}

Bug: b:152926504
Change-Id: I424f372f9a606e8a7b02e32649eb043709ab9dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130588Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Auto-Submit: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755260}

This reverts commit 090883ab.

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=1066696

Original change's description:
> CrOS: Get rid of some leftover panel code
> 
> Change-Id: Ib985375a552b06dacf7a647fafcdc87b30afd9e2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108161
> Commit-Queue: Manu Cornet <manucornet@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755125}

TBR=benwells@chromium.org,manucornet@chromium.org

Bug: 1066696
Change-Id: If558a3a10c5390df7a17ef86ea403cd33f023bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131547Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755259}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33eae455663e..d2b26ce6739e


Created with:
  gclient setdep -r src-internal@d2b26ce6739e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Idbe07682ce004b352bcb6de41ef8e1267c99baf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131497Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755258}

AppServiceProxy::LaunchAppWithFiles is added to replace
LaunchService->OpenApplication, and use AppService publishers to forward
and launch an app with files, to keep consistency.

The general function CreateAppLaunchParamsForIntent is moved to
launch_utils, which is used by both ExtensionApps and WebApps.

Add GetAppLaunchSource to get the AppLaunchSource from LaunchSource.

BUG=1061843

Change-Id: If8668f9e8f6ccabf8c7653ad4584f063346f1018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121860
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755257}

The new code generator of IDL dictionary provides a templated setter,
but it doesn't work for initializer lists to construct a member
directly.

This CL adds another setter for rvalues of member types, and makes it
possible to initialize a member through the setters.


Bug: 839389
Change-Id: I89ffd79fff92a58ac722052334afa639d9cf7918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129377
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755256}

Chrome and Firefox aligned on treating `"foo;bar"=baz` as a nameless cookie
with a value of `"foo`, and `"foo\"bar;baz"=qux` as a nameless cookie with
a value of `"foo\"bar`. That is, they both stop parsing the name/value pair
when they hit a `;`. This seems aligned with step 1 of
https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-05#section-5.3,
which defines the `name-value-pair` as everything up to but not including
the first `;`.

Adjusting these tests accordingly, as discussed in
https://github.com/httpwg/http-extensions/issues/1136.

Change-Id: I6930f8e18a8c573b21eaea5614e14c3b957ea0bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128135Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755255}

Bug: 1028409
Change-Id: Id289aa7a7c8c708bb6a530d3ebf6f5be4cb8deb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130266
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755254}

kSystemFeaturesDisableList pref represents a list of system features
(camera, settings, ..etc) to be disabled by an admin policy.
It should disable those features regardless of their underlying
implementation (PWA, Chrome App, Web App,..).

Bug: 1063404
Change-Id: Ica2e523aba36378fb9049820e73dde0afcad6cd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124655Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Cr-Commit-Position: refs/heads/master@{#755253}