- 28 Sep, 2019 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I664957d8f22063580084c44434059b0f513e33f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829905Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700951}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f96bdd640172..8dccfcd7c291 git log f96bdd640172..8dccfcd7c291 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 fmayer@google.com Merge "Re-emit strings if they are used as different types." 2019-09-27 fmayer@google.com Merge "Document exact and start offset." 2019-09-27 lalitm@google.com Merge "trace_processor: add basic cost estimation for db backed tables" Created with: gclient setdep -r src/third_party/perfetto@8dccfcd7c291 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I30b1da5cfa3526e33d83354fb67639c893f4cb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700950}
-
Gyuyoung Kim authored
As the last step to replace all uses of WebLocalizedString with IDS_FOO, this CL replaces remained uses of WebLocalizedString with IDS_FOO. Then, web_localized_string.h is removed finally. Bug: 995644 Change-Id: I3c4b04e31617046b8c239f4eb71a10075a51cf8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827274Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#700949}
-
Sunny Sachanandani authored
Support for direct composition pixel tests which do not use overlays has been added, so use that for the rounded corner tests. Bug: 1007411 Change-Id: Ia757847950e461850efe6f194211fb7815c6da66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829251 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#700948}
-
Theresa authored
This reverts commit 51a51ab0. Reason for revert: Tests already restricted to phones only Original change's description: > Disable BottomToolbarTest causing build bot failures. > > Bug: 1009145, 1009146 > TBR=twellington@chromium.org > > Change-Id: I8211bcc1dcf78da8b9782f421ad962da051c7e9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830328 > Reviewed-by: Ender <ender@google.com> > Commit-Queue: Ender <ender@google.com> > Auto-Submit: Ender <ender@google.com> > Cr-Commit-Position: refs/heads/master@{#700940} TBR=ender@google.com Change-Id: I383a47998ee17efdffbbf8265107a5ee6be6ccff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1009145, 1009146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829773Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#700947}
-
Mitsuru Oshima authored
This CL does the following: * When creating the transform (and invert one) for root window, apply additional rotation based on the panel orientation. * When computing the natural orientation, take the panel orientation into account. This is minimum change to panel orientation. The better, long term solution is to change the display manager to use the logical size, then put details behind lower level (when creating the platform window, and may be viz). We'll look into after this. covered by unittests Bug: 1001369 Test: manual (tested accelerometer rotation, mirroring, arc apps), Change-Id: I430554a0391a7025d081b7a3e8f3f36cab542e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824729 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700946}
-
Sunny Sachanandani authored
Bug: 1009137 Change-Id: Ie3dcfd7dd30e63091573a2c4cbb50ee92a2494d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829250 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL cleans up VRServiceClientRequest that is left in only FakeVRServiceClient class with the conversion to new mojo types. Bug: 955171 Change-Id: I1ce8923b4115d98fc84c69da64cb8b28d7a2f05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828719 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#700944}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a0159c03485b..71c1138d6739 git log a0159c03485b..71c1138d6739 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 tobine@google.com Vulkan: Emulate instanced attrib divisor 2019-09-27 cnorthrop@google.com Vulkan: Support texture base and max levels 2019-09-27 jmadill@chromium.org Rename util/system_utils to util/test_utils. 2019-09-27 jmadill@chromium.org GLES1: Correct 'active' attributes mask. Created with: gclient setdep -r src/third_party/angle@71c1138d6739 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I3740f5d2345e758930f80d021af4d79c15f41206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830205Reviewed-by:
-
Manu Cornet authored
Bug: 982512 Change-Id: I955e4a65c188323bf55b492dc9328334b9c6ea8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817149Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#700942}
-
Miyoung Shin authored
This CL cleans up VRDisplayClientRequest that is left in only FakeVRDisplayImplClient class with the conversion to new mojo types. Bug: 955171 Change-Id: I2bc25b4ed7a2a96feeb193ce70d496b86441d1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828663 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Tomasz Wiszkowski authored
Bug: 1009145, 1009146 TBR=twellington@chromium.org Change-Id: I8211bcc1dcf78da8b9782f421ad962da051c7e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830328Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Auto-Submit: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#700940}
-
Findit authored
This reverts commit 126c42bd. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 700895 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzEyNmM0MmJkMGU0ODE1Zjg5ODVkOTEyNWZhNGVlNzA3YjJjYjM0ZDgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/android-asan/2330 Sample Failed Step: compile Original change's description: > Migrate CdmFactory to new Mojo type > > This CL applies pending_receiver to CreateCdm function > in CdmFactory interface. Additionally, this CL converts > mojo::StrongBindingSet to mojo::UniqueReceiverSet. > > Bug: 955171 > Change-Id: I4bc983708e394800c3a31d3d6a598a39381fa3b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826755 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#700895} Change-Id: Ic41a2dcdf08887757f21f2af9d762b0f2f970618 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829253 Cr-Commit-Position: refs/heads/master@{#700939}
-
Mustafa Emre Acer authored
Changed from "Did you mean example.com?" to "Did you mean?" only. Old screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/94e03c4a69925c4c0ddc5362977fb31a388f513b New screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/41eff454e1cf545932ccb3a3d60f12f90d73eadd Bug: 1006867 Change-Id: Ie6a7222576f5132148e7f496d8067629e55a6456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830169 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#700938}
-
Dan Beam authored
Not launching this (keeping the fade). R=dpapad@chromium.org BUG=none Change-Id: Ida09d9aaecdd8f2e30dcb62292c393e64510d54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828499Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#700937}
-
Dan Beam authored
This was previously the case, at least for server-side opt-in to work. Somewhere along the line this was changed (multiple times) and now server-side opt-in to show "middle-slot" promos doesn't work any more. This is a pain for developers but a bigger pain for less technical folks to show demo promos. Also, OGB and doodle requests already send creds as well. R=mahmadi@chromium.org BUG=1003508 Change-Id: I75869a818f7fcaeba08fa3babbfa30426fb06cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830365Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#700936}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b5c70dab. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I42d68d24ccfaf5f385eff57507f8a38acd803a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829504Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700935}
-
Julie Jeongeun Kim authored
This CL converts TestStructPasser, IndirectTestDriver, Reflector, AssociatedInterfaceVendor, and InterfacePassingTestDriver to new mojo types using PendingRemote, Remote, PendingReceiver, Receiver, PendingAssociatedRemote, AssociatedRemote, PendingAssociatedReceiver, and AssociatedReceiver. Bug: 955171 Change-Id: If07e5ac24047b43dd147887f1dac03f113371b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827113Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts NetBenchmarking to new mojo types using Remote and PendingReceiver. Bug: 955171 Change-Id: Ic7bb297bfd5ade05e33d93d527f2ccb3ffff90eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828718Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#700933}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/69d781151b8a..39058571f71e git log 69d781151b8a..39058571f71e --date=short --no-merges --format='%ad %ae %s' 2019-09-27 ehmaldonado@chromium.org Reland "gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3." Created with: gclient setdep -r src/third_party/depot_tools@39058571f71e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1008202 Change-Id: I8b2c95163d6d26e64cc9f808feec8267636cb64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829926Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts OfflinePageAutoFetcher to new mojo types using Remote, PendingRemote, ReceiverSet, and PendingReceiver. Bug: 955171 Change-Id: I1747f4bd5830a1a077fba86466e372807171f939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828757Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
Bug: 425335 Change-Id: I4556bb5b1ef2e58b6599746de13b37af22adf5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830358 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#700930}
-
Julie Kim authored
This reverts commit d6027891. Reason for revert: Suspect for crbug.com/1008178 Original change's description: > Convert nacl.mojom to new Mojo types > > This CL converts NaClRendererHost and NaClExitControl > to new Mojo types. > > It also updates ProvideExitControl from nacl.mojom > and methods and members which implement it. > > Bug: 955171 > Change-Id: Ie6b875e07796b08818825474e8493e5f48072c3f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810509 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Derek Schuff <dschuff@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Commit-Queue: Julie Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#697852} TBR=dschuff@chromium.org,bbudge@chromium.org,sammc@chromium.org,oksamyt@chromium.org,jkim@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 955171,1008178 Change-Id: I8bdeb5bdd842ffa95ca41fd009717d46c843c3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829619 Commit-Queue: Jeongeun Kim <je_julie.kim@chromium.org> Reviewed-by:
Jeongeun Kim <je_julie.kim@chromium.org> Cr-Commit-Position: refs/heads/master@{#700929}
-
Alex Newcomer authored
Just add the padding when the drag starts. Bug: 1009120 Change-Id: Ia7e2216b3030b6bf2835a591a5fc1312b3eb9a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829554 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#700928}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dca6b5fe9a32..8ab1530cd3cd git log dca6b5fe9a32..8ab1530cd3cd --date=short --no-merges --format='%ad %ae %s' 2019-09-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8ab1530cd3cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: If33a4f52ef9190e3f741811021e0101b28ca737d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830377Reviewed-by:
-
Nick Harper authored
Change-Id: Ia284fcb130320088dc1269c986c2244d5b267536 Bug: 1008898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830363Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#700926}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ed74a5890e50..5f4659d6f7a8 git log ed74a5890e50..5f4659d6f7a8 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 zmo@chromium.org Add SubSysId and Revision as part of a GPU device identification. Created with: gclient setdep -r src/third_party/catapult@5f4659d6f7a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1006960 Change-Id: I18bd2a13b2557d03d4e5dc04e6eda70e4af6bc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830200Reviewed-by:
-
Manu Cornet authored
Change-Id: I02cfd0ad68407b54c681a88505eaf12e84a14753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830357 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#700924}
-
Frank Liberato authored
This reverts commit 1ccd84e0. Reason for revert: Many test failures due to static_cast @ rfhi.973 e.g.,: see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8901140067480428272/+/steps/app_shell_unittests/0/logs/Deterministic_failure:_RootWindowControllerTest.AppWindows__status_CRASH_/0 Original change's description: > Lower priority of processes hosting exclusively ads. > > This change adds a variable to ChildProcessPriorityLauncher to > indicate whether the associated process is only used to run tasks for > ad frames (low priority frames). That variable is then used by the > RenderProcessHost to background the frame in those cases. Notification > happens in the RenderProcessHost via new UpdateFrameWithPriority. > > Note: Identification of ad frames is done as per the AdTagging project. > Frames that have been marked as ads remain ads, and thus the > RenderProcessHost will remain low priority if the frame is navigated > to any other non-ad URL within the same process (same domain). > > Currently this is behind a feature which is off by default. > We will be experimenting with this to determine its impact on > both ads and in the browser as a whole. > > Bug: 979234 > Change-Id: I33d33bc9c1af16b04db211fda25217bd0b2fa85f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645978 > Commit-Queue: Eric Robinson <ericrobinson@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700786} TBR=dcheng@chromium.org,gab@chromium.org,jkarlin@chromium.org,alexmos@chromium.org,pbos@chromium.org,altimin@chromium.org,ericrobinson@chromium.org Change-Id: I5bd5742486245825babecd9eb53a54e0ad4adeac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 979234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830323Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#700923}
-
Guohui Deng authored
CastSystemMemoryPressureEvaluator can accept requests from apps to relax memory pressure thresholds. Normal memory pressure thresholds can be restored when those apps quit. Bug: internal b/141100797 Test: Build and run with eureka-internal/316737. Merge-With: eureka-internal/316737 Change-Id: I6752297ef1ea25e5e28965f00ad6cb04db194a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816729Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#700922}
-
Kyle Milka authored
Bug: 1009124 Change-Id: Idae33b2a04cb9dbf90c03b6dd707311ac981cc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830015 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700921}
-
Pavol Marko authored
The bots are deterministically failing on bots that have libassistent. TBR=antrim@chromium.org Bug: 1005454 Test: none Change-Id: Ic783f307a346bb3a1f2cb8865aef4a9d93234e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829344Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#700920}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b04334392d99..68c8fdf8f27c git log b04334392d99..68c8fdf8f27c --date=short --no-merges --format='%ad %ae %s' 2019-09-27 saklein@chromium.org artifacts_unittest: Cleanup the Bundle test cases. Created with: gclient setdep -r src/third_party/chromite@68c8fdf8f27c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3e241848c1601ca6ef2abf0fc4c34ded8a1c46f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829924Reviewed-by:
-
Lei Zhang authored
On Windows, GetFontData() calls from within sandboxed processes have to use the font_cache mechanism to work correctly. This requires a correctly patched GetFontData(), which broke in M76. https://crbug.com/980577 broke Import Address Table patching for gdi32.dll. This eventually got fixed, but the final fix in https://crrev.com/686696 tried to minimize the amount of patching necessary, and did not get it 100% correct for printing use cases. As a result, sometimes utility processes used for printing did not get patched. This fix by patching utility processes in InitializePDF(). Rearrange the function and update comments along the way. The font_cache mechanism in the Cloud Print service process also broke around the same time due to https://crrev.com/660952, but that just got fixed in https://crrev.com/700317. Bug: 1005867 Change-Id: I0bb691d8208fbbb9bf885767a959119a388def09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826197Reviewed-by:
-
Nate Fischer authored
No change to logic, this just removes redundant imports to clarify this class's dependencies. Bug: 994839 Test: autoninja -C out/Default chrome Change-Id: I579d9f1b3b24135fa729af3ca063eb3023a2d83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828497Reviewed-by:
-
Xiaohui Chen authored
Bug: None Test: flags unittests Change-Id: I38ca60403e7ee50291a6685b1ab1c0e54e07d25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829246Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#700916}
-
Maggie Chen authored
This test collects supports_dx12 and supports_vulkan from GPU info and compares them with the expected values according to the test bot configurations. Bug:977034 Change-Id: I12969114f8af72b0f6e90c37b219ec7d04b85299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828121Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
-
Min Qin authored
The use-after-free is introduced in the following call sequence: 1. DataObjectImpl::GetData() calls DragDownloadFile::Wait(), which starts nested runloop and wait for download to complete. 2. DragDownloadFile::DownloadCompleted() is called, and it calls DataObjectImpl::OnDownloadCompleted(). 3. OnDownloadCompleted() creates a new StoredDataInfo object, that clears up the scoped_refptr of DragDownloadFile in the StoredDataInfo. As a result, DragDownloadFile is deleted. 4. The nested runloop started in DragDownloadFile::Wait() should finish now, but the return statement touches the state_ member variable on the deleted object, This CL breaks the above sequence by checking the weakptr in 4 first before accessing the state_ member variable BUG=968303 Change-Id: Ie1266d344fe102f73451bda9f996e29d9bd00a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827488Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700914}
-
Ben Pastene authored
Blocked on crrev.com/c/1829543 Bug: 1007498 Change-Id: I961224ec3532cd42a9e1b7ad3048eeafc9d1a4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827672Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#700913}
-
Sammie Quon authored
Focus the beginning of the title for overview items, the center for all other tabbable desks items. Test: added test, manual Bug: 436147 Change-Id: Ieb3f78b29ebcae881bcd4f4bf04098d18bdd0bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829558 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#700912}
-
