- 05 Jun, 2020 40 commits
-
-
Carlos IL authored
The pref used for the EnableStricterMixedContentTreatment enterprise policy had its logic accidentally inverted as part of a refactor in crrev.com/c/2151841. This inverts the logic back. Bug: 1091033 Change-Id: Id14e89a304514b923cabecf6c4da982b0f60924d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229241 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#775761}
-
Scott Violet authored
AFAICT this class doesn't depend upon AwContents. BUG=none TEST=none Change-Id: I0a0427986e71e31625d58aaa6b6c6840597d1ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232762 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#775760}
-
Jon Mann authored
All fields are not required in manual proxy settings, and when any optional fields were omitted it was crashing. This adds guards to only serialized the provided fields. Bug: 966270 Fixed: 1091405 Change-Id: I9e5aef0b6181c9e766f4779389437d2677a4fc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232824Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#775759}
-
Gabriel Marin authored
dTLB and iTLB miss cycle events generate a high number of samples at current rates, which cause large spikes in memory use while the profile is in memory. Lower their sampling rates by a factor of 10. Also lower slightly the sampling rate for cache misses. BUG=1088476,b:157930353 Change-Id: I54fa18a6c28c5c600e42db81b2bb86c5d77dbaed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232745Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#775758}
-
Jun Kokatsu authored
This change removes innerHTML usage in various WebUI pages. Bug: 41905 Change-Id: I195b7d0bbf040f0bf1443222da75cb8a1734c16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226302 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#775757}
-
Stephen Chenney authored
These tests have somehow got their baselines wrong, and are failing with and without try job patches. Change-Id: I1496dd6b0158e9b2bdfb959a6d7f09b5f46a215c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232799 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#775756}
-
Anastasia Helfinstein authored
The onscreen keyboard needs to be displayed when Switch Access is enabled, despite the switch device appearing as a keyboard input, to allow the user to enter text. It also adds an externs file for the virtual_keyboard_private API, automatically generated from the existing file extensions/common/api/virtual_keyboard_private.json AX-Relnotes: n/a. Bug: 1091032 Change-Id: Ia2770485b2a2679812105c52761597776fd349a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229437Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#775755}
-
Mohamed Amir Yosef authored
Details are in crbug.com/1090740 screencast pre-Butter: https://screencast.googleplex.com/cast/NTUyNjczMjc1NDkxMTIzMnw3MjBkYjI2Mi05Ng screencast after-Butter: https://screencast.googleplex.com/cast/NTcyNTgzODU4MDM4Mzc0NHwxNjMzOGFmZC0yNw Bug: 1044038,1090740 Change-Id: I202ca32992bea93b04d378203fbe140cdf29126b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228883 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#775754}
-
Yi Gu authored
This reverts commit 5c76e821. Reason for revert: Caused consistent failure on the following bot: https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/67399 Original change's description: > [tools/perf] Add webview_cpu_usage metric > > This change adds a metric that calculates the amount of time WebView > spends on different frequencies. > > Bug: b/157855323 > Change-Id: Ibb1fa61cc2ba1479f2b76ef642dc03c64a9a14b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231452 > Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775713} TBR=oksamyt@chromium.org,khokhlov@google.com Change-Id: I58544fcad9e209ee005a4b6e5981ef780ab4b6d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/157855323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233681Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775753}
-
Pete Williamson authored
Since Context is a base class for Activity, we can replace it with the activity itself, and pass it as an argument whenever the context is needed. We need to do this because we require the activity for some UI operations. This is in preparation for getting the bottom sheet manager, which is only available on the ChromeActivity object. Bug: 1091529 Change-Id: I26791f3a8536eb52fab36c4e01c115fe589e432a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232822Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#775752}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e02ac975..23313e21 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I447dbe79f0c8ae1e8326fb00f6a73532199ca5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233298Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775751}
-
Nate Fischer authored
This adds Android.WebView.Launch.FlagsAtStartup, WebView's analog of Launch.FlagsAtStartup. This should be more-or-less compatible with Chrome histogram, with the caveat the Developer UI is only easily accessible on pre-stable channels whereas chrome://flags is easy to toggle in stable. This extends FlagsAtStartup's enum for the flags already exposed in the WebView Developer UI. Fixed: 1084178 Test: Manually verify WebView's hash mechanism produces correct results Test: Verify new enum hashes with 'AboutFlagsHistogramTest.*' Change-Id: Ifd09a98a8f994c7ef2041725d6e6e1233ef8da1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223332 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#775750}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e75bd40e047..506d4eb7e4ef 2020-06-05 titovartem@webrtc.org Add missing headers to fix chromium roll 2020-06-05 titovartem@webrtc.org Remove old Start method from VideoQualityAnalyzerInjectionHelper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ide8d596b3d5a8df638940ee4c457267c3fba52e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232795Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775749}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/81de8dd83064..bd37d6813a23 2020-06-05 jalyn@microsoft.com Add unit tests for shortcuts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibb168c0f0d464f42f333333a2f0836409d62e8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232792Reviewed-by:
-
Mohamed Amir Yosef authored
All subclasses PasswordBubbleControllerBase return a fixed title (i.e. the title doesn't change during the life time of the controller) except SaveUpdateBubbleController. Therefore, for all other controllers, it's safe to set the title only once. For SaveUpdateBubbleController(), GetTitle() has been made public such that the view can query it when the title changes. Bug: 1044038,1090740 Change-Id: I47799ad4b2b55568bfbae3ef9b884c1b25085d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231038 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Bruce Dawson authored
The Windows 10.0.19041 SDK modifies module.h so that it passes a lambda to InitOnceExecuteOnce. This works poorly because it is not possible to specify the calling convention of a lambda, and the callback requires a specific and non-default calling convention. This code works with VC++ because VC++ lambdas provide all possible calling conventions. It works with 64-bit builds with clang-cl because there is only one calling convention. But it fails on 32-bit builds with clang-cl. This define tells module.h to use the old singleton technique. The Microsoft developer who wrote the new technique has been made aware. See the bug for details. This change is a NOP for packaged toolchain users until we switch the packaged toolchain to the new SDK, but it avoids problems for developers who install the new SDK and build with it. Bug: 1089996 Change-Id: I38d9748b9def3038320ee106676a1f5e60f7349f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232766 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Reviewed-by:
David Bienvenu <davidbienvenu@google.com> Cr-Commit-Position: refs/heads/master@{#775746}
-
Xiyuan Xia authored
Slow bots could even have frame_expected == 1. It seems difficult to get a sane and useful expectation for the collected data. So drop the data sanity check and only verify that some data is collected to make it more stable. Bug: 1082281 Change-Id: I3d089e049c0ef3701a5ac05ae92df3141f37fc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233481Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775745}
-
Tom Anderson authored
When Xlib handles events, it parses them from the wire format with no way to get the wire data. XProto will require the wire data to parse events, so this CL switches the ownership of the event queue from Xlib to XCB. XCB does alter the event, but only by inserting a 4-byte extended sequence number after the first 32 bytes of the event, so it's easy to recover the wire event. Caveats: now Xlib APIs like XNextEvent and XPending don't work, so all usages need to be switched over to use x11::Connection. New functionality like x11::Connection::ReadResponses are added to take over this responsibility. I tried to audit all usages of these functions, but it's possible I may have missed some. Finally, to facilitate a gradual transition from Xlib to XProto, we'll need to temporarily have both XEvents and x11::Events. But the only way to get Xlib to parse an event from the wire format is to use _XEnq, which is part of the private API. This is unfortunate, but it's the only way to get it working AFAIK, and I don't think it's likely the _XEnq interface will change anyway. Followup CLs will add an XProto event parser and start switching things over. BUG=1066670 R=nickdiego,sky CC=msisov Change-Id: I1601a311a3ed73207858a01e0d2fa91ae83f56a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220635Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#775744}
-
danakj authored
The test seems to not be flaky any more with improvements made to the web test harness for site isolation. If wrong.. we can revert and investigate. Local run of 20 runs had 0 failures and TestExpectations claims it was very flaky. R=vmpstr@chromium.org Bug: 891427 Change-Id: Ia1f35a741436042a14f79a0df4e01e4dc76ff829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232747Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#775743}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d27e40cf55af..cf2d770d51db 2020-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie5a248ad71e332c150ae0c57459b1f63b1bcf84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232794Reviewed-by:
-
Henrique Nakashima authored
Bug: 1090033 Change-Id: I98baf2c718ce8fdfcc019891091ae8a59b95a466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227293 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#775741}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/2309f645e509507a1cc8f9845771110fcf986fd9..88024df12147e56b6abd66b743ff441a0aaa09a8 Bug: none Change-Id: I89e991a99d88123bbbcaccd71fdba66383ba64af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231590 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#775740}
-
Reilly Grant authored
This change implements support for persistent permissions in SerialChooserContext and assigns devices a persistent ID based on the Windows "device instance ID" path. This is the path used internally by the Windows Plug-and-Play infrastructure to track the identity of devices. Unlike the Web Bluetooth or WebUSB APIs we cannot only use properties provided by the device because there is not a consistent transport for serial devices. UARTs that are part of the hardware platform especially do not have useful identifiers. The operating system is aware of the overall device tree and can provide something that is stable enough for our purposes. Bug: 908836 Change-Id: I98628278f16f57efa58c0e019687660c33a22c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231981Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#775739}
-
Xiaocheng Hu authored
When two text nodes are shaped together (e.g., <span>foo</span><span>bar</span>), we only use the first node's Font. If they have different Font objects, then the FontFallbackList on the second node becomes stale. This patch makes sure that when calling Font::ShouldSkipDrawing() on the second node, we always use the up-to-date FontFallbackList, so that we don't hit a DCHECK about stale FontFallbackList. Bug: 1050564 Change-Id: I92db1875faebb7311a179d70512b413b43f408aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231905 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#775738}
-
Michael Crouse authored
The LiteVideoHintcache provides information per origin on whether LiteVideos should be triggered and the target parameters for throttling (via a LiteVideoHint). A future change will use the LiteVideoHintCache to make a decision on triggering the LiteVideo optimization. Bug: 1088027 Change-Id: Iec191875f3f8a62a95e0d7203f339491ef0d81fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222882 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#775737}
-
Haiyang Pan authored
* weblayer_bundle_test * weblayer_instrumentation_test_apk Almost all the tests fail with ClassNotFoundException for the class org.chromium.weblayer_private.WebLayerFactoryImpl Bug: 1088013 Change-Id: Ieb1b90dcbbb73547b44f9de11762c10019ce29fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232810 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#775736}
-
Elly Fong-Jones authored
Initializing WidgetDelegate's pointer to its Widget before adding the root view to the Widget allows for using WidgetDelegate::GetWidget() within an AddedToWidget handler, which is sometimes useful (eg the linked bug). Bug: 1038620 Change-Id: I561c959e14351e117189903c0b9ac3f3860a2515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233458 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#775735}
-
Ankit Kumar authored
This CL renames method ScrollIntoView() to ScrollAnnotationIntoView() and changes the input params to take an annotation and a page index instead of a rect. This change was needed as we have another caller for ScrollAnnotationIntoView(). Bug: 1085614 Change-Id: I8cc6725944ab3e870865c3d47942721ea4e1c97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228430Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#775734} -
Stefan Zager authored
Previously, this feature would cause the iframe element in the parent document to be composited. With this change, the iframe need not be composited, but the inner LayoutView will be. Change-Id: I9e3012969c755596acfbe597e18d29776f112b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231546Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#775733}
-
Eric Seckler authored
Events on other tracks or events with explicit timestamps should not emit a thread timestamp, as this timestamp is not reflective of their track or timestamp. Change-Id: I0c38488bbbb8f048151f971f68c5e4070109d14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233018 Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#775732}
-
Jeroen Dhollander authored
This will make debugging bugs easier. To enable these logs you need to enable VLOGS when launching chrome: --enable-logging=stderr --vmodule="assistant*=1" Otherwise the observer will simply not be created. Example output: [<snip>] Assistant: OnInteractionStarted: Text interaction with query 'open Play Store' [<snip>] Assistant: OnTextResponse: 'OK' [<snip>] Assistant: OnHtmlResponse: [<snip>] Assistant: OnSuggestionsResponse: { '👍 ', '👎 ', } [<snip>] Assistant: OnOpenAppResponse: with app 'com.android.vending' [<snip>] Assistant: OnInteractionFinished: with resolution AssistantInteractionResolution::kNormal Bug: b/157144814 Test: manually executed Change-Id: I328cbf4b4372169f161a7309028f2e4911dfef99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225249Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#775731}
-
Jeroen Dhollander authored
Trying to run Widevine CDM on linux-chromeos is not supported and will crash. Previously this was disabled indirectly because the library libc++.so.1 was missing, but now this library will be present if the GN arg |use_cros_on_device_assistant = true| is set. Test: Ensured Widevine is disabled on linux, and enabled when building for device Change-Id: I886f6df806de079169ca1367fc81df7aee169fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232754Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#775730}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c9201dd611b0..977bb0c2f35a 2020-06-05 jophba@chromium.org Fix openscreen.ci linux_arm64_debug bot If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1067809 Tbr: jophba@chromium.org Change-Id: Id8fd47cbcce93908f3ba01f34030dc1c3f6c82f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232786Reviewed-by:
-
Yi Gu authored
This test is flaky on Mac and Linux: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests%20(with%20patch)&tests=PrerenderTest.LinkManagerAddTwiceCancelTwice TBR=ryansturm@chromium.org Bug: 1087735 Change-Id: I2b1235e43423eed9585db89552c4ced769076311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232815Reviewed-by:
-
Andrew Grieve authored
Bug: 1091256 Change-Id: I244afe4d9735901937b39c0d0c554eddaf88eace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230493Reviewed-by:
-
Richard Knoll authored
This adds a new fuzzing target for Advertisement parsing. Note that the parsing is already running in a sandboxed utility process, but it's still good to verify with a fuzzer that raw data handling does not have any unexpected issues. Bug: 1091349 Change-Id: I3b1af84e5144fb2e88531ee6dc342dfc6ddc661b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203381Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775726}
-
Maksim Ivanov authored
Add debug assertions against misuses of PolicyBundle in self-assignment or self-modifying constructions. This CL doesn't bring proper support of such scenarios, but should at least make it more obvious that they're not supported (by documenting it and by catching during automated tests). Bug: none Change-Id: Ie92cf76b4b95b4bf253651eb1544cc884116a511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232859Reviewed-by:
Aya Elsayed <ayaelattar@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#775725}
-
Mason Freed authored
This CL reverses a change made in Chromium 83 that changed all selected text to color:black. Bug: 1074752 Change-Id: Ia705305ff746672454233427d32f0e906f1f0e28 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231461 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#775724}
-
Daniel Libby authored
This is a reland of 7a213fda Deflaked the test by adding a missing RunLoop and having more robust detection in the OutgoingVisualPropertiesIPCWatcher's, similar to the pattern we see in VisualPropertiesPropagation_VisibleViewportSize. Original change description: > Add window segments concept to the content layer > > This change adds a the window segments concept to the > SynchronizeVisualProperties cascade. A display feature splits a view by, > e.g., a fold or a mask - an accessor is added to RenderWidgetHostViewBase > to provide this information during the calculation of visual properties. > When the root render widget is split by the display feature, there are > multiple 'window segments' that web authors will be able to use to split > their view and have a logical separation of content (either through > JavaScript or CSS). > > The root widget window segments are computed by the root > RenderWidgetHostImpl, based on the display feature on the > RenderWidgetHostView. The segments are then propagated to child local > frame roots via RenderFrameProxy and CrossProcessFrameConnector via the > new member on VisualProperties. > > Follow-up changes will finish hooking this information up to Blink in > order to expose it to the web, and also integrate with the platform > specific APIs in order to get the display feature information from the > underlying operating system. > > Explainers: > https://github.com/webscreens/window-segments/blob/master/EXPLAINER.md > https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/Foldables/explainer.md > > i2p: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/_1_ljYsaqrU/qOoHJ7MhAgAJ > https://groups.google.com/a/chromium.org/d/msg/blink-dev/KsPRO3hkOGw/md4jgIAaAgAJ > > Bug: 1039050 1039051 > Change-Id: I6805cda5946bd5379ad6dcd68e092e5d7d9be42d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205123 > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773545} TBR=kinuko@chromium.org Change-Id: Ieb1d01d917fc75c84d01a37c455a7f12b836875f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229668 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#775723}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id9f4a0e3d7fe9d23da04fa07efe2035317519060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232823Reviewed-by:
-
