GitLab

Network Service: Update comments about the callback parameter for NetworkConnectionTracker::GetConnectionType()

This CL updates the comments about the callback parameter for
NetworkConnectionTracker::GetConnectionType() to make it clear
that the |callback| will not be called when connection type
can be retrieved synchronously.

Bug: None
Change-Id: I39eefe13311d9e594dc3f2518fb543014ccf5487
Reviewed-on: https://chromium-review.googlesource.com/c/1336078Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608928}

Bug: 905721
Change-Id: I6218a61cdd74b93257cb44580351c9c666092c0c
Reviewed-on: https://chromium-review.googlesource.com/c/1338964
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608927}

Fix bounds unittest to make sure an offset from fullscreen_surface
will be detected.

Bug: 896710
Test: FullscreenShellSurfaceTest.Bounds
Change-Id: Ia8e3213b5c854f423537a9d0e58455f3d497bea7
Reviewed-on: https://chromium-review.googlesource.com/c/1340863Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#608926}

When a message arrives for a lazy GCM subscription and Chrome isn't in
the foreground, it is persisted on disk until next time Chrome is in the
foreground.

This CL adds two histograms
1- Record the time spent to check if a subscription lazy upon receiving
a GCM message while Chrome is in the background.
2- Record the time spent in reading and replaying persisted
messages when Chrome goes to the foreground.

Bug: 882887
Change-Id: I2ea8e5a5c5242b573e842b56f08d7f1070d48856
Reviewed-on: https://chromium-review.googlesource.com/c/1333656Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608925}

Migrate from using our custom utility and helpers to a similar util
developed and maintained by the EG team. Doc at go/bling-axe

Bug: 856622
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib86b171447eac2961ec2591c8a08764d06b7a953
Reviewed-on: https://chromium-review.googlesource.com/c/1291570
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608924}

This is a reland of 56f3274d

Fix uninitialized |rotation_| in VideoFrameSubmitter.

Original change's description:
> Reland "Fix video quad rect and surface output rect"
>
> This is a reland of 1dfd4418
>
> Original change's description:
> > Fix video quad rect and surface output rect
> >
> > Video surface output rect didn't take rotation into account so when
> > SurfaceAggregator would stretch content to fill bounds, it would end up
> > with the wrong scaling factors (squash in one dimension and expand in
> > another) since the surface quad's bounds (in the embedder) were rotated.
> >
> > To work around this (or by accident), VideoFrameResourceProvider was
> > passing the rotated size as the quad's rect which doesn't make sense
> > intuitively.  This also worked by accident with DirectComposition
> > overlays because of applying another scaling which would fix the aspect
> > ratio again.
> >
> > This change makes it possible to use the |quad_to_target_transform| as
> > is, without having to apply an aspect ratio correcting scaling, and to
> > assume that the quad's rect is in the pre-transform space.
> >
> > Bug: 904035
> > Change-Id: Ia55e44f1f2b49b8d368a97af54f3ce9d90a81234
> > Reviewed-on: https://chromium-review.googlesource.com/c/1334971
> > Reviewed-by: enne <enne@chromium.org>
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Frank Liberato <liberato@chromium.org>
> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#608495}
>
> TBR=enne@chromium.org,kbr@chromium.org,liberato@chromium.org
>
> Bug: 904035
> Change-Id: I278a0ea2c5507f01ea13b31d2090b5f99537c7c3
> Reviewed-on: https://chromium-review.googlesource.com/c/1338418
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608596}

TBR=enne@chromium.org

Bug: 904035
Change-Id: I0f94cd8d71c7c9af60d3d57ac593d2f509e566b0
Reviewed-on: https://chromium-review.googlesource.com/c/1339200Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608923}

This logs image minimum dimension and dimension ratio for all images
loaded when a screen reader is enabled. For more info see go/gchro.

Bug: 905419
Change-Id: I75402356c4cf5e64211e37d928634b7b4754fc2b
Reviewed-on: https://chromium-review.googlesource.com/c/1336001
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608922}

Bug: 874296
Tbr: hbos@chromium.org
Change-Id: I1d76f979d9ff4cfcec0b5d5a34663dc48bb94056
Reviewed-on: https://chromium-review.googlesource.com/c/1289698
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608921}

This is required for correct heap tracing, since RTCQuicStream derives
ContextClient, which is a GC mixin.

Bug: 869498
Change-Id: I124c3a23e4a6e670fc3af195fa43498c3f9a857e
Reviewed-on: https://chromium-review.googlesource.com/c/1340790Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608920}

Tbr: justincohen@chromium.org
No-Try: true
Change-Id: Ie1eaf6202192b20bbbc42ca272f44e2c36921d06
Reviewed-on: https://chromium-review.googlesource.com/c/1340909Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608919}

https://chromium.googlesource.com/infra/luci/client-py.git/+log/f78187ab7712..7f463e66e1c4

$ git log f78187ab7..7f463e66e --date=short --no-merges --format='%ad %ae %s'
2018-11-16 bradhall Only allow repeated dimensions for 'caches'
2018-11-06 tikuta [client] Add --filepath-filter option to choose download files from isolate
2018-11-02 tikuta Revert "[client] Increase worker to download isolate files faster"
2018-11-01 tikuta [client] Increase worker to download isolate files faster
2018-11-01 vadimsh [isolate] Don't unexpectedly raise KeyError if the cache state file was lost.

Created with:
  roll-dep src/tools/swarming_client

Bug: 871453
Change-Id: If2148a3a89af930dcf8ec0a6a5f71684cf974c9b
Reviewed-on: https://chromium-review.googlesource.com/c/1340332
Commit-Queue: Brad Hall <bradhall@google.com>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608918}

When a request is originated from cryptotoken, bypass
the checks of the origin as cryptotoken already
validates the origin.

Change-Id: I9105a8e5881c901322a417845d2976636205a05c
Bug: 902567
Reviewed-on: https://chromium-review.googlesource.com/c/1318064
Commit-Queue: Casey Piper <piperc@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608917}

This patch parameterizes CharacterIteratorTest for LayoutNG to prevent
regressions when LayoutNG is enabled.

Bug: 810579
Change-Id: I160081c9389aed9ee8cb326be6e022d7b6fd375f
Reviewed-on: https://chromium-review.googlesource.com/c/1340271Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608916}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=jennyz@chromium.org

Bug: 903957
Change-Id: Idc81701192f6879ee7e11e2f15e89292d9406f9e
Reviewed-on: https://chromium-review.googlesource.com/c/1338414
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608915}

This reverts commit e2923c55.

Reason for revert: <revert the test expectations since original CL that cause failure is reverted>

Original change's description:
> Disable video-poster.html on Mac bots
>
> TBR=chrishtr@chromium.org
>
> Bug: 905860, 900602
> Change-Id: I5d2a01010b4424ffa4312dfaf01e3ca0af24d182
> Reviewed-on: https://chromium-review.googlesource.com/c/1338570
> Reviewed-by: Ella Ge <eirage@chromium.org>
> Commit-Queue: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608606}

TBR=chrishtr@chromium.org,eirage@chromium.org

Change-Id: Ibb383335e781e792898fdbce2f3eeb70639ad7a3
Bug: 905860, 900602
Reviewed-on: https://chromium-review.googlesource.com/c/1340763Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608914}

Recent commit 13fc02ff broke Windows build because the compiler on
Windows uses different ABIs than those on Linux. The change caused
the UI devtools server failed to be created so no connection could
be made. This CL fixes the calling, and added a unit test to
prevent future brokerage.

BUG=903987

Change-Id: Ie8c0201ab817482b9e7d6eaf305ff0620dff3540
Reviewed-on: https://chromium-review.googlesource.com/c/1336446Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608913}

In r604906 this method was updated to return the device list from cache
if available. By running the passed callback synchronously however this
violated the assumptions of other code, such as the USB device chooser
on Android.

Methods that execute a callback either synchronously or asynchronously
tend to trigger errors in other code and so rather than work around this
change in behavior this patch forces the callback to always be run
asynchronously.

Bug: 904321
Change-Id: Ib6a71bee3c578e42e2812bc762db40ebc2bd6994
Reviewed-on: https://chromium-review.googlesource.com/c/1338941
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#608912}

This allows enabling some disabled tests on Mac.

Bug: none
Change-Id: I3b5bce542d91f40842d9ab68bac60c1b11ef9014
Reviewed-on: https://chromium-review.googlesource.com/c/1338211Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608911}

Using wpt-import in Chromium a4d46091.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: Icdc3a568d2dfd89d63f768213bdc54a67e757982
Reviewed-on: https://chromium-review.googlesource.com/c/1340580
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608910}

https://webrtc.googlesource.com/src.git/+log/645a3afceae0..eee39206a2f6


git log 645a3afceae0..eee39206a2f6 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 sprang@webrtc.org Don't poll EncoderInfo from encoder twice per frame


Created with:
  gclient setdep -r src/third_party/webrtc@eee39206a2f6

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia7a23f4ddc9d9ce993b25ebf093d7b5d10187286
Reviewed-on: https://chromium-review.googlesource.com/c/1340388Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608909}

After a refactor I noticed that this unit test was broken.
_aligned_malloc() does not go through the allocator shims on windows,
but because we used EXPECT_TRUE() we didn't catch this failure. Delete
the _aligned_malloc() test and refactor allocationCheck() to return
failure count so that we can track failures across calls and return the
proper exit code.

Bug: 896019
Change-Id: Ibef719eb14980575cc52796167735f5a0ba177fc
Reviewed-on: https://chromium-review.googlesource.com/c/1339319
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608908}

This reverts this change:
https://chromium-review.googlesource.com/c/chromium/src/+/1323715

And changes the WebGraphicsContext3dProvider implementation to not
depend on Blink internals by using Skia types.

Bug: 902022
Change-Id: I1fbe7a261095f4b30f1365e99005d332d66b7df8
Reviewed-on: https://chromium-review.googlesource.com/c/1323616Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608907}

[ios] Implement TableViewPresentationControllerDelegate for Clear Browsing Data's Presentation Controller

This will allow for a tap on the shield to communicate to the coordinator the view controller
needs to be dismissed. The coordinator can then nil the view controller references.

Video: https://drive.google.com/open?id=1imYHGJI0Dw6mm9LJD2N4atO1WMTaEl23

Bug: 904776
Change-Id: I8c1d9baf9c6c6de28fcd015f645e978f82623d3d
Reviewed-on: https://chromium-review.googlesource.com/c/1336077
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608906}

This CL changes the policy so that the WakeLock is enabled only when an
RTCPeerConnection becomes connected.
Previously the WakeLock was enabled as soon as the RTCPeerConnection was
created. This caused problems for some users, since some sites create
peer connections that are never connected and are only closed when the
peer connection is removed.

Bug: 866200
Change-Id: I47e573f9555960c1a64a0f9834afb9d5dc048a94
Reviewed-on: https://chromium-review.googlesource.com/c/1315210Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608905}

In preparation for enabling an errorprone check that would prohibit
context#getApplicationContext in favour of ContextUtils#getApplicationContext
see https://bugs.chromium.org/p/chromium/issues/detail?id=560466
for context.

Bug: 846456
Change-Id: I13c432d238876cdf8c075e28f74d49e86f8f00a8
Reviewed-on: https://chromium-review.googlesource.com/c/1340376Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#608904}

This prevents an invalid request while in the lock screen, since the OOBE
dialog does not exist.

Bug: 905752
Change-Id: Ie1f820877ea659c9cbfa1e260c2e6a49776e46c9
Reviewed-on: https://chromium-review.googlesource.com/c/1338111Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608903}

/OPT:REF works again with libFuzzer on Windows thanks to a clang patch
and the recent roll.
Reenable it on libFuzzer on Windows builds.

Bug: 884545
Change-Id: Ia90acb6d1655d001c63d4fdc25700541f5ba4515
Reviewed-on: https://chromium-review.googlesource.com/c/1334556Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608902}

This CL removes "Reset Device Credentials" option from the "Protected
Content" settings and related implementation. See bug for the context.

Bug: 904883
Test: Verified that "Reset Device Credential" option is removed.
Change-Id: Id88c045b8c6128396cef41c48f28e7ffddf5a367
Reviewed-on: https://chromium-review.googlesource.com/c/1333903
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608901}

This is a reland of 73564b6c

Fixes Google Chrome Win Build Breakage by modifying
module_blacklist_cache_util_win.cc.

Original change's description:
> [base] Remove base::span's comparison operators
>
> At the recent ISO C++ Committee meeting in San Diego it was decided [1]
> to make std::span SemiRegular and drop its comparison operators [2]. For
> further info see also this blog post [3].
>
> This change updates the base::span implemention appropriately and
> replaces prior usages of the comparison operators with their STL
> algorithm equivalent.
>
> [1] http://redd.it/9vwvbz
> [2] https://wg21.link/p1085
> [3] https://abseil.io/blog/20180531-regular-types#evaluating-span
>
> Bug: 828324
> Change-Id: I94e94450df5f233b6de81da81f309386e0dcf4a7
> Reviewed-on: https://chromium-review.googlesource.com/c/1337628
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
> Reviewed-by: John Rummell <jrummell@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608702}

TBR=rockot@google.com,mek@chromium.org,dcheng@chromium.org,rsleevi@chromium.org,jrummell@chromium.org,haraken@chromium.org,hongjunchoi@chromium.org

Bug: 828324
Change-Id: I9c28c2a000dc0994143a7565632f3e7489c702ba
Reviewed-on: https://chromium-review.googlesource.com/c/1340219Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608900}

Call ScopedTaskEnvironment::SetLifetimeObserver(nullptr) to ensure that
the next test after ScopedTaskEnvironmentTest.LifetimeObserver doesn't
crash.

R=gab@chromium.org
BUG=905812

Change-Id: Ifbdcfa55695fbd5641ffccb8d3e60a80d1afb3ca
Reviewed-on: https://chromium-review.googlesource.com/c/1338090
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608899}

Moves IO thread-specific initialization into WebSubThread.

BUG=826465

Change-Id: I5527dafdf75c29fbc8478f7500c20a96410ad008
Reviewed-on: https://chromium-review.googlesource.com/c/1335961Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608898}

This is a reland of 20b9700c

Original change's description:
> Add Fast Transition as enterprise policy
>
> Add support for an enterprise policy that lets the admin
> turn Fast Transition on or off.
>
> BUG=791202
> CQ-DEPEND=1291930
> TEST=(1) unit-tests (2) Added network policy to YAPS
> server, enabled Fast Transition and checked that the
> values propagate to client
>
> Change-Id: I4092ffb33169219515d235a25b1153e197a5af2d
> Reviewed-on: https://chromium-review.googlesource.com/c/1297644
> Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607824}

Bug: 791202
Change-Id: Id89eec841667ceb821e52eb53a37f2f9641bcbaa
Reviewed-on: https://chromium-review.googlesource.com/c/1334839Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608897}

Bug: 906126
Change-Id: I4a6cce3f2b535fe24e44dd4569cb005c6edc2bc8
Reviewed-on: https://chromium-review.googlesource.com/c/1340481Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608896}

This crash was introduced due to the changes for URL backstack introduced
in https://chromium-review.googlesource.com/c/chromium/src/+/1309428

Bug: 903716
Change-Id: Idfb7c09fde27ed546628b875f6fa2ac68b6f1cd7
Reviewed-on: https://chromium-review.googlesource.com/c/1338484
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608895}

https://skia.googlesource.com/skia.git/+log/5bf5a64fe7a9..07ee63d076e5


git log 5bf5a64fe7a9..07ee63d076e5 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 csmartdalton@google.com sksl: Add builtinFMASupport to StandaloneShaderCaps
2018-11-16 brianosman@google.com Add SkPMColor4fFitsInBytes
2018-11-16 mtklein@google.com remove _DXDY_ sample procs
2018-11-16 jvanverth@google.com Remove use of integers for atlas indexing
2018-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 000df8b42041..b16f9897a868 (4 commits)
2018-11-16 halcanary@google.com SkShaper: better error info.
2018-11-16 mtklein@google.com I think the _DXDY_ code may all be dead.
2018-11-16 michaelludwig@google.com Update threshold for degenerate gradients
2018-11-16 brianosman@google.com Use GrVertexWriter for GrRegionOp, add writeQuad()
2018-11-16 brianosman@google.com Do CCPR hairline coverage scaling in floats, rather than bytes
2018-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 44994a88c9cc..000df8b42041 (1 commits)
2018-11-16 herb@google.com Fun with flags
2018-11-16 csmartdalton@google.com sksl: Polyfill fma() when not present in GLSL
2018-11-16 scroggo@google.com Add safety net logging for issue 118143775


Created with:
  gclient setdep -r src/third_party/skia@07ee63d076e5

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:905607,chromium:b/118143775
TBR=rmistry@chromium.org

Change-Id: I8f2c6d04a79abcc003ca4c5c9c02fb4e71c05441
Reviewed-on: https://chromium-review.googlesource.com/c/1340386Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608894}

Bug: 894200, 891059
Change-Id: Ic3ad1be6bf9ce21cd672266d42ef4259fd47cd9d
Reviewed-on: https://chromium-review.googlesource.com/c/1340568Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608893}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=timvolodine@chromium.org

Bug: 903957
Change-Id: Icaf8fe70611a4e937b69bca1c2a670a9a45ae5ac
Reviewed-on: https://chromium-review.googlesource.com/c/1338129Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608892}

Original CL description:
This change makes it possible to reprioritize socket pool ConnectJobs
to match their corresponding Requests. For TransportConnectJobs that are
reprioritized while undergoing host resolution, the corresponding host
resolver request is also reprioritized to match the connect job.

Reland fixes a bug in the original CL causing a failing DCHECK due to
trying to reprioritize jobs with RespectLimits::DISABLED, which
should not be reprioritized as they should always be MAXIMUM_PRIORITY.

Bug: 166689
Change-Id: If845c941b02a9a1c01c267ee463fda7205bd928c
Reviewed-on: https://chromium-review.googlesource.com/c/1333135
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608891}

Aside from adding the sanity check, this also hooks up loadTimeData in
pdf_viewer.js, and demonstrates how to plumb a feature flag from the
browser into pdf_viewer.js.

BUG=61248

Change-Id: I48850afaac17854af785d04a8ca93078ebd8532f
Reviewed-on: https://chromium-review.googlesource.com/c/1339244Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608890}

Change-Id: I9da271f43547686c9e141b2875e0b796d7adabae
Reviewed-on: https://chromium-review.googlesource.com/c/1340643Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608889}