- 21 Aug, 2018 40 commits
-
-
Rune Lillesveen authored
The test is not relying on fonts loading, but start using dummy urls instead. Bug: 875805 Change-Id: I4821e9e74fc9383d77ec2afd57652103e72f35c2 Reviewed-on: https://chromium-review.googlesource.com/1182807Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#584683}
-
Trent Apted authored
r584330 updated all annotations on ObserverList declarations to be ::Unchecked, but a few new declarations appeared since that. They need to be ::Unchecked as well in order for https://crrev.com/c/1053338 to land cleanly. TBR=gab@chromium.org Bug: 842987 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1c6d7ae8e9668438afa8184fd0c3884a21e9732d Reviewed-on: https://chromium-review.googlesource.com/1182712 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#584682}
-
Michael Giuffrida authored
When the SafeSitesFilterBehavior policy is enabled, filter top-level HTTP[S] navigations using Google's SafeSearch API (porn classifier). The SafeSites check is skipped if the URL is blacklisted or whitelisted by policy. This check is added to the existing PolicyBlacklistNavigationThrottle instead of creating a standalone navigation throttle because it depends on the blacklist/whitelist check that's already there, and conceptually serves a similar purpose (determining if a URL should be blocked by policy). Bug: 819405 Change-Id: Ica243fdbf44b06a2fc4148fb68f47a11d9b79a6b Reviewed-on: https://chromium-review.googlesource.com/1119102 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584681}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5089280a9cbc663298a85de1223a1bc0f6dfc1d9 Reviewed-on: https://chromium-review.googlesource.com/1182964 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584680}
-
Ryan Tseng authored
Bug: 875708 Change-Id: I057668ca809bcd9644c778690997a2ceed11ae8b Reviewed-on: https://chromium-review.googlesource.com/1183021Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#584679}
-
Michael Lippautz authored
The backing table should only be registered when processing the HashTable as otherwise the backing might be black but its fields might not be processed if it gets dropped till the final atomic pause. The registration will still be early enough to announce the slot to compaction. Bug: chromium:875555 Change-Id: Iad97df11f79d95524839fd0377585bc68b2442ea Reviewed-on: https://chromium-review.googlesource.com/1181130Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#584678}
-
Raymes Khoury authored
This flag has been enabled by default for several milestones. Change-Id: I54ee103f18d6f377cdf45de58dcee812ddde303b Reviewed-on: https://chromium-review.googlesource.com/1182905Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#584677}
-
Darren Shen authored
The design specs says the virtual keyboard is at +2 elevation instead of +24. Bug: 873327 Change-Id: I2895f149f693c8d4be4e35dc56c9d684cc07bf41 Reviewed-on: https://chromium-review.googlesource.com/1183004Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#584676}
-
Gemene Narcis authored
The code is executed once per profile. As it was introduced 5 months ago, and acording to metric reported users don't need it anymore. It's a manual revert of https://crrev.com/c/951607/ Bug: 817754 Change-Id: Iab2c5dfdb9effb4e2347f174faebeb67f9dd6a3e Reviewed-on: https://chromium-review.googlesource.com/1179151Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#584675}
-
Lei Zhang authored
Change-Id: I1c3ad2db29d6f5446a045990036f467054d735d8 Reviewed-on: https://chromium-review.googlesource.com/1179307 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584674}
-
Joshua Bell authored
The blink.mojom.LockManager registration is exposed via execution context parameterized binding (frames, dedicated/share/service workers); it does not need to be exposed at the service manager (renderer proces host) level. Change-Id: Idc033a65a9d5646310434d52756333daba68d23e Reviewed-on: https://chromium-review.googlesource.com/1181923 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 24c207be. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23111 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8bcc04662e86ef53394bee5152738cc632affec4 Reviewed-on: https://chromium-review.googlesource.com/1182952 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584672}
-
Anand K. Mistry authored
BUG=None Change-Id: I897361040b6af091de7f3f8a5b790e08f81d65bd Reviewed-on: https://chromium-review.googlesource.com/1182719 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584671}
-
Sam McNally authored
Currently drive-internals displays a path specific to the current implementation as the Drive mount path. When running with DriveFS enabled, this path is incorrect. Obtain the path from DriveIntegrationService instead so the correct path is displayed. Bug: 829703 Change-Id: Ie0f3a36c742c9476ce18c0cbede83d15ab670c53 Reviewed-on: https://chromium-review.googlesource.com/1182901 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Kevin Marshall authored
* Fixed webrunner_unittests (tests were not being exercised, so the test code drifted from the impl) * Added webrunner_unittests, webrunner_browsertests to Fuchsia test bot list. Bug: 871594 Change-Id: I3f86f2f1d76534c51236a3dea43dc898d996b121 Reviewed-on: https://chromium-review.googlesource.com/1174868 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584669}
-
Lei Zhang authored
- Avoid reading files on the UI thread. - Switch to new base::Value API. Change-Id: I5a4fae99d3624103538b62486552ecdb059e6ce9 Reviewed-on: https://chromium-review.googlesource.com/1179064 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Yuki Yamada authored
Current implementation of DOMArrayBuffer::Wrap() returns a object that is created in current realm because v8::ArrayBuffer::New() does not receive |creation_context|, the relevant realm. (current realm is used here: https://cs.chromium.org/chromium/src/v8/src/heap/factory.cc?sq=package:chromium&g=0&l=3056) We have to create event in the relevant realm of event's target in accord with DOM standard: https://dom.spec.whatwg.org/#firing-events This CL set appropriate realm on creating wrapper. A test for this already exists: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/websockets/multi-globals/message-received.html Change-Id: Ie225d9e45a0e78fcdbb7d86d04674531f9c745ac Reviewed-on: https://chromium-review.googlesource.com/1182913 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#584667}
-
Ryan Tseng authored
For the transition from 8 core to 16 core. Bug: 875708 Change-Id: I73ca7e9062974821a255ecc3147188f139d19cd9 Reviewed-on: https://chromium-review.googlesource.com/1182954 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
-
Sam McNally authored
It isn't supported by DriveFS and doesn't make much sense even with the current Drive sync implementation. Bug: 844292 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0237ea4bb903604672f5e2a7e07ffe3260db7a9a Reviewed-on: https://chromium-review.googlesource.com/1182906Reviewed-by:
-
Erik Luo authored
Before, the 'Copy as cURL' option would escape all characters outside of a limited range [\x20-\x7e] with ANSI-C `\u` or `\x`. This caused problems because `\x` does not properly encode Unicode chars outside of the range (e.g. latin, CJK, emoji). Instead, this CL treats control codes (C0, C1 sets) as the only characters that need `\u` escaping, while everything else (except single quote, backslash, newline) is not escaped. Bug: 578054 Change-Id: I47301014ebe394bd02eb9f6c60108f4962f331ca Reviewed-on: https://chromium-review.googlesource.com/1155924Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#584664}
-
Erik Luo authored
When opening the breakpoint editor and clicking on already-selected text, focus can move from CodeMirror's scroller to its textarea. This internal blur should not trigger a commit. Screenshot: https://imgur.com/a/kzyWLYj Bug: none Change-Id: I096692aaf5fe38104e80c8628dee28d9ba21d2c5 Reviewed-on: https://chromium-review.googlesource.com/1181651Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#584663}
-
Jinsuk Kim authored
This CL addresses the bug that scrolls to the bottom of the page opened by anchor in a new tab. The size of the contents should have been set earlier at |initializeTab|. This change comes with a risk of reintroducing the regression fixed by https://crrev.com/c/795479 since it's basically reverting what the CL did. As of this change, the reported regression is not reproducible, and it's not easy to find any other sites that exhibit the issue. The plan is to land this CL and react timely to any problems it might cause. Bug: 850868 Change-Id: Ie4fdbaa012f72a2b667b7b27c177fcc6b7a21032 Reviewed-on: https://chromium-review.googlesource.com/1180637Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#584662}
-
Xianzhu Wang authored
- fast/multicol/composited-layer-nested.html According to discussions and data in crbug.com/854192, we should not fragment a composited/squashed layer as a whole no matter if there are nested composited layers under it (as current BGPT code does). - fast/multicol/vertical-rl/composited-relpos-overlapping-will-change.html The new result looks more correct (the composited layer is placed in the second column where the layer's border box rect starts). Also updated the test to show more clearly. Bug: 854192 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie1ad00980034c6c991fa82d2ee4f675010292cdb Reviewed-on: https://chromium-review.googlesource.com/1180405 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584661}
-
Jinsuk Kim authored
Moved new test-only methods added to WebContents/RenderFrameHost in https://crrev.com/c/1163831 to targets content*test_support. Bug: 862153, 875742 Change-Id: Id9be5f53b45e2b28861a35401bba71020cf5fc0f Reviewed-on: https://chromium-review.googlesource.com/1180824Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#584660}
-
Yoshifumi Inoue authored
This patch disables NoBackgroundTasksTest.FirstNonEmptyPaintWithoutBackgroundTasks since this test attempt to create process with too long command line. TBR=fdoray@chromium.org Bug: 876184 Change-Id: I593569e46dc8bb127aacafba22cb05be9df506f3 Reviewed-on: https://chromium-review.googlesource.com/1182910Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584659}
-
Jun Choi authored
In current implementation, we auto-select transport type to previously used transport type. Disable this feature for MakeCredential request. Bug: 868212 Change-Id: I4b0c3e642df1eaffa8f76956223a6a7f9b66a21b Reviewed-on: https://chromium-review.googlesource.com/1182101 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584658}
-
Alex Kalugin authored
Bind VerifyChecksum operation callback to weak_factory_on_io_. Currently VerifyChecksum callback is not dropped when V4Database instance is destroyed which leads to possible crashes in V4LocalDatabaseManager with the following stack safe_browsing::V4Database::GetStoreStateMap() (this is null here) safe_browsing::V4LocalDatabaseManager::GetStoreStateMap() safe_browsing::V4LocalDatabaseManager::DatabaseReadyForUpdates(...) ... This can happen if V4LocalDatabaseManager is disabled and reenabled before DatabaseReadyForUpdates for the first V4Database instance callback is called. Steps to reproduce the crash: - Install Chrome - Run it in V4 Only mode - Go to chrome://settings and open advanced settings - click on "Protect you and your device from dangerous sites" toggle - Press and hold spacebar in order to toggle SB enabled/disabled states Change-Id: I75564e1a6d56184f5e49e901520ce16eeb91ab6c Reviewed-on: https://chromium-review.googlesource.com/1180884 Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#584657}
-
Byoungkown authored
As following the spec[1] at XRView, The eye has changed to use XREye instead of VREye. And it is nullable. [1] : https://immersive-web.github.io/webxr/#xrview-interface Bug: None Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib8e698f714ea107bc0ac9a275a6466d419a067e3 Reviewed-on: https://chromium-review.googlesource.com/1180629Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#584656}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd0c341bd251..85f5e7ccd1af git log dd0c341bd251..85f5e7ccd1af --date=short --no-merges --format='%ad %ae %s' 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 rrangel@chromium.org my_activity: Add review.coreboot.org as a source 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@85f5e7ccd1af The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=agable@chromium.org Change-Id: I62be0f7f911f1501375bacc6ea87781fc06996be Reviewed-on: https://chromium-review.googlesource.com/1182642Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584655}
-
Siddhartha authored
Add a config param to limit the total trace buffer size BUG=859260 Change-Id: Ic15e5aa0d381273eadcdad270d955441386cd288 Reviewed-on: https://chromium-review.googlesource.com/1182510 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#584654}
-
Yuzu Saijo authored
This CL implements CrashMemoryMetricsReporter on the renderer side and CrashMemoryMetricsManager on the browser side in order to manage the shared memory between the two process, which contains OOM related information. Shared memory now reports whether the crash was because of virtual address space OOM. TBR=sky@chromium.org Bug: 854073 Change-Id: Iebf12b83ac66417e71cba2ba647b080aed3e9da9 Reviewed-on: https://chromium-review.googlesource.com/1139845Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
Victor Costan authored
This CL introduces SqlTempStoreMemory flag, which is intended to be managed via Finch. When set, the flag causes sql::Database to run a PRAGMA temp_store=MEMORY [1] query on every opened database. This approach is intended to approximate the effect of building SQLite with the SQLITE_TEMP_STORE=3 [2] macro, to measure the memory consumption impact. Ideally, we'd test the macro directly, but //sql is a core component of Chrome, so we can't load different versions of it based on Finch. [1] https://www.sqlite.org/pragma.html#pragma_temp_store [2] https://www.sqlite.org/compile.html#temp_store Bug: 875538 Change-Id: I537d90d763be1100503ed4bd2ada2ee19eb090bb Reviewed-on: https://chromium-review.googlesource.com/1180530Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584652}
-
JunHo Seo authored
Convert list: snav-1st-stop snav-aligned-not-aligned snav-clipped-overflowed-content snav-container-only-white-space snav-container-white-space snav-date Bug: 803086 Change-Id: Id5723780293df17fd0c0020914630d2f1ea7d198 Reviewed-on: https://chromium-review.googlesource.com/1177527Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#584651}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I116723e6f80fcfd9d665ad7f80d0cd1636dd2019 Reviewed-on: https://chromium-review.googlesource.com/1182876Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584650}
-
Yoshifumi Inoue authored
This reverts commit be7c1259. Reason for revert: Can't find gold. /bin/sh: 1: ../../build/toolchain/cros/build/cros_cache/chrome-sdk/tarballs/daisy+10974.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.27.0-gold: not found Original change's description: > Relativize cros compiler path > > Combined with https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1180801 > this patch removes absolute path from command line for simple chrome build. > > This is a part of effort for build cache sharing when using goma by > removing absolute path from compile result. > > Bug: chromium:846610 > Change-Id: Ia40a7194b4e485f26424f27ebfc210355e352cc0 > Reviewed-on: https://chromium-review.googlesource.com/1180826 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584648} TBR=vapier@chromium.org,dpranke@chromium.org,tikuta@chromium.org,manojgupta@chromium.org Change-Id: I93891636a39e5b72f019f262c297c4f07239d0e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:846610 Reviewed-on: https://chromium-review.googlesource.com/1182882Reviewed-by:
-
Takuto Ikuta authored
Combined with https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1180801 this patch removes absolute path from command line for simple chrome build. This is a part of effort for build cache sharing when using goma by removing absolute path from compile result. Bug: chromium:846610 Change-Id: Ia40a7194b4e485f26424f27ebfc210355e352cc0 Reviewed-on: https://chromium-review.googlesource.com/1180826Reviewed-by:
-
Justin Cohen authored
Bug: 869392 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id49d6eb03cecf76d8ed7ec476f300b6b4cb5de23 Reviewed-on: https://chromium-review.googlesource.com/1180550Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584647}
-
Tom Anderson authored
The GTK theme draws a different top area depending on if Chrome or the window manager draws the frame [1]. On themes like KDE's Breeze, these colors can be very different. This can cause colors calculated from the frame color (like the inactive tab text color) to be calculated incorrectly. This CL caches the system and Chrome frame colors in GtkUi and gets the appropriate one depending on the user's preferences. Also fix the GTK2 build. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/native_theme_gtk3.cc?rcl=ae5bd514aea0486e53a743ddc2870ac3029eb9b3&l=654 BUG=875844 R=pkasting Change-Id: Ia3e8065de1f843618277b6c562bb9fb54671691d Reviewed-on: https://chromium-review.googlesource.com/1182508 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#584646}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f2bae22e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23106 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I835e44bffee560c96453d83cf02d2c7c9ae379d4 Reviewed-on: https://chromium-review.googlesource.com/1182607 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Yuzu Saijo authored
This CL fixes a bug in test_suites.pyl and introduces sharding to memory.leak_detection benchmark. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1180788 TBR=nednguyen@chromium.org,dpranke@chromium.org Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ie1a3be0b3b47a9feb57d77a779a6df8cf8257a3c Reviewed-on: https://chromium-review.googlesource.com/1182714Reviewed-by:
-
