GitLab

We want to differentiate between first show attempt/result and
subsequent re-show attempts/results in UMA histograms for proactive
suggestions so that we can measure engagement of users the first time
they are presented w/ content in comparison to re-presentations of the
same content.

To accomplish this we add:
- Assistant.ProactiveSuggestions.FirstShowAttempt
- Assistant.ProactiveSuggestions.FirstShowAttempt.<Prefix>.ByCategory
- Assistant.ProactiveSuggestions.FirstShowResult
- Assistant.ProactiveSuggestions.FirstShowResult.<Prefix>.ByCategory
- Assistant.ProactiveSuggestions.ReshowAttempt
- Assistant.ProactiveSuggestions.ReshowAttempt.<Prefix>.ByCategory
- Assistant.ProactiveSuggestions.ReshowResult
- Assistant.ProactiveSuggestions.ReshowResult.<Prefix>.ByCategory

We mark the following pre-existing histograms as obsolete:
- Assistant.ProactiveSuggestions.ShowAttempt
- Assistant.ProactiveSuggestions.ShowAttempt.<Suffix>
- Assistant.ProactiveSuggestions.ShowResult
- Assistant.ProactiveSuggestions.ShowResult.<Suffix>

Bug: b:144875278
Change-Id: I8af637b43bb485d8ed1a7356311dd25a9aabb7e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951549
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722688}

This CL converts MediaDrmStorageRequest to PendingReceiver<MediaDrmStorage>.

Bug: 955171
Change-Id: Ia9b255c0a0719ad9a3a5aa0fef04dbd4a9d970e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954992Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#722687}

This CL converts P2PSocketManagerRequest to
PendingReceiver<P2PSocketManager> as well as renames
BindRequest to BindReceiver.

Bug: 955171
Change-Id: I11f552f9615fad2bfa0f04e5bb69394a3126ad7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954818Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#722686}

Adds the allowWithoutSanitization property to clipboard permissions, to support
raw clipboard access. This is exposed to the web as changing the permission
descriptor, so that navigator.permission, and later navigator.clipboard, can
expose allowWithoutSanitization. This change is web compatible, as no existing
web API usage is affected.

Blink: Adds the allowWithoutSanitization concept to blink-exposed classes,
such as ClipboardPromise, PermissionName, and permission.mojom. This matches
the direction proposed for specifications in the explainer[1].

Browser: Renames the existing CLIPBOARD_READ to CLIPBOARD_READ_WRITE, and
CLIPBOARD_WRITE to CLIPBOARD_SANITIZED_WRITE. This affects browser-side classes,
such as PermissionType and ContentSettings. This matches the direction proposed
for Chrome's permission model.

Translation: Translates between blink and browser permission models, where:
(1) CLIPBOARD_READ_WRITE = clipboard-write with allowWithoutSanitization:true,
                       and clipboard-read with any allowWithoutSanitization value.
(2) CLIPBOARD_SANITIZED_WRITE = clipboard-write with allowWithoutSanitization:false.

UMA: Renames histogram and enum values accordingly. This does mean new graphs
will be generated to track existing forms of clipboard permissions usage.

Test infrastructure: PermissionsHelper and TestRunner will have a visible change
in API, to use "clipboard-read-write" and "clipboard-sanitized-write".

Public-facing APIs: ChromeDriver, navigator.permission.query, and in the future
navigator.clipboard.{read,write} may now be able to access the new
allowWithoutSanitization property via updates to the permission descriptor.
Existing API use is not affected.

Here's a (slightly messy) diagram of Permissions classes and concepts relevant to this review: https://drive.google.com/file/d/1hjqE9oyCoI3cBxDDH7H1-Cl7xDqk4LJ5/view?usp=sharing

These permissions were first implemented through CLs in https://crbug.com/677564

Design Doc Permission Section: https://docs.google.com/document/d/1XDOtTv8DtwTi4GaszwRFIJCOuzAEA4g9Tk0HrasQAdE/edit#heading=h.121tek4wy4sh

[1]: https://github.com/WICG/raw-clipboard-access/blob/master/explainer.md

Bug: 897289
Change-Id: Ia5d20a1c602aff813c07ae37634914033b6c4418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895749
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722685}

This is a simple check to allow us to be able to easily run a limit
study to understand the effectiveness of previews. By limit study, we
mean showing Previews on all page loads for a subset of the population.
The limit study will still utilize the CanApplyPreview logic (e.g.,
hints and blacklists).

Bug: 1031593
Change-Id: I4fd6aec779447615a0660f3d22167091441d4e12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954710
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722684}

Also fixes throwing a raw Exception when led errors. This also got
lost in bad rebases earlier I think.

Change-Id: Icb02f538c70dd1425b4d6f8e825022813c8fecf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881813
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722683}

Clicking on a link that would open a new tab should just navigate to
that website when the link is clicked in a preview tab.

The request for urls to be opened in a new tab goes through
WebContentsDelegate |shouldCreateWebContents| -> |webContentsCreated|
-> |addNewContents|. This CL handles it by having
|shouldCreateWebContents| return false so that no new WebContents
object is created. The passed URL is loaded into the preview
tab instead.

Bug: 1014777
Change-Id: If4fd76f563427aaae230af4e0519c2c388791fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954990Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722682}

New CDP event to support localization of DevTools Security panel,
Security.visibleSecurityStateChanged, is checked in [1]. The handler for
this new event is currently behind an experiment [2]. To enable the new
hadnler in DevTools frontend, tests need to be fixed. This CL disables
security tests for now and later CLs will fix tests and re-enable these.

[1]: crrev.com/c/1646792
[2]: crrev.com/c/1880356

Bug: 946860
Change-Id: I2138f03e81b6aaf1d4f8ec96fa94eb52f40b9a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947944
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#722681}

Unfortunately, some child classes (Viewer Reference Spaces) have good,
valid reasons to override getPose (to guarantee that they can return
identity and not just near-identity which may have some interesting
rounding errors).  However, most child classes do not need to override
getPose. By forcing these children to implement MojoFromSpace or
SpaceFromMojo, their implementations of getPose can be simplified to
the parent implementation.

There were also some subtle bugs that lead to XRReferenceSpace's
SpaceFromMojo != Inverse(MojoFromSpace). Mainly this was that
MojoFromSpace post-multiplied the origin offset, which SpaceFromMojo did
not pre-multiply; but the pose for viewer space's was also wrong. This
was further complicated by the fact that one method required
mojo_from_viewer while the other didn't. Rather than plumb this value
through for all cases when really only the viewer space needed it, a
method was added to XRSession to get this transform when needed. This
allowed removing the SetMojoFromViewer method on XRFrame.

The DefaultViewerPose and SpaceFromViewerWithDefaultAndOffset methods
also had very limited and specific uses. By simplifying the way that
mojo_from_viewer was handled, DefaultViewerPose was able to be removed.
With this removed, SpaceFromViewerWithDefaultAndOffset is now basically
just a helper method to return InverseOriginOffset * SpaceFromViewer.

Unfortunately, different spaces have one of SpaceFromMojo/MojoFromSpace
that they can return more efficiently. It didn't seem worthwhile to
remove one or the other for the sake of simplicity when that could
cause some spaces to have a double inverse performed on the transform.
A helper TryInvert method was added to help simplify the "alternative"
method.

Bug: 1030413
Change-Id: Id4b047d0514ce8796412318585465d1a4e80fb13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954163Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722680}

Also using this public InkDrop interface from ConfigureBubbleMenuItem
to remove the hover animations.

Bug: 1015634
Change-Id: Iadc2256625c9b8aaca6ec283f96a95e8f06ae265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954938Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722679}

In the Autofill popup bubble, shows a "Use a virtual card number"
option if all the requirements are met.

Clicking on this new button is not handled yet. Will do that in next CL.

Attached screenshot in bug comment#4

Bug: 1020740
Change-Id: Ib0c85d7bc2233ea7c05b624ad9bdea0ec2eb2d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947955
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#722678}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ia0520570285882ac5f8dbabc5ebd7321af074d99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956128Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#722677}

Also adding JS type checking in the process.

Bug: 1028829
Change-Id: Ie5efb57026fdc544dfc969c254383e2658c5fd72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956045
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722676}

https://swiftshader.googlesource.com/SwiftShader.git/+log/629b743dd803..c166eb7c0f9a

git log 629b743dd803..c166eb7c0f9a --date=short --first-parent --format='%ad %ae %s'
2019-12-06 bclayton@google.com Reactor: Rename Blend() to Shuffle()

Created with:
  gclient setdep -r src/third_party/swiftshader@c166eb7c0f9a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I93ed66207e5b2a4d1fbc226f4e69d97ecfa60758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956126Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#722675}

Annotations that could be retained, are retained. Note that the
upstream annotation library used differs from androidx, so for example,
@Nullable can be retained if it's used on a parameter or field, but
not as an annotation for a generic type parameter.

This CL addresses the following annotations:
Keeps @Nullable whenever possible.
Removes @MonotonicNotNull, @NonNull, @UnderInitialization.

Bug: 1024945
Change-Id: I68a102da6e299296827f9c6fedbeff25136588b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945920Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722674}

Before this CL, extensions::URLLoaderFactoryManager's
OverrideURLLoaderFactoryParams method would not be explicitly told
whether the factory will be used by a content script.  Instead, the
method would try to infer this, by checking if the |process| where the
factory will be used is an extension process.

The inference above will give incorrect results in case of content
scripts being injected into (other) extensions - in this case the
|process|-based inference will incorrectly conclude that the factory is
*not* for a content script.

After this CL, an explicit |is_for_isolated_world| parameter is passed
to the OverrideURLLoaderFactoryParams method.

Bug: 1025303
Change-Id: If947796f6017ddbe2dd6968254cb8b9ea7f34c94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920004
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722673}

This CL creates a SharedImageRepresentationDawn for Ozone-based
SharedImages. This is mostly adapted from
ExternalVkImageDawnRepresentation and works by passing the dma-buf
handle to Dawn.

Synchronization will be added in a following CL.

Bug: 1023997,996470
Change-Id: I940a0ec9d659d31efaa63fac909d312d3558e675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913083
Commit-Queue: Brian Ho <hob@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722672}

BUG=1029855
TEST=manual
R=sunnyps@chromium.org

Change-Id: Ia96d9e7a068edcba01002a31b1703f539d6e84d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956113Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722671}

This picks up a change that increases checksum caching for batch_isolate.

Bug: 969162
Change-Id: Ic0df249ac7644b9d3db3dee0a13483b8eca8bdfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955796
Auto-Submit: Erik Chen <erikchen@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722670}

Feature kSupervisedUserInitiatedExtensionInstall should be disabled by
default for M80. Otherwise, a child user can install extensions, but
those extensions will remain force-disabled. There will be no way to
enable those extensions, leading to a half-baked user experience.
Child users should not be able to install extensions in M80.

Bug: 1031628
Change-Id: I553d57b24fa97f3c5dba3c78a1b7acb162bcb4b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953721Reviewed-by: Dan S <danan@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722669}

Three tests are flaking, mark them as flaky until root cause can be
investigated.

Bug: 965268, 1031095, 1031567
Change-Id: I8b0a85f1385250abca8264278ec2dcd97531dcba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956017
Commit-Queue: kylechar <kylechar@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722668}

This removes marking window as ARC app from shelf to exo which owns ARC
window. Now all such operations are centralized in exo.

TEST=ARC functionality is preserved. unit tests
BUG=None

Change-Id: Iaa7205733b2299ce7986a19f984e498dced50ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955818
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722667}

This fixes a bug that happens in an interplay of find in page and
mutating locked subtrees. We don't paint the subtree, and the DCHECK
happens during the self painting phase of the element. This change
ensures that the DCHECK is aware of display locking.

R=chrishtr@chromium.org

Change-Id: Ib58adaffab9e11d2d813fe54a56ea3aa72ddfd32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956038
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722666}

The IS_CHROMECAST define is declared in 16 different places, which is
risky especially if the define is used in a header file.

Move this to a common buildflag header in //build, alongside the chrome
branding flags. This flag needs to be in a widely scoped location, since
we don't know if we're allowed to use //chromecast until we check the
flag's value.

OS_CHROMEOS uses a global #define for this, and that would work here, but
global ifdefs are discouraged. There are few enough uses of IS_CHROMECAST
that having explicit dependencies on a buildflag header isn't too onerous.

No functional change.

Bug: 1030969
TBR=kylechar@chromium.org, dgozman@chromium.org, benwells@chromium.org, kbr@chromium.org, dalecurtis@chromium.org, reillyg@chromium.org, foolip@chromium.org

Change-Id: I48d9ffccde7e7a680ce572f15a8ba1ef11adcc6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951981
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722665}

is_previous_layout_right_side_up_ shall be updated for clamshell/tablet
transition, even in cases where OnDisplayMetricsChanged is not called.

Fixed: 1029181
Change-Id: I9706c4273de1e632da01e019d54a825b39acd219
Bug: 1029181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948918
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722664}

Create a new class, ExtensionActionViewControllerUnitTest, which
subclasses ToolbarActionsBarTest, and add common utility methods in
that test class. Also move
ToolbarActionsBarTest::SetActionWantsToRunOnTab() to this new class,
as it was only used in these tests.

This reduces a lot of the repeated boilerplate code in the
ExtensionActionViewController related unittests, and will make
adjusting them for the ExtensionsMenu behavior easier.

No behavior change is expected.

Bug: 984654

Change-Id: Ic85832939187d04dd64ff0e9ef995cd86a8f5925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940881
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722663}

As a part of moving to storage service, the indexeddb code can't depend
on BrowserThread::IO and will need some other new IO thread.  To handle
this, the idb context now exposes an IOTaskRunner (which for now is
still the browser IO thread) which is plumbed everywhere that is needed.

Change-Id: Idef64cb47ab4483b2584ce6d7b19aee25d6add18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954724Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722662}

https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29
https://ci.chromium.org/p/chromium/builders/ci/ToTWin%28dll%29
They don't fail anymore for CleanerSandboxInterfaceTest. So consider the fix
works.
I don't see it's necessary to make the resetacl more general(i.e. pass in base::FilePath)
for now. But it is in a general place. Let me know if a general
signature is favorable.

Bug: 956016
Change-Id: I870e01dfa62a09ada372985dc5d9c9dcdc01b328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956145
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722661}

Uses the ExtensionsContainer interface instead of ToolbarActionsBar to
show NTP and DSE warning bubbles. This fixes crashes (DCHECKs) when
using DDG or other default-search-engine extensions.

This also adds the NTP extensions trigger to ExtensionsToolbarContainer
which was used to be able to verify the fix on Linux.

Bug: chromium:985834, chromium:999100
Change-Id: I42b884f2ba7b1978be52daf194abe24f21f453de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956078
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722660}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7471ec58dc43..dca1c7eb4884


Created with:
  gclient setdep -r src-internal@dca1c7eb4884

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1024588
Tbr: jbudorick@google.com
Change-Id: I7a03802ecbc17a75b65bc5c44dd484868dd22cc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956019Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#722659}

The OpenVR SDK has made some changes that we need since the last time it
was updated. Primarily, this is the addition of the method:
GetAppContainerFilePaths and a few other updates intended to allow the
SDK to work better in the AppContainer version of the WebXr device
process.

Some prototyping will still need to be done before this can actually be
achieved, but doing this first roll better enables that and sets up a
(hopefully) smaller diff if another roll is needed due to any issues
discovered during prototyping.

Fixed:845255

Change-Id: I6f9af21df282b3fe90cd9855aefd4b4ff9cc3c56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935411Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722658}

Changes between reland 1 and reland 2:

1.) Added lazy load ensure load to relevant privacy subpage tests.

> Changes between original submission and reland:

> 1.) Privacy-page subpages are now in lazy_load.html
> 2.) Fixed bug that erroneously showed "privacy" in the settings menu of "Guest" mode settings.
> 3.) Fixed bug where going to chrome://settings/clearBrowsingData didn't work unless the advanced section was expanded when the flag for this change was disabled.
> 4.) Reordered a few settings rows to match the most current mocks.

>> Revert "Friendly Privacy Setting Initial Redesign"

>> This reverts commit 544412a4.

>> Reason for revert: Performance and functional regressions
>> https://bugs.chromium.org/p/chromium/issues/detail?id=1024034#c5

>>> Original change's description:
>>> Friendly Privacy Setting Initial Redesign

> >>> This CL does 3 things:
> >>> 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag.
> >>> 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on.
> >>> 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag.

>>> Bug: 1014143
>>> Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088
>>> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094
>>> Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
>>> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
>>> Cr-Commit-Position: refs/heads/master@{#714287}

Change-Id: I127cdd31a404f4c7df0d75650e762536fcefd053
Bug: 1031520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950954
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722657}

Lots of warning messages started appearing, and it turns out
that the existing 'code' subcommand was deprecated. Simply using
private-code would be good enough.

Bug: 1030484
Test: build
Change-Id: I0c73c003de7a31d1b324170da37cdc3dacd022a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955908Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722656}

This is a reland of 197dd2b5

This is an unedited reland. The old one was reverted because of a crash, but
this CL should fix the crash, making this reland safe:

https://chromium-review.googlesource.com/c/chromium/src/+/1955787

Original change's description:
> [omnibox] ZeroSuggestProvider: classify search results w/ input text
>
> Currently, when we get search suggest results back from
> ZeroSuggestProvider, nothing is bolded. This is inconsistent with
> as-you-type search suggestions.
>
> The root cause is that we purposely set AutocompleteInput::input_text
> to an empty string for all ZeroSuggest queries, to avoid leaking the
> user's current URL. (The URL is separately included in eligible).
>
> The lack of bolding is an unintended side effect.
>
> This CL fixes that, by re-classifying all the search suggest results
> that come back with the real input text on the client side.
>
> This is primarily intended to improve On Focus Query Refinements,
> but this will affect all ZeroSuggest modes that return search results
> from a non-empty omnibox. (Should not affect NTP).
>
> Note nothing is bolded at all when the input text is empty (on NTP).
>
> Navigational suggestions are not affected by this CL. They are
> currently not bolded at all.
>
> Bug: 963173
> Change-Id: I7982c780f4b03f3d2b4992051d291fe1cd86f4b7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947765
> Reviewed-by: manuk hovanesian <manukh@chromium.org>
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#721114}

Bug: 963173
Change-Id: I4a6d1195a47cab19ef4cc9e1b3756e3f6ab9f20c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954250Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722655}

For every cookie included in a request log metrics on the scheme that
the cookie was set by relative to the scheme of the request url.

Bug: 1028984
Change-Id: Icce3970a7cfe5212d4059e3e1256db633fb451c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938035
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722654}

Now integration tests will launch WebEngine with --enable-logging=stderr
and dup it's own stderr to WebEngine.

Bug: 1009099
Change-Id: I9b0e15f22fc7a758ccdc5e78a3548a34bca6651d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956225
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722653}

D3D11VideoDecoder is crashing periodically with a null |decode_cb_|.
It's unclear how this is happening.

This CL checks for the null callback and skips it, to prevent the
crash.  It also adds some debugging that hopefully will tell us
where the null callback is coming from:

 - Provided to Decode()
 - Popped off the buffer queue in DoDecode
 - Cleared elsewhere

Bug: 1012464
Change-Id: Idc4eb1842aa98989b9ceea30ed5aa769f0a63ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954735Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722652}

6 pixel video tests are now expected to pass on SkiaRenderer Vulkan for
android after some bug fixes. Hence removing them from test expectation.

Bug: 991291
Change-Id: Ifc98a2b674dbd27c3980df6e69b139201eaa58dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954258Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722651}

These tests use properties that are not currently allowed by the spec.
Therefore they are not part of the basic ::marker functionality.

BUG=1031667

Change-Id: I79743233bdcee10715bf34bca56c49c7168832b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955729Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#722650}

https://pdfium.googlesource.com/pdfium.git/+log/f3883e32a739..170f685582e1

git log f3883e32a739..170f685582e1 --date=short --first-parent --format='%ad %ae %s'
2019-12-06 kmoon@chromium.org Add utility for filter-encoding PDF streams
2019-12-06 patrik@pspdfkit.com Allow reading font name from Windows `name` table entry.

Created with:
  gclient setdep -r src/third_party/pdfium@170f685582e1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I15c3c786e6b81d1c17a27aa69951c8aaee3adfef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956084Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#722649}