- 18 Nov, 2019 8 commits
-
-
Noel Gordon authored
file_manager.css is mostly visually ordered: the splitter comes after the #directory-tree so move its CSS after the #directory-tree CSS. Second, no need for separate margin-inline-{start,end} CSS rules when the margin values are the same. Shorter to say "margin: 0 -3px" which sets margin-inline-{start,end} to -3px anyway (aka it is RTL-aware). Bug: 992819, 1002790 Change-Id: I12848afd496693aa0e122251a977a36708c5c5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921010 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#716055}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/011e0230f209..aa133ed09624 git log 011e0230f209..aa133ed09624 --date=short --no-merges --format='%ad %ae %s' 2019-11-17 sigurds@chromium.org [scripts] Fix path in dtrun Created with: gclient setdep -r src/third_party/devtools-frontend/src@aa133ed09624 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: None Change-Id: Id4067b8c4d139beaa1592dab9fbd09a348efda4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716054}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8df26949b193..a2d2c86d683b git log 8df26949b193..a2d2c86d683b --date=short --no-merges --format='%ad %ae %s' 2019-11-17 andrewlamb@chromium.org Add special suffixes to GetNonUniBuildLabBoardName. Created with: gclient setdep -r src/third_party/chromite@a2d2c86d683b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I68da86b3b99fff1b58317e1b816aa96d23f9d42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920718Reviewed-by:
-
Keith Lee authored
externs/input_method_private.js is modified when chrome/common/extensions/api/input_method_private.json is modified. These files are linked and should share owners. Change-Id: I334669b10e74f5f008b87292b1345166fad0f615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918783Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#716052}
-
Anand K. Mistry authored
Also, remove the various ACTION_TEMPLATEs and replace them with aliases to RunOnceCallback. Bug: 1018338 Change-Id: Ib6c4b04d3d75b5b4efcadeb8a01bd6e3a142d622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918785 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#716051}
-
Curtis McMullan authored
We would like to specify two perimeter boundaries for the virtual keyboard. First is the size of the window that contains the virtual keyboard. The second is the area of the keyboard window that cannot be clipped off screen (the clip bounds). The private api method added in this commit allows us to define the second. In a follow up commit we will define the clipping logic that uses these new bounds. Bug: 1020461 Change-Id: I0dc869eb216658d073cff94ab7da82ca4d92cbc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896483 Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#716050}
-
Tom Anderson authored
BUG=1025348 R=isherman Change-Id: Iad61349e1b85ae39969b37f40072140f69ab975d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919826 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#716049}
-
Chris Hall authored
This reverts commit 73523239. Reason for revert: Android build breakage https://ci.chromium.org/p/chromium/builders/ci/android-archive-dbg/2850 Original change's description: > Roll Fuchsia SDK from 889657143585 to 889655272837 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > TBR=cr-fuchsia+bot@chromium.org > > Change-Id: Ic983cd7541dcb0655656118f60ba0b38954edc5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920776 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#716047} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: Ic4225b7b48532adfbb112af03f891c7e1deaa888 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921014Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#716048}
-
- 17 Nov, 2019 9 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic983cd7541dcb0655656118f60ba0b38954edc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920776Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/633593165dde..8df26949b193 git log 633593165dde..8df26949b193 --date=short --no-merges --format='%ad %ae %s' 2019-11-17 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8df26949b193 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iea9b9fa5654f9089b3afe32d98750e8f261765b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920528Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibf14028d7466a9b72c49fc032a191feec8f62183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920757Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2c8d40dc6a85..633593165dde git log 2c8d40dc6a85..633593165dde --date=short --no-merges --format='%ad %ae %s' 2019-11-17 vapier@chromium.org cros_tree_map: drop Created with: gclient setdep -r src/third_party/chromite@633593165dde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I822486eee917c5df4d03d6196f897eaacb56707b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920756Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/332f46975386..2c8d40dc6a85 git log 332f46975386..2c8d40dc6a85 --date=short --no-merges --format='%ad %ae %s' 2019-11-17 vapier@chromium.org gob_util: drop netrc support Created with: gclient setdep -r src/third_party/chromite@2c8d40dc6a85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6428bec34e0bb133e4c5d8260fd156cf28a479b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919714Reviewed-by:
-
Luke Zielinski authored
Still getting timeouts when setting `--test-types` to omit wdspec tests (also note that this flag is buggy so setting it twice overwrites the values, so we were only running reftests on the previous try). Try disabling multi-processing this time. Bug: 1023835 Change-Id: I2131a31ba3ba796cb7a82536a6b0bd3c44862a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919324 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#716042}
-
Luke Zielinski authored
This allows us to mark any subtest failures as expected without enumerating all of them. Bug: 937369 Change-Id: I34a7d300a1ea3bd36f91f02f1cc33115644d1468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917682Reviewed-by:
-
Josh Nohle authored
Due to the limited bandwidth of GCM messages, CryptAuth does not send the feature-type string in GCM messages. Instead it sends the Base64Url-encoded, SHA-256 8-byte hash of the feature type string. The clients are responsible for mapping the hash onto its corresponding feature type. The previous implementation was incorrect; we must assume a hashed value. The feature-type key-value pair is only used in v2 DeviceSync GCM messages. Because v2 DeviceSync is not enabled on Chrome OS, no existing users are affected by this change. Bug: 951969 Change-Id: If12069750a3bb51dc93e09aa8e00a7097fb5c31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916962 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#716040}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib4ddc3fd3605f52864adff257ddf067102e25681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919711Reviewed-by:
-
- 16 Nov, 2019 23 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c71af3a2659b..332f46975386 git log c71af3a2659b..332f46975386 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 zachr@google.com cros_setup_toolchains: remove dev-util/cargo from toolchains setup Created with: gclient setdep -r src/third_party/chromite@332f46975386 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1fd0d40c5a74c5393dc662630faeb19a753ade43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919712Reviewed-by:
-
Josh Nohle authored
Provide to/from conversion functions between CryptAuthFeatureType and * the string used for protos * multidevice::SoftwareFeature Add unit tests for conversions to and from CryptAuthFeatureType. Bug: 951969 Change-Id: Ic2ffdcd76ee69b3ed36901848e61c842e3230d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917980 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Yuly Novikov authored
xr_browser_tests was missing from "Mac10.14 Tests" in testing/buildbot/chromium.fyi.json Since the two CLs adding the bot and adding the test landed shortly one after another. https://chromium-review.googlesource.com/c/chromium/src/+/1918162 https://chromium-review.googlesource.com/c/chromium/src/+/1480546 TBR=agable, bsheedy Bug: 933606, 1018846 Change-Id: Ie3ebfc031a3498f4b5bb677a72f8c5d92824e884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920748Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#716036}
-
Mike West authored
Frames with the `allow-popup` and `allow-popup-to-escape-sandbox` flags can cause JavaScript execution in their origin by navigating to a `javascript:` URL via `target=_blank` or similar. This is technically correct, but surprising. https://github.com/whatwg/html/pull/5083 aims to tighten that check to match developers' expectations that `javascript:` URLs controlled by a page that's been sandboxed away from script will not execute. Bug: 1014371 Change-Id: I3b5fa676e73cbf78485b85ce2593284bce2e68cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916467Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#716035}
-
Vaclav Brozek authored
As described in the design doc [1], a new class, CSVPasswordSequence, is introduced to allow iterating over a CSV-encoded list of credentials while decoding it into PasswordForms. [1] https://docs.google.com/document/d/1wsZBl93S_WGaXZqrqq5SP08LVZ0zDKf6e9nlptyl9AY/edit?usp=sharing Bug: 934326 Change-Id: Ife9e646c2c9d38aabf69f74dac86b9a55a477d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908527Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#716034}
-
Paul Moy authored
Chrome is trying to communicate with the cros_healthd daemon via D-Bus. cros_healthd's method which Chrome calls has changed to include an additional argument. Add this argument to the MethodCall sent to cros_healthd. /var/log/chrome/chrome for StatusUploader messages Bug: b:128683357 Test: chery-pick crrev.com/c/1779132 and check Change-Id: I477c466927f110ce5667034c00b48b8b2c830d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912643Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#716033}
-
Jeremy Roman authored
It is also necessary to handle the possibility of the other renderer sending a nonsense reply to the IPC. Bug: 1013389 Change-Id: I745c7bc1de21a5c7f96b5ced52cec3320ed03d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891120 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#716032}
-
Koji Ishii authored
Following bot results are included. 276 278 280 283 284 285 286 287 289 290 291 292 293 294 295 296 297 298 299 300 129 lines were removed and 32 lines were deflaked by consecutive results since 289. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ied00f67eef668ccc906254ef86f73a730c5a1d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914579Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#716031}
-
Michael Crouse authored
This change enables the optimization guide store to load and store host model features from the remote Optimization Guide Service. Bug: 1001194 Change-Id: I9124e106f872d94ab90aa0f6a30e0e29f48ca9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911226Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#716030}
-
David Benjamin authored
Refreshing all the test certificates is tedious, however generate-test-certs.sh cannot be run incrementally right now: 1. Every time it is run, the CA private keys change, so all certificates have to be refreshed. This usually breaks pinning tests, etc., and is an unnecessary complication. 2. Serial numbers must not collide. Despite this, we try to manually run things anyway, with the result that the currently checked in certificates do not match the script output in serial number! I suspect we removed a certificate in the middle of the tower at some point. To make this a bit friendlier: 1. Preserving the root and intermeidate keys if already present. 2. Randomizing the certificate serial numbers rather than counting incrementally. This means that a developer can run the script and only check in the certificate they care about. Bug: 984685 Change-Id: I3c0b0e85654dd62f82fb83f90fd1252ebbaa3135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918385Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#716029}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9ffb485eb01c..c71af3a2659b git log 9ffb485eb01c..c71af3a2659b --date=short --no-merges --format='%ad %ae %s' 2019-11-16 vapier@chromium.org remote_access: have all remote commands use utf-8 encoding by default Created with: gclient setdep -r src/third_party/chromite@c71af3a2659b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4b142d21513bd20add5a21597ce4f853417dd87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919252Reviewed-by:
-
David Benjamin authored
The comparator did not correctly handle the case when left->priority() > right->priority(). std::make_heap and friends will not work correctly with a bad comparator and may arbitrarily misbehave. This was caught by running tests with _LIBCPP_DEBUG=0. Bug: 923166, 1018920 Change-Id: Ie480f669746566cbe045c539e203b3b89564d267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919659 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#716027}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a67b97032ab3..9ffb485eb01c git log a67b97032ab3..9ffb485eb01c --date=short --no-merges --format='%ad %ae %s' 2019-11-16 vapier@chromium.org gs: switch to cros_collections.Collections 2019-11-16 haddowk@chromium.org moblab_vm: change the disk layout for the VM image. 2019-11-16 vapier@chromium.org gerrit_unittest: require gitcookies for tests (and drop netrc) Created with: gclient setdep -r src/third_party/chromite@9ffb485eb01c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iaab32fd709884c4d47e662e6d85c2e226ed413b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920527Reviewed-by:
-
Mikel Astiz authored
If sync encryption keys are missing, the user should be prompted with a convenient button in the profile menu to trigger a reauth flow with Gaia and retrieve the keys. Bug: 1019687 Change-Id: I68181d836c2cd0f110e44dfbe434041b1014780e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895347 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#716025}
-
Minggang Wang authored
Currently, the NavigationImmediateResponse feature is enabled by default through a flag kNavigationImmediateResponseBody. As this feature has been landed for some time, this patch removes this flag and the support for the old behavior. Bug: 1017705 Change-Id: If02d58b28ccaadfa1ca94e080217321521a009fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911148 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#716024}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/extensions This CL was uploaded by git cl split. R=finnur@chromium.org Bug: 1018667 Change-Id: I086571be2512e726282a47d3f957beeb8d6a0dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917761 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716023}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e0de92d8e44..a67b97032ab3 git log 4e0de92d8e44..a67b97032ab3 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 vapier@chromium.org cros_oobe_autoconfig: rework code for Python 3 2019-11-16 yusukes@google.com StaticKCM: Roll XkbToKcmConverter w/ ARCVM system image Created with: gclient setdep -r src/third_party/chromite@a67b97032ab3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6ec6bb0aafad2ab9ff057e6db681a79f521158dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919477Reviewed-by:
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/client_hints This CL was uploaded by git cl split. R=ryansturm@chromium.org Bug: 1018667 Change-Id: I4d6ccb972fdafd58f33d11cf090fc61560bdb50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916825 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716021}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ff3290ed. With Chromium commits locally applied on WPT: 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." e83dd93c "Limit backtracking on regexp called from blink." 6e3e930c "Change `sec-fetch-mode` from `no-cors` to `navigate` for <embed> / <object>." c8b6e1ce "Chromedriver] Fix PerformAction to support multi touch points cases" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib4311211fc2040b66a55787b158e4b865859af2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919605Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716020}
-
Martin Robinson authored
When children of dialogs have focus, explicitly assign the active state to the dialog. This will allow Orca to properly announce dialogs. We need to do something special here, because in Chromium dialogs do not have their own toplevel windows. Bug: 1023208 Change-Id: I02a0a89781d88477238728b8b516b7a2606d6af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917224Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#716019}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae17e6fd3e30..4e0de92d8e44 git log ae17e6fd3e30..4e0de92d8e44 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 vapier@chromium.org binpkg: decode data from gs as utf-8 & switch to io.StringIO 2019-11-16 vapier@chromium.org gob_util/gerrit_unittest: get it working under Python 3 Created with: gclient setdep -r src/third_party/chromite@4e0de92d8e44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic90718fa71bc56600aea1558f8723b03ebab3557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919476Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If80b79d9d4fb737a05ccc970f5926bbf21023a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919475Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/873514fca868..ae17e6fd3e30 git log 873514fca868..ae17e6fd3e30 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 sanikak@chromium.org auto_updater: Updating readability of the auto_updater_transfer classes 2019-11-16 sanikak@chromium.org auto_updater: Adding 'transfer from staging server' functionality to chromite AutoUpdater Created with: gclient setdep -r src/third_party/chromite@ae17e6fd3e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7bfbf72b7811fce4776fd259dcb3f84494da4c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919474Reviewed-by:
-
